Skip to contentSkip to conversation

iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER

PATCH Applied Michael Walle 3 participants 3 messages Aug 3, 2020 – Aug 9, 2020 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER

The kernel fails to compile due to undefined reference to devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not enabled. The original patch [1] had this dependency. But somehow it didn't make it into the kernel tree. Re-add it.

[1] https://lore.kernel.org/lkml/[email protected]/

Fixes 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
---
 drivers/iio/adc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
index 66d9cc073157..d94dc800b842 100644
@@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:

Quoted 9 lines

The kernel fails to compile due to undefined reference to devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not enabled. The original patch [1] had this dependency. But somehow it didn't make it into the kernel tree. Re-add it.

[1] https://lore.kernel.org/lkml/[email protected]/

Fixes 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
Quoted 18 lines
---
 drivers/iio/adc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
index 66d9cc073157..d94dc800b842 100644
@@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.
maintainer Applied
#2 lore raw
Quoted 6 lines · On Mon, 03 Aug 2020 13:59:12 +0200 Heiko Stuebner…

Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:

Quoted 5 lines

The kernel fails to compile due to undefined reference to devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not enabled. The original patch [1] had this dependency. But somehow it didn't make it into the kernel tree. Re-add it.

Quoted 6 lines
Quoted 4 lines

[1] https://lore.kernel.org/lkml/[email protected]/

Fixes 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

Quoted 23 lines
Quoted 19 lines
---
 drivers/iio/adc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
index 66d9cc073157..d94dc800b842 100644
@@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.