ext4: remove unused parameter of ext4_generic_delete_entry function
PATCH 1/1 ext4: remove unused parameter of ext4_generic_delete_entry function
The ext4_generic_delete_entry function defines the handle_t type variable, handle, as a parameter, but it is not used.
Signed-off-by Kyoungho Koo <[email protected]>
--- fs/ext4/ext4.h | 3 +-- fs/ext4/inline.c | 2 +- fs/ext4/namei.c | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-)
fs/ext4/ext4.h +1 -2
@@ -2764,8 +2764,7 @@ extern int ext4_search_dir(struct buffer_head *bh,struct ext4_filename *fname, unsigned int offset, struct ext4_dir_entry_2 **res_dir); -extern int ext4_generic_delete_entry(handle_t *handle, - struct inode *dir, +extern int ext4_generic_delete_entry(struct inode *dir, struct ext4_dir_entry_2 *de_del, struct buffer_head *bh, void *entry_buf,
fs/ext4/inline.c +1 -1
@@ -1706,7 +1706,7 @@ int ext4_delete_inline_entry(handle_t *handle,if (err) goto out; - err =ext4_generic_delete_entry (handle, dir, de_del, bh, + err =ext4_generic_delete_entry (dir, de_del, bh, inline_start, inline_size,0 );if (err) goto out;
fs/ext4/namei.c +2 -4
@@ -2455,8 +2455,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,* ext4_generic_delete_entry deletes a directory entry by merging it * with the previous entry */ -int ext4_generic_delete_entry(handle_t *handle, - struct inode *dir, +int ext4_generic_delete_entry(struct inode *dir, struct ext4_dir_entry_2 *de_del, struct buffer_head *bh, void *entry_buf,
@@ -2517,8 +2516,7 @@ static int ext4_delete_entry(handle_t *handle,if (unlikely (err)) goto out; - err =ext4_generic_delete_entry (handle, dir, de_del, - bh, bh->b_data, + err =ext4_generic_delete_entry (dir, de_del, bh, bh->b_data, dir->i_sb->s_blocksize, csum_size);if (err) goto out;
Signature · 1 line
2.17.1
Quoted 4 lines · Kyoungho Koo
The
ext4_generic_delete_entryfunction defines thehandle_ttype variable, handle, as a parameter, but it is not used.Signed-off-by Kyoungho Koo <[email protected]>
LGTM, feel free to add:
Reviewed-by Ritesh Harjani <[email protected]>
Quoted 4 lines · Kyoungho Koo
The
ext4_generic_delete_entryfunction defines thehandle_ttype variable, handle, as a parameter, but it is not used.Signed-off-by Kyoungho Koo <[email protected]>
Applied, thanks.
- Ted