drivers/gpu/drm/drm_bridge.c:201 drm_bridge_attach() error: uninitialized symbol 'ret'.
PATCH 12/16 drivers/gpu/drm/drm_bridge.c:201 drm_bridge_attach() error: uninitialized symbol 'ret'.
tree: https://github.com/superna9999/linux amlogic/v5.9/s400-mipi-dsi head: 4cbe7065356e7e68a59a0787bc4a4a3ca9375065 commit: 87c65f7a5406d7484a6e9aeab87b275f29542aed [12/16] drm: bridge: debug config: i386-randconfig-m021-20200802 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
smatch warnings:drivers/gpu/drm/drm_bridge.c:201 drm_bridge_attach() error: uninitialized symbol 'ret'.
# https://github.com/superna9999/linux/commit/87c65f7a5406d7484a6e9aeab87b275f29542aed
git remote add superna9999 https://github.com/superna9999/linux
git remote update superna9999
git checkout 87c65f7a5406d7484a6e9aeab87b275f29542aed
vim +/ret +201 drivers/gpu/drm/drm_bridge.c
3bb80f249525c05 Laurent Pinchart 2016-11-28 175 int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
a25b988ff83f3ca Laurent Pinchart 2020-02-26 176 struct drm_bridge *previous,
a25b988ff83f3ca Laurent Pinchart 2020-02-26 177 enum drm_bridge_attach_flags flags)
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 178 {
3bb80f249525c05 Laurent Pinchart 2016-11-28 179 int ret;
^^^^^^^3bb80f249525c05 Laurent Pinchart 2016-11-28 180
87c65f7a5406d74 Neil Armstrong 2020-04-06 181 pr_info("%s %08x %08x %08x\n", __func__, encoder, bridge, previous);
87c65f7a5406d74 Neil Armstrong 2020-04-06 182
3bb80f249525c05 Laurent Pinchart 2016-11-28 183 if (!encoder || !bridge)
3bb80f249525c05 Laurent Pinchart 2016-11-28 184 return -EINVAL;
3bb80f249525c05 Laurent Pinchart 2016-11-28 185
3bb80f249525c05 Laurent Pinchart 2016-11-28 186 if (previous && (!previous->dev || previous->encoder != encoder))
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 187 return -EINVAL;
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 188
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 189 if (bridge->dev)
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 190 return -EBUSY;
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 191
3bb80f249525c05 Laurent Pinchart 2016-11-28 192 bridge->dev = encoder->dev;
3bb80f249525c05 Laurent Pinchart 2016-11-28 193 bridge->encoder = encoder;
3bb80f249525c05 Laurent Pinchart 2016-11-28 194
05193dc38197021 Boris Brezillon 2019-12-03 195 if (previous)
05193dc38197021 Boris Brezillon 2019-12-03 196 list_add(&bridge->chain_node, &previous->chain_node);
05193dc38197021 Boris Brezillon 2019-12-03 197 else
05193dc38197021 Boris Brezillon 2019-12-03 198 list_add(&bridge->chain_node, &encoder->bridge_chain);
05193dc38197021 Boris Brezillon 2019-12-03 199
3bb80f249525c05 Laurent Pinchart 2016-11-28 200 if (bridge->funcs->attach) {
87c65f7a5406d74 Neil Armstrong 2020-04-06 @201 pr_info("%s:%d %d\n", __func__, __LINE__, ret);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Probably supposed to be one line later.
a25b988ff83f3ca Laurent Pinchart 2020-02-26 202 ret = bridge->funcs->attach(bridge, flags);
751465913f045a1 Boris Brezillon 2020-01-28 203 if (ret < 0)
751465913f045a1 Boris Brezillon 2020-01-28 204 goto err_reset_bridge;
3bb80f249525c05 Laurent Pinchart 2016-11-28 205 }
751465913f045a1 Boris Brezillon 2020-01-28 206
751465913f045a1 Boris Brezillon 2020-01-28 207 if (bridge->funcs->atomic_reset) {
751465913f045a1 Boris Brezillon 2020-01-28 208 struct drm_bridge_state *state;
751465913f045a1 Boris Brezillon 2020-01-28 209
751465913f045a1 Boris Brezillon 2020-01-28 210 state = bridge->funcs->atomic_reset(bridge);
751465913f045a1 Boris Brezillon 2020-01-28 211 if (IS_ERR(state)) {
751465913f045a1 Boris Brezillon 2020-01-28 212 ret = PTR_ERR(state);
751465913f045a1 Boris Brezillon 2020-01-28 213 goto err_detach_bridge;
751465913f045a1 Boris Brezillon 2020-01-28 214 }
751465913f045a1 Boris Brezillon 2020-01-28 215
751465913f045a1 Boris Brezillon 2020-01-28 216 drm_atomic_private_obj_init(bridge->dev, &bridge->base,
751465913f045a1 Boris Brezillon 2020-01-28 217 &state->base,
751465913f045a1 Boris Brezillon 2020-01-28 218 &drm_bridge_priv_state_funcs);
3bb80f249525c05 Laurent Pinchart 2016-11-28 219 }
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 220
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 221 return 0;
751465913f045a1 Boris Brezillon 2020-01-28 222
751465913f045a1 Boris Brezillon 2020-01-28 223 err_detach_bridge:
751465913f045a1 Boris Brezillon 2020-01-28 224 if (bridge->funcs->detach)
751465913f045a1 Boris Brezillon 2020-01-28 225 bridge->funcs->detach(bridge);
751465913f045a1 Boris Brezillon 2020-01-28 226
751465913f045a1 Boris Brezillon 2020-01-28 227 err_reset_bridge:
751465913f045a1 Boris Brezillon 2020-01-28 228 bridge->dev = NULL;
751465913f045a1 Boris Brezillon 2020-01-28 229 bridge->encoder = NULL;
751465913f045a1 Boris Brezillon 2020-01-28 230 list_del(&bridge->chain_node);
751465913f045a1 Boris Brezillon 2020-01-28 231 return ret;
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 232 }
3d3f8b1f8b62c3a Ajay Kumar 2015-01-20 233 EXPORT_SYMBOL(drm_bridge_attach);---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org