Skip to contentSkip to conversation

vdpa_sim: init iommu lock

PATCH In review Michael S. Tsirkin 2 participants 2 messages Aug 10, 2020 – Aug 11, 2020 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 vdpa_sim: init iommu lock

The patch adding the iommu lock did not initialize it. The struct is zero-initialized so this is mostly a problem when using lockdep.

Cc Max Gurtovoy <[email protected]>
Fixes 0ea9ee430e74 ("vdpasim: protect concurrent access to iommu iotlb")
---
 drivers/vdpa/vdpa_sim/vdpa_sim.c | 1 +
 1 file changed, 1 insertion(+)
drivers/vdpa/vdpa_sim/vdpa_sim.c +1 -0
index df3224b138ee..604d9d25ca47 100644
@@ -358,6 +358,7 @@ static struct vdpasim *vdpasim_create(void)
 
 	INIT_WORK(&vdpasim->work, vdpasim_work);
 	spin_lock_init(&vdpasim->lock);
+	spin_lock_init(&vdpasim->iommu_lock);
 
 	dev = &vdpasim->vdpa.dev;
 	dev->coherent_dma_mask = DMA_BIT_MASK(64);
Signature · 1 line
MST
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Michael S. Tsirkin

The patch adding the iommu lock did not initialize it. The struct is zero-initialized so this is mostly a problem when using lockdep.

Cc Max Gurtovoy <[email protected]>
Fixes 0ea9ee430e74 ("vdpasim: protect concurrent access to iommu iotlb")
Quoted 16 lines
---
  drivers/vdpa/vdpa_sim/vdpa_sim.c | 1 +
  1 file changed, 1 insertion(+)
drivers/vdpa/vdpa_sim/vdpa_sim.c +1 -0
index df3224b138ee..604d9d25ca47 100644
@@ -358,6 +358,7 @@ static struct vdpasim *vdpasim_create(void)
 
  	INIT_WORK(&vdpasim->work, vdpasim_work);
  	spin_lock_init(&vdpasim->lock);
+	spin_lock_init(&vdpasim->iommu_lock);
 
  	dev = &vdpasim->vdpa.dev;
  	dev->coherent_dma_mask = DMA_BIT_MASK(64);