vdpa_sim: fix pointer math in get_config
Michael S. Tsirkin
maintainerPATCH 1/1 vdpa_sim: fix pointer math in get_config
There is a pointer math bug here: the variable cast is a struct so the offset is in units of struct size. If "offset" is non-zero this will copy memory from beyond the end of the array.
Fixes 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vdpa/vdpa_sim/vdpa_sim.c +1 -1
@@ -558,7 +558,7 @@ static void vdpasim_get_config(struct vdpa_device *vdpa, unsigned int offset,struct vdpasim *vdpasim =vdpa_to_sim (vdpa);if (offset + len <sizeof (struct virtio_net_config )) -memcpy (buf, &vdpasim->config + offset, len); +memcpy (buf, (u8 *)&vdpasim->config + offset, len); } static void vdpasim_set_config(struct vdpa_device *vdpa, unsigned int offset,
Signature · 6 lines
MST _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization