Skip to contentSkip to conversation

package/rauc: fix build with c99 and above compilers

PATCH New Yair Ben-Avraham 2 participants 3 messages Aug 10, 2020 – Aug 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rauc: fix build with c99 and above compilers

- fix build inline functions
- fix signature path

---
 package/rauc/rauc.hash | 2 +-
 package/rauc/rauc.mk   | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
package/rauc/rauc.hash +1 -1
index 51f37f6cb8..d327122293 100644
@@ -1,4 +1,4 @@
 # Locally calculated, after verifying against
-# https://github.com/rauc/rauc/releases/download/v1.3/rauc-1.4.tar.xz.asc
+# https://github.com/rauc/rauc/releases/download/v1.4/rauc-1.4.tar.xz.asc
 sha256  85aabf214cd93a37f7ad0b3aaad89eb94facf0f3ebf6e2edca945acbca9b0967  rauc-1.4.tar.xz
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
package/rauc/rauc.mk +2 -0
index 1915c783aa..553467f618 100644
@@ -30,6 +30,8 @@ ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 RAUC_DEPENDENCIES += systemd
 endif
 
+RAUC_CFLAGS += -fgnu89-inline
+
 define RAUC_INSTALL_INIT_SYSTEMD
 	mkdir $(TARGET_DIR)/usr/lib/systemd/system/rauc.service.d
 	printf '[Install]\nWantedBy=multi-user.target\n' \

--
2.20.1

#1 lore raw

PATCH 1/1 package/rauc: fix build with c99 and above compilers

Quoted 4 lines · On Mon, 10 Aug 2020 08:43:32 +0000 Yair Ben-Avraham <[email protected]>…

- fix build inline functions
- fix signature path

It seems weird that a well-maintained piece of software such as RAUC has build issues with C99+ compilers.

Do you have a reference to the build failure ? In our autobuilders perhaps ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/rauc: fix build with c99 and above compilers

In reply to Yair Ben-Avraham

Hello Yair,

Quoted 4 lines · On Mon, 10 Aug 2020 08:43:32 +0000 Yair Ben-Avraham <[email protected]>…

- fix build inline functions
- fix signature path

Since I haven't heard back from you about the C99 build issue, I've applied a commit that just fixes the signature URL:

https://git.buildroot.org/buildroot/commit/?id=a9b454387cdc60a69fc2bac8a24d0e2cf3c5ddb3

Do not hesitate to get back to us with more details about the C99/-fgnu89-inline issue.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com