hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
PATCH 1/1 hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported PMBus command.
--- drivers/hwmon/pmbus/isl68137.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/hwmon/pmbus/isl68137.c +6 -1
@@ -67,6 +67,7 @@ enum variants { raa_dmpvr1_2rail, raa_dmpvr2_1rail, raa_dmpvr2_2rail, + raa_dmpvr2_2rail_nontc, raa_dmpvr2_3rail, raa_dmpvr2_hv, };
@@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client, info->pages =1 ; info->read_word_data = raa_dmpvr2_read_word_data;break ; +case raa_dmpvr2_2rail_nontc: + info->func[0 ] &= ~PMBUS_HAVE_TEMP ; + info->func[1 ] &= ~PMBUS_HAVE_TEMP ; + fallthrough;case raa_dmpvr2_2rail: info->pages =2 ; info->read_word_data = raa_dmpvr2_read_word_data;
@@ -304,7 +309,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = { {"raa228000", raa_dmpvr2_hv}, {"raa228004", raa_dmpvr2_hv}, {"raa228006", raa_dmpvr2_hv}, - {"raa228228", raa_dmpvr2_2rail}, + {"raa228228", raa_dmpvr2_2rail_nontc}, {"raa229001", raa_dmpvr2_2rail}, {"raa229004", raa_dmpvr2_2rail}, {}
Signature · 1 line
2.20.1
Guenter Roeck
maintainerQuoted 4 lines · Grant Peltier
Per the RAA228228 datasheet,
READ_TEMPERATURE_1is not a supported PMBus command.Signed-off-by Grant Peltier <[email protected]>
Please copy [email protected] on hwmon patches. This patch is not in the hwmon patchwork, which in general almost guarantees that it gets lost since I usually pull patches from there. As it happens, you are lucky that I noticed. Patch applied.
Guenter
Quoted 37 lines
--- drivers/hwmon/pmbus/isl68137.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/hwmon/pmbus/isl68137.c +6
-1@@ -67,6 +67,7 @@ enum variants { raa_dmpvr1_2rail, raa_dmpvr2_1rail, raa_dmpvr2_2rail, + raa_dmpvr2_2rail_nontc, raa_dmpvr2_3rail, raa_dmpvr2_hv, };@@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client, info->pages =1 ; info->read_word_data = raa_dmpvr2_read_word_data;break ; +case raa_dmpvr2_2rail_nontc: + info->func[0 ] &= ~PMBUS_HAVE_TEMP ; + info->func[1 ] &= ~PMBUS_HAVE_TEMP ; + fallthrough;case raa_dmpvr2_2rail: info->pages =2 ; info->read_word_data = raa_dmpvr2_read_word_data;@@ -304,7 +309,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = { {"raa228000", raa_dmpvr2_hv}, {"raa228004", raa_dmpvr2_hv}, {"raa228006", raa_dmpvr2_hv}, - {"raa228228", raa_dmpvr2_2rail}, + {"raa228228", raa_dmpvr2_2rail_nontc}, {"raa229001", raa_dmpvr2_2rail}, {"raa229004", raa_dmpvr2_2rail}, {}
Ah, my apologies. Duly noted for the future. Thanks for catching it.
Grant
-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: Tuesday, August 11, 2020 12:17 PM
To: Grant Peltier <[email protected]>
Cc: Grant Peltier <[email protected]>; [email protected]; Adam Vaughn <[email protected]>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
Quoted 4 lines · Grant Peltier
Per the RAA228228 datasheet,
READ_TEMPERATURE_1is not a supported PMBus command.Signed-off-by Grant Peltier <[email protected]>
Please copy [email protected] on hwmon patches. This patch is not in the hwmon patchwork, which in general almost guarantees that it gets lost since I usually pull patches from there. As it happens, you are lucky that I noticed. Patch applied.
Guenter
Quoted 38 lines
--- drivers/hwmon/pmbus/isl68137.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/hwmon/pmbus/isl68137.cindex0c622711ef7e..58aa95a3c010100644drivers/hwmon/pmbus/isl68137.c +5
-0@@ -67,6 +67,7 @@ enum variants { raa_dmpvr1_2rail, raa_dmpvr2_1rail, raa_dmpvr2_2rail, + raa_dmpvr2_2rail_nontc, raa_dmpvr2_3rail, raa_dmpvr2_hv, };@@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client, info->pages =1 ; info->read_word_data = raa_dmpvr2_read_word_data;break ; +case raa_dmpvr2_2rail_nontc: + info->func[0 ] &= ~PMBUS_HAVE_TEMP ; + info->func[1 ] &= ~PMBUS_HAVE_TEMP ; + fallthrough;case raa_dmpvr2_2rail: info->pages =2 ; info->read_word_data = raa_dmpvr2_read_word_data; @@ -304,7 +309,7@@ static const struct
i2c_device_idraa_dmpvr_id[] = {drivers/hwmon/pmbus/isl68137.c +1
-1{"raa228000", raa_dmpvr2_hv}, {"raa228004", raa_dmpvr2_hv}, {"raa228006", raa_dmpvr2_hv}, - {"raa228228", raa_dmpvr2_2rail}, + {"raa228228", raa_dmpvr2_2rail_nontc}, {"raa229001", raa_dmpvr2_2rail}, {"raa229004", raa_dmpvr2_2rail}, {}