Skip to contentSkip to conversation

Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

PATCH Superseded Chee Hong Ang 5 participants 9 messages Aug 11, 2020 Kbuild

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +7 -4
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)
 
Signature · 1 line
2.2.0
#1 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 10 lines · Chee Hong Ang

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---

What changed between V1 and V2 ? Changelog is missing.

Quoted 8 lines
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +0 -0
index 4483a9b..f4631f1 100644

Makefile u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE · line 1589

Quoted 10 lines
Makefile +3 -2
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)

Also, now that I look at it, if you want to generate some new target, it should be a Makefile target, just like u-boot-with-spl.sfp is a Makefile target. So then you can do make <target>.

#2 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 9 lines · Chee Hong Ang
Quoted 8 lines

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

Quoted 4 lines
Quoted 2 lines

---

What changed between V1 and V2 ? Changelog is missing.

In V2, 'make u-boot-with-nand-spl.sfp' will generate spl/u-boot-nand-splx4.sfp which contains 4 x (SPL + 64KB padding). Commit message already mentioned how to generate this SFP file with 64Kb padding for each SPL in SFP.

Quoted 14 lines
Quoted 14 lines
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +0 -0
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE

ifneq ($(CONFIG_ARCH_SOCFPGA),) quiet_cmd_socboot = SOCBOOT $@
cmd_socboot = cat spl/u-boot-spl.sfp spl/u-boot-spl.sfp \

Makefile +1 -2
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
Quoted 8 lines

Makefile u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE · line 1589

Quoted 4 lines
Makefile +2 -0
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)

Also, now that I look at it, if you want to generate some new target, it should be a Makefile target, just like u-boot-with-spl.sfp is a Makefile target. So then you can do make <target>.

There is already a target 'u-boot-with-nand-spl.sfp' in Makefile:
u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
$(call if_changed,socnandboot)

V2 patch contains the following changes as well which are missing in this email thread:
@@ -1592,8 +1593,10 @@ cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
cat spl/u-boot-spl.sfp spl/u-boot-spl.pad \
spl/u-boot-spl.sfp spl/u-boot-spl.pad \
spl/u-boot-spl.sfp spl/u-boot-spl.pad \
- spl/u-boot-spl.sfp spl/u-boot-spl.pad \
- u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+ spl/u-boot-spl.sfp \
+ spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+ cat spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+ rm -f $@ spl/u-boot-spl.pad
u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
$(call if_changed,socnandboot)

#3 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 9 lines · Chee Hong
Quoted 9 lines · Chee Hong Ang
Quoted 8 lines

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

---

What changed between V1 and V2 ? Changelog is missing.

In V2, 'make u-boot-with-nand-spl.sfp' will generate spl/u-boot-nand-splx4.sfp which contains 4 x (SPL + 64KB padding). Commit message already mentioned how to generate this SFP file with 64Kb padding for each SPL in SFP.

The changelog in the patches is there so it's quickly obvious what changed in the patch without searching for previous version and running a diff.

Quoted 22 lines
Quoted 13 lines
Quoted 13 lines
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +0 -0
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE

ifneq ($(CONFIG_ARCH_SOCFPGA),) quiet_cmd_socboot = SOCBOOT $@
cmd_socboot = cat spl/u-boot-spl.sfp spl/u-boot-spl.sfp \

Makefile +1 -2
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
Quoted 8 lines

Makefile u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE · line 1589

Quoted 4 lines
Makefile +2 -0
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)

Also, now that I look at it, if you want to generate some new target, it should be a Makefile target, just like u-boot-with-spl.sfp is a Makefile target. So then you can do make <target>.

Quoted 3 lines

There is already a target 'u-boot-with-nand-spl.sfp' in Makefile:
u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
$(call if_changed,socnandboot)

Right, so there should be a new one, u-boot-with-spl-x4.sfp: spl/u-boot-spl.sfp FORCE
and then whatever target needs the -x4 variant should again depend on it, e.g.

u-boot-with-nand-spl.sfp: spl/u-boot-spl-x4.sfp u-boot.img FORCE

#4 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

In reply to Chee Hong Ang
Quoted 31 lines · Chee Hong Ang

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +3 -2
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \

Makefile cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \ · line 1601

Quoted 10 lines
Makefile +4 -2
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)

It's not immediately clear to me why we're doing this here, rather than instructing the user to write the file 4 times when programming. On TI platforms, even on NAND, for forever there's been multiple locations the ROM will check for the loader. Is there a reason to not handle this at that level?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200811/48b87df8/attachment.sig>
#5 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 41 lines · Tom Rini
Quoted 39 lines · Chee Hong Ang

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +7 -4
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
Quoted 8 lines

Makefile cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \ · line 1601

Quoted 2 lines
Makefile +0 -0
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)

It's not immediately clear to me why we're doing this here, rather than instructing the user to write the file 4 times when programming. On TI platforms, even on NAND, for forever there's been multiple locations the ROM will check for the loader. Is there a reason to not handle this at that level?

The u-boot-with-spl.sfp was there to have one U-Boot image including SPL, other platforms do that as well. Except for the NAND case, where the padding is different.

#6 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 51 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 39 lines · Chee Hong Ang

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +7 -4
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
Quoted 8 lines

Makefile cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \ · line 1601

Quoted 2 lines
Makefile +0 -0
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)

It's not immediately clear to me why we're doing this here, rather than instructing the user to write the file 4 times when programming. On TI platforms, even on NAND, for forever there's been multiple locations the ROM will check for the loader. Is there a reason to not handle this at that level?

Quoted 3 lines

The u-boot-with-spl.sfp was there to have one U-Boot image including SPL, other platforms do that as well. Except for the NAND case, where the padding is different.

Right, it's a convenience file and handy in some cases. But what's the reason for doing the 4 copy case? It makes sense to create "u-boot-with-stuff-plus-header" when there's a header that has to cover the whole load, or you're going to write it to an SD card or there's some non-trivial mangling involved. Is the problem that "u-boot-spl.sfp" isn't ever expected to be seen by the user and so it would be odd to tell them to write that in the 4 places and then write u-boot.img in the correct place, so instead we have to pad everything out and make a large file?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200811/871d4d28/attachment.sig>
#7 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Am 11.08.2020 um 16:21 schrieb Tom Rini:

Quoted 56 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 41 lines · Chee Hong Ang
Quoted 40 lines

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +7 -4
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
Quoted 8 lines

Makefile cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \ · line 1601

Quoted 2 lines
Makefile +0 -0
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)

It's not immediately clear to me why we're doing this here, rather than instructing the user to write the file 4 times when programming. On TI platforms, even on NAND, for forever there's been multiple locations the ROM will check for the loader. Is there a reason to not handle this at that level?

Quoted 3 lines

The u-boot-with-spl.sfp was there to have one U-Boot image including SPL, other platforms do that as well. Except for the NAND case, where the padding is different.

Quoted 9 lines

Right, it's a convenience file and handy in some cases. But what's the reason for doing the 4 copy case? It makes sense to create "u-boot-with-stuff-plus-header" when there's a header that has to cover the whole load, or you're going to write it to an SD card or there's some non-trivial mangling involved. Is the problem that "u-boot-spl.sfp" isn't ever expected to be seen by the user and so it would be odd to tell them to write that in the 4 places and then write u-boot.img in the correct place, so instead we have to pad everything out and make a large file?

As U-Boot and SPL have to fit together, I think it's better to create just one file that has to be written to SD card or flash. And writing to NOR flash is, depending on how you do it, not too quick, so it's *very* convenient to have this "4x SPL plus U-Boot" single file (start the command, get a coffee and wait).

And yes, it *is* just a convenience thing. But I think it's a good thing to have as result from the build. Even if it's only for the "dumb standard user" not having to know the offset where U-Boot has to be put...

Regards,
Simon

#8 lore raw

PATCH v2 1/1 Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

Quoted 73 lines · Simon Goldschmidt

Am 11.08.2020 um 16:21 schrieb Tom Rini:

Quoted 56 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 41 lines · Chee Hong Ang
Quoted 40 lines

Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for booting up Cyclone5/Arria10.

For Cyclone5 using NAND flash image layout for 128 KB memory blocks, 'make u-boot-with-nand-spl.sfp' to generate spl/u-boot-nand-splx4.sfp which contains four 128KB SPL images (each 64KB SPL is followed by 64KB of zero-padding).

---
 Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Makefile +7 -4
index 4483a9b..f4631f1 100644
@@ -1582,8 +1582,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE
 ifneq ($(CONFIG_ARCH_SOCFPGA),)
 quiet_cmd_socboot = SOCBOOT $@
 cmd_socboot = cat	spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			spl/u-boot-spl.sfp spl/u-boot-spl.sfp	\
-			u-boot.img > $@ || rm -f $@
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \
+	      cat	spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@
 u-boot-with-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socboot)
 
@@ -1592,8 +1593,10 @@ cmd_socnandboot =  dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \
 		   cat	spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
 			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			spl/u-boot-spl.sfp spl/u-boot-spl.pad \
-			u-boot.img > $@ || rm -f $@ spl/u-boot-spl.pad
+			spl/u-boot-spl.sfp \
+			spl/u-boot-spl.pad > spl/u-boot-nand-splx4.sfp ; \
+		   cat	spl/u-boot-nand-splx4.sfp u-boot.img > $@ || \
+		   rm	-f $@ spl/u-boot-spl.pad
Quoted 8 lines

Makefile cmd_socnandboot = dd if=/dev/zero of=spl/u-boot-spl.pad bs=64 count=1024 ; \ · line 1601

Quoted 2 lines
Makefile +0 -0
 u-boot-with-nand-spl.sfp: spl/u-boot-spl.sfp u-boot.img FORCE
 	$(call if_changed,socnandboot)

It's not immediately clear to me why we're doing this here, rather than instructing the user to write the file 4 times when programming. On TI platforms, even on NAND, for forever there's been multiple locations the ROM will check for the loader. Is there a reason to not handle this at that level?

Quoted 3 lines

The u-boot-with-spl.sfp was there to have one U-Boot image including SPL, other platforms do that as well. Except for the NAND case, where the padding is different.

Quoted 9 lines

Right, it's a convenience file and handy in some cases. But what's the reason for doing the 4 copy case? It makes sense to create "u-boot-with-stuff-plus-header" when there's a header that has to cover the whole load, or you're going to write it to an SD card or there's some non-trivial mangling involved. Is the problem that "u-boot-spl.sfp" isn't ever expected to be seen by the user and so it would be odd to tell them to write that in the 4 places and then write u-boot.img in the correct place, so instead we have to pad everything out and make a large file?

As U-Boot and SPL have to fit together, I think it's better to create just one file that has to be written to SD card or flash. And writing to NOR flash is, depending on how you do it, not too quick, so it's *very* convenient to have this "4x SPL plus U-Boot" single file (start the command, get a coffee and wait).

Quoted 3 lines

And yes, it *is* just a convenience thing. But I think it's a good thing to have as result from the build. Even if it's only for the "dumb standard user" not having to know the offset where U-Boot has to be put...

Alright, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200811/f0d75422/attachment.sig>