Skip to contentSkip to conversation

libpeas: gobject-introspection is mandatory and cannot be configured

PATCH In review Adrian Bunk 3 participants 6 messages Aug 8, 2020 – Aug 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libpeas: gobject-introspection is mandatory and cannot be configured

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".

---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +4 -0
index 881751008..1b754343a 100644
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI += " \
Signature · 1 line
2.17.1
#1 lore raw

There is an option for it:
https://gitlab.gnome.org/GNOME/libpeas/-/blob/master/meson_options.txt#L12

so maybe it's a bug somehow?

Alex

Quoted 31 lines · Adrian Bunk

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR:
Unknown variable "libpeas_gir".

---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +0 -0
index 881751008..1b754343a 100644
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache

features_check

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +4 -2
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection
--disable-introspection"
+
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI += " \
--

2.17.1

#2 lore raw
In reply to Adrian Bunk
Quoted 13 lines · Adrian Bunk

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".

---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +0 -0
index 881751008..1b754343a 100644

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb GTKDOC_MESON_OPTION = "gtk_doc" · line 15

Quoted 6 lines
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +3 -0
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"

these are autotools options but since dunfell we use meson to build libpeas so I wonder how this is happening
perhaps some bbappends need to catch up may be ?

Quoted 8 lines
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +1 -1
+
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI += " \
--

2.17.1

#3 lore raw

I had a look at this, the failure is in unit tests which do not honour the meson option to switch introspection off - can be easily patched out I think.

Alex

Quoted 39 lines · Khem Raj
Quoted 2 lines · Adrian Bunk

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR:

Unknown variable "libpeas_gir".

Review

Quoted 7 lines
---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb GTKDOC_MESON_OPTION = "gtk_doc" · line 11

Quoted 6 lines

index 881751008..1b754343a 100644

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +0 -0
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache

features_check

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb GTKDOC_MESON_OPTION = "gtk_doc"

Quoted 4 lines
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +3 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection

--disable-introspection"

these are autotools options but since dunfell we use meson to build libpeas so I wonder how this is happening
perhaps some bbappends need to catch up may be ?

Quoted 8 lines
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +1 -1
+
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI += " \
--

2.17.1

#4 lore raw
Quoted 3 lines · Alexander Kanavin

I had a look at this, the failure is in unit tests which do not honour the meson option to switch introspection off - can be easily patched out I think.

Andreas has just fixed that upstream. :-)

Quoted 1 line

Alex

cu
Adrian

#5 lore raw
In reply to Khem Raj
Quoted 17 lines · Khem Raj
Quoted 16 lines · Adrian Bunk

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".

---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +0 -0
index 881751008..1b754343a 100644
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
 
Quoted 8 lines

meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb GTKDOC_MESON_OPTION = "gtk_doc" · line 15

Quoted 3 lines
meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb +3 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"

these are autotools options but since dunfell we use meson to build libpeas so I wonder how this is happening
perhaps some bbappends need to catch up may be ?
...

No, this was just me pasting from zeus without turning on my brain...

cu
Adrian