package/mtd: crypto support needs linux-headers
PATCH 1/1 package/mtd: crypto support needs linux-headers
crypto support needs linux-headers as it includes <linux/hash_info.h> since version 2.1.2 and
https://github.com/sigma-star/mtd-utils/commit/a739b59efe7996e3bdcbe8b17743dc05ac7c110a
Fixes:
- http://autobuild.buildroot.org/results/dbaeed9e9e2af191166808d2d6d6d3c2e5051c2c
--- package/mtd/mtd.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/mtd/mtd.mk +2 -2
@@ -21,8 +21,8 @@ endif ifeq ($(BR2_PACKAGE_MTD_UBIFS_UTILS),y) MTD_DEPENDENCIES += util-linux zlib lzo host-pkgconf MTD_CONF_OPTS += --with-ubifs -ifeq ($(BR2_PACKAGE_OPENSSL),y) -MTD_DEPENDENCIES += openssl +ifeq ($(BR2_PACKAGE_LINUX_HEADERS)$(BR2_PACKAGE_OPENSSL),yy) +MTD_DEPENDENCIES += linux-headers openssl MTD_CONF_OPTS += --with-crypto else MTD_CONF_OPTS += --without-crypto
Signature · 1 line
2.27.0
PATCH 1/1 package/mtd: crypto support needs linux-headers
Quoted 6 lines · On Tue, 11 Aug 2020 11:19:17 +0200 Fabrice Fontaine via buildroot…
crypto support needs linux-headers as it includes <
linux/hash_info.h> since version 2.1.2 and
https://github.com/sigma-star/mtd-utils/commit/a739b59efe7996e3bdcbe8b17743dc05ac7c110aFixes:
- http://autobuild.buildroot.org/results/dbaeed9e9e2af191166808d2d6d6d3c2e5051c2c
You can't do that, as linux-headers is only used for the internal toolchain backend. Also the kernel headers are already present in all toolchains, so how could this change anything ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/mtd: crypto support needs linux-headers
Le mar. 11 ao?t 2020 ? 12:30, Thomas Petazzoni
<[email protected]> a ?crit :
Quoted 8 lines
Quoted 4 lines · On Tue, 11 Aug 2020 11:19:17 +0200 Fabrice Fontaine via buildroot…
crypto support needs linux-headers as it includes <
linux/hash_info.h> since version 2.1.2 and
https://github.com/sigma-star/mtd-utils/commit/a739b59efe7996e3bdcbe8b17743dc05ac7c110a
Quoted 6 lines
Quoted 2 lines
Fixes:
- http://autobuild.buildroot.org/results/dbaeed9e9e2af191166808d2d6d6d3c2e5051c2cYou can't do that, as linux-headers is only used for the internal toolchain backend. Also the kernel headers are already present in all toolchains, so how could this change anything ?
I was not aware that kernel headers were already present in all toolchains. Thanks for spotting my mistake. I'll send a v2 adding a dependency on headers 4.12 as this is the real issue.
However, it should be noted that we have an "issue" with the iputils package as it has an optional dependency on linux-headers since commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32.
I assume that this dependency is also not needed?
Quoted 6 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
PATCH 1/1 package/mtd: crypto support needs linux-headers
Fabrice, All,
On 2020-08-11 17:01 +0200, Fabrice Fontaine via buildroot spake thusly:
Quoted 4 lines
Le mar. 11 ao?t 2020 ? 12:30, Thomas Petazzoni
<[email protected]> a ?crit :Quoted 2 lines
On Tue, 11 Aug 2020 11:19:17 +0200
Fabrice Fontaine via buildroot <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
crypto support needs linux-headers as it includes <
linux/hash_info.h> since version 2.1.2 andYou can't do that, as linux-headers is only used for the internal toolchain backend. Also the kernel headers are already present in all toolchains, so how could this change anything ?
I was not aware that kernel headers were already present in all toolchains. Thanks for spotting my mistake. I'll send a v2 adding a dependency on headers 4.12 as this is the real issue.
Yes.
Quoted 4 lines
However, it should be noted that we have an "issue" with the iputils package as it has an optional dependency on linux-headers since commit
9ffcd9279e5505535a73cf1200b3a86fd425cf32.
I assume that this dependency is also not needed?
s/not needed/incorrect/, yes
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'