mm: remove superfluous __ClearPageWaiters()
Subsystems (4)
PATCH 3/3 mm: remove superfluous __ClearPageWaiters()
Presumably __ClearPageWaiters() was added to follow the previously removed __ClearPageActive() pattern.
Only flags that are in PAGE_FLAGS_CHECK_AT_FREE needs to be properly cleared because otherwise we think there may be some kind of leak. PG_waiters is not one of those flags and leaving the clearing to PAGE_FLAGS_CHECK_AT_PREP is more appropriate.
Signed-off-by Yu Zhao <[email protected]>
--- include/linux/page-flags.h | 2 +- mm/filemap.c | 2 ++ mm/memremap.c | 2 -- mm/swap.c | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-)
include/linux/page-flags.h +1 -1
@@ -318,7 +318,7 @@ static inline int TestClearPage##uname(struct page *page) { return 0; } TESTSETFLAG_FALSE(uname) TESTCLEARFLAG_FALSE(uname) __PAGEFLAG(Locked, locked, PF_NO_TAIL) -PAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) __CLEARPAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) +PAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) PAGEFLAG(Error, error, PF_NO_TAIL) TESTCLEARFLAG(Error, error, PF_NO_TAIL) PAGEFLAG(Referenced, referenced, PF_HEAD) TESTCLEARFLAG(Referenced, referenced, PF_HEAD)
mm/filemap.c +2 -0
@@ -1079,6 +1079,8 @@ static void wake_up_page_bit(struct page *page, int bit_nr)* other pages on it. * * That's okay, it's a rare case. The next waker will clear it. +* Otherwise the bit will be cleared by PAGE_FLAGS_CHECK_AT_PREP +* when the page is being freed. */ }spin_unlock_irqrestore (&q->lock, flags);
mm/memremap.c +0 -2
@@ -451,8 +451,6 @@ void free_devmap_managed_page(struct page *page)return ; } -__ClearPageWaiters (page); -mem_cgroup_uncharge (page);/*
mm/swap.c +0 -3
@@ -90,7 +90,6 @@ static void __page_cache_release(struct page *page)del_page_from_lru_list (page, lruvec,page_off_lru (page));spin_unlock_irqrestore (&pgdat->lru_lock, flags); } -__ClearPageWaiters (page); }static void __put_single_page (struct page *page)
@@ -898,8 +897,6 @@ void release_pages(struct page **pages, int nr)del_page_from_lru_list (page, lruvec,page_off_lru (page)); } -__ClearPageWaiters (page); -list_add (&page->lru, &pages_to_free); }if (locked_pgdat)
Signature · 1 line
2.28.0.236.gb10cc79966-goog