drivers: optee: allow op-tee to access devices on the i2c bus
Subsystems (2)
PATCH v8 1/1 drivers: optee: allow op-tee to access devices on the i2c bus
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way.
This trampoline driver allow OP-TEE to access them.
---
v8: review fixes
fix types and add TEEC_ERROR_NOT_SUPPORTED to GP errors
v7: add support for ten bit i2c slave addressing
v6: compile out if CONFIG_I2C not enabled
v5: alphabetic order of includes
v4: remove unnecessary extra line in optee_msg.h
v3: use from/to msg param to support all types of memory
modify OPTEE_MSG_RPC_CMD_I2C_TRANSFER message id
drivers/tee/optee/optee_msg.h | 21 +++++++ drivers/tee/optee/optee_private.h | 1 + drivers/tee/optee/rpc.c | 96 +++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)
drivers/tee/optee/optee_msg.h +21 -0
@@ -419,4 +419,25 @@ struct optee_msg_arg {*/ #define OPTEE_MSG_RPC_CMD_SHM_FREE 7 +/* +* Access a device on an i2c bus +* +* [in] param[0].u.value.a mode: RD(0), WR(1) +* [in] param[0].u.value.b i2c adapter +* [in] param[0].u.value.c i2c chip +* +* [in] param[1].u.value.a i2c control flags +* +* [in/out] memref[2] buffer to exchange the transfer data +* with the secure world +* +* [out] param[3].u.value.a bytes transferred by the driver +*/ +#define OPTEE_MSG_RPC_CMD_I2C_TRANSFER 21 +/* I2C master transfer modes */ +#define OPTEE_MSG_RPC_CMD_I2C_TRANSFER_RD 0 +#define OPTEE_MSG_RPC_CMD_I2C_TRANSFER_WR 1 +/* I2C master control flags */ +#define OPTEE_MSG_RPC_CMD_I2C_FLAGS_TEN_BIT BIT(0) +#endif /* _OPTEE_MSG_H */
drivers/tee/optee/optee_private.h +1 -0
@@ -17,6 +17,7 @@/* Some Global Platform error codes used in this driver */ #define TEEC_SUCCESS 0x00000000#define TEEC_ERROR_BAD_PARAMETERS 0xFFFF0006 +#define TEEC_ERROR_NOT_SUPPORTED 0xFFFF000A#define TEEC_ERROR_COMMUNICATION 0xFFFF000E#define TEEC_ERROR_OUT_OF_MEMORY 0xFFFF000C#define TEEC_ERROR_SHORT_BUFFER 0xFFFF0010
drivers/tee/optee/rpc.c +96 -0
114 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 18 lines · Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and
RUNTIME_PMdont get in the way.This trampoline driver allow OP-TEE to access them.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
v8: review fixes
fix types and addTEEC_ERROR_NOT_SUPPORTEDto GP errors
v7: add support for ten bit i2c slave addressing
v6: compile out ifCONFIG_I2Cnot enabled
v5: alphabetic order of includes
v4: remove unnecessary extra line inoptee_msg.h
v3: use from/to msg param to support all types of memory
modifyOPTEE_MSG_RPC_CMD_I2C_TRANSFERmessage id
Quoted 5 lines
drivers/tee/optee/optee_msg.h | 21 +++++++ drivers/tee/optee/optee_private.h | 1 + drivers/tee/optee/rpc.c | 96 +++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)
This looks good to me. Did you test this with the recently merged
https://github.com/OP-TEE/optee_os/pull/4024 ?
Cheers,
Jens
Quoted 19 lines · Jens Wiklander
Quoted 18 lines · Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and
RUNTIME_PMdont get in the way.This trampoline driver allow OP-TEE to access them.
Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
v8: review fixes
fix types and addTEEC_ERROR_NOT_SUPPORTEDto GP errors
v7: add support for ten bit i2c slave addressing
v6: compile out ifCONFIG_I2Cnot enabled
v5: alphabetic order of includes
v4: remove unnecessary extra line inoptee_msg.h
v3: use from/to msg param to support all types of memory
modifyOPTEE_MSG_RPC_CMD_I2C_TRANSFERmessage id
Quoted 8 lines
Quoted 5 lines
drivers/tee/optee/optee_msg.h | 21 +++++++ drivers/tee/optee/optee_private.h | 1 + drivers/tee/optee/rpc.c | 96 +++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)This looks good to me. Did you test this with the recently merged
https://github.com/OP-TEE/optee_os/pull/4024 ?
I am in the process (please hold this until I can validate end to end as I was doing with the original code).
I had to rebase from 3.6.0 to the tip of op-tee so it is taking me a bit longer than anticipated.
Also I noticed that unfortunately a bug managed to get in that PR. The return value is on p[3] not in p[2].
See below.
https://github.com/OP-TEE/optee_os/commit/30c53a72426366d0a4eb4aa396c37b8fd048a82a#r41447494
Also this version v8 also has now a problem (params get updated after calling optee_to_msg_param hence the i2c return value from the transfer does never reach optee)
apologies. will fix.
Quoted 3 lines
Cheers,
Jens