Skip to contentSkip to conversation

net/ena/base: fix doorbell evaluation for the LLQ case

PATCH Applied Artur Rojek 3 participants 3 messages Aug 13, 2020 – Aug 18, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ena/base: fix doorbell evaluation for the LLQ case

From: Michal Krawczyk <[email protected]>

This patch adds a missing LLQ-related check in the ena_com_is_doorbell_needed() routine, which is relevant for the feature supported by the next generation HW of the ENA.

Fixes b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
[Extracted from a bigger patch]
---
 drivers/net/ena/base/ena_eth_com.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ena/base/ena_eth_com.h +2 -1
index e37b642d4..3d66237b8 100644
@@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
 	llq_info = &io_sq->llq_info;
 	num_descs = ena_tx_ctx->num_bufs;
 
-	if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
+	if (llq_info->disable_meta_caching ||
+	    unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
 		++num_descs;
 
 	if (num_descs > llq_info->descs_num_before_header) {
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

śr., 12 sie 2020 o 18:37 Artur Rojek <[email protected]> napisał(a):

Quoted 7 lines

From: Michal Krawczyk <[email protected]>

This patch adds a missing LLQ-related check in the ena_com_is_doorbell_needed() routine, which is relevant for the feature supported by the next generation HW of the ENA.

Quoted 6 lines
Fixes b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
[Extracted from a bigger patch]
Quoted 21 lines
---
 drivers/net/ena/base/ena_eth_com.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ena/base/ena_eth_com.h +2 -2
index e37b642d4..3d66237b8 100644
@@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
        llq_info = &io_sq->llq_info;
        num_descs = ena_tx_ctx->num_bufs;
 
-       if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
+       if (llq_info->disable_meta_caching ||
+           unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
                ++num_descs;
 
        if (num_descs > llq_info->descs_num_before_header) {
--

2.28.0

Applied
#2 lore raw
Quoted 10 lines · Marcin Wojtas

Hi,

śr., 12 sie 2020 o 18:37 Artur Rojek <[email protected]> napisał(a):

Quoted 7 lines

From: Michal Krawczyk <[email protected]>

This patch adds a missing LLQ-related check in the ena_com_is_doorbell_needed() routine, which is relevant for the feature supported by the next generation HW of the ENA.

Quoted 9 lines
Quoted 6 lines
Fixes b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
[Extracted from a bigger patch]

Applied to dpdk-next-net/main, thanks.