net/ena/base: fix doorbell evaluation for the LLQ case
PATCH 1/1 net/ena/base: fix doorbell evaluation for the LLQ case
From: Michal Krawczyk <[email protected]>
This patch adds a missing LLQ-related check in the ena_com_is_doorbell_needed() routine, which is relevant for the feature supported by the next generation HW of the ENA.
--- drivers/net/ena/base/ena_eth_com.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ena/base/ena_eth_com.h +2 -1
@@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq, llq_info = &io_sq->llq_info; num_descs = ena_tx_ctx->num_bufs; -if (unlikely (ena_com_meta_desc_changed (io_sq, ena_tx_ctx))) +if (llq_info->disable_meta_caching || +unlikely (ena_com_meta_desc_changed (io_sq, ena_tx_ctx))) ++num_descs;if (num_descs > llq_info->descs_num_before_header) {
Signature · 1 line
2.28.0
Hi,
śr., 12 sie 2020 o 18:37 Artur Rojek <[email protected]> napisał(a):
Quoted 7 lines
From: Michal Krawczyk <[email protected]>
This patch adds a missing LLQ-related check in the
ena_com_is_doorbell_needed()routine, which is relevant for the feature supported by the next generation HW of the ENA.
Quoted 6 lines
Fixes b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")Signed-off-by Michal Krawczyk <[email protected]>[Extracted from a bigger patch]Signed-off-by Artur Rojek <[email protected]>
Quoted 21 lines
--- drivers/net/ena/base/ena_eth_com.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/ena/base/ena_eth_com.h +2
-2@@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq, llq_info = &io_sq->llq_info; num_descs = ena_tx_ctx->num_bufs; -if (unlikely (ena_com_meta_desc_changed (io_sq, ena_tx_ctx))) +if (llq_info->disable_meta_caching || +unlikely (ena_com_meta_desc_changed (io_sq, ena_tx_ctx))) ++num_descs;if (num_descs > llq_info->descs_num_before_header) { --2.28.0
Ferruh Yigit
AppliedQuoted 10 lines · Marcin Wojtas
Hi,
śr., 12 sie 2020 o 18:37 Artur Rojek <[email protected]> napisał(a):
Quoted 7 lines
From: Michal Krawczyk <[email protected]>
This patch adds a missing LLQ-related check in the
ena_com_is_doorbell_needed()routine, which is relevant for the feature supported by the next generation HW of the ENA.
Quoted 9 lines
Quoted 6 lines
Fixes b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")Signed-off-by Michal Krawczyk <[email protected]>[Extracted from a bigger patch]Signed-off-by Artur Rojek <[email protected]>Reviewed-by Marcin Wojtas <[email protected]>
Applied to dpdk-next-net/main, thanks.