Skip to contentSkip to conversation

package/iputils: drop wrong linux-headers dependency

PATCH New Fabrice Fontaine 4 participants 4 messages Aug 11, 2020 – Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/iputils: drop wrong linux-headers dependency

Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a linux-headers dependency when switching to meson.

Remove it as headers are always provided by the toolchain.

---
 package/iputils/iputils.mk | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
package/iputils/iputils.mk +1 -6
index 0d260891e2..d09bc58b34 100644
@@ -40,13 +40,8 @@ IPUTILS_DEPENDENCIES += libgcrypt
 else ifeq ($(BR2_PACKAGE_OPENSSL),y)
 IPUTILS_CONF_OPTS += -DUSE_CRYPTO=openssl
 IPUTILS_DEPENDENCIES += openssl
-else ifeq ($(BR2_PACKAGE_LINUX_HEADERS),y)
-IPUTILS_CONF_OPTS += -DUSE_CRYPTO=kernel
-IPUTILS_DEPENDENCIES += linux-headers
 else
-IPUTILS_CONF_OPTS += -DUSE_CRYPTO=none
-# BUILD_NINFOD=true and USE_CRYPTO=none cannot be combined
-IPUTILS_NINFOD = n
+IPUTILS_CONF_OPTS += -DUSE_CRYPTO=kernel
 endif
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/iputils: drop wrong linux-headers dependency

Hi Fabrice,

Quoted 6 lines

Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a linux-headers dependency when switching to meson.

Remove it as headers are always provided by the toolchain.

Thanks!

BTW next release (which should be soon) will not depend on any crypto library (md5 implementation is included).

Kind regards,
Petr

#2 lore raw

PATCH 1/1 package/iputils: drop wrong linux-headers dependency

In reply to Fabrice Fontaine
Quoted 9 lines · On Wed, 12 Aug 2020 00:37:40 +0200 Fabrice Fontaine via buildroot…

Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a linux-headers dependency when switching to meson.

Remove it as headers are always provided by the toolchain.

---
 package/iputils/iputils.mk | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/iputils: drop wrong linux-headers dependency

In reply to Fabrice Fontaine
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine via buildroot <[email protected]> writes:

Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a linux-headers dependency when switching to meson.

Remove it as headers are always provided by the toolchain.

Committed to 2020.02.x and 2020.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard