random32: add a tracepoint for prandom_u32()
Subsystems (4)
PATCH 1/1 random32: add a tracepoint for prandom_u32()
There has been some heat around prandom_u32() lately, and some people were wondering if there was a simple way to determine how often it was used, before considering making it maybe 10 times more expensive.
This tracepoint exports the generated pseudo random value.
Tested:
perf list | grep prandom_u32
random:prandom_u32 [Tracepoint event]
perf record -a [-g] [-C1] -e random:prandom_u32 sleep 1
[ perf record: Woken up 0 times to write data ]
[ perf record: Captured and wrote 259.748 MB perf.data (924087 samples) ]
perf report --nochildren
...
97.67% ksoftirqd/1 [kernel.vmlinux] [k] prandom_u32
|
---prandom_u32
prandom_u32
|
|--48.86%--tcp_v4_syn_recv_sock
| tcp_check_req
| tcp_v4_rcv
| ...
--48.81%--tcp_conn_request
tcp_v4_conn_request
tcp_rcv_state_process
...perf script
---
According to MAINTAINERS, lib/random32.c is part of networking...
include/trace/events/random.h | 17 +++++++++++++++++ lib/random32.c | 2 ++ 2 files changed, 19 insertions(+)
include/trace/events/random.h +17 -0
@@ -307,6 +307,23 @@ TRACE_EVENT(urandom_read, __entry->pool_left, __entry->input_left) ); +TRACE_EVENT (prandom_u32, + + TP_PROTO(unsigned int ret), + +TP_ARGS (ret), + +TP_STRUCT__entry ( + __field( unsigned int, ret) + ), + +TP_fast_assign ( + __entry->ret = ret; + ), + +TP_printk ("ret=%u" , __entry->ret) +); +#endif /* _TRACE_RANDOM_H */ /* This part must be outside protection */
lib/random32.c +2 -0
@@ -39,6 +39,7 @@#include <linux/random.h> #include <linux/sched.h> #include <asm/unaligned.h> +#include <trace/events/random.h> #ifdef CONFIG_RANDOM32_SELFTEST static void __init prandom_state_selftest (void );
@@ -82,6 +83,7 @@ u32 prandom_u32(void)u32 res; res =prandom_u32_state (state); +trace_prandom_u32 (res);put_cpu_var (net_rand_state);return res;
Signature · 1 line
2.28.0.220.ged08abb693-goog
Quoted 31 lines · Eric Dumazet
There has been some heat around
prandom_u32()lately, and some people were wondering if there was a simple way to determine how often it was used, before considering making it maybe 10 times more expensive.This tracepoint exports the generated pseudo random value.
Tested:
perf list | grep
prandom_u32
random:prandom_u32 [Tracepoint event]perf record -a [-g] [-C1] -e random:prandom_u32 sleep 1
[ perf record: Woken up 0 times to write data ]
[ perf record: Captured and wrote 259.748 MB perf.data (924087 samples) ]perf report --nochildren
... 97.67% ksoftirqd/1 [kernel.vmlinux] [k] prandom_u32 | ---prandom_u32 prandom_u32 | |--48.86%--tcp_v4_syn_recv_sock | tcp_check_req | tcp_v4_rcv | ... --48.81%--tcp_conn_request tcp_v4_conn_request tcp_rcv_state_process ...
Quoted 5 lines
perf script
Signed-off-by Eric Dumazet <[email protected]>Cc Willy Tarreau <[email protected]>Cc Sedat Dilek <[email protected]>
Thanks for the patch and embedding a list of instructions with linux-perf.
- Sedat -
Quoted 58 lines
---
According toMAINTAINERS,lib/random32.cis part of networking...include/trace/events/random.h | 17 +++++++++++++++++ lib/random32.c | 2 ++ 2 files changed, 19 insertions(+)include/trace/events/random.h +17
-0@@ -307,6 +307,23 @@ TRACE_EVENT(urandom_read, __entry->pool_left, __entry->input_left) ); +TRACE_EVENT (prandom_u32, + + TP_PROTO(unsigned int ret), + +TP_ARGS (ret), + +TP_STRUCT__entry ( + __field( unsigned int, ret) + ), + +TP_fast_assign ( + __entry->ret = ret; + ), + +TP_printk ("ret=%u" , __entry->ret) +); +#endif /* _TRACE_RANDOM_H */ /* This part must be outside protection */ lib/random32.c +2
-1@@ -39,6 +39,7 @@#include <linux/random.h> #include <linux/sched.h> #include <asm/unaligned.h> +#include <trace/events/random.h> #ifdef CONFIG_RANDOM32_SELFTEST static void __init prandom_state_selftest (void );@@ -82,6 +83,7 @@ u32 prandom_u32(void)u32 res; res =prandom_u32_state (state); +trace_prandom_u32 (res);put_cpu_var (net_rand_state);return res; --2.28.0.220.ged08abb693-goog
From: Eric Dumazet <[email protected]>
Date: Thu, 13 Aug 2020 10:06:43 -0700
Quoted 30 lines
There has been some heat around
prandom_u32()lately, and some people were wondering if there was a simple way to determine how often it was used, before considering making it maybe 10 times more expensive.This tracepoint exports the generated pseudo random value.
Tested:
perf list | grep
prandom_u32
random:prandom_u32 [Tracepoint event]perf record -a [-g] [-C1] -e random:prandom_u32 sleep 1
[ perf record: Woken up 0 times to write data ]
[ perf record: Captured and wrote 259.748 MB perf.data (924087 samples) ]perf report --nochildren
... 97.67% ksoftirqd/1 [kernel.vmlinux] [k] prandom_u32 | ---prandom_u32 prandom_u32 | |--48.86%--tcp_v4_syn_recv_sock | tcp_check_req | tcp_v4_rcv | ... --48.81%--tcp_conn_request tcp_v4_conn_request tcp_rcv_state_process ...
Quoted 3 lines
perf script
Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks Eric.