Skip to contentSkip to conversation

libbacktrace: new package

PATCH Superseded Avi Shukron 3 participants 5 messages Aug 13, 2020 – Aug 15, 2020

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libbacktrace: new package

libbacktrace is a C library that may be linked into a C/C++ program to produce symbolic backtraces.

---
 package/Config.in                      |  1 +
 package/libbacktrace/Config.in         |  7 +++++++
 package/libbacktrace/libbacktrace.hash |  3 +++
 package/libbacktrace/libbacktrace.mk   | 16 ++++++++++++++++
 4 files changed, 27 insertions(+)
 create mode 100644 package/libbacktrace/Config.in
 create mode 100644 package/libbacktrace/libbacktrace.hash
 create mode 100644 package/libbacktrace/libbacktrace.mk
package/Config.in +1 -0
index d7e79f4795..cf65919091 100644
@@ -179,6 +179,7 @@ menu "Development tools"
 	source "package/subversion/Config.in"
 	source "package/tree/Config.in"
 	source "package/yasm/Config.in"
+	source "package/libbacktrace/Config.in"
 endmenu
 
 menu "Filesystem and flash utilities"
package/libbacktrace/Config.in new file +7 -0
new file mode 100644
index 0000000000..0f940dd588
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBBACKTRACE
+	bool "libbacktrace"
+	help
+	  A C library that may be linked into a C/C++ program to
+	  produce symbolic backtraces
+
+	  https://github.com/ianlancetaylor/libbacktrace
package/libbacktrace/libbacktrace.hash new file +3 -0
new file mode 100644
index 0000000000..9c73990677
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8  LICENSE
+sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5  9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz
package/libbacktrace/libbacktrace.mk new file +16 -0
new file mode 100644
index 0000000000..4179295cea
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libbacktrace
+#
+################################################################################
+
+LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704
+LIBBACKTRACE_SITE = https://github.com/ianlancetaylor/libbacktrace/archive
+LIBBACKTRACE_SOURCE = $(LIBBACKTRACE_VERSION).tar.gz
+
+LIBBACKTRACE_LICENSE = BSD
+LIBBACKTRACE_LICENSE_FILES = LICENSE
+
+LIBBACKTRACE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 libbacktrace: new package

Avi, All,

On 2020-08-13 23:11 +0300, Avi Shukron spake thusly:

Quoted 2 lines

libbacktrace is a C library that may be linked into a C/C++ program to produce symbolic backtraces.

Thanks for this patch. See below for some comments.

Quoted 16 lines
---
 package/Config.in                      |  1 +
 package/libbacktrace/Config.in         |  7 +++++++
 package/libbacktrace/libbacktrace.hash |  3 +++
 package/libbacktrace/libbacktrace.mk   | 16 ++++++++++++++++
 4 files changed, 27 insertions(+)
 create mode 100644 package/libbacktrace/Config.in
 create mode 100644 package/libbacktrace/libbacktrace.hash
 create mode 100644 package/libbacktrace/libbacktrace.mk
package/Config.in +0 -0
index d7e79f4795..cf65919091 100644

package/Config.in menu "Development tools" · line 182

Quoted 4 lines
package/Config.in +1 -0
@@ -179,6 +179,7 @@ menu "Development tools"
 	source "package/subversion/Config.in"
 	source "package/tree/Config.in"
 	source "package/yasm/Config.in"
+	source "package/libbacktrace/Config.in"

Keep alphabetical ordering. This can be verified with:

    $ make check-package
    package/Config.in:182: Packages in: menu "Development tools",
                           are not alphabetically ordered;
                           correct order: '-', '_', digits, capitals, lowercase;
                           first incorrect package: libbacktrace

[--SNIP--]

package/libbacktrace/libbacktrace.hash line 3

Quoted 9 lines
package/libbacktrace/libbacktrace.hash new file +3 -0
new file mode 100644
index 0000000000..9c73990677
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8  LICENSE
+sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5  9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz

It is customary that we put the licenses after the source archives.

Quoted 6 lines
package/libbacktrace/libbacktrace.mk new file +0 -0
new file mode 100644
index 0000000000..4179295cea

package/libbacktrace/libbacktrace.mk line 9

Quoted 9 lines
package/libbacktrace/libbacktrace.mk new file +9 -0
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libbacktrace
+#
+################################################################################
+
+LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704
+LIBBACKTRACE_SITE = https://github.com/ianlancetaylor/libbacktrace/archive
+LIBBACKTRACE_SOURCE = $(LIBBACKTRACE_VERSION).tar.gz

You should use the github helper macro, as this provides a better named archive, and thus you do not need to set the _SOURCE variable either:

    LIBBACTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION))

package/libbacktrace/libbacktrace.mk line 11

Quoted 1 line
package/libbacktrace/libbacktrace.mk new file +1 -0
+LIBBACKTRACE_LICENSE = BSD

There are a lot of "BSD" license, so we want to have the exact one. The closest would be BSD-3C, but the wording of the third bullet point is slightly different, so it is not exactly BSD-3C.

I think we can list it as:

LIBBACKTRACE_LICENSE = BSD-3C-like

Care to fix those and respin, please?

Regards,
Yann E. MORIN.

Quoted 12 lines
package/libbacktrace/libbacktrace.mk new file +5 -0
+LIBBACKTRACE_LICENSE_FILES = LICENSE
+
+LIBBACKTRACE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 libbacktrace: new package

A C library that may be linked into a C/C++ program to produce symbolic backtraces.

---
 package/Config.in                      |  1 +
 package/libbacktrace/Config.in         |  7 +++++++
 package/libbacktrace/libbacktrace.hash |  3 +++
 package/libbacktrace/libbacktrace.mk   | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/libbacktrace/Config.in
 create mode 100644 package/libbacktrace/libbacktrace.hash
 create mode 100644 package/libbacktrace/libbacktrace.mk
package/Config.in +1 -0
index d7e79f4795..7460d3f006 100644
@@ -170,6 +170,7 @@ menu "Development tools"
 	source "package/grep/Config.in"
 	source "package/jo/Config.in"
 	source "package/jq/Config.in"
+	source "package/libbacktrace/Config.in"
 	source "package/libtool/Config.in"
 	source "package/make/Config.in"
 	source "package/patch/Config.in"
package/libbacktrace/Config.in new file +7 -0
new file mode 100644
index 0000000000..0f940dd588
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBBACKTRACE
+	bool "libbacktrace"
+	help
+	  A C library that may be linked into a C/C++ program to
+	  produce symbolic backtraces
+
+	  https://github.com/ianlancetaylor/libbacktrace
package/libbacktrace/libbacktrace.hash new file +3 -0
new file mode 100644
index 0000000000..ecd530a33b
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5  libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz
+sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8  LICENSE
package/libbacktrace/libbacktrace.mk new file +15 -0
new file mode 100644
index 0000000000..fb1f6c058a
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libbacktrace
+#
+################################################################################
+
+LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704
+LIBBACKTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION))
+
+LIBBACKTRACE_LICENSE = BSD-3C-like
+LIBBACKTRACE_LICENSE_FILES = LICENSE
+
+LIBBACKTRACE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1
#3 lore raw

PATCH v2 1/1 libbacktrace: new package

Hello,

Quoted 20 lines · Avi Shukron

A C library that may be linked into a C/C++ program to produce symbolic backtraces.

---
 package/Config.in                      |  1 +
 package/libbacktrace/Config.in         |  7 +++++++
 package/libbacktrace/libbacktrace.hash |  3 +++
 package/libbacktrace/libbacktrace.mk   | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/libbacktrace/Config.in
 create mode 100644 package/libbacktrace/libbacktrace.hash
 create mode 100644 package/libbacktrace/libbacktrace.mk
package/Config.in +0 -0
index d7e79f4795..7460d3f006 100644

package/Config.in menu "Development tools" · line 173

Quoted 4 lines
package/Config.in +1 -0
@@ -170,6 +170,7 @@ menu "Development tools"
        source "package/grep/Config.in"
        source "package/jo/Config.in"
        source "package/jq/Config.in"
+       source "package/libbacktrace/Config.in"

Comparing to other packages in the "development tools" menu, I don't think this is the correct place for libbacktrace.
In my opinion, it should be placed on one of the submenus under "libraries".

Quoted 49 lines
package/Config.in +0 -0
        source "package/libtool/Config.in"
        source "package/make/Config.in"
        source "package/patch/Config.in"
package/libbacktrace/Config.in new file +7 -0
new file mode 100644
index 0000000000..0f940dd588
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBBACKTRACE
+       bool "libbacktrace"
+       help
+         A C library that may be linked into a C/C++ program to
+         produce symbolic backtraces
+
+         https://github.com/ianlancetaylor/libbacktrace
package/libbacktrace/libbacktrace.hash new file +3 -0
new file mode 100644
index 0000000000..ecd530a33b
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5  libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz
+sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8  LICENSE
package/libbacktrace/libbacktrace.mk new file +15 -1
new file mode 100644
index 0000000000..fb1f6c058a
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libbacktrace
+#
+################################################################################
+
+LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704
+LIBBACKTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION))
+
+LIBBACKTRACE_LICENSE = BSD-3C-like
+LIBBACKTRACE_LICENSE_FILES = LICENSE
+
+LIBBACKTRACE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
--

2.25.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Asaf.

#4 lore raw

PATCH v2 1/1 libbacktrace: new package

The only appropriate submenu under "Libraries" is alongside libunwind under "Other",
which is kinda saying "I don't know where else to put it". Anyway - I don't think it is
important too much as long as it is searchable in a place that makes sense.

I'll send v3 soon.

Quoted 91 lines · Asaf Kahlon

Hello,

Quoted 20 lines · Avi Shukron

A C library that may be linked into a C/C++ program to produce symbolic backtraces.

---
 package/Config.in                      |  1 +
 package/libbacktrace/Config.in         |  7 +++++++
 package/libbacktrace/libbacktrace.hash |  3 +++
 package/libbacktrace/libbacktrace.mk   | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/libbacktrace/Config.in
 create mode 100644 package/libbacktrace/libbacktrace.hash
 create mode 100644 package/libbacktrace/libbacktrace.mk
package/Config.in +0 -0
index d7e79f4795..7460d3f006 100644

package/Config.in menu "Development tools" · line 173

Quoted 4 lines
package/Config.in +1 -0
@@ -170,6 +170,7 @@ menu "Development tools"
        source "package/grep/Config.in"
        source "package/jo/Config.in"
        source "package/jq/Config.in"
+       source "package/libbacktrace/Config.in"

Comparing to other packages in the "development tools" menu, I don't think this is the correct place for libbacktrace.
In my opinion, it should be placed on one of the submenus under "libraries".

Review

Quoted 4 lines
package/Config.in +0 -0
        source "package/libtool/Config.in"
        source "package/make/Config.in"
        source "package/patch/Config.in"
(quoted diff) +0 -0

b/package/libbacktrace/Config.in

Review

Quoted 13 lines

new file mode 100644
index 0000000000..0f940dd588

package/libbacktrace/Config.in new file +7 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBBACKTRACE
+       bool "libbacktrace"
+       help
+         A C library that may be linked into a C/C++ program to
+         produce symbolic backtraces
+
+         https://github.com/ianlancetaylor/libbacktrace
(quoted diff) +0 -0

b/package/libbacktrace/libbacktrace.hash

package/libbacktrace/libbacktrace.hash line 2

Quoted 7 lines

new file mode 100644
index 0000000000..ecd530a33b

package/libbacktrace/libbacktrace.hash new file +2 -0
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256

13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz

package/libbacktrace/libbacktrace.hash line 3

Quoted 1 line
package/libbacktrace/libbacktrace.hash new file +1 -0
+sha256

ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE

Review

Quoted 1 line
(quoted diff) +0 -0

b/package/libbacktrace/libbacktrace.mk

package/libbacktrace/libbacktrace.mk

Quoted 6 lines

new file mode 100644
index 0000000000..fb1f6c058a

package/libbacktrace/libbacktrace.mk new file +0 -0
@@ -0,0 +1,15 @@

+################################################################################

package/libbacktrace/libbacktrace.mk line 4

Quoted 4 lines
package/libbacktrace/libbacktrace.mk new file +3 -0
+#
+# libbacktrace
+#

+################################################################################

package/libbacktrace/libbacktrace.mk

Quoted 3 lines
package/libbacktrace/libbacktrace.mk new file +3 -0
+
+LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704
+LIBBACKTRACE_SITE = $(call

github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION))

Quoted 10 lines
package/libbacktrace/libbacktrace.mk new file +7 -1
+
+LIBBACKTRACE_LICENSE = BSD-3C-like
+LIBBACKTRACE_LICENSE_FILES = LICENSE
+
+LIBBACKTRACE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
--

2.25.1

Quoted 7 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Asaf.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200815/ec0bb0e7/attachment.html>