Skip to contentSkip to conversation

package/mender-artifact: do not download modules during the build process

PATCH New aduskett at gmail.com 1 participant 1 message Aug 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/mender-artifact: do not download modules during the build process

From: Adam Duskett <[email protected]>

By default, go will attempt to download needed modules before building, which is not desirable. This behavior also causes permission issues when cleaning, as go downloads modules as read-only by default. Because mender-artifact includes the modules in the vendor directory, mod=vendor prevents the package from downloading the go modules during the build process and prevents permission issues when cleaning.

Fixes:
http://autobuild.buildroot.net/results/d5bcaca73ae74fe8b0ebd39b6331564cd639fb66

---
Changes v1 -> v2:
- Reword commit message
- Add a comment in the .mk file

 package/mender-artifact/mender-artifact.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/mender-artifact/mender-artifact.mk +8 -0
index c81ec9ba53..67fdc44b9d 100644
@@ -31,6 +31,14 @@ HOST_MENDER_ARTIFACT_LICENSE_FILES = \
 
 HOST_MENDER_ARTIFACT_DEPENDENCIES = host-xz
 
+# By default, go will attempt to download needed modules before building, which
+# is not desirable. This behavior also causes permission issues when cleaning,
+# as go downloads modules as read-only by default. Because mender-artifact
+# includes the modules in the vendor directory, mod=vendor prevents the package
+# from downloading the go modules during the build process and prevents
+# permission issues when cleaning.
+HOST_MENDER_ARTIFACT_GO_ENV = GOFLAGS="-mod=vendor"
+
 HOST_MENDER_ARTIFACT_LDFLAGS = -X main.Version=$(HOST_MENDER_ARTIFACT_VERSION)
 
 HOST_MENDER_ARTIFACT_BUILD_TARGETS = cli/mender-artifact
Signature · 1 line
2.26.2