config: remap flags used for Arm platforms
Subsystems (2)
RFC PATCH 1/1 config: remap flags used for Arm platforms
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use: RTE_ARCH_ARM, RTE_ARCH_ARMv7 and RTE_ARCH_ARM64.RTE_ARCH_ARM64 is used to flag 64-bit aarch64 platforms, while RTE_ARCH_ARM & RTE_ARCH_ARMv7 are used to flag 32-bit platforms. RTE_ARCH_ARMv7 is for ARMv7 platforms as its name suggested.
The issue is that flag name RTE_ARCH_ARM is unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.
RTE_ARCH_ARM
|
+----RTE_ARCH_ARM32
| |
| +----RTE_ARCH_ARMv7
| |
| +----RTE_ARCH_ARMv8_AARCH32
|
+----RTE_ARCH_ARM64RTE_ARCH_ARM32 will be used for 32-bit Arm platforms.
It includes RTE_ARCH_ARMv7 and RTE_ARCH_ARMv8_AARCH32. RTE_ARCH_ARMv7 is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32 is for aarch32 state on aarch64 platforms. RTE_ARCH_ARM64 is for 64-bit Arm platforms.RTE_ARCH_ARM will be used for all Arm platforms, including RTE_ARCH_ARM32 and RTE_ARCH_ARM64.
To fit into the new naming scheme, current usage of RTE_ARCH_ARM in project code is mapped to RTE_ARCH_ARM32.
--- app/test/test_cpuflags.c | 2 +- app/test/test_xmmt_ops.h | 2 +- config/arm/meson.build | 2 +- config/defconfig_arm-armv7a-linuxapp-gcc | 2 +- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/dpaax/compat.h | 2 +- drivers/net/i40e/Makefile | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- drivers/net/virtio/Makefile | 2 +- drivers/net/virtio/virtio_ethdev.c | 2 +- lib/librte_acl/Makefile | 2 +- lib/librte_acl/meson.build | 2 +- lib/librte_acl/rte_acl.c | 4 ++-- lib/librte_eal/arm/include/rte_vect.h | 4 ++-- lib/librte_eal/common/eal_internal_cfg.h | 2 +- lib/librte_lpm/Makefile | 2 +- lib/librte_lpm/rte_lpm.h | 2 +- 18 files changed, 21 insertions(+), 21 deletions(-)
app/test/test_cpuflags.c +1 -1
@@ -86,7 +86,7 @@ test_cpuflags(void)CHECK_FOR_FLAG (RTE_CPUFLAG_ICACHE_SNOOP );#endif -#if defined(RTE_ARCH_ARM ) +#if defined(RTE_ARCH_ARM32 )printf ("Check for NEON:\t\t" );CHECK_FOR_FLAG (RTE_CPUFLAG_NEON );#endif
app/test/test_xmmt_ops.h +1 -1
@@ -7,7 +7,7 @@#include <rte_vect.h> -#if defined(RTE_ARCH_ARM ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_ARM32 ) || defined(RTE_ARCH_ARM64 )/* vect_* abstraction implementation using NEON */
config/arm/meson.build +1 -1
@@ -132,7 +132,7 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) if not dpdk_conf.get('RTE_ARCH_64') dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) - dpdk_conf.set('RTE_ARCH_ARM', 1) + dpdk_conf.set('RTE_ARCH_ARM32', 1) dpdk_conf.set('RTE_ARCH_ARMv7', 1) # the minimum architecture supported, armv7-a, needs the following, # mk/machine/armv7a/rte.vars.mk sets it too
config/defconfig_arm-armv7a-linuxapp-gcc +1 -1
@@ -6,7 +6,7 @@ CONFIG_RTE_MACHINE="armv7a" CONFIG_RTE_ARCH="arm" -CONFIG_RTE_ARCH_ARM=y +CONFIG_RTE_ARCH_ARM32=y CONFIG_RTE_ARCH_ARMv7=y CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"
drivers/bus/fslmc/qbman/qbman_sys_decl.h +1 -1
@@ -32,7 +32,7 @@ static inline void prefetch_for_store(void *p) { asmvolatile ("prfm pstl1keep, [%0, #0]" : :"r" (p)); } -#elif defined(RTE_ARCH_ARM ) +#elif defined(RTE_ARCH_ARM32 )#define dcbz (p) memset(p, 0, 64)#define lwsync () { asm volatile("dmb st" : : : "memory"); }#define dcbf (p) RTE_SET_USED(p)
drivers/common/dpaax/compat.h +1 -1
@@ -163,7 +163,7 @@ static inline void out_be32(volatile void *__p, u32 val) asmvolatile ("prfm pldl1keep, [%0, #64]" : :"r" (p)); \ } while (0) -#elif defined(RTE_ARCH_ARM ) +#elif defined(RTE_ARCH_ARM32 )#define dcbz (p) memset((p), 0, 32)#define dcbz_64 (p) memset((p), 0, 64)#define dcbf (p) RTE_SET_USED(p)
drivers/net/i40e/Makefile +1 -1
@@ -69,7 +69,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_dcb.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_rxtx.c -ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM32) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_altivec.c
drivers/net/ixgbe/Makefile +1 -1
@@ -88,7 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_fdir.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_pf.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_flow.c -ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM32) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_X86),y) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_sse.c
drivers/net/ixgbe/ixgbe_rxtx.h +2 -2
@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM32 )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH#endif
@@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM32 )uint16_t rxrearm_nb;/**< number of remaining to be re-armed */ uint16_t rxrearm_start;/**< the idx we start the re-arming from */ #endif
drivers/net/virtio/Makefile +1 -1
@@ -32,7 +32,7 @@ ifeq ($(CONFIG_RTE_ARCH_X86),y) SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple_sse.c else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple_altivec.c -else ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) +else ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM32) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple_neon.c endif
drivers/net/virtio/virtio_ethdev.c +1 -1
@@ -2337,7 +2337,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) }if (hw->use_vec_rx) { -#if definedRTE_ARCH_ARM64 || definedRTE_ARCH_ARM +#if definedRTE_ARCH_ARM64 || definedRTE_ARCH_ARM32 if (!rte_cpu_get_flag_enabled (RTE_CPUFLAG_NEON )) {PMD_DRV_LOG (INFO ,"disabled split ring vectorized path for requirement not met" );
lib/librte_acl/Makefile +1 -1
@@ -20,7 +20,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_bld.c SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_gen.c SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_scalar.c -ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM32) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_neon.c CFLAGS_acl_run_neon.o += -flax-vector-conversions ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
lib/librte_acl/meson.build +1 -1
@@ -27,7 +27,7 @@ if dpdk_conf.has('RTE_ARCH_X86') cflags += '-DCC_AVX2_SUPPORT' endif -elif dpdk_conf.has('RTE_ARCH_ARM') or dpdk_conf.has('RTE_ARCH_ARM64') +elif dpdk_conf.has('RTE_ARCH_ARM32') or dpdk_conf.has('RTE_ARCH_ARM64') cflags += '-flax-vector-conversions' sources += files('acl_run_neon.c') elif dpdk_conf.has('RTE_ARCH_PPC_64')
lib/librte_acl/rte_acl.c +2 -2
@@ -44,7 +44,7 @@ rte_acl_classify_sse(__rte_unused const struct rte_acl_ctx *ctx, }#endif -#ifndef RTE_ARCH_ARM +#ifndef RTE_ARCH_ARM32 #ifndef RTE_ARCH_ARM64 int rte_acl_classify_neon(__rte_unused const struct rte_acl_ctx *ctx,
@@ -111,7 +111,7 @@ RTE_INIT(rte_acl_init)#if defined(RTE_ARCH_ARM64 ) alg =RTE_ACL_CLASSIFY_NEON ; -#elif defined(RTE_ARCH_ARM ) +#elif defined(RTE_ARCH_ARM32 )if (rte_cpu_get_flag_enabled (RTE_CPUFLAG_NEON )) alg =RTE_ACL_CLASSIFY_NEON ;#elif defined(RTE_ARCH_PPC_64 )
lib/librte_eal/arm/include/rte_vect.h +2 -2
@@ -28,7 +28,7 @@ typedef union rte_xmm {double pd[XMM_SIZE /sizeof (double )]; } __rte_aligned(16) rte_xmm_t; -#ifdef RTE_ARCH_ARM +#ifdef RTE_ARCH_ARM32 /* NEON intrinsic vqtbl1q_u8() is not supported in ARMv7-A(AArch32) */ static __inlineuint8x16_t vqtbl1q_u8 (uint8x16_t a,uint8x16_t b)
@@ -62,7 +62,7 @@ vaddvq_u16(uint16x8_t a)#endif -#if defined(RTE_ARCH_ARM ) || \ +#if defined(RTE_ARCH_ARM32 ) || \ (defined(RTE_ARCH_ARM64 ) &&RTE_CC_IS_GNU && (GCC_VERSION <70000 ))/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) * On AArch64, this intrinsic is supported since GCC version 7.
lib/librte_eal/common/eal_internal_cfg.h +1 -1
@@ -15,7 +15,7 @@#include "eal_thread.h" -#if defined(RTE_ARCH_ARM ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_ARM32 ) || defined(RTE_ARCH_ARM64 )#define MAX_HUGEPAGE_SIZES 4/**< support up to 4 page sizes */ #else #define MAX_HUGEPAGE_SIZES 3/**< support up to 3 page sizes */
lib/librte_lpm/Makefile +1 -1
@@ -18,7 +18,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_LPM) := rte_lpm.c rte_lpm6.c # install this header file SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include := rte_lpm.h rte_lpm6.h -ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM32) $(CONFIG_RTE_ARCH_ARM64)),) SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h else ifeq ($(CONFIG_RTE_ARCH_X86),y) SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h
lib/librte_lpm/rte_lpm.h +1 -1
@@ -420,7 +420,7 @@ static inline void rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], uint32_t defv); -#if defined(RTE_ARCH_ARM ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_ARM32 ) || defined(RTE_ARCH_ARM64 )#include "rte_lpm_neon.h" #elif defined(RTE_ARCH_PPC_64 )#include "rte_lpm_altivec.h"
Signature · 1 line
2.17.1
Quoted 31 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms.
It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.
Quoted 7 lines
To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
Just to note that for all architectures there is the RTE_ARCH_64 define which is set if the system is 64-bit. That could be used instead if you didn't want to have to specially define ARM32 and ARM64 macros.
/Bruce
Quoted 47 lines
-----Original Message-----
From: Bruce Richardson <[email protected]>
Sent: Friday, August 14, 2020 4:13 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platformsQuoted 34 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms. It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.
Quoted 8 lines
Quoted 4 lines
Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
Just to note that for all architectures there is the
RTE_ARCH_64define which is set if the system is 64-bit. That could be used instead if you didn't want to have to specially define ARM32 and ARM64 macros.
Yes. Thanks for the note.RTE_ARCH_ARM64 is used in architecture specific cases. For example, when a processing path is not implemented by some of 64-bit architectures, RTE_ARCH_64 is not sufficient.
Quoted 1 line
/Bruce
Quoted 51 lines · Ruifeng Wang
Quoted 51 lines
-----Original Message-----
From: Bruce Richardson <[email protected]>
Sent: Friday, August 14, 2020 4:13 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platformsQuoted 38 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms. It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
Quoted 8 lines
Quoted 4 lines
Just to note that for all architectures there is the
RTE_ARCH_64define which is set if the system is 64-bit. That could be used instead if you didn't want to have to specially define ARM32 and ARM64 macros.Yes. Thanks for the note.
RTE_ARCH_ARM64is used in architecture specific cases. For example, when a processing path is not implemented by some of 64-bit architectures,RTE_ARCH_64is not sufficient.
Yes, but is RTE_ARCH_ARM64 not identical to RTE_ARCH_ARM && RTE_ARCH_64?
Quoted 70 lines
-----Original Message-----
From: Bruce Richardson <[email protected]>
Sent: Friday, August 14, 2020 6:01 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platformsQuoted 22 lines · Ruifeng Wang
Quoted 22 lines
-----Original Message-----
From: Bruce Richardson <[email protected]>
Sent: Friday, August 14, 2020 4:13 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platformsQuoted 9 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in thename.
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
To make the flag names more clear, a naming scheme is proposed.
RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms. It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
Just to note that for all architectures there is the
RTE_ARCH_64define which is set if the system is 64-bit. That could be used instead if you didn't want to have to specially define ARM32 and ARM64macros.
Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Yes. Thanks for the note.
RTE_ARCH_ARM64is used in architecture specific cases. For example, when a processing path is not implemented by some of 64-bit architectures,
RTE_ARCH_64is not sufficient.Quoted 1 line
Yes, but is
RTE_ARCH_ARM64not identical toRTE_ARCH_ARM&&RTE_ARCH_64?
My thought is:
1. RTE_ARCH_ARM64 is a direct macro, so with better readability.
2. RTE_ARCH_ARM64 is already used widely in the project.
So I think it is better not to replace the occurrences with combination of other macros.
Quoted 38 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms.
It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
<...>
config/defconfig_arm-armv7a-linuxapp-gcc line 11
Quoted 8 lines
config/defconfig_arm-armv7a-linuxapp-gcc +1
-1@@ -6,7 +6,7 @@ CONFIG_RTE_MACHINE="armv7a" CONFIG_RTE_ARCH="arm" -CONFIG_RTE_ARCH_ARM=y +CONFIG_RTE_ARCH_ARM32=y CONFIG_RTE_ARCH_ARMv7=y CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"
According commit log message I thought 'RTE_ARCH_ARM' will be always set, isn't it the case?
Is below wrong:
aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARM32 | ARMv7 aarch32 -> ARM | ARM32 | ARMv8_AARCH32
If so some of the 'defined(RTE_ARCH_ARM32) || defined(RTE_ARCH_ARM64)' checks can be simplified as 'defined(RTE_ARCH_ARM)'
Also currently missing 'ARCH_64' flag implies the 32bit support, for all architectures, what about having a common 'ARCH_32' flag and use for all arch, instead of 'ARM32'? So something like below:
aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARMv7 | ARCH_32 aarch32 -> ARM | ARMv8_AARCH32 | ARCH_32
Just to record matching flags for other archs are:
x86_64 -> X86 | X86_64 | ARCH_64 i686 -> X86 | I686 x86_32 -> X86 | X86_32
ppc_64 -> PPC_64 | ARCH_64
Quoted 63 lines · Ferruh Yigit
Quoted 38 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms.
It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
<...>
config/defconfig_arm-armv7a-linuxapp-gcc line 11
Quoted 8 lines
config/defconfig_arm-armv7a-linuxapp-gcc +1
-1@@ -6,7 +6,7 @@ CONFIG_RTE_MACHINE="armv7a" CONFIG_RTE_ARCH="arm" -CONFIG_RTE_ARCH_ARM=y +CONFIG_RTE_ARCH_ARM32=y CONFIG_RTE_ARCH_ARMv7=y CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"According commit log message I thought '
RTE_ARCH_ARM' will be always set, isn't it the case?Is below wrong:
aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARM32 | ARMv7 aarch32 -> ARM | ARM32 | ARMv8_AARCH32If so some of the '
defined(RTE_ARCH_ARM32)||defined(RTE_ARCH_ARM64)' checks can be simplified as 'defined(RTE_ARCH_ARM)'
Quoted 7 lines
Also currently missing '
ARCH_64' flag implies the 32bit support, for all architectures, what about having a common 'ARCH_32' flag and use for all arch, instead of 'ARM32'? So something like below:aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARMv7 | ARCH_32 aarch32 -> ARM | ARMv8_AARCH32 | ARCH_32
Not sure why you would need ARCH_32, since it's basically just !ARCH_64.
Quoted 64 lines · Bruce Richardson
Quoted 63 lines · Ferruh Yigit
Quoted 38 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms.
It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
<...>
config/defconfig_arm-armv7a-linuxapp-gcc line 11
Quoted 8 lines
config/defconfig_arm-armv7a-linuxapp-gcc +1
-1@@ -6,7 +6,7 @@ CONFIG_RTE_MACHINE="armv7a" CONFIG_RTE_ARCH="arm" -CONFIG_RTE_ARCH_ARM=y +CONFIG_RTE_ARCH_ARM32=y CONFIG_RTE_ARCH_ARMv7=y CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"According commit log message I thought '
RTE_ARCH_ARM' will be always set, isn't it the case?Is below wrong:
aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARM32 | ARMv7 aarch32 -> ARM | ARM32 | ARMv8_AARCH32If so some of the '
defined(RTE_ARCH_ARM32)||defined(RTE_ARCH_ARM64)' checks can be simplified as 'defined(RTE_ARCH_ARM)'
Quoted 9 lines
Quoted 7 lines
Also currently missing '
ARCH_64' flag implies the 32bit support, for all architectures, what about having a common 'ARCH_32' flag and use for all arch, instead of 'ARM32'? So something like below:aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARMv7 | ARCH_32 aarch32 -> ARM | ARMv8_AARCH32 | ARCH_32Not sure why you would need
ARCH_32, since it's basically just !ARCH_64.
Just to be more explicit, other than that same as '!ARCH_64'.
Quoted 66 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Tuesday, August 18, 2020 10:36 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [RFC PATCH] config: remap flags used for Arm platformsQuoted 38 lines · Ruifeng Wang
Flags are used to distinguish different platform architectures. These flags can be used to pick different code paths for different architectures at compile time.
For Arm platforms, there are 3 flags in use:RTE_ARCH_ARM,RTE_ARCH_ARMv7andRTE_ARCH_ARM64.RTE_ARCH_ARM64is used to flag 64-bit aarch64 platforms, whileRTE_ARCH_ARM&RTE_ARCH_ARMv7are used to flag 32-bit platforms.RTE_ARCH_ARMv7is for ARMv7 platforms as its name suggested.The issue is that flag name
RTE_ARCH_ARMis unclear and could cause confusion. No info about platform word length is included in the name. To make the flag names more clear, a naming scheme is proposed.RTE_ARCH_ARM | +----RTE_ARCH_ARM32 | | | +----RTE_ARCH_ARMv7 | | | +----RTE_ARCH_ARMv8_AARCH32 | +----RTE_ARCH_ARM64
RTE_ARCH_ARM32will be used for 32-bit Arm platforms. It includesRTE_ARCH_ARMv7andRTE_ARCH_ARMv8_AARCH32.RTE_ARCH_ARMv7is for ARMv7 platforms.RTE_ARCH_ARMv8_AARCH32is for aarch32 state on aarch64 platforms.RTE_ARCH_ARM64is for 64-bit Arm platforms.RTE_ARCH_ARMwill be used for all Arm platforms, includingRTE_ARCH_ARM32andRTE_ARCH_ARM64.To fit into the new naming scheme, current usage of
RTE_ARCH_ARMin project code is mapped toRTE_ARCH_ARM32.Suggested-by Honnappa Nagarahalli <[email protected]>Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Phil Yang <[email protected]>---
<...>
config/defconfig_arm-armv7a-linuxapp-gcc line 11
Quoted 8 lines
config/defconfig_arm-armv7a-linuxapp-gcc +1
-1@@ -6,7 +6,7 @@ CONFIG_RTE_MACHINE="armv7a" CONFIG_RTE_ARCH="arm" -CONFIG_RTE_ARCH_ARM=y +CONFIG_RTE_ARCH_ARM32=y CONFIG_RTE_ARCH_ARMv7=y CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9"According commit log message I thought '
RTE_ARCH_ARM' will be always set, isn't it the case?
Quoted 5 lines
Is below wrong:
aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARM32 | ARMv7 aarch32 -> ARM | ARM32 | ARMv8_AARCH32
Yes, it is.
This is correct.
Quoted 4 lines
If so some of the '
defined(RTE_ARCH_ARM32)||defined(RTE_ARCH_ARM64)' checks can be simplified as 'defined(RTE_ARCH_ARM)'
Will do the change when converting this RFC to a patch.
Quoted 8 lines
Also currently missing '
ARCH_64' flag implies the 32bit support, for all architectures, what about having a common 'ARCH_32' flag and use for all arch, instead of 'ARM32'? So something like below:aarch64 -> ARM | ARM64 | ARCH_64 armv7a -> ARM | ARMv7 | ARCH_32 aarch32 -> ARM | ARMv8_AARCH32 | ARCH_32
Having a common 'ARCH_32' flag for all arch is good.
Then for Arm we will have:RTE_ARCH_ARM
|
+----RTE_ARCH_32
| |
| +----RTE_ARCH_ARMv7
| |
| +----RTE_ARCH_ARMv8_AARCH32
|
+----RTE_ARCH_64
|
+----RTE_ARCH_ARM64For x86 we will have:RTE_ARCH_X86
|
+----RTE_ARCH_32
| |
| +----RTE_ARCH_I686
| |
| +----RTE_ARCH_X86_X32
|
+----RTE_ARCH_64
|
+----RTE_ARCH_X86_64For PowerPC we will have: RTE_ARCH_PPC_64
Quoted 10 lines
Just to record matching flags for other archs are:
x86_64 -> X86 | X86_64 | ARCH_64 i686 -> X86 | I686 x86_32 -> X86 | X86_32
ppc_64->PPC_64|ARCH_64