fixes for example app builds
cover fixes for example app builds
While helping prepare some patches for converting the DPDK examples to build using pkg-config, a number of errors and warnings were encountered in the example app builds. These patches fix those issues.
Bruce Richardson (4):
power: make guest channel headers public examples/vm_power_manager: fix string truncation warning examples/mp_server: fix snprintf overflow examples/mp_server: clear string truncation warning
.../multi_process/client_server_mp/mp_server/main.c | 2 +-
.../multi_process/client_server_mp/shared/common.h | 2 +-
examples/vm_power_manager/channel_manager.c | 11 ++++++++---
examples/vm_power_manager/channel_monitor.c | 1 -
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/guest_cli/main.c | 1 +
.../vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
.../vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +-
examples/vm_power_manager/vm_power_cli.c | 1 -
lib/librte_power/guest_channel.c | 3 +--
lib/librte_power/meson.build | 4 +++-
lib/librte_power/power_kvm_vm.c | 3 +--
...hannel_commands.h => rte_power_channel_commands.h} | 0
.../{guest_channel.h => rte_power_guest_channel.h} | 2 +-
14 files changed, 20 insertions(+), 16 deletions(-)
rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)
rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)Signature · 1 line
2.25.1
PATCH 1/4 power: make guest channel headers public
The channel commands header file contains definitions that are used by the example application for power management, and so need to be made public. Similarly the guest_channel.h header is used by the guest_cli example utility, so needs to be public also. Without this change, the example apps, or any end-user apps based on them, can not be compiled outside the main DPDK build.
---
examples/vm_power_manager/channel_manager.c | 1 -
examples/vm_power_manager/channel_monitor.c | 1 -
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/guest_cli/main.c | 1 +
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +-
examples/vm_power_manager/vm_power_cli.c | 1 -
lib/librte_power/guest_channel.c | 3 +--
lib/librte_power/meson.build | 4 +++-
lib/librte_power/power_kvm_vm.c | 3 +--
.../{channel_commands.h => rte_power_channel_commands.h} | 0
.../{guest_channel.h => rte_power_guest_channel.h} | 2 +-
12 files changed, 10 insertions(+), 12 deletions(-)
rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)
rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)examples/vm_power_manager/channel_manager.c +0 -1
@@ -27,7 +27,6 @@#include <libvirt/libvirt.h> #include "channel_manager.h" -#include "channel_commands.h" #include "channel_monitor.h" #include "power_manager.h"
examples/vm_power_manager/channel_monitor.c +0 -1
@@ -35,7 +35,6 @@#include <libvirt/libvirt.h> #include "channel_monitor.h" -#include "channel_commands.h" #include "channel_manager.h" #include "power_manager.h" #include "oob_monitor.h"
examples/vm_power_manager/channel_monitor.h +1 -1
@@ -6,7 +6,7 @@#define CHANNEL_MONITOR_H_ #include "channel_manager.h" -#include "channel_commands.h" +#include "rte_power_channel_commands.h" struct core_share {unsigned int pcpu;
examples/vm_power_manager/guest_cli/main.c +1 -0
@@ -14,6 +14,7 @@#include <rte_eal.h> #include <rte_log.h> +#include "rte_power_channel_commands.h" #include "vm_power_cli_guest.h" #include "parse.h"
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +1 -1
@@ -19,7 +19,7 @@#include <rte_ethdev.h> #include <rte_power.h> -#include <guest_channel.h> +#include <rte_power_guest_channel.h> #include "vm_power_cli_guest.h"
examples/vm_power_manager/guest_cli/vm_power_cli_guest.h +1 -1
@@ -9,7 +9,7 @@extern "C" {#endif -#include "channel_commands.h" +struct channel_packet ;struct channel_packet *get_policy (void );
examples/vm_power_manager/vm_power_cli.c +0 -1
@@ -21,7 +21,6 @@#include "channel_manager.h" #include "channel_monitor.h" #include "power_manager.h" -#include "channel_commands.h" struct cmd_quit_result {cmdline_fixed_string_t quit;
lib/librte_power/guest_channel.c +1 -2
@@ -16,8 +16,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1
lib/librte_power/meson.build +3 -1
@@ -10,5 +10,7 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c', 'rte_power_empty_poll.c', 'power_pstate_cpufreq.c', 'power_common.c') -headers = files('rte_power.h','rte_power_empty_poll.h') +headers = files('rte_power.h','rte_power_empty_poll.h', + 'rte_power_guest_channel.h', + 'rte_power_channel_commands.h') deps += ['timer']
lib/librte_power/power_kvm_vm.c +1 -2
@@ -6,8 +6,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #include "power_kvm_vm.h" #include "power_common.h"
lib/librte_power/rte_power_channel_commands.h renamed from lib/librte_power/channel_commands.h +0 -0
lib/librte_power/rte_power_guest_channel.h renamed from lib/librte_power/guest_channel.h +1 -1
@@ -8,7 +8,7 @@extern "C" {#endif -#include <channel_commands.h> +#include <rte_power_channel_commands.h> /** * Check if any Virtio-Serial VM end-points exist in path.
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 1/4] power: make guest channel headers public
Quoted 12 lines · Bruce Richardson
The channel commands header file contains definitions that are used by the example application for power management, and so need to be made public. Similarly the
guest_channel.hheader is used by theguest_cliexample utility, so needs to be public also. Without this change, the example apps, or any end-user apps based on them, can not be compiled outside the main DPDK build.Fixes 210c383e247b ("power: packet format for vm power management")Fixes cd0d5547e873 ("power: vm communication channels in guest")Signed-off-by Bruce Richardson <[email protected]>
Quoted 17 lines
---
examples/vm_power_manager/channel_manager.c | 1 -
examples/vm_power_manager/channel_monitor.c | 1 -
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/guest_cli/main.c | 1 +
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +-
examples/vm_power_manager/vm_power_cli.c | 1 -
lib/librte_power/guest_channel.c | 3 +--
lib/librte_power/meson.build | 4 +++-
lib/librte_power/power_kvm_vm.c | 3 +--
.../{channel_commands.h => rte_power_channel_commands.h} | 0
.../{guest_channel.h => rte_power_guest_channel.h} | 2 +-
12 files changed, 10 insertions(+), 12 deletions(-)
rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)
rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)Note, this patch does not include the makefile changes, as the work was done when testing with the makefile removal patchset applied, and make support is being removed in this release.
PATCH 2/4 examples/vm_power_manager: fix string truncation warning
In reply to Bruce RichardsonWhen compiling on ubuntu 20.04, a warning was issued about possible truncation of the path string for the power management socket.
channel_manager.c: In function ‘add_all_channels’:
channel_manager.c:470:41: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 90 [-Wformat-truncation=]
470 | sizeof(chan_info->channel_path), "%s%s",
| ^~
This can be fixed by adding in an explicit truncation check to the code and handling it appropriately.
--- examples/vm_power_manager/channel_manager.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
examples/vm_power_manager/channel_manager.c +8 -2
@@ -466,9 +466,15 @@ add_all_channels(const char *vm_name)continue ; } -snprintf (chan_info->channel_path, +if ((size_t )snprintf (chan_info->channel_path,sizeof (chan_info->channel_path),"%s%s" , -CHANNEL_MGR_SOCKET_PATH , dir->d_name); +CHANNEL_MGR_SOCKET_PATH , dir->d_name) + >=sizeof (chan_info->channel_path)) { +RTE_LOG (ERR ,CHANNEL_MANAGER ,"Pathname too long for channel '%s%s'\n" , +CHANNEL_MGR_SOCKET_PATH , dir->d_name); +rte_free (chan_info); +continue ; + }if (setup_channel_info (&vm_info, &chan_info, channel_num) <0 ) {rte_free (chan_info);
Signature · 1 line
2.25.1
PATCH 3/4 examples/mp_server: fix snprintf overflow
In reply to Bruce RichardsonWhen producing a printable mac address the buffer was appropriately sized for holding the mac address exactly, but the actual snprintf included a '\n' character at the end, which means that the snprintf technically is getting truncated i.e. the \n would not be added due to lack of space. This gets flagged as a problem by modern versions of gcc, e.g. on Ubuntu 20.04.
main.c:77:37: warning: ‘__builtin___snprintf_chk’ output truncated before the last format character [-Wformat-truncation=]
77 | "%02x:%02x:%02x:%02x:%02x:%02x\n",
| ^
Since the \n is getting stripped anyway, we can fix the issue by just removing it from the printf string.
--- examples/multi_process/client_server_mp/mp_server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/multi_process/client_server_mp/mp_server/main.c +1 -1
@@ -74,7 +74,7 @@ get_printable_mac_addr(uint16_t port)return err_address; }snprintf (addresses[port],sizeof (addresses[port]), -"%02x:%02x:%02x:%02x:%02x:%02x\n" , +"%02x:%02x:%02x:%02x:%02x:%02x" , mac.addr_bytes[0 ], mac.addr_bytes[1 ], mac.addr_bytes[2 ], mac.addr_bytes[3 ], mac.addr_bytes[4 ], mac.addr_bytes[5 ]); }
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 3/4] examples/mp_server: fix snprintf overflow
Quoted 27 lines · On Fri, 14 Aug 2020 12:00:44 +0100 Bruce Richardson…
When producing a printable mac address the buffer was appropriately sized for holding the mac address exactly, but the actual snprintf included a '\n' character at the end, which means that the snprintf technically is getting truncated i.e. the \n would not be added due to lack of space. This gets flagged as a problem by modern versions of gcc, e.g. on Ubuntu 20.04.
main.c:77:37: warning: ‘__builtin___snprintf_chk’ output truncated before the last format character [-Wformat-truncation=]
77 | "%02x:%02x:%02x:%02x:%02x:%02x\n",
| ^Since the \n is getting stripped anyway, we can fix the issue by just removing it from the printf string.
Fixes af75078fece3 ("first public release")Signed-off-by Bruce Richardson <[email protected]>--- examples/multi_process/client_server_mp/mp_server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)examples/multi_process/client_server_mp/mp_server/main.c +0
-0
examples/multi_process/client_server_mp/mp_server/main.c get_printable_mac_addr(uint16_t port) · line 80
Quoted 8 lines
examples/multi_process/client_server_mp/mp_server/main.c +1
-1@@ -74,7 +74,7 @@ get_printable_mac_addr(uint16_t port)return err_address; }snprintf (addresses[port],sizeof (addresses[port]), -"%02x:%02x:%02x:%02x:%02x:%02x\n" , +"%02x:%02x:%02x:%02x:%02x:%02x" , mac.addr_bytes[0 ], mac.addr_bytes[1 ], mac.addr_bytes[2 ], mac.addr_bytes[3 ], mac.addr_bytes[4 ], mac.addr_bytes[5 ]); }
Please convert to rte_ether_format_addr() instead of local hard coded format.
PATCH 4/4 examples/mp_server: clear string truncation warning
In reply to Bruce RichardsonCompiling with GCC 9.3 on Ubuntu 20.04 gives a warning about possible string truncation when getting the RX queue name:
In file included from init.c:36:init.c: In function ‘init’:../shared/common.h:38:28: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 8 [-Wformat-truncation=]
38 | #define MP_CLIENT_RXQ_NAME "MProc_Client_%u_RX"
| ^~~~~~~~~~~~~~~~~~~~
../shared/common.h:52:35: note: in expansion of macro ‘MP_CLIENT_RXQ_NAME’
52 | snprintf(buffer, sizeof(buffer), MP_CLIENT_RXQ_NAME, id);
| ^~~~~~~~~~~~~~~~~~This is a false positive, as the value of the "id" is limited to 255, being stored in the app as a uint8_t value, removing the possibility of the %u being replaced by anything other then 3 characters max (rather than up to 10 as thought by the compiler). Therefore, the warning can be easily removed by changing the type of the "id" parameter to the local function from "unsigned" to "uint8_t" also, ensuring the compiler is aware of the range limit.
--- examples/multi_process/client_server_mp/shared/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/multi_process/client_server_mp/shared/common.h +1 -1
@@ -43,7 +43,7 @@ struct port_info {* Given the rx queue name template above, get the queue name */ static inline const char * -get_rx_queue_name (unsigned id) +get_rx_queue_name (uint8_t id) {/* buffer for return value. Size calculated by %u being replaced * by maximum 3 digits (plus an extra byte for safety) */
Signature · 1 line
2.25.1
v2 cover fixes for example app builds
In reply to Bruce RichardsonWhile helping prepare some patches for converting the DPDK examples to build using pkg-config, a number of errors and warnings were encountered in the example app builds. These patches fix those issues.
NOTE: no makefile changes are included since make support is being removed in this release
Bruce Richardson (4):
power: make guest channel headers public examples/vm_power_manager: fix string truncation warning examples/mp_server: fix snprintf overflow examples/mp_server: clear string truncation warning
.../client_server_mp/mp_server/main.c | 17 ++++++++++-------
.../client_server_mp/shared/common.h | 2 +-
examples/vm_power_manager/channel_manager.c | 11 ++++++++---
examples/vm_power_manager/channel_monitor.c | 1 -
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/guest_cli/main.c | 1 +
.../guest_cli/vm_power_cli_guest.c | 2 +-
.../guest_cli/vm_power_cli_guest.h | 2 +-
examples/vm_power_manager/vm_power_cli.c | 1 -
lib/librte_power/guest_channel.c | 3 +--
lib/librte_power/meson.build | 4 +++-
lib/librte_power/power_kvm_vm.c | 3 +--
..._commands.h => rte_power_channel_commands.h} | 0
...uest_channel.h => rte_power_guest_channel.h} | 2 +-
14 files changed, 29 insertions(+), 22 deletions(-)
rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)
rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)Signature · 1 line
2.25.1
PATCH v2 1/4 power: make guest channel headers public
The channel commands header file contains definitions that are used by the example application for power management, and so need to be made public. Similarly the guest_channel.h header is used by the guest_cli example utility, so needs to be public also. Without this change, the example apps, or any end-user apps based on them, can not be compiled outside the main DPDK build.
---
examples/vm_power_manager/channel_manager.c | 1 -
examples/vm_power_manager/channel_monitor.c | 1 -
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/guest_cli/main.c | 1 +
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +-
examples/vm_power_manager/vm_power_cli.c | 1 -
lib/librte_power/guest_channel.c | 3 +--
lib/librte_power/meson.build | 4 +++-
lib/librte_power/power_kvm_vm.c | 3 +--
.../{channel_commands.h => rte_power_channel_commands.h} | 0
.../{guest_channel.h => rte_power_guest_channel.h} | 2 +-
12 files changed, 10 insertions(+), 12 deletions(-)
rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%)
rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)examples/vm_power_manager/channel_manager.c +0 -1
@@ -27,7 +27,6 @@#include <libvirt/libvirt.h> #include "channel_manager.h" -#include "channel_commands.h" #include "channel_monitor.h" #include "power_manager.h"
examples/vm_power_manager/channel_monitor.c +0 -1
@@ -35,7 +35,6 @@#include <libvirt/libvirt.h> #include "channel_monitor.h" -#include "channel_commands.h" #include "channel_manager.h" #include "power_manager.h" #include "oob_monitor.h"
examples/vm_power_manager/channel_monitor.h +1 -1
@@ -6,7 +6,7 @@#define CHANNEL_MONITOR_H_ #include "channel_manager.h" -#include "channel_commands.h" +#include "rte_power_channel_commands.h" struct core_share {unsigned int pcpu;
examples/vm_power_manager/guest_cli/main.c +1 -0
@@ -14,6 +14,7 @@#include <rte_eal.h> #include <rte_log.h> +#include "rte_power_channel_commands.h" #include "vm_power_cli_guest.h" #include "parse.h"
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +1 -1
@@ -19,7 +19,7 @@#include <rte_ethdev.h> #include <rte_power.h> -#include <guest_channel.h> +#include <rte_power_guest_channel.h> #include "vm_power_cli_guest.h"
examples/vm_power_manager/guest_cli/vm_power_cli_guest.h +1 -1
@@ -9,7 +9,7 @@extern "C" {#endif -#include "channel_commands.h" +struct channel_packet ;struct channel_packet *get_policy (void );
examples/vm_power_manager/vm_power_cli.c +0 -1
@@ -21,7 +21,6 @@#include "channel_manager.h" #include "channel_monitor.h" #include "power_manager.h" -#include "channel_commands.h" struct cmd_quit_result {cmdline_fixed_string_t quit;
lib/librte_power/guest_channel.c +1 -2
@@ -16,8 +16,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1
lib/librte_power/meson.build +3 -1
@@ -10,5 +10,7 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c', 'rte_power_empty_poll.c', 'power_pstate_cpufreq.c', 'power_common.c') -headers = files('rte_power.h','rte_power_empty_poll.h') +headers = files('rte_power.h','rte_power_empty_poll.h', + 'rte_power_guest_channel.h', + 'rte_power_channel_commands.h') deps += ['timer']
lib/librte_power/power_kvm_vm.c +1 -2
@@ -6,8 +6,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #include "power_kvm_vm.h" #include "power_common.h"
lib/librte_power/rte_power_channel_commands.h renamed from lib/librte_power/channel_commands.h +0 -0
lib/librte_power/rte_power_guest_channel.h renamed from lib/librte_power/guest_channel.h +1 -1
@@ -8,7 +8,7 @@extern "C" {#endif -#include <channel_commands.h> +#include <rte_power_channel_commands.h> /** * Check if any Virtio-Serial VM end-points exist in path.
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 1/4] power: make guest channel headers public
Hi Bruce,
Quoted 169 lines · Bruce Richardson
The channel commands header file contains definitions that are used by the example application for power management, and so need to be made public. Similarly the
guest_channel.hheader is used by theguest_cliexample utility, so needs to be public also. Without this change, the example apps, or any end-user apps based on them, can not be compiled outside the main DPDK build.Fixes 210c383e247b ("power: packet format for vm power management")Fixes cd0d5547e873 ("power: vm communication channels in guest")Signed-off-by Bruce Richardson <[email protected]>--- examples/vm_power_manager/channel_manager.c | 1 - examples/vm_power_manager/channel_monitor.c | 1 - examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/guest_cli/main.c | 1 + examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +- examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 +- examples/vm_power_manager/vm_power_cli.c | 1 - lib/librte_power/guest_channel.c | 3 +-- lib/librte_power/meson.build | 4 +++- lib/librte_power/power_kvm_vm.c | 3 +-- .../{channel_commands.h => rte_power_channel_commands.h} | 0 .../{guest_channel.h => rte_power_guest_channel.h} | 2 +- 12 files changed, 10 insertions(+), 12 deletions(-)rename
lib/librte_power/{channel_commands.h=>rte_power_channel_commands.h} (100%) renamelib/librte_power/{guest_channel.h=>rte_power_guest_channel.h} (98%)examples/vm_power_manager/channel_manager.c +0
-1@@ -27,7 +27,6 @@#include <libvirt/libvirt.h> #include "channel_manager.h" -#include "channel_commands.h" #include "channel_monitor.h" #include "power_manager.h" examples/vm_power_manager/channel_monitor.c +0
-1@@ -35,7 +35,6 @@#include <libvirt/libvirt.h> #include "channel_monitor.h" -#include "channel_commands.h" #include "channel_manager.h" #include "power_manager.h" #include "oob_monitor.h" examples/vm_power_manager/channel_monitor.h +1
-1@@ -6,7 +6,7 @@#define CHANNEL_MONITOR_H_ #include "channel_manager.h" -#include "channel_commands.h" +#include "rte_power_channel_commands.h" struct core_share {unsigned int pcpu;examples/vm_power_manager/guest_cli/main.c +1
-0@@ -14,6 +14,7 @@#include <rte_eal.h> #include <rte_log.h> +#include "rte_power_channel_commands.h" #include "vm_power_cli_guest.h" #include "parse.h" examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +1
-1@@ -19,7 +19,7 @@#include <rte_ethdev.h> #include <rte_power.h> -#include <guest_channel.h> +#include <rte_power_guest_channel.h> #include "vm_power_cli_guest.h" examples/vm_power_manager/guest_cli/vm_power_cli_guest.h +1
-1@@ -9,7 +9,7 @@extern "C" {#endif -#include "channel_commands.h" +struct channel_packet ;struct channel_packet *get_policy (void );examples/vm_power_manager/vm_power_cli.c +0
-1@@ -21,7 +21,6 @@#include "channel_manager.h" #include "channel_monitor.h" #include "power_manager.h" -#include "channel_commands.h" struct cmd_quit_result {cmdline_fixed_string_t quit;lib/librte_power/guest_channel.c +1
-2@@ -16,8 +16,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1lib/librte_power/meson.build +3
-1@@ -10,5 +10,7 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c', 'rte_power_empty_poll.c', 'power_pstate_cpufreq.c', 'power_common.c') -headers = files('rte_power.h','rte_power_empty_poll.h') +headers = files('rte_power.h','rte_power_empty_poll.h', + 'rte_power_guest_channel.h', + 'rte_power_channel_commands.h') deps += ['timer']lib/librte_power/power_kvm_vm.c +1
-2@@ -6,8 +6,7 @@#include <rte_log.h> -#include "guest_channel.h" -#include "channel_commands.h" +#include "rte_power_guest_channel.h" #include "power_kvm_vm.h" #include "power_common.h" lib/librte_power/rte_power_channel_commands.h renamed from lib/librte_power/channel_commands.h +0
-0lib/librte_power/rte_power_guest_channel.h renamed from lib/librte_power/guest_channel.h +0
-0
lib/librte_power/rte_power_guest_channel.h line 14
Quoted 8 lines
lib/librte_power/rte_power_guest_channel.h renamed from lib/librte_power/guest_channel.h +1
-1@@ -8,7 +8,7 @@extern "C" {#endif -#include <channel_commands.h> +#include <rte_power_channel_commands.h> /** * Check if any Virtio-Serial VM end-points exist in path.
Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: make guest channel headers public
In reply to Bruce Richardson