Skip to contentSkip to conversation

drm/amd/pm: drop redundant MEM_TYPE_* macros

PATCH In review Evan Quan 3 participants 3 messages Aug 14, 2020

Subsystems (3)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amd/pm: drop redundant MEM_TYPE_* macros

As these are already defined in amdgpu_atombios.h. Otherwise, we may hit "redefined" compile warning.

Change-Id Ia2a9e10b35173fedcbbd8e0abb8ad38dd231baf4
---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h +0 -9
index 3ee54f182943..76ed2e413594 100644
@@ -26,15 +26,6 @@
 
 #include "hwmgr.h"
 
-#define MEM_TYPE_GDDR5  0x50
-#define MEM_TYPE_GDDR4  0x40
-#define MEM_TYPE_GDDR3  0x30
-#define MEM_TYPE_DDR2   0x20
-#define MEM_TYPE_GDDR1  0x10
-#define MEM_TYPE_DDR3   0xb0
-#define MEM_TYPE_MASK   0xF0
-
-
 /* As returned from PowerConnectorDetectionTable. */
 #define PP_ATOM_POWER_BUDGET_DISABLE_OVERDRIVE  0x80
 #define PP_ATOM_POWER_BUDGET_SHOW_WARNING       0x40
Signature · 6 lines
2.28.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Evan Quan
Sent: Friday, August 14, 2020 4:44 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amd/pm: drop redundant MEM_TYPE_* macros

As these are already defined in amdgpu_atombios.h. Otherwise, we may hit "redefined" compile warning.

Change-Id Ia2a9e10b35173fedcbbd8e0abb8ad38dd231baf4
---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 9 ---------
 1 file changed, 9 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h +0 -10
index 3ee54f182943..76ed2e413594 100644
@@ -26,15 +26,6 @@
 
 #include "hwmgr.h"
 
-#define MEM_TYPE_GDDR5  0x50
-#define MEM_TYPE_GDDR4  0x40
-#define MEM_TYPE_GDDR3  0x30
-#define MEM_TYPE_DDR2   0x20
-#define MEM_TYPE_GDDR1  0x10
-#define MEM_TYPE_DDR3   0xb0
-#define MEM_TYPE_MASK   0xF0
-
-
 /* As returned from PowerConnectorDetectionTable. */  #define PP_ATOM_POWER_BUDGET_DISABLE_OVERDRIVE  0x80
 #define PP_ATOM_POWER_BUDGET_SHOW_WARNING       0x40
--

2.28.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7CFeifei.Xu%40amd.com%7Cb57418b0630d47f141bd08d8402e3bdc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637329914622450013&amp;sdata=uuHzhQ7DDnANxqLtUhx%2FllmcFXg%2F1qPNzhQPa93IFdI%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by Nirmoy Das on v1 1/1
#2 lore raw
In reply to Evan Quan

Nirmoy

Quoted 19 lines · Evan Quan

As these are already defined in amdgpu_atombios.h. Otherwise, we may hit "redefined" compile warning.

Change-Id Ia2a9e10b35173fedcbbd8e0abb8ad38dd231baf4
---
  drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 9 ---------
  1 file changed, 9 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h +0 -2
index 3ee54f182943..76ed2e413594 100644
@@ -26,15 +26,6 @@
 
  #include "hwmgr.h"
 
-#define MEM_TYPE_GDDR5  0x50
-#define MEM_TYPE_GDDR4  0x40

drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h line 31

Quoted 10 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h +0 -7
-#define MEM_TYPE_GDDR3  0x30
-#define MEM_TYPE_DDR2   0x20
-#define MEM_TYPE_GDDR1  0x10
-#define MEM_TYPE_DDR3   0xb0
-#define MEM_TYPE_MASK   0xF0
-
-
  /* As returned from PowerConnectorDetectionTable. */
  #define PP_ATOM_POWER_BUDGET_DISABLE_OVERDRIVE  0x80
  #define PP_ATOM_POWER_BUDGET_SHOW_WARNING       0x40

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx