mmc: host: msm: Add optional full power cycle property.
Subsystems (5)
Device tree bindings Arm Qualcomm mailing list MMC, SD and SDIO Arm Qualcomm support +1 more subsystems
PATCH 1/2 mmc: host: msm: Add optional full power cycle property.
On some eMMCs (at least the ones used on Sony msm8994 boards) enabling full power cycle is required to prevent permanent damage to the flash memory, whereas on others it results in better performance.
Signed-off-by Konrad Dybcio <[email protected]>
--- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++ drivers/mmc/host/sdhci-msm.c | 6 ++++++ 2 files changed, 10 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-msm.txt +4 -0
@@ -54,6 +54,10 @@ Required properties: - qcom,dll-config: Chipset and Platform specific value. Use this field to specify the DLL_CONFIG register value as per Hardware Programming Guide. +- qcom,full-pwr-cycle: Enable full power cycle CAP2. This is required for optimal + performance on some eMMCs, whereas others need it to prevent permanent + damage to the flash memory. + Optional Properties: * Following bus parameters are required for interconnect bandwidth scaling: - interconnects: Pairs of phandles and interconnect provider specifier
drivers/mmc/host/sdhci-msm.c +6 -0
@@ -2242,6 +2242,12 @@ static int sdhci_msm_probe(struct platform_device *pdev) msm_host->saved_tuning_phase =INVALID_TUNING_PHASE ; +if (of_find_property (pdev->dev.of_node,"qcom,full-pwr-cycle" ,NULL )) + msm_host->mmc->caps2 |=MMC_CAP2_FULL_PWR_CYCLE ; + +else +dev_info (&pdev->dev,"MMC full power cycle is not enabled. This might result in subpar performance or permanent damage on some devices.\n" ); +/* Setup SDCC bus voter clock. */ msm_host->bus_clk =devm_clk_get (&pdev->dev,"bus" );if (!IS_ERR (msm_host->bus_clk)) {
Signature · 1 line
2.28.0
PATCH 2/2 arm64: dts: qcom: kitakami: Enable qcom,full-pwr-cycle on SDHCI1
This is required to prevent permanent eMMC damage.
Signed-off-by Konrad Dybcio <[email protected]>
--- arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi +2 -0
@@ -439,6 +439,8 @@ &sdhc1 { * vmmc-supply = <&pm8994_l20>; * vqmmc-supply = <&pm8994_s4>; */ + + qcom,full-pwr-cycle; }; &sdhc2 {
Signature · 1 line
2.28.0
As I mentioned in the next email, please ignore this patch. The whole idea is incorrect and does not solve the problem.
Konrad