Skip to contentSkip to conversation

eal: change debug diagnostic message from udev handler

PATCH Applied Stephen Hemminger 3 participants 3 messages Aug 14, 2020 – Sep 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal: change debug diagnostic message from udev handler

The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.

Fixes 0d0f478d0483 ("eal/linux: add uevent parse and process")
---
 lib/librte_eal/linux/eal_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/librte_eal/linux/eal_dev.c +1 -2
index 83c9cd660754..83b6068264cb 100644
@@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
 
 	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
 	if (ret < 0) {
-		RTE_LOG(DEBUG, EAL, "It is not an valid event "
-			"that need to be handle.\n");
+		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
 		return;
 	}
 
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw

hi, stephen

Agree, it is make sense that the ignore event will sometimes involve the information which should not be ignore.

Quoted 8 lines · Stephen Hemminger

The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.

Fixes 0d0f478d0483 ("eal/linux: add uevent parse and process")

Should this cc line be removed? After that, please and thanks.

Quoted 19 lines
---
  lib/librte_eal/linux/eal_dev.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
lib/librte_eal/linux/eal_dev.c +1 -2
index 83c9cd660754..83b6068264cb 100644
@@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
 
  	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
  	if (ret < 0) {
-		RTE_LOG(DEBUG, EAL, "It is not an valid event "
-			"that need to be handle.\n");
+		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
  		return;
  	}
 
Acked-by Jeff Guo on v1 1/1 Applied
#2 lore raw
In reply to Stephen Hemminger
Quoted 9 lines · Stephen Hemminger

The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.

Fixes 0d0f478d0483 ("eal/linux: add uevent parse and process")

Applied.

Signature · 1 line
David Marchand