eal: change debug diagnostic message from udev handler
PATCH 1/1 eal: change debug diagnostic message from udev handler
The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.
--- lib/librte_eal/linux/eal_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
lib/librte_eal/linux/eal_dev.c +1 -2
@@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param) ret =dev_uev_parse (buf, &uevent,EAL_UEV_MSG_LEN );if (ret <0 ) { -RTE_LOG (DEBUG ,EAL ,"It is not an valid event " -"that need to be handle.\n" ); +RTE_LOG (DEBUG ,EAL ,"Ignoring uevent '%s'\n" , buf);return ; }
Signature · 1 line
2.27.0
hi, stephen
Agree, it is make sense that the ignore event will sometimes involve the information which should not be ignore.
Quoted 8 lines · Stephen Hemminger
The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.
Fixes 0d0f478d0483 ("eal/linux: add uevent parse and process")
Should this cc line be removed? After that, please and thanks.
Quoted 19 lines
Signed-off-by Stephen Hemminger <[email protected]>--- lib/librte_eal/linux/eal_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)lib/librte_eal/linux/eal_dev.c +1
-2@@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param) ret =dev_uev_parse (buf, &uevent,EAL_UEV_MSG_LEN );if (ret <0 ) { -RTE_LOG (DEBUG ,EAL ,"It is not an valid event " -"that need to be handle.\n" ); +RTE_LOG (DEBUG ,EAL ,"Ignoring uevent '%s'\n" , buf);return ; }
Quoted 9 lines · Stephen Hemminger
The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log.
Fixes 0d0f478d0483 ("eal/linux: add uevent parse and process")Signed-off-by Stephen Hemminger <[email protected]>
Applied.
Signature · 1 line
David Marchand