package/mpv: link with libatomic if needed
PATCH 1/1 package/mpv: link with libatomic if needed
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
--- package/mpv/mpv.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/mpv/mpv.mk +4 -0
@@ -235,4 +235,8 @@ else MPV_CONF_OPTS += --disable-x11 endif +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) +MPV_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -latomic" +endif + $(eval $(waf-package))
Signature · 1 line
2.27.0
PATCH 1/1 package/mpv: link with libatomic if needed
Quoted 4 lines · On Sat, 15 Aug 2020 23:57:30 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692cSigned-off-by Fabrice Fontaine <[email protected]>
Thanks! I was also looking (briefly) at this build issue. I see that mpv has:
depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8
Does RISC-V implements the sync 8-byte built-in ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/mpv: link with libatomic if needed
Le dim. 16 ao?t 2020 ? 00:11, Thomas Petazzoni
<[email protected]> a ?crit :
Quoted 7 lines
Quoted 3 lines · On Sat, 15 Aug 2020 23:57:30 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
Quoted 7 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>Thanks! I was also looking (briefly) at this build issue. I see that mpv has:
depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8Does RISC-V implements the sync 8-byte built-in ?
It seems that __sync builtins have been dropped since version 0.24.0 and
https://github.com/mpv-player/mpv/commit/c3205d294e519f994829d9355eb133670729aab4
so this dependency should also be updated to reflect that atomic is mandatory.
Quoted 6 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
Thomas Petazzoni
AppliedPATCH 1/1 package/mpv: link with libatomic if needed
In reply to Fabrice FontaineQuoted 7 lines · On Sat, 15 Aug 2020 23:57:30 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692cSigned-off-by Fabrice Fontaine <[email protected]>--- package/mpv/mpv.mk | 4 ++++ 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/mpv: link with libatomic if needed
In reply to Fabrice FontaineQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692cSigned-off-by Fabrice Fontaine <[email protected]>
Committed to 2020.02.x and 2020.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard