Skip to contentSkip to conversation

usb: renesas-xhci: add missing versions

PATCH New Vinod Koul 1 participant 1 message Aug 16, 2020

Subsystems (2)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH v2 1/1 usb: renesas-xhci: add missing versions

Some devices in wild are reporting firmware version as 0x2011 and 0x2020, so add these as well

Reported by: Anastasios Vacharakis <[email protected]> Reported by: Glen Journeay <[email protected]>

Fixes 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201")

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911

---
Greg, this fixes regression for folks with preprogrammed controllers with firmware version 0x2020 and 0x2011, please mark as stable material

 drivers/usb/host/xhci-pci-renesas.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/usb/host/xhci-pci-renesas.c +7 -2
index 59b1965ad0a3..f32b5a958ace 100644
@@ -50,14 +50,19 @@
 #define RENESAS_RETRY	10000
 #define RENESAS_DELAY	10
 
-#define ROM_VALID_01 0x2013
-#define ROM_VALID_02 0x2026
+/* keep the ids sorted */
+#define ROM_VALID_01 0x2011
+#define ROM_VALID_02 0x2013
+#define ROM_VALID_03 0x2020
+#define ROM_VALID_04 0x2026
 
 static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version)
 {
 	switch (version) {
 	case ROM_VALID_01:
 	case ROM_VALID_02:
+	case ROM_VALID_03:
+	case ROM_VALID_04:
 		return 0;
 	}
 	dev_err(&pdev->dev, "FW has invalid version :%d\n", version);
Signature · 1 line
2.26.2