package/libcamera: disable werror
PATCH 1/1 package/libcamera: disable werror
This will fix the following build failure:
../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark FrameWrap::getQuark()':/home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable]
gpointer *gapg_temp_atomic = (gpointer *)(atomic); \
^Fixes:
- http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91
--- package/libcamera/libcamera.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/libcamera/libcamera.mk +2 -1
@@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ LIBCAMERA_CONF_OPTS = \ -Dandroid=false \ -Ddocumentation=false \ - -Dtest=false + -Dtest=false \ + -Dwerror=false LIBCAMERA_INSTALL_STAGING = YES LIBCAMERA_LICENSE = \ LGPL-2.1+ (library), \
Signature · 1 line
2.27.0
Yann E. MORIN
AppliedPATCH 1/1 package/libcamera: disable werror
Fabrice, All,
On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly:
Quoted 11 lines
This will fix the following build failure:
../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark
FrameWrap::getQuark()':/home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable]gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ ^Fixes:
- http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91Signed-off-by Fabrice Fontaine <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 25 lines
--- package/libcamera/libcamera.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/libcamera/libcamera.mk +2
-1@@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ LIBCAMERA_CONF_OPTS = \ -Dandroid=false \ -Ddocumentation=false \ - -Dtest=false + -Dtest=false \ + -Dwerror=false LIBCAMERA_INSTALL_STAGING = YES LIBCAMERA_LICENSE = \ LGPL-2.1+ (library), \Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/libcamera: disable werror
Hi Fabrice,
Out of interest, have you investigated to see if this has been fixed or reported in upstream glib?
This looks like an issue in the specific glib version rather than libcamera, so IMO disabling -Werror is just a workaround ... a viable one of course ... but not solving the underlying fault.
Of course that is the peril of -Werror, we aim to keep warning free, but the dependencies are out of our control so if they fail to do the same, then that can cause these issues for packaging.
Anyway the -Werror=false is only at the buildroot packaging, so we can still aim to be warning clear in libcamera of course ;-)
Thanks for keeping libcamera building successfully on buildroot!
--
Regards
Kieran
Quoted 46 lines · Yann E. MORIN
Fabrice, All,
On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly:
Quoted 11 lines
This will fix the following build failure:
../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark
FrameWrap::getQuark()':/home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable]gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ ^Fixes:
- http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91Signed-off-by Fabrice Fontaine <[email protected]>Applied to master, thanks.
Regards,
Yann E. MORIN.Quoted 25 lines
--- package/libcamera/libcamera.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/libcamera/libcamera.mk +2
-1@@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ LIBCAMERA_CONF_OPTS = \ -Dandroid=false \ -Ddocumentation=false \ - -Dtest=false + -Dtest=false \ + -Dwerror=false LIBCAMERA_INSTALL_STAGING = YES LIBCAMERA_LICENSE = \ LGPL-2.1+ (library), \Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 3 lines
Regards -- Kieran
PATCH 1/1 package/libcamera: disable werror
Hi Kieran,
Le lun. 17 ao?t 2020 ? 13:16, Kieran Bingham
<[email protected]> a ?crit :
Quoted 5 lines
Hi Fabrice,
Out of interest, have you investigated to see if this has been fixed or reported in upstream glib?
To my knowledge, the issue has not been fixed or reported. I don't really understand why we get this failure, gapg_temp_atomic has been added since version 2.63.1 and
https://github.com/GNOME/glib/commit/3251cce524dbde48e0e5ea0df3169f76e10d0794.gapg_temp_atomic is set and then used in __atomic_load.
Quoted 68 lines
This looks like an issue in the specific glib version rather than libcamera, so IMO disabling -Werror is just a workaround ... a viable one of course ... but not solving the underlying fault.
Of course that is the peril of -Werror, we aim to keep warning free, but the dependencies are out of our control so if they fail to do the same, then that can cause these issues for packaging.
Anyway the -Werror=false is only at the buildroot packaging, so we can still aim to be warning clear in libcamera of course ;-)
Thanks for keeping libcamera building successfully on buildroot!
--
RegardsKieran
Quoted 41 lines · Yann E. MORIN
Fabrice, All,
On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly:
Quoted 11 lines
This will fix the following build failure:
../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark
FrameWrap::getQuark()':/home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable]gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ ^Fixes:
- http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91Signed-off-by Fabrice Fontaine <[email protected]>Applied to master, thanks.
Regards,
Yann E. MORIN.Quoted 21 lines
--- package/libcamera/libcamera.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/libcamera/libcamera.mk +2
-2@@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ LIBCAMERA_CONF_OPTS = \ -Dandroid=false \ -Ddocumentation=false \ - -Dtest=false + -Dtest=false \ + -Dwerror=false LIBCAMERA_INSTALL_STAGING = YES LIBCAMERA_LICENSE = \ LGPL-2.1+ (library), \ --2.27.0
Quoted 5 lines
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 4 lines
--
Regards
--
Kieran
Best Regards,
Fabrice