drm/amdgpu: add condition check for trace_amdgpu_cs()
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: add condition check for trace_amdgpu_cs()
v1:
add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function.
v2:
add a new wrapper function to trace all amdgpu cs ibs.
Signed-off-by Kevin Wang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +13 -3
@@ -1275,13 +1275,24 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,return r; } +static void trace_amdgpu_cs_ibs (struct amdgpu_cs_parser *parser) +{ +int i; + +if (!trace_amdgpu_cs_enabled ()) +return ; + +for (i =0 ; i < parser->job->num_ibs; i++) +trace_amdgpu_cs (parser, i); +} +int amdgpu_cs_ioctl (struct drm_device *dev,void *data,struct drm_file *filp) {struct amdgpu_device *adev = dev->dev_private;union drm_amdgpu_cs *cs = data;struct amdgpu_cs_parser parser = {};bool reserved_buffers = false; -int i, r; +int r;if (amdgpu_ras_intr_triggered ())return -EHWPOISON ;
@@ -1319,8 +1330,7 @@ int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) reserved_buffers = true; -for (i =0 ; i < parser.job->num_ibs; i++) -trace_amdgpu_cs (&parser, i); +trace_amdgpu_cs_ibs (&parser); r =amdgpu_cs_vm_handling (&parser);if (r)
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 17.08.20 um 12:34 schrieb Kevin Wang:
Quoted 8 lines
v1:
add trace event enabled check to avoid nop loop when submit multi ibs inamdgpu_cs_ioctl()function.v2:
add a new wrapper function to trace all amdgpu cs ibs.Signed-off-by Kevin Wang <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 35 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +12
-1@@ -1275,13 +1275,24 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,return r; } +static void trace_amdgpu_cs_ibs (struct amdgpu_cs_parser *parser) +{ +int i; + +if (!trace_amdgpu_cs_enabled ()) +return ; + +for (i =0 ; i < parser->job->num_ibs; i++) +trace_amdgpu_cs (parser, i); +} +int amdgpu_cs_ioctl (struct drm_device *dev,void *data,struct drm_file *filp) {struct amdgpu_device *adev = dev->dev_private;union drm_amdgpu_cs *cs = data;struct amdgpu_cs_parser parser = {};bool reserved_buffers = false; -int i, r; +int r;if (amdgpu_ras_intr_triggered ())return -EHWPOISON ;
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) · line 1336
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1
-2@@ -1319,8 +1330,7 @@ int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) reserved_buffers = true; -for (i =0 ; i < parser.job->num_ibs; i++) -trace_amdgpu_cs (&parser, i); +trace_amdgpu_cs_ibs (&parser); r =amdgpu_cs_vm_handling (&parser);if (r)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx