Skip to contentSkip to conversation

ref-manual: Fix mistake in base class description.

PATCH In review Vasyl Vavrychuk 2 participants 4 messages Aug 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ref-manual: Fix mistake in base class description.

Clearly, previous sentense speaks about definitions in classes which can be overrided or extended in other classes.

---
 documentation/ref-manual/ref-classes.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/ref-classes.xml +1 -1
index 1dcd5fdd03..1f353b3c30 100644
@@ -191,7 +191,7 @@
         tasks such as fetching, unpacking, configuring (empty by default),
         compiling (runs any <filename>Makefile</filename> present), installing
         (empty by default) and packaging (empty by default).
-        These classes are often overridden or extended by other classes
+        These definitions are often overridden or extended by other classes
         such as the
         <link linkend='ref-classes-autotools'><filename>autotools</filename></link>
         class or the
Signature · 1 line
2.23.0
#1 lore raw

PATCH 2/2 ref-manual: Mention that staging class is enabled by default.

This information is present for all other classes inherited by base class.

Previously it was mentioned for staging class to but then it was gonne.

---
 documentation/ref-manual/ref-classes.xml | 5 +++++
 1 file changed, 5 insertions(+)
documentation/ref-manual/ref-classes.xml +5 -0
index 1f353b3c30..4d7baff430 100644
@@ -3386,6 +3386,11 @@ This check was removed for YP 2.3 release
                 </para></listitem>
         </itemizedlist>
     </para>
+
+    <para>
+        This class is enabled by default since it is inherited by
+        the <filename>base</filename> class.
+    </para>
 </section>
 
 <section id='ref-classes-syslinux'>
Signature · 1 line
2.23.0
#2 lore raw
In reply to Vasyl Vavrychuk

And these two should go to [email protected], I think :)

Alex

Quoted 30 lines · Vasyl Vavrychuk

Clearly, previous sentense speaks about definitions in classes which can be overrided or extended in other classes.

---
 documentation/ref-manual/ref-classes.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/ref-classes.xml +0 -0
index 1dcd5fdd03..1f353b3c30 100644
@@ -191,7 +191,7 @@
         tasks such as fetching, unpacking, configuring (empty by default),
         compiling (runs any <filename>Makefile</filename> present),

installing
(empty by default) and packaging (empty by default).

documentation/ref-manual/ref-classes.xml +1 -1
-        These classes are often overridden or extended by other classes
+        These definitions are often overridden or extended by other

classes
such as the
<link
linkend='ref-classes-autotools'><filename>autotools</filename></link>
class or the
--
2.23.0

#3 lore raw

Thanks, sorry for disturbing.

Quoted 39 lines · Alexander Kanavin

And these two should go to [email protected], I think :)

Alex

Quoted 31 lines · Vasyl Vavrychuk

Clearly, previous sentense speaks about definitions in classes which can be overrided or extended in other classes.

---
 documentation/ref-manual/ref-classes.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/ref-classes.xml +0 -0
index 1dcd5fdd03..1f353b3c30 100644
@@ -191,7 +191,7 @@
         tasks such as fetching, unpacking, configuring (empty by
 default),
         compiling (runs any <filename>Makefile</filename> present),

installing
(empty by default) and packaging (empty by default).

documentation/ref-manual/ref-classes.xml +1 -1
-        These classes are often overridden or extended by other classes
+        These definitions are often overridden or extended by other

classes
such as the
<link
linkend='ref-classes-autotools'><filename>autotools</filename></link>
class or the
--
2.23.0