drm/msm/gpu: make ringbuffer readonly
Subsystems (4)
PATCH 1/1 drm/msm/gpu: make ringbuffer readonly
From: Rob Clark <[email protected]>
The GPU has no business writing into the ringbuffer, let's make it readonly to the GPU.
Fixes 7198e6b03155 ("drm/msm: add a3xx gpu support")
Signed-off-by Rob Clark <[email protected]>
--- drivers/gpu/drm/msm/msm_ringbuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_ringbuffer.c +2 -1
@@ -27,7 +27,8 @@ struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, ring->id = id; ring->start =msm_gem_kernel_new (gpu->dev,MSM_GPU_RINGBUFFER_SZ , -MSM_BO_WC , gpu->aspace, &ring->bo, &ring->iova); +MSM_BO_WC |MSM_BO_GPU_READONLY , gpu->aspace, &ring->bo, + &ring->iova);if (IS_ERR (ring->start)) { ret =PTR_ERR (ring->start);
Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
The GPU has no business writing into the ringbuffer, let's make it readonly to the GPU.
Yep. There are some additional things we can do in the a6xx family to make this even more robust but for the vast majority of targets out in this world this is a good and necessary fix.
Reviewed-by Jordan Crouse <[email protected]>
Quoted 23 lines
Fixes 7198e6b03155 ("drm/msm: add a3xx gpu support")Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/msm/msm_ringbuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/msm_ringbuffer.c +2
-1@@ -27,7 +27,8 @@ struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, ring->id = id; ring->start =msm_gem_kernel_new (gpu->dev,MSM_GPU_RINGBUFFER_SZ , -MSM_BO_WC , gpu->aspace, &ring->bo, &ring->iova); +MSM_BO_WC |MSM_BO_GPU_READONLY , gpu->aspace, &ring->bo, + &ring->iova);if (IS_ERR (ring->start)) { ret =PTR_ERR (ring->start);Signature · 1 line
2.26.2
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel