Skip to contentSkip to conversation

mm: util: update the kerneldoc for kstrdup_const()

PATCH RESEND Applied Bartosz Golaszewski 1 participant 1 message Aug 17, 2020

Subsystems (2)
Memory management MM core
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH RESEND 1/1 mm: util: update the kerneldoc for kstrdup_const()

From: Bartosz Golaszewski <[email protected]>

Memory allocated with kstrdup_const() must not be passed to regular krealloc() as it is not aware of the possibility of the chunk residing in .rodata. Since there are no potential users of krealloc_const() at the moment, let's just update the doc to make it explicit.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 mm/util.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/util.c +2 -1
index 5ef378a2a038..bb902f5a6582 100644
@@ -69,7 +69,8 @@ EXPORT_SYMBOL(kstrdup);
  * @s: the string to duplicate
  * @gfp: the GFP mask used in the kmalloc() call when allocating memory
  *
- * Note: Strings allocated by kstrdup_const should be freed by kfree_const.
+ * Note: Strings allocated by kstrdup_const should be freed by kfree_const and
+ * must not be passed to krealloc().
  *
  * Return: source string if it is in .rodata section otherwise
  * fallback to kstrdup.
Signature · 1 line
2.26.1