wirless: convert tasklets to use new tasklet_setup()
Subsystems (22)
cover wirless: convert tasklets to use new tasklet_setup()
From: Allen Pais <[email protected]>
Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the wireless drivers to use the new tasklet_setup() API
Allen Pais (16):
wireless: ath5k: convert tasklets to use new tasklet_setup() API
wireless: ath9k: convert tasklets to use new tasklet_setup() API
wireless: ath: convert tasklets to use new tasklet_setup() API
wireless: ath11k: convert tasklets to use new tasklet_setup() API
wireless: atmel: convert tasklets to use new tasklet_setup() API
wireless: b43legacy: convert tasklets to use new tasklet_setup() API
wireless: brcm80211: convert tasklets to use new tasklet_setup() API
wireless: ipw2x00: convert tasklets to use new tasklet_setup() API
wireless: iwlegacy: convert tasklets to use new tasklet_setup() API
wireless: intersil: convert tasklets to use new tasklet_setup() API
wireless: marvell: convert tasklets to use new tasklet_setup() API
wireless: mediatek: convert tasklets to use new tasklet_setup() API
wireless: quantenna: convert tasklets to use new tasklet_setup() API
wireless: ralink: convert tasklets to use new tasklet_setup() API
wireless: realtek: convert tasklets to use new tasklet_setup() API
wireless: zydas: convert tasklets to use new tasklet_setup() API
drivers/net/wireless/ath/ath11k/ahb.c | 7 +++--- drivers/net/wireless/ath/ath5k/base.c | 24 +++++++++---------- drivers/net/wireless/ath/ath5k/rfkill.c | 7 +++--- drivers/net/wireless/ath/ath9k/ath9k.h | 4 ++-- drivers/net/wireless/ath/ath9k/beacon.c | 4 ++-- drivers/net/wireless/ath/ath9k/htc.h | 4 ++-- drivers/net/wireless/ath/ath9k/htc_drv_init.c | 6 ++--- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 8 +++---- drivers/net/wireless/ath/ath9k/init.c | 5 ++-- drivers/net/wireless/ath/ath9k/main.c | 4 ++-- drivers/net/wireless/ath/ath9k/wmi.c | 7 +++--- drivers/net/wireless/ath/ath9k/wmi.h | 2 +- drivers/net/wireless/ath/carl9170/usb.c | 7 +++--- drivers/net/wireless/atmel/at76c50x-usb.c | 9 ++++--- .../net/wireless/broadcom/b43legacy/main.c | 8 +++---- drivers/net/wireless/broadcom/b43legacy/pio.c | 7 +++--- .../broadcom/brcm80211/brcmsmac/mac80211_if.c | 6 ++--- .../broadcom/brcm80211/brcmsmac/mac80211_if.h | 2 +- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 9 ++++--- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 7 +++--- .../net/wireless/intel/iwlegacy/3945-mac.c | 8 +++---- .../net/wireless/intel/iwlegacy/4965-mac.c | 8 +++---- .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++------- drivers/net/wireless/intersil/orinoco/main.c | 7 +++--- drivers/net/wireless/intersil/p54/p54pci.c | 8 +++---- drivers/net/wireless/marvell/mwl8k.c | 16 ++++++------- drivers/net/wireless/mediatek/mt76/mac80211.c | 2 +- drivers/net/wireless/mediatek/mt76/mt76.h | 2 +- .../wireless/mediatek/mt76/mt7603/beacon.c | 4 ++-- .../net/wireless/mediatek/mt76/mt7603/init.c | 3 +-- .../wireless/mediatek/mt76/mt7603/mt7603.h | 2 +- .../net/wireless/mediatek/mt76/mt7615/mmio.c | 6 ++--- .../net/wireless/mediatek/mt76/mt76x02_dfs.c | 10 ++++---- .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 14 +++++------ drivers/net/wireless/mediatek/mt76/tx.c | 4 ++-- drivers/net/wireless/mediatek/mt76/usb.c | 12 +++++----- drivers/net/wireless/mediatek/mt7601u/dma.c | 12 +++++----- .../quantenna/qtnfmac/pcie/pearl_pcie.c | 7 +++--- .../quantenna/qtnfmac/pcie/topaz_pcie.c | 7 +++--- .../net/wireless/ralink/rt2x00/rt2400pci.c | 14 ++++++----- .../net/wireless/ralink/rt2x00/rt2500pci.c | 14 ++++++----- .../net/wireless/ralink/rt2x00/rt2800mmio.c | 24 +++++++++++-------- .../net/wireless/ralink/rt2x00/rt2800mmio.h | 10 ++++---- drivers/net/wireless/ralink/rt2x00/rt2x00.h | 10 ++++---- .../net/wireless/ralink/rt2x00/rt2x00dev.c | 5 ++-- drivers/net/wireless/ralink/rt2x00/rt61pci.c | 20 +++++++++------- drivers/net/wireless/realtek/rtlwifi/pci.c | 21 ++++++++-------- drivers/net/wireless/realtek/rtlwifi/usb.c | 9 ++++--- drivers/net/wireless/realtek/rtw88/main.c | 3 +-- drivers/net/wireless/realtek/rtw88/tx.c | 4 ++-- drivers/net/wireless/realtek/rtw88/tx.h | 2 +- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 8 +++---- 52 files changed, 208 insertions(+), 223 deletions(-)
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 1/16 wireless: ath5k: convert tasklets to use new tasklet_setup() API
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/ath/ath5k/base.c | 24 ++++++++++++------------ drivers/net/wireless/ath/ath5k/rfkill.c | 7 +++---- 2 files changed, 15 insertions(+), 16 deletions(-)
drivers/net/wireless/ath/ath5k/base.c +12 -12
@@ -1536,12 +1536,12 @@ ath5k_set_current_imask(struct ath5k_hw *ah) }static void -ath5k_tasklet_rx (unsigned long data) +ath5k_tasklet_rx (struct tasklet_struct *t) {struct ath5k_rx_status rs = {};struct sk_buff *skb, *next_skb;dma_addr_t next_skb_addr; -struct ath5k_hw *ah = (void *)data; +struct ath5k_hw *ah =from_tasklet (ah, t, rxtq);struct ath_common *common =ath5k_hw_common (ah);struct ath5k_buf *bf;struct ath5k_desc *ds;
@@ -1784,10 +1784,10 @@ ath5k_tx_processq(struct ath5k_hw *ah, struct ath5k_txq *txq) }static void -ath5k_tasklet_tx (unsigned long data) +ath5k_tasklet_tx (struct tasklet_struct *t) {int i; -struct ath5k_hw *ah = (void *)data; +struct ath5k_hw *ah =from_tasklet (ah, t, txtq);for (i =0 ; i <AR5K_NUM_TX_QUEUES ; i++)if (ah->txqs[i].setup && (ah->ah_txq_isr_txok_all &BIT (i)))
@@ -2176,9 +2176,9 @@ ath5k_beacon_config(struct ath5k_hw *ah)spin_unlock_bh (&ah->block); } -static void ath5k_tasklet_beacon (unsigned long data) +static void ath5k_tasklet_beacon (struct tasklet_struct *t) { -struct ath5k_hw *ah = (struct ath5k_hw *) data; +struct ath5k_hw *ah =from_tasklet (ah, t, beacontq);/* * Software beacon alert--time to send a beacon.
@@ -2447,9 +2447,9 @@ ath5k_calibrate_work(struct work_struct *work)static void -ath5k_tasklet_ani (unsigned long data) +ath5k_tasklet_ani (struct tasklet_struct *t) { -struct ath5k_hw *ah = (void *)data; +struct ath5k_hw *ah =from_tasklet (ah, t, ani_tasklet); ah->ah_cal_mask |=AR5K_CALIBRATION_ANI ;ath5k_ani_calibration (ah);
@@ -3069,10 +3069,10 @@ ath5k_init(struct ieee80211_hw *hw) hw->queues =1 ; } -tasklet_init (&ah->rxtq, ath5k_tasklet_rx, (unsigned long )ah); -tasklet_init (&ah->txtq, ath5k_tasklet_tx, (unsigned long )ah); -tasklet_init (&ah->beacontq, ath5k_tasklet_beacon, (unsigned long )ah); -tasklet_init (&ah->ani_tasklet, ath5k_tasklet_ani, (unsigned long )ah); +tasklet_setup (&ah->rxtq, ath5k_tasklet_rx); +tasklet_setup (&ah->txtq, ath5k_tasklet_tx); +tasklet_setup (&ah->beacontq, ath5k_tasklet_beacon); +tasklet_setup (&ah->ani_tasklet, ath5k_tasklet_ani);INIT_WORK (&ah->reset_work, ath5k_reset_work);INIT_WORK (&ah->calib_work, ath5k_calibrate_work);
drivers/net/wireless/ath/ath5k/rfkill.c +3 -4
@@ -73,9 +73,9 @@ ath5k_is_rfkill_set(struct ath5k_hw *ah) }static void -ath5k_tasklet_rfkill_toggle (unsigned long data) +ath5k_tasklet_rfkill_toggle (struct tasklet_struct *t) { -struct ath5k_hw *ah = (void *)data; +struct ath5k_hw *ah =from_tasklet (ah, t, rf_kill.toggleq);bool blocked; blocked =ath5k_is_rfkill_set (ah);
@@ -90,8 +90,7 @@ ath5k_rfkill_hw_start(struct ath5k_hw *ah) ah->rf_kill.gpio = ah->ah_capabilities.cap_eeprom.ee_rfkill_pin; ah->rf_kill.polarity = ah->ah_capabilities.cap_eeprom.ee_rfkill_pol; -tasklet_init (&ah->rf_kill.toggleq, ath5k_tasklet_rfkill_toggle, - (unsigned long )ah); +tasklet_setup (&ah->rf_kill.toggleq, ath5k_tasklet_rfkill_toggle);ath5k_rfkill_disable (ah);
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API
Quoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
c068a9ec3c94 ath5k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717393/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
c068a9ec3c94 ath5k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717393/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API
Hi,
Quoted 12 lines
Quoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Quoted 8 lines
Patch applied to ath-next branch of ath.git, thanks.
c068a9ec3c94ath5k: convert tasklets to use newtasklet_setup()API--
https://patchwork.kernel.org/patch/11717393/https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Could you please drop these and wait for V2. A change was proposed for from_tasklet() api. The new API should be picked shortly. I will send out the updated version early next week.
Thanks,
- Allen
Signature · 3 lines
ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API
Quoted 17 lines · Allen Pais
Hi,
Quoted 16 lines
Quoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>Patch applied to ath-next branch of ath.git, thanks.
c068a9ec3c94ath5k: convert tasklets to use newtasklet_setup()API
Quoted 8 lines
Quoted 4 lines
--
https://patchwork.kernel.org/patch/11717393/https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Could you please drop these and wait for V2. A change was proposed for
from_tasklet()api. The new API should be picked shortly. I will send out the updated version early next week.
Too late, I don't normally rebase my trees as it's just too much of a hassle. Please don't submit patches which are not ready to be applied!
Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 17 lines · Allen Pais
Hi,
Quoted 16 lines
Quoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>Patch applied to ath-next branch of ath.git, thanks.
c068a9ec3c94ath5k: convert tasklets to use newtasklet_setup()API
Quoted 8 lines
Quoted 4 lines
--
https://patchwork.kernel.org/patch/11717393/https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Could you please drop these and wait for V2. A change was proposed for
from_tasklet()api. The new API should be picked shortly. I will send out the updated version early next week.
Too late, I don't normally rebase my trees as it's just too much of a hassle. Please don't submit patches which are not ready to be applied!
Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 2/16 wireless: ath9k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/ath/ath9k/ath9k.h | 4 ++-- drivers/net/wireless/ath/ath9k/beacon.c | 4 ++-- drivers/net/wireless/ath/ath9k/htc.h | 4 ++-- drivers/net/wireless/ath/ath9k/htc_drv_init.c | 6 ++---- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 8 ++++---- drivers/net/wireless/ath/ath9k/init.c | 5 ++--- drivers/net/wireless/ath/ath9k/main.c | 4 ++-- drivers/net/wireless/ath/ath9k/wmi.c | 7 +++---- drivers/net/wireless/ath/ath9k/wmi.h | 2 +- 9 files changed, 20 insertions(+), 24 deletions(-)
drivers/net/wireless/ath/ath9k/ath9k.h +2 -2
@@ -713,7 +713,7 @@ struct ath_beacon {bool tx_last; }; -void ath9k_beacon_tasklet (unsigned long data); +void ath9k_beacon_tasklet (struct tasklet_struct *t);void ath9k_beacon_config (struct ath_softc *sc,struct ieee80211_vif *main_vif,bool beacons);void ath9k_beacon_assign_slot (struct ath_softc *sc,struct ieee80211_vif *vif);
@@ -1117,7 +1117,7 @@ static inline void ath_read_cachesize(struct ath_common *common, int *csz) common->bus_ops->read_cachesize (common, csz); } -void ath9k_tasklet (unsigned long data); +void ath9k_tasklet (struct tasklet_struct *t);int ath_cabq_update (struct ath_softc *);u8 ath9k_parse_mpdudensity (u8 mpdudensity);irqreturn_t ath_isr (int irq,void *dev);
drivers/net/wireless/ath/ath9k/beacon.c +2 -2
@@ -385,9 +385,9 @@ void ath9k_csa_update(struct ath_softc *sc) ath9k_csa_update_vif, sc); } -void ath9k_beacon_tasklet (unsigned long data) +void ath9k_beacon_tasklet (struct tasklet_struct *t) { -struct ath_softc *sc = (struct ath_softc *)data; +struct ath_softc *sc =from_tasklet (sc, t, bcon_tasklet);struct ath_hw *ah = sc->sc_ah;struct ath_common *common =ath9k_hw_common (ah);struct ath_buf *bf =NULL ;
drivers/net/wireless/ath/ath9k/htc.h +2 -2
@@ -583,14 +583,14 @@ int ath9k_htc_tx_get_slot(struct ath9k_htc_priv *priv);void ath9k_htc_tx_clear_slot (struct ath9k_htc_priv *priv,int slot);void ath9k_htc_tx_drain (struct ath9k_htc_priv *priv);void ath9k_htc_txstatus (struct ath9k_htc_priv *priv,void *wmi_event); -void ath9k_tx_failed_tasklet (unsigned long data); +void ath9k_tx_failed_tasklet (struct tasklet_struct *t);void ath9k_htc_tx_cleanup_timer (struct timer_list *t);bool ath9k_htc_csa_is_finished (struct ath9k_htc_priv *priv);int ath9k_rx_init (struct ath9k_htc_priv *priv);void ath9k_rx_cleanup (struct ath9k_htc_priv *priv);void ath9k_host_rx_init (struct ath9k_htc_priv *priv); -void ath9k_rx_tasklet (unsigned long data); +void ath9k_rx_tasklet (struct tasklet_struct *t);u32 ath9k_htc_calcrxfilter (struct ath9k_htc_priv *priv);void ath9k_htc_ps_wakeup (struct ath9k_htc_priv *priv);
drivers/net/wireless/ath/ath9k/htc_drv_init.c +2 -4
@@ -645,10 +645,8 @@ static int ath9k_init_priv(struct ath9k_htc_priv *priv,spin_lock_init (&priv->tx.tx_lock);mutex_init (&priv->mutex);mutex_init (&priv->htc_pm_lock); -tasklet_init (&priv->rx_tasklet, ath9k_rx_tasklet, - (unsigned long )priv); -tasklet_init (&priv->tx_failed_tasklet, ath9k_tx_failed_tasklet, - (unsigned long )priv); +tasklet_setup (&priv->rx_tasklet, ath9k_rx_tasklet); +tasklet_setup (&priv->tx_failed_tasklet, ath9k_tx_failed_tasklet);INIT_DELAYED_WORK (&priv->ani_work, ath9k_htc_ani_work);INIT_WORK (&priv->ps_work, ath9k_ps_work);INIT_WORK (&priv->fatal_work, ath9k_fatal_work);
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c +4 -4
@@ -570,9 +570,9 @@ void ath9k_htc_tx_drain(struct ath9k_htc_priv *priv)spin_unlock_bh (&priv->tx.tx_lock); } -void ath9k_tx_failed_tasklet (unsigned long data) +void ath9k_tx_failed_tasklet (struct tasklet_struct *t) { -struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data; +struct ath9k_htc_priv *priv =from_tasklet (priv, t, tx_failed_tasklet);spin_lock (&priv->tx.tx_lock);if (priv->tx.flags &ATH9K_HTC_OP_TX_DRAIN ) {
@@ -1062,9 +1062,9 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,/* * FIXME: Handle FLUSH later on. */ -void ath9k_rx_tasklet (unsigned long data) +void ath9k_rx_tasklet (struct tasklet_struct *t) { -struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data; +struct ath9k_htc_priv *priv =from_tasklet (priv, t, rx_tasklet);struct ath9k_htc_rxbuf *rxbuf =NULL , *tmp_buf =NULL ;struct ieee80211_rx_status rx_status;struct sk_buff *skb;
drivers/net/wireless/ath/ath9k/init.c +2 -3
@@ -728,9 +728,8 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc,spin_lock_init (&sc->sc_pm_lock);spin_lock_init (&sc->chan_lock);mutex_init (&sc->mutex); -tasklet_init (&sc->intr_tq, ath9k_tasklet, (unsigned long )sc); -tasklet_init (&sc->bcon_tasklet, ath9k_beacon_tasklet, - (unsigned long )sc); +tasklet_setup (&sc->intr_tq, ath9k_tasklet); +tasklet_setup (&sc->bcon_tasklet, ath9k_beacon_tasklet);timer_setup (&sc->sleep_timer, ath_ps_full_sleep,0 );INIT_WORK (&sc->hw_reset_work, ath_reset_work);
drivers/net/wireless/ath/ath9k/main.c +2 -2
@@ -368,9 +368,9 @@ static void ath_node_detach(struct ath_softc *sc, struct ieee80211_sta *sta)ath_dynack_node_deinit (sc->sc_ah, an); } -void ath9k_tasklet (unsigned long data) +void ath9k_tasklet (struct tasklet_struct *t) { -struct ath_softc *sc = (struct ath_softc *)data; +struct ath_softc *sc =from_tasklet (sc, t, intr_tq);struct ath_hw *ah = sc->sc_ah;struct ath_common *common =ath9k_hw_common (ah);enum ath_reset_type type;
drivers/net/wireless/ath/ath9k/wmi.c +3 -4
@@ -106,8 +106,7 @@ struct wmi *ath9k_init_wmi(struct ath9k_htc_priv *priv)mutex_init (&wmi->multi_rmw_mutex);init_completion (&wmi->cmd_wait);INIT_LIST_HEAD (&wmi->pending_tx_events); -tasklet_init (&wmi->wmi_event_tasklet, ath9k_wmi_event_tasklet, - (unsigned long )wmi); +tasklet_setup (&wmi->wmi_event_tasklet, ath9k_wmi_event_tasklet);return wmi; }
@@ -136,9 +135,9 @@ void ath9k_wmi_event_drain(struct ath9k_htc_priv *priv)spin_unlock_irqrestore (&priv->wmi->wmi_lock, flags); } -void ath9k_wmi_event_tasklet (unsigned long data) +void ath9k_wmi_event_tasklet (struct tasklet_struct *t) { -struct wmi *wmi = (struct wmi *)data; +struct wmi *wmi =from_tasklet (wmi, t, wmi_event_tasklet);struct ath9k_htc_priv *priv = wmi->drv_priv;struct wmi_cmd_hdr *hdr;void *wmi_event;
drivers/net/wireless/ath/ath9k/wmi.h +1 -1
@@ -185,7 +185,7 @@ int ath9k_wmi_cmd(struct wmi *wmi, enum wmi_cmd_id cmd_id, u8 *cmd_buf, u32 cmd_len, u8 *rsp_buf, u32 rsp_len, u32 timeout); -void ath9k_wmi_event_tasklet (unsigned long data); +void ath9k_wmi_event_tasklet (struct tasklet_struct *t);void ath9k_fatal_work (struct work_struct *work);void ath9k_wmi_event_drain (struct ath9k_htc_priv *priv);void ath9k_stop_wmi (struct ath9k_htc_priv *priv);
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 02/16] wireless: ath9k: convert tasklets to use new tasklet_setup() API
Quoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
f91a35b46af0 ath9k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717397/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 02/16] wireless: ath9k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 8 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
f91a35b46af0 ath9k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717397/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 3/16 wireless: ath: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/ath/carl9170/usb.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/carl9170/usb.c +3 -4
@@ -377,9 +377,9 @@ void carl9170_usb_handle_tx_err(struct ar9170 *ar) } } -static void carl9170_usb_tasklet (unsigned long data) +static void carl9170_usb_tasklet (struct tasklet_struct *t) { -struct ar9170 *ar = (struct ar9170 *) data; +struct ar9170 *ar =from_tasklet (ar, t, usb_tasklet);if (!IS_INITIALIZED (ar))return ;
@@ -1082,8 +1082,7 @@ static int carl9170_usb_probe(struct usb_interface *intf,init_completion (&ar->cmd_wait);init_completion (&ar->fw_boot_wait);init_completion (&ar->fw_load_wait); -tasklet_init (&ar->usb_tasklet, carl9170_usb_tasklet, - (unsigned long )ar); +tasklet_setup (&ar->usb_tasklet, carl9170_usb_tasklet);atomic_set (&ar->tx_cmd_urbs,0 );atomic_set (&ar->tx_anch_urbs,0 );
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API
Hello,
looking at the other patches in this series, I think this patch's subject "ath:" tag was supposed to be "carl9170:"?
(so the full subject is:
"wireless: carl9170: convert tasklets to use new tasklet_setup() API")
Quoted 9 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>
Seems to work.
Quoted 31 lines
--- drivers/net/wireless/ath/carl9170/usb.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/net/wireless/ath/carl9170/usb.c +3
-4@@ -377,9 +377,9 @@ void carl9170_usb_handle_tx_err(struct ar9170 *ar) } } -static void carl9170_usb_tasklet (unsigned long data) +static void carl9170_usb_tasklet (struct tasklet_struct *t) { -struct ar9170 *ar = (struct ar9170 *) data; +struct ar9170 *ar =from_tasklet (ar, t, usb_tasklet);if (!IS_INITIALIZED (ar))return ;@@ -1082,8 +1082,7 @@ static int carl9170_usb_probe(struct usb_interface *intf,init_completion (&ar->cmd_wait);init_completion (&ar->fw_boot_wait);init_completion (&ar->fw_load_wait); -tasklet_init (&ar->usb_tasklet, carl9170_usb_tasklet, - (unsigned long )ar); +tasklet_setup (&ar->usb_tasklet, carl9170_usb_tasklet);atomic_set (&ar->tx_cmd_urbs,0 );atomic_set (&ar->tx_anch_urbs,0 );
Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 9 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
de7dbc2dbef7 carl9170: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717455/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 9 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
de7dbc2dbef7 carl9170: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717455/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 4/16 wireless: ath11k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/ath/ath11k/ahb.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/ath11k/ahb.c +3 -4
@@ -675,9 +675,9 @@ static void ath11k_ahb_free_irq(struct ath11k_base *ab)ath11k_ahb_free_ext_irq (ab); } -static void ath11k_ahb_ce_tasklet (unsigned long data) +static void ath11k_ahb_ce_tasklet (struct tasklet_struct *t) { -struct ath11k_ce_pipe *ce_pipe = (struct ath11k_ce_pipe *)data; +struct ath11k_ce_pipe *ce_pipe =from_tasklet (ce_pipe, t, intr_tq);ath11k_ce_per_engine_service (ce_pipe->ab, ce_pipe->pipe_num);
@@ -827,8 +827,7 @@ static int ath11k_ahb_config_irq(struct ath11k_base *ab) irq_idx =ATH11K_IRQ_CE0_OFFSET + i; -tasklet_init (&ce_pipe->intr_tq, ath11k_ahb_ce_tasklet, - (unsigned long )ce_pipe); +tasklet_setup (&ce_pipe->intr_tq, ath11k_ahb_ce_tasklet); irq =platform_get_irq_byname (ab->pdev, irq_name[irq_idx]); ret = request_irq(irq, ath11k_ahb_ce_interrupt_handler, IRQF_TRIGGER_RISING, irq_name[irq_idx],
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 04/16] wireless: ath11k: convert tasklets to use new tasklet_setup() API
Quoted 7 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
c08279a93191 ath11k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717399/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 04/16] wireless: ath11k: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 7 lines · Allen Pais
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Allen Pais <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
c08279a93191 ath11k: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717399/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 5/16 wireless: atmel: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly and remove .data field.
--- drivers/net/wireless/atmel/at76c50x-usb.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/net/wireless/atmel/at76c50x-usb.c +4 -5
@@ -1199,7 +1199,6 @@ static void at76_rx_callback(struct urb *urb) {struct at76_priv *priv = urb->context; - priv->rx_tasklet.data = (unsigned long )urb;tasklet_schedule (&priv->rx_tasklet); }
@@ -1545,10 +1544,10 @@ static inline int at76_guess_freq(struct at76_priv *priv)return ieee80211_channel_to_frequency (channel,NL80211_BAND_2GHZ ); } -static void at76_rx_tasklet (unsigned long param) +static void at76_rx_tasklet (struct tasklet_struct *t) { -struct urb *urb = (struct urb *)param; -struct at76_priv *priv = urb->context; +struct at76_priv *priv =from_tasklet (priv, t, rx_tasklet); +struct urb *urb = priv->rx_urb;struct at76_rx_buffer *buf;struct ieee80211_rx_status rx_status = {0 };
@@ -2215,7 +2214,7 @@ static struct at76_priv *at76_alloc_new_device(struct usb_device *udev)INIT_WORK (&priv->work_join_bssid, at76_work_join_bssid);INIT_DELAYED_WORK (&priv->dwork_hw_scan, at76_dwork_hw_scan); -tasklet_init (&priv->rx_tasklet, at76_rx_tasklet,0 ); +tasklet_setup (&priv->rx_tasklet, at76_rx_tasklet); priv->pm_mode =AT76_PM_OFF ; priv->pm_period =0 ;
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API
Quoted 10 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly and remove .data field.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>
11 patches applied to wireless-drivers-next.git, thanks.
a36f50e5b937 atmel: convert tasklets to use new tasklet_setup() API fc6722301428 b43legacy: convert tasklets to use new tasklet_setup() API 427a06beb072 brcmsmac: convert tasklets to use new tasklet_setup() API ae6cf59f80f7 ipw2x00: convert tasklets to use new tasklet_setup() API b81b9d372ac8 iwlegacy: convert tasklets to use new tasklet_setup() API 7433c9690318 intersil: convert tasklets to use new tasklet_setup() API 51c41aa93ef5 mwl8k: convert tasklets to use new tasklet_setup() API aff8e8d02ec2 qtnfmac: convert tasklets to use new tasklet_setup() API a0d6ea9b6e1c rt2x00: convert tasklets to use new tasklet_setup() API d3ccc14dfe95 rtlwifi/rtw88: convert tasklets to use new tasklet_setup() API 26721b02466e zd1211rw: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717451/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 10 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly and remove .data field.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>
11 patches applied to wireless-drivers-next.git, thanks.
a36f50e5b937 atmel: convert tasklets to use new tasklet_setup() API fc6722301428 b43legacy: convert tasklets to use new tasklet_setup() API 427a06beb072 brcmsmac: convert tasklets to use new tasklet_setup() API ae6cf59f80f7 ipw2x00: convert tasklets to use new tasklet_setup() API b81b9d372ac8 iwlegacy: convert tasklets to use new tasklet_setup() API 7433c9690318 intersil: convert tasklets to use new tasklet_setup() API 51c41aa93ef5 mwl8k: convert tasklets to use new tasklet_setup() API aff8e8d02ec2 qtnfmac: convert tasklets to use new tasklet_setup() API a0d6ea9b6e1c rt2x00: convert tasklets to use new tasklet_setup() API d3ccc14dfe95 rtlwifi/rtw88: convert tasklets to use new tasklet_setup() API 26721b02466e zd1211rw: convert tasklets to use new tasklet_setup() API
Signature · 3 lines
https://patchwork.kernel.org/patch/11717451/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API
Quoted 15 lines · Kalle Valo
Quoted 10 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly and remove .data field.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>11 patches applied to wireless-drivers-next.git, thanks.
Quoted 16 lines
a36f50e5b937atmel: convert tasklets to use newtasklet_setup()APIfc6722301428b43legacy: convert tasklets to use newtasklet_setup()API427a06beb072brcmsmac: convert tasklets to use newtasklet_setup()APIae6cf59f80f7ipw2x00: convert tasklets to use newtasklet_setup()APIb81b9d372ac8iwlegacy: convert tasklets to use newtasklet_setup()API7433c9690318intersil: convert tasklets to use newtasklet_setup()API51c41aa93ef5mwl8k: convert tasklets to use newtasklet_setup()APIaff8e8d02ec2qtnfmac: convert tasklets to use newtasklet_setup()APIa0d6ea9b6e1crt2x00: convert tasklets to use newtasklet_setup()APId3ccc14dfe95rtlwifi/rtw88: convert tasklets to use newtasklet_setup()API26721b02466ezd1211rw: convert tasklets to use newtasklet_setup()APISignature · 3 lines
https://patchwork.kernel.org/patch/11717451/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
FWIW, I don't think a revert is needed here to wait for the from_tasket() -> container_from() API to land since from_tasklet() is already being used by other trees. Let's just get this done so we can get closer to ripping out the old tasklet API. We'll have to do a treewide from_timer(), from_tasklet() -> container_from() anyway...
Signature · 1 line
Kees Cook
PATCH 6/16 wireless: b43legacy: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/broadcom/b43legacy/main.c | 8 +++----- drivers/net/wireless/broadcom/b43legacy/pio.c | 7 +++---- 2 files changed, 6 insertions(+), 9 deletions(-)
drivers/net/wireless/broadcom/b43legacy/main.c +3 -5
@@ -1275,9 +1275,9 @@ static void handle_irq_ucode_debug(struct b43legacy_wldev *dev) }/* Interrupt handler bottom-half */ -static void b43legacy_interrupt_tasklet (unsigned long data) +static void b43legacy_interrupt_tasklet (struct tasklet_struct *t) { -struct b43legacy_wldev *dev = (struct b43legacy_wldev *)data; +struct b43legacy_wldev *dev =from_tasklet (dev, t, isr_tasklet);u32 reason;u32 dma_reason[ARRAY_SIZE (dev->dma_reason)];u32 merged_dma_reason =0 ;
@@ -3741,9 +3741,7 @@ static int b43legacy_one_core_attach(struct ssb_device *dev, wldev->wl = wl;b43legacy_set_status (wldev, B43legacy_STAT_UNINIT); wldev->bad_frames_preempt = modparam_bad_frames_preempt; -tasklet_init (&wldev->isr_tasklet, - b43legacy_interrupt_tasklet, - (unsigned long )wldev); +tasklet_setup (&wldev->isr_tasklet, b43legacy_interrupt_tasklet);if (modparam_pio) wldev->__using_pio = true;INIT_LIST_HEAD (&wldev->list);
drivers/net/wireless/broadcom/b43legacy/pio.c +3 -4
@@ -264,9 +264,9 @@ static int pio_tx_packet(struct b43legacy_pio_txpacket *packet)return 0 ; } -static void tx_tasklet (unsigned long d) +static void tx_tasklet (struct tasklet_struct *t) { -struct b43legacy_pioqueue *queue = (struct b43legacy_pioqueue *)d; +struct b43legacy_pioqueue *queue =from_tasklet (queue, t, txtask);struct b43legacy_wldev *dev = queue->dev;unsigned long flags;struct b43legacy_pio_txpacket *packet, *tmp_packet;
@@ -331,8 +331,7 @@ struct b43legacy_pioqueue *b43legacy_setup_pioqueue(struct b43legacy_wldev *dev,INIT_LIST_HEAD (&queue->txfree);INIT_LIST_HEAD (&queue->txqueue);INIT_LIST_HEAD (&queue->txrunning); -tasklet_init (&queue->txtask, tx_tasklet, - (unsigned long )queue); +tasklet_setup (&queue->txtask, tx_tasklet); value =b43legacy_read32 (dev, B43legacy_MMIO_MACCTL); value &= ~B43legacy_MACCTL_BE;
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 7/16 wireless: brcm80211: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 6 +++--- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +3 -3
@@ -982,11 +982,11 @@ static const struct ieee80211_ops brcms_ops = { .set_tim = brcms_ops_beacon_set_tim, }; -void brcms_dpc (unsigned long data) +void brcms_dpc (struct tasklet_struct *t) {struct brcms_info *wl; - wl = (struct brcms_info *) data; + wl =from_tasklet (wl, t, tasklet);spin_lock_bh (&wl->lock);
@@ -1149,7 +1149,7 @@ static struct brcms_info *brcms_attach(struct bcma_device *pdev)init_waitqueue_head (&wl->tx_flush_wq);/* setup the bottom half handler */ -tasklet_init (&wl->tasklet, brcms_dpc, (unsigned long ) wl); +tasklet_setup (&wl->tasklet, brcms_dpc);spin_lock_init (&wl->lock);spin_lock_init (&wl->isr_lock);
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h +1 -1
@@ -106,7 +106,7 @@ struct brcms_timer *brcms_init_timer(struct brcms_info *wl,void brcms_free_timer (struct brcms_timer *timer);void brcms_add_timer (struct brcms_timer *timer,uint ms,int periodic);bool brcms_del_timer (struct brcms_timer *timer); -void brcms_dpc (unsigned long data); +void brcms_dpc (struct tasklet_struct *t);void brcms_timer (struct brcms_timer *t);void brcms_fatal_error (struct brcms_info *wl);
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 07/16] wireless: brcm80211: convert tasklets to use new tasklet_setup() API
Quoted 6 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.
Quoted 6 lines
Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>--- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 6 +++--- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
PATCH 8/16 wireless: ipw2x00: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 9 ++++----- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 7 +++---- 2 files changed, 7 insertions(+), 9 deletions(-)
drivers/net/wireless/intel/ipw2x00/ipw2100.c +4 -5
@@ -3204,9 +3204,9 @@ static void ipw2100_tx_send_data(struct ipw2100_priv *priv) } } -static void ipw2100_irq_tasklet (unsigned long data) +static void ipw2100_irq_tasklet (struct tasklet_struct *t) { -struct ipw2100_priv *priv = (struct ipw2100_priv *)data; +struct ipw2100_priv *priv =from_tasklet (priv, t, irq_tasklet);struct net_device *dev = priv->net_dev;unsigned long flags;u32 inta, tmp;
@@ -6005,7 +6005,7 @@ static void ipw2100_rf_kill(struct work_struct *work)spin_unlock_irqrestore (&priv->low_lock, flags); } -static void ipw2100_irq_tasklet (unsigned long data); +static void ipw2100_irq_tasklet (struct tasklet_struct *t);static const struct net_device_ops ipw2100_netdev_ops = { .ndo_open = ipw2100_open,
@@ -6135,8 +6135,7 @@ static struct net_device *ipw2100_alloc_device(struct pci_dev *pci_dev,INIT_DELAYED_WORK (&priv->rf_kill, ipw2100_rf_kill);INIT_DELAYED_WORK (&priv->scan_event, ipw2100_scan_event); -tasklet_init (&priv->irq_tasklet, - ipw2100_irq_tasklet, (unsigned long )priv); +tasklet_setup (&priv->irq_tasklet, ipw2100_irq_tasklet);/* NOTE: We do not start the deferred work for status checks yet */ priv->stop_rf_kill =1 ;
drivers/net/wireless/intel/ipw2x00/ipw2200.c +3 -4
@@ -1945,9 +1945,9 @@ static void notify_wx_assoc_event(struct ipw_priv *priv)wireless_send_event (priv->net_dev,SIOCGIWAP , &wrqu,NULL ); } -static void ipw_irq_tasklet (unsigned long data) +static void ipw_irq_tasklet (struct tasklet_struct *t) { -struct ipw_priv *priv = (struct ipw_priv *)data; +struct ipw_priv *priv =from_tasklet (priv, t, irq_tasklet);u32 inta, inta_mask, handled =0 ;unsigned long flags;int rc =0 ;
@@ -10673,8 +10673,7 @@ static void ipw_setup_deferred_work(struct ipw_priv *priv)INIT_WORK (&priv->qos_activate, ipw_bg_qos_activate);#endif /* CONFIG_IPW2200_QOS */ -tasklet_init (&priv->irq_tasklet, - ipw_irq_tasklet, (unsigned long )priv); +tasklet_setup (&priv->irq_tasklet, ipw_irq_tasklet); } static void shim__set_security(struct net_device *dev,
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 9/16 wireless: iwlegacy: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 8 +++----- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 8 +++----- 2 files changed, 6 insertions(+), 10 deletions(-)
drivers/net/wireless/intel/iwlegacy/3945-mac.c +3 -5
@@ -1374,9 +1374,9 @@ il3945_dump_nic_error_log(struct il_priv *il) }static void -il3945_irq_tasklet (unsigned long data) +il3945_irq_tasklet (struct tasklet_struct *t) { -struct il_priv *il = (struct il_priv *)data; +struct il_priv *il =from_tasklet (il, t, irq_tasklet);u32 inta, handled =0 ;u32 inta_fh;unsigned long flags;
@@ -3399,9 +3399,7 @@ il3945_setup_deferred_work(struct il_priv *il)timer_setup (&il->watchdog, il_bg_watchdog,0 ); -tasklet_init (&il->irq_tasklet, - il3945_irq_tasklet, - (unsigned long )il); +tasklet_setup (&il->irq_tasklet, il3945_irq_tasklet); } static void
drivers/net/wireless/intel/iwlegacy/4965-mac.c +3 -5
@@ -4344,9 +4344,9 @@ il4965_synchronize_irq(struct il_priv *il) }static void -il4965_irq_tasklet (unsigned long data) +il4965_irq_tasklet (struct tasklet_struct *t) { -struct il_priv *il = (struct il_priv *)data; +struct il_priv *il =from_tasklet (il, t, irq_tasklet);u32 inta, handled =0 ;u32 inta_fh;unsigned long flags;
@@ -6238,9 +6238,7 @@ il4965_setup_deferred_work(struct il_priv *il)timer_setup (&il->watchdog, il_bg_watchdog,0 ); -tasklet_init (&il->irq_tasklet, - il4965_irq_tasklet, - (unsigned long )il); +tasklet_setup (&il->irq_tasklet, il4965_irq_tasklet); } static void
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 10/16 wireless: intersil: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly and remove .data field.
--- .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++--------- drivers/net/wireless/intersil/orinoco/main.c | 7 +++---- drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++---- 3 files changed, 16 insertions(+), 17 deletions(-)
drivers/net/wireless/intersil/hostap/hostap_hw.c +9 -9
@@ -2083,9 +2083,9 @@ static void hostap_rx_skb(local_info_t *local, struct sk_buff *skb)/* Called only as a tasklet (software IRQ) */ -static void hostap_rx_tasklet (unsigned long data) +static void hostap_rx_tasklet (struct tasklet_struct *t) { -local_info_t *local = (local_info_t *) data; +local_info_t *local =from_tasklet (local, t, rx_tasklet);struct sk_buff *skb;while ((skb =skb_dequeue (&local->rx_list)) !=NULL )
@@ -2288,9 +2288,9 @@ static void prism2_tx_ev(local_info_t *local)/* Called only as a tasklet (software IRQ) */ -static void hostap_sta_tx_exc_tasklet (unsigned long data) +static void hostap_sta_tx_exc_tasklet (struct tasklet_struct *t) { -local_info_t *local = (local_info_t *) data; +local_info_t *local =from_tasklet (local, t, sta_tx_exc_tasklet);struct sk_buff *skb;while ((skb =skb_dequeue (&local->sta_tx_exc_list)) !=NULL ) {
@@ -2390,9 +2390,9 @@ static void prism2_txexc(local_info_t *local)/* Called only as a tasklet (software IRQ) */ -static void hostap_info_tasklet (unsigned long data) +static void hostap_info_tasklet (struct tasklet_struct *t) { -local_info_t *local = (local_info_t *) data; +local_info_t *local =from_tasklet (local, t, info_tasklet);struct sk_buff *skb;while ((skb =skb_dequeue (&local->info_list)) !=NULL ) {
@@ -2469,9 +2469,9 @@ static void prism2_info(local_info_t *local)/* Called only as a tasklet (software IRQ) */ -static void hostap_bap_tasklet (unsigned long data) +static void hostap_bap_tasklet (struct tasklet_struct *t) { -local_info_t *local = (local_info_t *) data; +local_info_t *local =from_tasklet (local, t, bap_tasklet);struct net_device *dev = local->dev;u16 ev;int frames =30 ;
@@ -3183,7 +3183,7 @@ prism2_init_local_data(struct prism2_helper_functions *funcs, int card_idx,/* Initialize tasklets for handling hardware IRQ related operations * outside hw IRQ handler */ #define HOSTAP_TASKLET_INIT (q, f, d) \ -do { memset((q), 0, sizeof(*(q))); (q)->func = (f); (q)->data = (d); } \ +do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \ while (0)HOSTAP_TASKLET_INIT (&local->bap_tasklet, hostap_bap_tasklet, (unsigned long ) local);
drivers/net/wireless/intersil/orinoco/main.c +3 -4
@@ -1062,9 +1062,9 @@ static void orinoco_rx(struct net_device *dev, stats->rx_dropped++; } -static void orinoco_rx_isr_tasklet (unsigned long data) +static void orinoco_rx_isr_tasklet (struct tasklet_struct *t) { -struct orinoco_private *priv = (struct orinoco_private *) data; +struct orinoco_private *priv =from_tasklet (priv, t, rx_tasklet);struct net_device *dev = priv->ndev;struct orinoco_rx_data *rx_data, *temp;struct hermes_rx_descriptor *desc;
@@ -2198,8 +2198,7 @@ struct orinoco_privateINIT_WORK (&priv->wevent_work, orinoco_send_wevents);INIT_LIST_HEAD (&priv->rx_list); -tasklet_init (&priv->rx_tasklet, orinoco_rx_isr_tasklet, - (unsigned long ) priv); +tasklet_setup (&priv->rx_tasklet, orinoco_rx_isr_tasklet);spin_lock_init (&priv->scan_lock);INIT_LIST_HEAD (&priv->scan_list);
drivers/net/wireless/intersil/p54/p54pci.c +4 -4
@@ -278,10 +278,10 @@ static void p54p_check_tx_ring(struct ieee80211_hw *dev, u32 *index, } } -static void p54p_tasklet (unsigned long dev_id) +static void p54p_tasklet (struct tasklet_struct *t) { -struct ieee80211_hw *dev = (struct ieee80211_hw *)dev_id; -struct p54p_priv *priv = dev->priv; +struct p54p_priv *priv =from_tasklet (priv, t, tasklet); +struct ieee80211_hw *dev =pci_get_drvdata (priv->pdev);struct p54p_ring_control *ring_control = priv->ring_control; p54p_check_tx_ring(dev, &priv->tx_idx_mgmt, 3, ring_control->tx_mgmt,
@@ -620,7 +620,7 @@ static int p54p_probe(struct pci_dev *pdev, priv->common.tx = p54p_tx;spin_lock_init (&priv->lock); -tasklet_init (&priv->tasklet, p54p_tasklet, (unsigned long )dev); +tasklet_setup (&priv->tasklet, p54p_tasklet); err = request_firmware_nowait(THIS_MODULE, 1, "isl3886pci", &priv->pdev->dev, GFP_KERNEL,
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
kernel test robot
build botRe: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API
Thank you for the patch! Perhaps something to improve:
Hi Allen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc1 next-20200817] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
In file included from drivers/net/wireless/intersil/hostap/hostap_cs.c:196:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'prism2_tx_80211':
drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable 'fc' set but not used [-Wunused-but-set-variable]
1806 | u16 tx_control, fc;
| ^~
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hostap_rx_tasklet':
drivers/net/wireless/intersil/hostap/hostap_hw.c:2088:24: error: implicit declaration of function 'from_tasklet' [-Werror=implicit-function-declaration]
2088 | local_info_t *local = from_tasklet(local, t, rx_tasklet);
| ^~~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c:2088:47: error: 'rx_tasklet' undeclared (first use in this function); did you mean 'rt_task'?
2088 | local_info_t *local = from_tasklet(local, t, rx_tasklet);
| ^~~~~~~~~~
| rt_task
drivers/net/wireless/intersil/hostap/hostap_hw.c:2088:47: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hostap_sta_tx_exc_tasklet':
drivers/net/wireless/intersil/hostap/hostap_hw.c:2293:47: error: 'sta_tx_exc_tasklet' undeclared (first use in this function); did you mean 'hostap_sta_tx_exc_tasklet'?
2293 | local_info_t *local = from_tasklet(local, t, sta_tx_exc_tasklet);
| ^~~~~~~~~~~~~~~~~~
| hostap_sta_tx_exc_tasklet
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hostap_info_tasklet':
drivers/net/wireless/intersil/hostap/hostap_hw.c:2395:47: error: 'info_tasklet' undeclared (first use in this function)
2395 | local_info_t *local = from_tasklet(local, t, info_tasklet);
| ^~~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hostap_bap_tasklet':
drivers/net/wireless/intersil/hostap/hostap_hw.c:2474:47: error: 'bap_tasklet' undeclared (first use in this function)
2474 | local_info_t *local = from_tasklet(local, t, bap_tasklet);
| ^~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'prism2_init_local_data':
>> drivers/net/wireless/intersil/hostap/hostap_hw.c:3186:48: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
3186 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
| ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3188:2: note: in expansion of macro 'HOSTAP_TASKLET_INIT'
3188 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intersil/hostap/hostap_hw.c:3186:48: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
3186 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
| ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3191:2: note: in expansion of macro 'HOSTAP_TASKLET_INIT'
3191 | HOSTAP_TASKLET_INIT(&local->info_tasklet, hostap_info_tasklet,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intersil/hostap/hostap_hw.c:3186:48: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
3186 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
| ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3195:2: note: in expansion of macro 'HOSTAP_TASKLET_INIT'
3195 | HOSTAP_TASKLET_INIT(&local->rx_tasklet,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intersil/hostap/hostap_hw.c:3186:48: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
3186 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
| ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3199:2: note: in expansion of macro 'HOSTAP_TASKLET_INIT'
3199 | HOSTAP_TASKLET_INIT(&local->sta_tx_exc_tasklet,
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
from drivers/net/wireless/intersil/hostap/hostap_cs.c:196:
At top level:
drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: 'freq_list' defined but not used [-Wunused-const-variable=]
11 | static const long freq_list[] = { 2412, 2417, 2422, 2427, 2432, 2437, 2442,
| ^~~~~~~~~cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/7422b542061c089de37cc0fd975ba08d269277ac
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 git checkout 7422b542061c089de37cc0fd975ba08d269277ac
vim +3186 drivers/net/wireless/intersil/hostap/hostap_hw.c
3108
3109 local->func = funcs;
3110 local->func->cmd = hfa384x_cmd;
3111 local->func->read_regs = hfa384x_read_regs;
3112 local->func->get_rid = hfa384x_get_rid;
3113 local->func->set_rid = hfa384x_set_rid;
3114 local->func->hw_enable = prism2_hw_enable;
3115 local->func->hw_config = prism2_hw_config;
3116 local->func->hw_reset = prism2_hw_reset;
3117 local->func->hw_shutdown = prism2_hw_shutdown;
3118 local->func->reset_port = prism2_reset_port;
3119 local->func->schedule_reset = prism2_schedule_reset;
3120 #ifdef PRISM2_DOWNLOAD_SUPPORT
3121 local->func->read_aux_proc_ops = &prism2_download_aux_dump_proc_ops;
3122 local->func->download = prism2_download;
3123 #endif /* PRISM2_DOWNLOAD_SUPPORT */
3124 local->func->tx = prism2_tx_80211;
3125 local->func->set_tim = prism2_set_tim;
3126 local->func->need_tx_headroom = 0; /* no need to add txdesc in
3127 * skb->data (FIX: maybe for DMA bus
3128 * mastering? */
3129
3130 local->mtu = mtu;
3131
3132 rwlock_init(&local->iface_lock);
3133 spin_lock_init(&local->txfidlock);
3134 spin_lock_init(&local->cmdlock);
3135 spin_lock_init(&local->baplock);
3136 spin_lock_init(&local->lock);
3137 spin_lock_init(&local->irq_init_lock);
3138 mutex_init(&local->rid_bap_mtx);
3139
3140 if (card_idx < 0 || card_idx >= MAX_PARM_DEVICES)
3141 card_idx = 0;
3142 local->card_idx = card_idx;
3143
3144 len = strlen(essid);
3145 memcpy(local->essid, essid,
3146 len > MAX_SSID_LEN ? MAX_SSID_LEN : len);
3147 local->essid[MAX_SSID_LEN] = '\0';
3148 i = GET_INT_PARM(iw_mode, card_idx);
3149 if ((i >= IW_MODE_ADHOC && i <= IW_MODE_REPEAT) ||
3150 i == IW_MODE_MONITOR) {
3151 local->iw_mode = i;
3152 } else {
3153 printk(KERN_WARNING "prism2: Unknown iw_mode %d; using "
3154 "IW_MODE_MASTER\n", i);
3155 local->iw_mode = IW_MODE_MASTER;
3156 }
3157 local->channel = GET_INT_PARM(channel, card_idx);
3158 local->beacon_int = GET_INT_PARM(beacon_int, card_idx);
3159 local->dtim_period = GET_INT_PARM(dtim_period, card_idx);
3160 local->wds_max_connections = 16;
3161 local->tx_control = HFA384X_TX_CTRL_FLAGS;
3162 local->manual_retry_count = -1;
3163 local->rts_threshold = 2347;
3164 local->fragm_threshold = 2346;
3165 local->rssi_to_dBm = 100; /* default; to be overriden by
3166 * cnfDbmAdjust, if available */
3167 local->auth_algs = PRISM2_AUTH_OPEN | PRISM2_AUTH_SHARED_KEY;
3168 local->sram_type = -1;
3169 local->scan_channel_mask = 0xffff;
3170 local->monitor_type = PRISM2_MONITOR_RADIOTAP;
3171
3172 /* Initialize task queue structures */
3173 INIT_WORK(&local->reset_queue, handle_reset_queue);
3174 INIT_WORK(&local->set_multicast_list_queue,
3175 hostap_set_multicast_list_queue);
3176
3177 INIT_WORK(&local->set_tim_queue, handle_set_tim_queue);
3178 INIT_LIST_HEAD(&local->set_tim_list);
3179 spin_lock_init(&local->set_tim_lock);
3180
3181 INIT_WORK(&local->comms_qual_update, handle_comms_qual_update);
3182
3183 /* Initialize tasklets for handling hardware IRQ related operations
3184 * outside hw IRQ handler */
3185 #define HOSTAP_TASKLET_INIT(q, f, d) \
> 3186 do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \ 3187 while (0)
3188 HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
3189 (unsigned long) local);
3190
3191 HOSTAP_TASKLET_INIT(&local->info_tasklet, hostap_info_tasklet,
3192 (unsigned long) local);
3193 hostap_info_init(local);
3194
3195 HOSTAP_TASKLET_INIT(&local->rx_tasklet,
3196 hostap_rx_tasklet, (unsigned long) local);
3197 skb_queue_head_init(&local->rx_list);
3198
3199 HOSTAP_TASKLET_INIT(&local->sta_tx_exc_tasklet,
3200 hostap_sta_tx_exc_tasklet, (unsigned long) local);
3201 skb_queue_head_init(&local->sta_tx_exc_list);
3202
3203 INIT_LIST_HEAD(&local->cmd_queue);
3204 init_waitqueue_head(&local->hostscan_wq);
3205
3206 lib80211_crypt_info_init(&local->crypt_info, dev->name, &local->lock);
3207
3208 timer_setup(&local->passive_scan_timer, hostap_passive_scan, 0);
3209 timer_setup(&local->tick_timer, hostap_tick_timer, 0);
3210 local->tick_timer.expires = jiffies + 2 * HZ;
3211 add_timer(&local->tick_timer);
3212
3213 INIT_LIST_HEAD(&local->bss_list);
3214
3215 hostap_setup_dev(dev, local, HOSTAP_INTERFACE_MASTER);
3216
3217 dev->type = ARPHRD_IEEE80211;
3218 dev->header_ops = &hostap_80211_ops;
3219
3220 rtnl_lock();
3221 ret = dev_alloc_name(dev, "wifi%d");
3222 SET_NETDEV_DEV(dev, sdev);
3223 if (ret >= 0)
3224 ret = register_netdevice(dev);
3225
3226 prism2_set_lockdep_class(dev);
3227 rtnl_unlock();
3228 if (ret < 0) {
3229 printk(KERN_WARNING "%s: register netdevice failed!\n",
3230 dev_info);
3231 goto fail;
3232 }
3233 printk(KERN_INFO "%s: Registered netdevice %s\n", dev_info, dev->name);
3234
3235 hostap_init_data(local);
3236 return dev;
3237
3238 fail:
3239 free_netdev(dev);
3240 return NULL;
3241 }
3242
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 8 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly and remove .data field.
Quoted 7 lines
Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>--- .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++--------- drivers/net/wireless/intersil/orinoco/main.c | 7 +++---- drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++---- 3 files changed, 16 insertions(+), 17 deletions(-)
This patch seems to cause several warnings along the lines of:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ?prism2_init_local_data?:drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ?void (*)(struct tasklet_struct *)? to ?void (*)(long unsigned int)? [-Wcast-function-type] 3185 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } | ^drivers/net/wireless/intersil/hostap/hostap_hw.c:3187:2: note: in expansion of macro ?HOSTAP_TASKLET_INIT?
3187 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
| ^~~~~~~~~~~~~~~~~~~drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ?void (*)(struct tasklet_struct *)? to ?void (*)(long unsigned int)? [-Wcast-function-type]
Signature · 4 lines
Lee Jones [???] Senior Technical Lead - Developer Services Linaro.org ? Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 11/16 wireless: marvell: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/marvell/mwl8k.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/wireless/marvell/mwl8k.c +8 -8
@@ -4630,10 +4630,10 @@ static irqreturn_t mwl8k_interrupt(int irq, void *dev_id)return IRQ_HANDLED ; } -static void mwl8k_tx_poll (unsigned long data) +static void mwl8k_tx_poll (struct tasklet_struct *t) { -struct ieee80211_hw *hw = (struct ieee80211_hw *)data; -struct mwl8k_priv *priv = hw->priv; +struct mwl8k_priv *priv =from_tasklet (priv, t, poll_tx_task); +struct ieee80211_hw *hw =pci_get_drvdata (priv->pdev);int limit;int i;
@@ -4659,10 +4659,10 @@ static void mwl8k_tx_poll(unsigned long data) } } -static void mwl8k_rx_poll (unsigned long data) +static void mwl8k_rx_poll (struct tasklet_struct *t) { -struct ieee80211_hw *hw = (struct ieee80211_hw *)data; -struct mwl8k_priv *priv = hw->priv; +struct mwl8k_priv *priv =from_tasklet (priv, t, poll_rx_task); +struct ieee80211_hw *hw =pci_get_drvdata (priv->pdev);int limit; limit =32 ;
@@ -6120,9 +6120,9 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)INIT_WORK (&priv->fw_reload, mwl8k_hw_restart_work);/* TX reclaim and RX tasklets. */ -tasklet_init (&priv->poll_tx_task, mwl8k_tx_poll, (unsigned long )hw); +tasklet_setup (&priv->poll_tx_task, mwl8k_tx_poll);tasklet_disable (&priv->poll_tx_task); -tasklet_init (&priv->poll_rx_task, mwl8k_rx_poll, (unsigned long )hw); +tasklet_setup (&priv->poll_rx_task, mwl8k_rx_poll);tasklet_disable (&priv->poll_rx_task);/* Power management cookie */
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 12/16 wireless: mediatek: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/mediatek/mt76/mac80211.c | 2 +- drivers/net/wireless/mediatek/mt76/mt76.h | 2 +- drivers/net/wireless/mediatek/mt76/mt7603/beacon.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7603/init.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h | 2 +- drivers/net/wireless/mediatek/mt76/mt7615/mmio.c | 6 +++--- drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c | 10 +++++----- drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c | 14 ++++++-------- drivers/net/wireless/mediatek/mt76/tx.c | 4 ++-- drivers/net/wireless/mediatek/mt76/usb.c | 12 ++++++------ drivers/net/wireless/mediatek/mt7601u/dma.c | 12 ++++++------ 11 files changed, 34 insertions(+), 37 deletions(-)
drivers/net/wireless/mediatek/mt76/mac80211.c +1 -1
@@ -439,7 +439,7 @@ mt76_alloc_device(struct device *pdev, unsigned int size,for (i =0 ; i <ARRAY_SIZE (dev->q_rx); i++)skb_queue_head_init (&dev->rx_skb[i]); -tasklet_init (&dev->tx_tasklet, mt76_tx_tasklet, (unsigned long )dev); +tasklet_setup (&dev->tx_tasklet, mt76_tx_tasklet); dev->wq =alloc_ordered_workqueue ("mt76" ,0 );if (!dev->wq) {
drivers/net/wireless/mediatek/mt76/mt76.h +1 -1
@@ -899,7 +899,7 @@ void mt76_stop_tx_queues(struct mt76_dev *dev, struct ieee80211_sta *sta, bool send_bar);void mt76_txq_schedule (struct mt76_phy *phy,enum mt76_txq_id qid);void mt76_txq_schedule_all (struct mt76_phy *phy); -void mt76_tx_tasklet (unsigned long data); +void mt76_tx_tasklet (struct tasklet_struct *t); void mt76_release_buffered_frames(struct ieee80211_hw *hw, struct ieee80211_sta *sta, u16 tids, int nframes,
drivers/net/wireless/mediatek/mt76/mt7603/beacon.c +2 -2
@@ -64,9 +64,9 @@ mt7603_add_buffered_bc(void *priv, u8 *mac, struct ieee80211_vif *vif) data->count[mvif->idx]++; } -void mt7603_pre_tbtt_tasklet (unsigned long arg) +void mt7603_pre_tbtt_tasklet (struct tasklet_struct *t) { -struct mt7603_dev *dev = (struct mt7603_dev *)arg; +struct mt7603_dev *dev =from_tasklet (dev, t, mt76.pre_tbtt_tasklet);struct mt76_queue *q;struct beacon_bc_data data = {};struct sk_buff *skb;
drivers/net/wireless/mediatek/mt76/mt7603/init.c +1 -2
@@ -533,8 +533,7 @@ int mt7603_register_device(struct mt7603_dev *dev)spin_lock_init (&dev->ps_lock);INIT_DELAYED_WORK (&dev->mt76.mac_work, mt7603_mac_work); -tasklet_init (&dev->mt76.pre_tbtt_tasklet, mt7603_pre_tbtt_tasklet, - (unsigned long )dev); +tasklet_setup (&dev->mt76.pre_tbtt_tasklet, mt7603_pre_tbtt_tasklet);/* Check for 7688, which only has 1SS */ dev->mphy.antenna_mask =3 ;
drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h +1 -1
@@ -255,7 +255,7 @@ void mt7603_sta_assoc(struct mt76_dev *mdev, struct ieee80211_vif *vif,void mt7603_sta_remove (struct mt76_dev *mdev,struct ieee80211_vif *vif,struct ieee80211_sta *sta); -void mt7603_pre_tbtt_tasklet (unsigned long arg); +void mt7603_pre_tbtt_tasklet (struct tasklet_struct *t);void mt7603_update_channel (struct mt76_dev *mdev);
drivers/net/wireless/mediatek/mt76/mt7615/mmio.c +3 -3
@@ -98,9 +98,9 @@ static irqreturn_t mt7615_irq_handler(int irq, void *dev_instance)return IRQ_HANDLED ; } -static void mt7615_irq_tasklet (unsigned long data) +static void mt7615_irq_tasklet (struct tasklet_struct *t) { -struct mt7615_dev *dev = (struct mt7615_dev *)data; +struct mt7615_dev *dev =from_tasklet (dev, t, irq_tasklet);u32 intr, mask =0 ;mt76_wr (dev,MT_INT_MASK_CSR ,0 );
@@ -206,7 +206,7 @@ int mt7615_mmio_probe(struct device *pdev, void __iomem *mem_base, dev = container_of(mdev, struct mt7615_dev, mt76);mt76_mmio_init (&dev->mt76, mem_base); -tasklet_init (&dev->irq_tasklet, mt7615_irq_tasklet, (unsigned long )dev); +tasklet_setup (&dev->irq_tasklet, mt7615_irq_tasklet); dev->reg_map = map; dev->ops = ops;
drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c +5 -5
@@ -609,10 +609,11 @@ static void mt76x02_dfs_check_event_window(struct mt76x02_dev *dev) } } -static void mt76x02_dfs_tasklet (unsigned long arg) +static void mt76x02_dfs_tasklet (struct tasklet_struct *t) { -struct mt76x02_dev *dev = (struct mt76x02_dev *)arg; -struct mt76x02_dfs_pattern_detector *dfs_pd = &dev->dfs_pd; +struct mt76x02_dfs_pattern_detector *dfs_pd =from_tasklet (dfs_pd, t, + dfs_tasklet); +struct mt76x02_dev *dev =container_of (dfs_pd,typeof (*dev), dfs_pd);u32 engine_mask;int i;
@@ -860,8 +861,7 @@ void mt76x02_dfs_init_detector(struct mt76x02_dev *dev)INIT_LIST_HEAD (&dfs_pd->seq_pool); dev->mt76.region =NL80211_DFS_UNSET ; dfs_pd->last_sw_check = jiffies; -tasklet_init (&dfs_pd->dfs_tasklet, mt76x02_dfs_tasklet, - (unsigned long )dev); +tasklet_setup (&dfs_pd->dfs_tasklet, mt76x02_dfs_tasklet); } static void
drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c +6 -8
@@ -11,9 +11,9 @@#include "mt76x02_mcu.h" #include "trace.h" -static void mt76x02_pre_tbtt_tasklet (unsigned long arg) +static void mt76x02_pre_tbtt_tasklet (struct tasklet_struct *t) { -struct mt76x02_dev *dev = (struct mt76x02_dev *)arg; +struct mt76x02_dev *dev =from_tasklet (dev, t, mt76.pre_tbtt_tasklet);struct mt76_queue *q = dev->mt76.q_tx[MT_TXQ_PSD ].q;struct beacon_bc_data data = {};struct sk_buff *skb;
@@ -151,9 +151,9 @@ static void mt76x02_process_tx_status_fifo(struct mt76x02_dev *dev)mt76x02_send_tx_status (dev, &stat, &update); } -static void mt76x02_tx_tasklet (unsigned long data) +static void mt76x02_tx_tasklet (struct tasklet_struct *t) { -struct mt76x02_dev *dev = (struct mt76x02_dev *)data; +struct mt76x02_dev *dev =from_tasklet (dev, t, mt76.tx_tasklet);mt76x02_mac_poll_tx_status (dev, false);mt76x02_process_tx_status_fifo (dev);
@@ -197,10 +197,8 @@ int mt76x02_dma_init(struct mt76x02_dev *dev)if (!status_fifo)return -ENOMEM ; -tasklet_init (&dev->mt76.tx_tasklet, mt76x02_tx_tasklet, - (unsigned long )dev); -tasklet_init (&dev->mt76.pre_tbtt_tasklet, mt76x02_pre_tbtt_tasklet, - (unsigned long )dev); +tasklet_setup (&dev->mt76.tx_tasklet, mt76x02_tx_tasklet); +tasklet_setup (&dev->mt76.pre_tbtt_tasklet, mt76x02_pre_tbtt_tasklet);spin_lock_init (&dev->txstatus_fifo_lock);kfifo_init (&dev->txstatus_fifo, status_fifo, fifo_size);
drivers/net/wireless/mediatek/mt76/tx.c +2 -2
@@ -585,9 +585,9 @@ void mt76_txq_schedule_all(struct mt76_phy *phy) }EXPORT_SYMBOL_GPL (mt76_txq_schedule_all); -void mt76_tx_tasklet (unsigned long data) +void mt76_tx_tasklet (struct tasklet_struct *t) { -struct mt76_dev *dev = (struct mt76_dev *)data; +struct mt76_dev *dev =from_tasklet (dev, t, tx_tasklet);mt76_txq_schedule_all (&dev->phy);if (dev->phy2)
drivers/net/wireless/mediatek/mt76/usb.c +6 -6
@@ -669,9 +669,9 @@ mt76u_process_rx_queue(struct mt76_dev *dev, struct mt76_queue *q)mt76_rx_poll_complete (dev,MT_RXQ_MAIN ,NULL ); } -static void mt76u_rx_tasklet (unsigned long data) +static void mt76u_rx_tasklet (struct tasklet_struct *t) { -struct mt76_dev *dev = (struct mt76_dev *)data; +struct mt76_dev *dev =from_tasklet (dev, t, usb.rx_tasklet);int i;rcu_read_lock ();
@@ -792,9 +792,9 @@ int mt76u_resume_rx(struct mt76_dev *dev) }EXPORT_SYMBOL_GPL (mt76u_resume_rx); -static void mt76u_tx_tasklet (unsigned long data) +static void mt76u_tx_tasklet (struct tasklet_struct *t) { -struct mt76_dev *dev = (struct mt76_dev *)data; +struct mt76_dev *dev =from_tasklet (dev, t, tx_tasklet);struct mt76_queue_entry entry;struct mt76_sw_queue *sq;struct mt76_queue *q;
@@ -1133,8 +1133,8 @@ int mt76u_init(struct mt76_dev *dev, mt76u_ops.rmw = ext ? mt76u_rmw_ext : mt76u_rmw; mt76u_ops.write_copy = ext ? mt76u_copy_ext : mt76u_copy; -tasklet_init (&usb->rx_tasklet, mt76u_rx_tasklet, (unsigned long )dev); -tasklet_init (&dev->tx_tasklet, mt76u_tx_tasklet, (unsigned long )dev); +tasklet_setup (&usb->rx_tasklet, mt76u_rx_tasklet); +tasklet_setup (&dev->tx_tasklet, mt76u_tx_tasklet);INIT_WORK (&usb->stat_work, mt76u_tx_status_data); usb->data_len =usb_maxpacket (udev,usb_sndctrlpipe (udev,0 ),1 );
drivers/net/wireless/mediatek/mt7601u/dma.c +6 -6
@@ -212,9 +212,9 @@ static void mt7601u_complete_rx(struct urb *urb)spin_unlock_irqrestore (&dev->rx_lock, flags); } -static void mt7601u_rx_tasklet (unsigned long data) +static void mt7601u_rx_tasklet (struct tasklet_struct *t) { -struct mt7601u_dev *dev = (struct mt7601u_dev *) data; +struct mt7601u_dev *dev =from_tasklet (dev, t, rx_tasklet);struct mt7601u_dma_buf_rx *e;while ((e =mt7601u_rx_get_pending_entry (dev))) {
@@ -266,9 +266,9 @@ static void mt7601u_complete_tx(struct urb *urb)spin_unlock_irqrestore (&dev->tx_lock, flags); } -static void mt7601u_tx_tasklet (unsigned long data) +static void mt7601u_tx_tasklet (struct tasklet_struct *t) { -struct mt7601u_dev *dev = (struct mt7601u_dev *) data; +struct mt7601u_dev *dev =from_tasklet (dev, t, tx_tasklet);struct sk_buff_head skbs;unsigned long flags;
@@ -507,8 +507,8 @@ int mt7601u_dma_init(struct mt7601u_dev *dev) {int ret = -ENOMEM ; -tasklet_init (&dev->tx_tasklet, mt7601u_tx_tasklet, (unsigned long ) dev); -tasklet_init (&dev->rx_tasklet, mt7601u_rx_tasklet, (unsigned long ) dev); +tasklet_setup (&dev->tx_tasklet, mt7601u_tx_tasklet); +tasklet_setup (&dev->rx_tasklet, mt7601u_rx_tasklet); ret =mt7601u_alloc_tx (dev);if (ret)
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Re: [PATCH 12/16] wireless: mediatek: convert tasklets to use new tasklet_setup() API
Quoted 9 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>
Please split this patch into two, mt76 and mt7601u patches go into separate trees.
Patch set to Changes Requested.
Signature · 3 lines
https://patchwork.kernel.org/patch/11717429/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH 12/16] wireless: mediatek: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisQuoted 9 lines · Allen Pais
From: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct
tasklet_structpointer to all tasklet callbacks, switch to using the newtasklet_setup()andfrom_tasklet()to pass the tasklet pointer explicitly.Signed-off-by Romain Perier <[email protected]>Signed-off-by Allen Pais <[email protected]>
Please split this patch into two, mt76 and mt7601u patches go into separate trees.
Patch set to Changes Requested.
Signature · 3 lines
https://patchwork.kernel.org/patch/11717429/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 13/16 wireless: quantenna: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 7 +++---- drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-)
drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c +3 -4
@@ -1091,9 +1091,9 @@ static void qtnf_pearl_fw_work_handler(struct work_struct *work)put_device (&pdev->dev); } -static void qtnf_pearl_reclaim_tasklet_fn (unsigned long data) +static void qtnf_pearl_reclaim_tasklet_fn (struct tasklet_struct *t) { -struct qtnf_pcie_pearl_state *ps = (void *)data; +struct qtnf_pcie_pearl_state *ps =from_tasklet (ps, t, base.reclaim_tq);qtnf_pearl_data_tx_reclaim (ps);qtnf_en_txdone_irq (ps);
@@ -1145,8 +1145,7 @@ static int qtnf_pcie_pearl_probe(struct qtnf_bus *bus, unsigned int tx_bd_size,return ret; } -tasklet_init (&ps->base.reclaim_tq, qtnf_pearl_reclaim_tasklet_fn, - (unsigned long )ps); +tasklet_setup (&ps->base.reclaim_tq, qtnf_pearl_reclaim_tasklet_fn);netif_napi_add (&bus->mux_dev, &bus->mux_napi, qtnf_pcie_pearl_rx_poll,10 );
drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c +3 -4
@@ -1105,9 +1105,9 @@ static void qtnf_topaz_fw_work_handler(struct work_struct *work)put_device (&pdev->dev); } -static void qtnf_reclaim_tasklet_fn (unsigned long data) +static void qtnf_reclaim_tasklet_fn (struct tasklet_struct *t) { -struct qtnf_pcie_topaz_state *ts = (void *)data; +struct qtnf_pcie_topaz_state *ts =from_tasklet (ts, t, base.reclaim_tq);qtnf_topaz_data_tx_reclaim (ts); }
@@ -1158,8 +1158,7 @@ static int qtnf_pcie_topaz_probe(struct qtnf_bus *bus,return ret; } -tasklet_init (&ts->base.reclaim_tq, qtnf_reclaim_tasklet_fn, - (unsigned long )ts); +tasklet_setup (&ts->base.reclaim_tq, qtnf_reclaim_tasklet_fn);netif_napi_add (&bus->mux_dev, &bus->mux_napi, qtnf_topaz_rx_poll,10 );
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 14/16 wireless: ralink: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.
--- .../net/wireless/ralink/rt2x00/rt2400pci.c | 14 ++++++----- .../net/wireless/ralink/rt2x00/rt2500pci.c | 14 ++++++----- .../net/wireless/ralink/rt2x00/rt2800mmio.c | 24 +++++++++++-------- .../net/wireless/ralink/rt2x00/rt2800mmio.h | 10 ++++---- drivers/net/wireless/ralink/rt2x00/rt2x00.h | 10 ++++---- .../net/wireless/ralink/rt2x00/rt2x00dev.c | 5 ++-- drivers/net/wireless/ralink/rt2x00/rt61pci.c | 20 +++++++++------- 7 files changed, 54 insertions(+), 43 deletions(-)
drivers/net/wireless/ralink/rt2x00/rt2400pci.c +8 -6
@@ -1319,9 +1319,10 @@ static inline void rt2400pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,spin_unlock_irq (&rt2x00dev->irqmask_lock); } -static void rt2400pci_txstatus_tasklet (unsigned long data) +static void rt2400pci_txstatus_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + txstatus_tasklet);u32 reg;/*
@@ -1347,17 +1348,18 @@ static void rt2400pci_txstatus_tasklet(unsigned long data) } } -static void rt2400pci_tbtt_tasklet (unsigned long data) +static void rt2400pci_tbtt_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, tbtt_tasklet);rt2x00lib_beacondone (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt2400pci_enable_interrupt (rt2x00dev,CSR8_TBCN_EXPIRE ); } -static void rt2400pci_rxdone_tasklet (unsigned long data) +static void rt2400pci_rxdone_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + rxdone_tasklet);if (rt2x00mmio_rxdone (rt2x00dev))tasklet_schedule (&rt2x00dev->rxdone_tasklet);else if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))
drivers/net/wireless/ralink/rt2x00/rt2500pci.c +8 -6
@@ -1447,9 +1447,10 @@ static inline void rt2500pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,spin_unlock_irq (&rt2x00dev->irqmask_lock); } -static void rt2500pci_txstatus_tasklet (unsigned long data) +static void rt2500pci_txstatus_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + txstatus_tasklet);u32 reg;/*
@@ -1475,17 +1476,18 @@ static void rt2500pci_txstatus_tasklet(unsigned long data) } } -static void rt2500pci_tbtt_tasklet (unsigned long data) +static void rt2500pci_tbtt_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, tbtt_tasklet);rt2x00lib_beacondone (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt2500pci_enable_interrupt (rt2x00dev,CSR8_TBCN_EXPIRE ); } -static void rt2500pci_rxdone_tasklet (unsigned long data) +static void rt2500pci_rxdone_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + rxdone_tasklet);if (rt2x00mmio_rxdone (rt2x00dev))tasklet_schedule (&rt2x00dev->rxdone_tasklet);else if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))
drivers/net/wireless/ralink/rt2x00/rt2800mmio.c +14 -10
@@ -210,18 +210,19 @@ static inline void rt2800mmio_enable_interrupt(struct rt2x00_dev *rt2x00dev,spin_unlock_irq (&rt2x00dev->irqmask_lock); } -void rt2800mmio_pretbtt_tasklet (unsigned long data) +void rt2800mmio_pretbtt_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + pretbtt_tasklet);rt2x00lib_pretbtt (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt2800mmio_enable_interrupt (rt2x00dev,INT_MASK_CSR_PRE_TBTT ); }EXPORT_SYMBOL_GPL (rt2800mmio_pretbtt_tasklet); -void rt2800mmio_tbtt_tasklet (unsigned long data) +void rt2800mmio_tbtt_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, tbtt_tasklet);struct rt2800_drv_data *drv_data = rt2x00dev->drv_data;u32 reg;
@@ -254,9 +255,10 @@ void rt2800mmio_tbtt_tasklet(unsigned long data) }EXPORT_SYMBOL_GPL (rt2800mmio_tbtt_tasklet); -void rt2800mmio_rxdone_tasklet (unsigned long data) +void rt2800mmio_rxdone_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + rxdone_tasklet);if (rt2x00mmio_rxdone (rt2x00dev))tasklet_schedule (&rt2x00dev->rxdone_tasklet);else if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))
@@ -264,9 +266,10 @@ void rt2800mmio_rxdone_tasklet(unsigned long data) }EXPORT_SYMBOL_GPL (rt2800mmio_rxdone_tasklet); -void rt2800mmio_autowake_tasklet (unsigned long data) +void rt2800mmio_autowake_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + autowake_tasklet);rt2800mmio_wakeup (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags)) rt2800mmio_enable_interrupt(rt2x00dev,
@@ -307,9 +310,10 @@ static void rt2800mmio_fetch_txstatus(struct rt2x00_dev *rt2x00dev)spin_unlock_irqrestore (&rt2x00dev->irqmask_lock, flags); } -void rt2800mmio_txstatus_tasklet (unsigned long data) +void rt2800mmio_txstatus_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + txstatus_tasklet);rt2800_txdone (rt2x00dev,16 );
drivers/net/wireless/ralink/rt2x00/rt2800mmio.h +5 -5
@@ -126,11 +126,11 @@ void rt2800mmio_fill_rxdone(struct queue_entry *entry, struct rxdone_entry_desc *rxdesc);/* Interrupt functions */ -void rt2800mmio_txstatus_tasklet (unsigned long data); -void rt2800mmio_pretbtt_tasklet (unsigned long data); -void rt2800mmio_tbtt_tasklet (unsigned long data); -void rt2800mmio_rxdone_tasklet (unsigned long data); -void rt2800mmio_autowake_tasklet (unsigned long data); +void rt2800mmio_txstatus_tasklet (struct tasklet_struct *t); +void rt2800mmio_pretbtt_tasklet (struct tasklet_struct *t); +void rt2800mmio_tbtt_tasklet (struct tasklet_struct *t); +void rt2800mmio_rxdone_tasklet (struct tasklet_struct *t); +void rt2800mmio_autowake_tasklet (struct tasklet_struct *t);irqreturn_t rt2800mmio_interrupt (int irq,void *dev_instance);void rt2800mmio_toggle_irq (struct rt2x00_dev *rt2x00dev,enum dev_state state);
drivers/net/wireless/ralink/rt2x00/rt2x00.h +5 -5
@@ -518,11 +518,11 @@ struct rt2x00lib_ops {/* * TX status tasklet handler. */ -void (*txstatus_tasklet) (unsigned long data); -void (*pretbtt_tasklet) (unsigned long data); -void (*tbtt_tasklet) (unsigned long data); -void (*rxdone_tasklet) (unsigned long data); -void (*autowake_tasklet) (unsigned long data); +void (*txstatus_tasklet) (struct tasklet_struct *t); +void (*pretbtt_tasklet) (struct tasklet_struct *t); +void (*tbtt_tasklet) (struct tasklet_struct *t); +void (*rxdone_tasklet) (struct tasklet_struct *t); +void (*autowake_tasklet) (struct tasklet_struct *t);/* * Device init handlers.
drivers/net/wireless/ralink/rt2x00/rt2x00dev.c +2 -3
@@ -1167,9 +1167,8 @@ static int rt2x00lib_probe_hw(struct rt2x00_dev *rt2x00dev)*/ #define RT2X00_TASKLET_INIT (taskletname) \ if (rt2x00dev->ops->lib->taskletname) { \ - tasklet_init(&rt2x00dev->taskletname, \ - rt2x00dev->ops->lib->taskletname, \ - (unsigned long)rt2x00dev); \ + tasklet_setup(&rt2x00dev->taskletname, \ + rt2x00dev->ops->lib->taskletname); \ }RT2X00_TASKLET_INIT (txstatus_tasklet);
drivers/net/wireless/ralink/rt2x00/rt61pci.c +12 -8
@@ -2190,34 +2190,38 @@ static void rt61pci_enable_mcu_interrupt(struct rt2x00_dev *rt2x00dev,spin_unlock_irq (&rt2x00dev->irqmask_lock); } -static void rt61pci_txstatus_tasklet (unsigned long data) +static void rt61pci_txstatus_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + txstatus_tasklet); +rt61pci_txdone (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt61pci_enable_interrupt (rt2x00dev,INT_MASK_CSR_TXDONE ); } -static void rt61pci_tbtt_tasklet (unsigned long data) +static void rt61pci_tbtt_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, tbtt_tasklet);rt2x00lib_beacondone (rt2x00dev);if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt61pci_enable_interrupt (rt2x00dev,INT_MASK_CSR_BEACON_DONE ); } -static void rt61pci_rxdone_tasklet (unsigned long data) +static void rt61pci_rxdone_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + rxdone_tasklet);if (rt2x00mmio_rxdone (rt2x00dev))tasklet_schedule (&rt2x00dev->rxdone_tasklet);else if (test_bit (DEVICE_STATE_ENABLED_RADIO , &rt2x00dev->flags))rt61pci_enable_interrupt (rt2x00dev,INT_MASK_CSR_RXDONE ); } -static void rt61pci_autowake_tasklet (unsigned long data) +static void rt61pci_autowake_tasklet (struct tasklet_struct *t) { -struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data; +struct rt2x00_dev *rt2x00dev =from_tasklet (rt2x00dev, t, + autowake_tasklet);rt61pci_wakeup (rt2x00dev);rt2x00mmio_register_write (rt2x00dev,M2H_CMD_DONE_CSR ,0xffffffff );
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 15/16 wireless: realtek: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly and remove .data field.
--- drivers/net/wireless/realtek/rtlwifi/pci.c | 21 ++++++++++----------- drivers/net/wireless/realtek/rtlwifi/usb.c | 9 ++++----- drivers/net/wireless/realtek/rtw88/main.c | 3 +-- drivers/net/wireless/realtek/rtw88/tx.c | 4 ++-- drivers/net/wireless/realtek/rtw88/tx.h | 2 +- 5 files changed, 18 insertions(+), 21 deletions(-)
drivers/net/wireless/realtek/rtlwifi/pci.c +10 -11
@@ -1061,16 +1061,18 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id)return ret; } -static void _rtl_pci_irq_tasklet (unsigned long data) +static void _rtl_pci_irq_tasklet (struct tasklet_struct *t) { -struct ieee80211_hw *hw = (struct ieee80211_hw *)data; +struct rtl_priv *rtlpriv =from_tasklet (rtlpriv, t, works.irq_tasklet); +struct ieee80211_hw *hw = rtlpriv->hw;_rtl_pci_tx_chk_waitq (hw); } -static void _rtl_pci_prepare_bcn_tasklet (unsigned long data) +static void _rtl_pci_prepare_bcn_tasklet (struct tasklet_struct *t) { -struct ieee80211_hw *hw = (struct ieee80211_hw *)data; -struct rtl_priv *rtlpriv =rtl_priv (hw); +struct rtl_priv *rtlpriv =from_tasklet (rtlpriv, t, + works.irq_prepare_bcn_tasklet); +struct ieee80211_hw *hw = rtlpriv->hw;struct rtl_pci *rtlpci =rtl_pcidev (rtl_pcipriv (hw));struct rtl_mac *mac =rtl_mac (rtl_priv (hw));struct rtl8192_tx_ring *ring =NULL ;
@@ -1194,12 +1196,9 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw, rtlpci->acm_method =EACMWAY2_SW ;/*task */ -tasklet_init (&rtlpriv->works.irq_tasklet, - _rtl_pci_irq_tasklet, - (unsigned long )hw); -tasklet_init (&rtlpriv->works.irq_prepare_bcn_tasklet, - _rtl_pci_prepare_bcn_tasklet, - (unsigned long )hw); +tasklet_setup (&rtlpriv->works.irq_tasklet, _rtl_pci_irq_tasklet); +tasklet_setup (&rtlpriv->works.irq_prepare_bcn_tasklet, + _rtl_pci_prepare_bcn_tasklet);INIT_WORK (&rtlpriv->works.lps_change_work, rtl_lps_change_work_callback); }
drivers/net/wireless/realtek/rtlwifi/usb.c +4 -5
@@ -289,7 +289,7 @@ static int _rtl_usb_init_tx(struct ieee80211_hw *hw)return 0 ; } -static void _rtl_rx_work (unsigned long param); +static void _rtl_rx_work (struct tasklet_struct *t);static int _rtl_usb_init_rx (struct ieee80211_hw *hw) {
@@ -310,8 +310,7 @@ static int _rtl_usb_init_rx(struct ieee80211_hw *hw)init_usb_anchor (&rtlusb->rx_cleanup_urbs);skb_queue_head_init (&rtlusb->rx_queue); - rtlusb->rx_work_tasklet.func = _rtl_rx_work; - rtlusb->rx_work_tasklet.data = (unsigned long )rtlusb; + rtlusb->rx_work_tasklet.func = (void (*)(unsigned long ))_rtl_rx_work;return 0 ; }
@@ -528,9 +527,9 @@ static void _rtl_rx_pre_process(struct ieee80211_hw *hw, struct sk_buff *skb)#define __RX_SKB_MAX_QUEUED 64 -static void _rtl_rx_work (unsigned long param) +static void _rtl_rx_work (struct tasklet_struct *t) { -struct rtl_usb *rtlusb = (struct rtl_usb *)param; +struct rtl_usb *rtlusb =from_tasklet (rtlusb, t, rx_work_tasklet);struct ieee80211_hw *hw =usb_get_intfdata (rtlusb->intf);struct sk_buff *skb;
drivers/net/wireless/realtek/rtw88/main.c +1 -2
@@ -1422,8 +1422,7 @@ int rtw_core_init(struct rtw_dev *rtwdev)timer_setup (&rtwdev->tx_report.purge_timer, rtw_tx_report_purge_timer,0 ); -tasklet_init (&rtwdev->tx_tasklet, rtw_tx_tasklet, - (unsigned long )rtwdev); +tasklet_setup (&rtwdev->tx_tasklet, rtw_tx_tasklet);INIT_DELAYED_WORK (&rtwdev->watch_dog_work, rtw_watch_dog_work);INIT_DELAYED_WORK (&coex->bt_relink_work, rtw_coex_bt_relink_work);
drivers/net/wireless/realtek/rtw88/tx.c +2 -2
@@ -587,9 +587,9 @@ static void rtw_txq_push(struct rtw_dev *rtwdev,rcu_read_unlock (); } -void rtw_tx_tasklet (unsigned long data) +void rtw_tx_tasklet (struct tasklet_struct *t) { -struct rtw_dev *rtwdev = (void *)data; +struct rtw_dev *rtwdev =from_tasklet (rtwdev, t, tx_tasklet);struct rtw_txq *rtwtxq, *tmp;spin_lock_bh (&rtwdev->txq_lock);
drivers/net/wireless/realtek/rtw88/tx.h +1 -1
@@ -94,7 +94,7 @@ void rtw_tx(struct rtw_dev *rtwdev, struct sk_buff *skb);void rtw_txq_init (struct rtw_dev *rtwdev,struct ieee80211_txq *txq);void rtw_txq_cleanup (struct rtw_dev *rtwdev,struct ieee80211_txq *txq); -void rtw_tx_tasklet (unsigned long data); +void rtw_tx_tasklet (struct tasklet_struct *t); void rtw_tx_pkt_info_update(struct rtw_dev *rtwdev, struct rtw_tx_pkt_info *pkt_info, struct ieee80211_sta *sta,
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
kernel test robot
build botRe: [PATCH 15/16] wireless: realtek: convert tasklets to use new tasklet_setup() API
Thank you for the patch! Perhaps something to improve:
Hi Allen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v5.9-rc1 next-20200817]
[cannot apply to wireless-drivers/master ath6kl/ath-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/net/wireless/realtek/rtlwifi/usb.c: In function '_rtl_usb_init_rx':
>> drivers/net/wireless/realtek/rtlwifi/usb.c:313:33: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
313 | rtlusb->rx_work_tasklet.func = (void(*)(unsigned long))_rtl_rx_work;
| ^
drivers/net/wireless/realtek/rtlwifi/usb.c: In function '_rtl_rx_work':
drivers/net/wireless/realtek/rtlwifi/usb.c:532:27: error: implicit declaration of function 'from_tasklet' [-Werror=implicit-function-declaration]
532 | struct rtl_usb *rtlusb = from_tasklet(rtlusb, t, rx_work_tasklet);
| ^~~~~~~~~~~~
drivers/net/wireless/realtek/rtlwifi/usb.c:532:51: error: 'rx_work_tasklet' undeclared (first use in this function)
532 | struct rtl_usb *rtlusb = from_tasklet(rtlusb, t, rx_work_tasklet);
| ^~~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtlwifi/usb.c:532:51: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/b985c52fd11092396a6b0bd4b208d4b99269efcf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 git checkout b985c52fd11092396a6b0bd4b208d4b99269efcf
vim +313 drivers/net/wireless/realtek/rtlwifi/usb.c
293
294 static int _rtl_usb_init_rx(struct ieee80211_hw *hw)
295 {
296 struct rtl_priv *rtlpriv = rtl_priv(hw);
297 struct rtl_usb_priv *usb_priv = rtl_usbpriv(hw);
298 struct rtl_usb *rtlusb = rtl_usbdev(usb_priv);
299
300 rtlusb->rx_max_size = rtlpriv->cfg->usb_interface_cfg->rx_max_size;
301 rtlusb->rx_urb_num = rtlpriv->cfg->usb_interface_cfg->rx_urb_num;
302 rtlusb->in_ep = rtlpriv->cfg->usb_interface_cfg->in_ep_num;
303 rtlusb->usb_rx_hdl = rtlpriv->cfg->usb_interface_cfg->usb_rx_hdl;
304 rtlusb->usb_rx_segregate_hdl =
305 rtlpriv->cfg->usb_interface_cfg->usb_rx_segregate_hdl;
306
307 pr_info("rx_max_size %d, rx_urb_num %d, in_ep %d\n",
308 rtlusb->rx_max_size, rtlusb->rx_urb_num, rtlusb->in_ep);
309 init_usb_anchor(&rtlusb->rx_submitted);
310 init_usb_anchor(&rtlusb->rx_cleanup_urbs);
311
312 skb_queue_head_init(&rtlusb->rx_queue);
> 313 rtlusb->rx_work_tasklet.func = (void(*)(unsigned long))_rtl_rx_work;
314
315 return 0;
316 }
317
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 16/16 wireless: zydas: convert tasklets to use new tasklet_setup() API
In reply to Allen PaisFrom: Allen Pais <[email protected]>
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly and remove .data fieldd
--- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/zydas/zd1211rw/zd_usb.c +4 -4
@@ -1140,9 +1140,9 @@ static void zd_rx_idle_timer_handler(struct work_struct *work)zd_usb_reset_rx (usb); } -static void zd_usb_reset_rx_idle_timer_tasklet (unsigned long param) +static void zd_usb_reset_rx_idle_timer_tasklet (struct tasklet_struct *t) { -struct zd_usb *usb = (struct zd_usb *)param; +struct zd_usb *usb =from_tasklet (usb, t, rx.reset_timer_tasklet);zd_usb_reset_rx_idle_timer (usb); }
@@ -1178,8 +1178,8 @@ static inline void init_usb_rx(struct zd_usb *usb) }ZD_ASSERT (rx->fragment_length ==0 );INIT_DELAYED_WORK (&rx->idle_work, zd_rx_idle_timer_handler); - rx->reset_timer_tasklet.func = zd_usb_reset_rx_idle_timer_tasklet; - rx->reset_timer_tasklet.data = (unsigned long )usb; + rx->reset_timer_tasklet.func = (void (*)(unsigned long )) + zd_usb_reset_rx_idle_timer_tasklet; }static inline void init_usb_tx (struct zd_usb *usb)
Signature · 7 lines
2.17.1 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
kernel test robot
build botRe: [PATCH 16/16] wireless: zydas: convert tasklets to use new tasklet_setup() API
Thank you for the patch! Perhaps something to improve:
Hi Allen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v5.9-rc1 next-20200817]
[cannot apply to wireless-drivers/master ath6kl/ath-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/net/wireless/zydas/zd1211rw/zd_usb.c: In function 'zd_usb_reset_rx_idle_timer_tasklet':
drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1145:23: error: implicit declaration of function 'from_tasklet' [-Werror=implicit-function-declaration]
1145 | struct zd_usb *usb = from_tasklet(usb, t, rx.reset_timer_tasklet);
| ^~~~~~~~~~~~
drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1145:44: error: 'rx' undeclared (first use in this function); did you mean 'rq'?
1145 | struct zd_usb *usb = from_tasklet(usb, t, rx.reset_timer_tasklet);
| ^~
| rq
drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1145:44: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/zydas/zd1211rw/zd_usb.c: In function 'init_usb_rx':
>> drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1181:33: warning: cast between incompatible function types from 'void (*)(struct tasklet_struct *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
1181 | rx->reset_timer_tasklet.func = (void (*)(unsigned long))
| ^cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/b1c5065eea8de31c83b4e7f764b9142157f54def
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Allen-Pais/wirless-convert-tasklets-to-use-new-tasklet_setup/20200817-171147 git checkout b1c5065eea8de31c83b4e7f764b9142157f54def
vim +1181 drivers/net/wireless/zydas/zd1211rw/zd_usb.c
1167
1168 static inline void init_usb_rx(struct zd_usb *usb)
1169 {
1170 struct zd_usb_rx *rx = &usb->rx;
1171
1172 spin_lock_init(&rx->lock);
1173 mutex_init(&rx->setup_mutex);
1174 if (interface_to_usbdev(usb->intf)->speed == USB_SPEED_HIGH) {
1175 rx->usb_packet_size = 512;
1176 } else {
1177 rx->usb_packet_size = 64;
1178 }
1179 ZD_ASSERT(rx->fragment_length == 0);
1180 INIT_DELAYED_WORK(&rx->idle_work, zd_rx_idle_timer_handler);
> 1181 rx->reset_timer_tasklet.func = (void (*)(unsigned long))
1182 zd_usb_reset_rx_idle_timer_tasklet;
1183 }
1184
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Jiri Slaby
maintainerQuoted 5 lines · Allen Pais
From: Allen Pais <[email protected]>
Commit
12cc923f1ccc("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the wireless drivers to use the newtasklet_setup()API
General question for the whole series: have you considered the long-term aim instead? That is: convert away from tasklets completely? I.e. use threaded irqs or workqueues?
thanks,
Signature · 7 lines
js suse labs -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 5 lines
General question for the whole series: have you considered the long-term aim instead? That is: convert away from tasklets completely? I.e. use threaded irqs or workqueues?
Yes, since changing tasklets to workqueues or threaded irqs
becomes a little trivial when it comes to tree-wide change, this approach was considered. I am open to both.
Signature · 6 lines
- Allen -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k