Skip to contentSkip to conversation

package/rtl8821au: add patch fixing sprintf error

PATCH New Christian Stewart 4 participants 6 messages Aug 8, 2020 – Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

Fixes compile errors against certain kernels.

---

v1 -> v2:

-cjs: format patch with -N
-cjs: add upstream + signed-off to patches
-cjs: thanks for the review from Peter

---
 ...-fallthrough-comments-for-kernel-5.3.patch |   7 +-
 ...river-crashes-from-aircrack-ng-rtl88.patch |   5 +-
 ...f-for-extending-string-which-causes-.patch | 339 ++++++++++++++++++
 3 files changed, 346 insertions(+), 5 deletions(-)
 create mode 100644 package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch
package/rtl8821au/0001-Fix-implicit-fallthrough-comments-for-kernel-5.3.patch +4 -3
index d323e8f938..00e801b6b1 100644
@@ -1,10 +1,11 @@
-From f41695e4069404639690d98c7aadfe72117965a6 Mon Sep 17 00:00:00 2001
+From 99f1e8bd7172ddf9613db3531a8b37921ed73351 Mon Sep 17 00:00:00 2001
 From: Jesper Skov <[email protected]>
 Date: Fri, 25 Oct 2019 10:05:41 +0200
 Subject: [PATCH] Fix implicit fallthrough comments for kernel 5.3
 
-[Upstram: https://github.com/abperiasamy/rtl8812AU_8821AU_linux/commit/e8a30a4c5a80efbbd5b1dbfe11b22916df4492f9.patch]
+[Upstream: https://github.com/abperiasamy/rtl8812AU_8821AU_linux/commit/e8a30a4c5a80efbbd5b1dbfe11b22916df4492f9.patch]
 Signed-off-by: Peter Seiderer <[email protected]>
+Signed-off-by: Christian Stewart <[email protected]>
 ---
  core/rtw_mlme_ext.c | 2 ++
  1 file changed, 2 insertions(+)
@@ -24,5 +25,5 @@ index 24565ea..380f507 100644
  		_mgt_dispatcher(padapter, ptable, precv_frame);
  #ifdef CONFIG_HOSTAPD_MLME
 -- 
-2.26.0
+2.28.0
 
package/rtl8821au/0002-Fix-kernel-5.3-driver-crashes-from-aircrack-ng-rtl88.patch +3 -2
index 6b1b70270a..213ea806b0 100644
@@ -1,10 +1,11 @@
-From b7f8f8572d5abca6e1f0163a583628c0207d0be4 Mon Sep 17 00:00:00 2001
+From cde2dbf6e94e00fcf198422b03de01d3090675d9 Mon Sep 17 00:00:00 2001
 From: Jesper Skov <[email protected]>
 Date: Fri, 25 Oct 2019 10:10:29 +0200
 Subject: [PATCH] Fix kernel 5.3 driver crashes, from aircrack-ng/rtl8812au#421
 
 [Upstream: https://github.com/abperiasamy/rtl8812AU_8821AU_linux/commit/822b485d36d6f72304a219c3be228f40968b542b.patch]
 Signed-off-by: Peter Seiderer <[email protected]>
+Signed-off-by: Christian Stewart <[email protected]>
 ---
  os_dep/linux/rtw_cfgvendor.c | 45 ++++++++++++++++++++++++++++++++++++
  1 file changed, 45 insertions(+)
@@ -164,5 +165,5 @@ index e7ba90a..81fc8af 100644
  	}
  };
 -- 
-2.26.0
+2.28.0
 
package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch new file +339 -0

339 lines not on this page · raw message

Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

Quoted 4 lines · On Sat, 8 Aug 2020 10:38:00 -0700 Christian Stewart <[email protected]> wrote:

Fixes compile errors against certain kernels.

Applied to master, thanks. I have to say the snippet of code that is being patched here does not give a very good feel of the rtl8821au code base :-/

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

Hi Thomas,

Quoted 4 lines · Thomas Petazzoni

On Sat, 8 Aug 2020 10:38:00 -0700
Christian Stewart <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Fixes compile errors against certain kernels.

Applied to master, thanks. I have to say the snippet of code that is being patched here does not give a very good feel of the rtl8821au code base :-/

After years of struggling with USB rtl cards (and helping others do the same) I have to agree.

Best regards,
Christian

#3 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

Quoted 6 lines · On Thu, 13 Aug 2020 14:31:26 -0700 Christian Stewart <[email protected]> wrote:
Quoted 3 lines

Applied to master, thanks. I have to say the snippet of code that is being patched here does not give a very good feel of the rtl8821au code base :-/

After years of struggling with USB rtl cards (and helping others do the same) I have to agree.

And nobody ever thought of taking all these crappy out of tree WiFi drivers, submit them for drivers/staging/ inclusion in the upstream kernel, and progressively clean them up ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

Hello Thomas,

Quoted 7 lines · Thomas Petazzoni
Quoted 4 lines · On Thu, 13 Aug 2020 14:31:26 -0700 Christian Stewart <[email protected]> wrote:
Quoted 3 lines

Applied to master, thanks. I have to say the snippet of code that is being patched here does not give a very good feel of the rtl8821au code base :-/

Quoted 6 lines
Quoted 2 lines

After years of struggling with USB rtl cards (and helping others do the same) I have to agree.

And nobody ever thought of taking all these crappy out of tree WiFi drivers, submit them for drivers/staging/ inclusion in the upstream kernel, and progressively clean them up ?

For some there are already staging alternatives (see [1], [2], [3], [4], [5])...

Regards,
Peter

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/rtl8188eu
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/rtl8192e
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/rtl8192u
[4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/rtl8712
[5] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/rtl8723bs

Quoted 2 lines

Thomas

#5 lore raw

PATCH v2 1/1 package/rtl8821au: add patch fixing sprintf error

In reply to Christian Stewart
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christian" == Christian Stewart <[email protected]> writes:

Fixes compile errors against certain kernels.

---

Quoted 7 lines

v1 -> v2:

-cjs: format patch with -N
-cjs: add upstream + signed-off to patches
-cjs: thanks for the review from Peter

Committed to 2020.02.x and 2020.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard