Skip to contentSkip to conversation

arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

PATCH Superseded Tanmay Shah 2 participants 2 messages Aug 17, 2020

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tanmay Shah

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

This node defines alternate DP HPD functionality of GPIO.

Signed-off-by Tanmay Shah <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +14 -0
index bf2f2bb1aa79..9f97cf5dd9ab 100644
@@ -1457,6 +1457,20 @@ pinconf-sd-cd {
 					drive-strength = <2>;
 				};
 			};
+
+			dp_hot_plug_det: dp-hot-plug-det {
+				pinmux {
+					pins = "gpio117";
+					function = "dp_hot";
+				};
+
+				config {
+					pins = "gpio117";
+					bias-disable;
+					input-enable;
+					drive-strength = <2>;
+				};
+			};
 		};
 
 		gpu: gpu@5000000 {

base-commit: 62975d27d647a40c58d3b96c29b911fc4f33c310

Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Quoting Tanmay Shah (2020-08-17 15:45:27)

Quoted 13 lines

This node defines alternate DP HPD functionality of GPIO.

Signed-off-by Tanmay Shah <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index bf2f2bb1aa79..9f97cf5dd9ab 100644
@@ -1457,6 +1457,20 @@ pinconf-sd-cd {
                                        drive-strength = <2>;

arch/arm64/boot/dts/qcom/sc7180.dtsi pinconf-sd-cd { · line 1467

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +8 -0
                                };
                        };
+
+                       dp_hot_plug_det: dp-hot-plug-det {
+                               pinmux {
+                                       pins = "gpio117";
+                                       function = "dp_hot";
+                               };
+
+                               config {

The node name is usualy called pinconf. Please use that.

arch/arm64/boot/dts/qcom/sc7180.dtsi pinconf-sd-cd { · line 1471

Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +4 -0
+                                       pins = "gpio117";
+                                       bias-disable;
+                                       input-enable;
+                                       drive-strength = <2>;

My understanding is that drive-strength doesn't do anything when the pin is input. So this line should be removed.

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -0
+                               };
+                       };
                };
 
                gpu: gpu@5000000 {