Support virtio cross-device resources
Subsystems (5)
v7 cover Support virtio cross-device resources
This patchset implements the current proposal for virtio cross-device resource sharing [1]. It will be used to import virtio resources into the virtio-video driver currently under discussion [2]. The patch under consideration to add support in the virtio-video driver is [3]. It uses the APIs from v3 of this series, but the changes to update it are relatively minor.
This patchset adds a new flavor of dma-bufs that supports querying the underlying virtio object UUID, as well as adding support for exporting resources from virtgpu.
[1] https://markmail.org/thread/2ypjt5cfeu3m6lxu
[2] https://markmail.org/thread/p5d3k566srtdtute
[3] https://markmail.org/thread/j4xlqaaim266qpks
v6 -> v7 changes:
- Fix most strict checkpatch comments
David Stevens (3):
virtio: add dma-buf support for exported objects
virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature drm/virtio: Support virtgpu exported resources
drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio/virtgpu_drv.h | 21 ++++++ drivers/gpu/drm/virtio/virtgpu_kms.c | 4 ++ drivers/gpu/drm/virtio/virtgpu_prime.c | 96 +++++++++++++++++++++++++- drivers/gpu/drm/virtio/virtgpu_vq.c | 55 +++++++++++++++ drivers/virtio/Makefile | 2 +- drivers/virtio/virtio.c | 6 ++ drivers/virtio/virtio_dma_buf.c | 85 +++++++++++++++++++++++ include/linux/virtio.h | 1 + include/linux/virtio_dma_buf.h | 37 ++++++++++ include/uapi/linux/virtio_gpu.h | 19 +++++ 11 files changed, 325 insertions(+), 4 deletions(-) create mode 100644 drivers/virtio/virtio_dma_buf.c create mode 100644 include/linux/virtio_dma_buf.h
Signature · 6 lines
2.28.0.220.ged08abb693-goog --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
PATCH v7 1/3 virtio: add dma-buf support for exported objects
This change adds a new flavor of dma-bufs that can be used by virtio drivers to share exported objects. A virtio dma-buf can be queried by virtio drivers to obtain the UUID which identifies the underlying exported object.
--- drivers/virtio/Makefile | 2 +- drivers/virtio/virtio.c | 6 +++ drivers/virtio/virtio_dma_buf.c | 85 +++++++++++++++++++++++++++++++++ include/linux/virtio.h | 1 + include/linux/virtio_dma_buf.h | 37 ++++++++++++++ 5 files changed, 130 insertions(+), 1 deletion(-) create mode 100644 drivers/virtio/virtio_dma_buf.c create mode 100644 include/linux/virtio_dma_buf.h
drivers/virtio/Makefile +1 -1
@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_VIRTIO) += virtio.o virtio_ring.o +obj-$(CONFIG_VIRTIO) += virtio.o virtio_ring.o virtio_dma_buf.o obj-$(CONFIG_VIRTIO_MMIO) += virtio_mmio.o obj-$(CONFIG_VIRTIO_PCI) += virtio_pci.o virtio_pci-y := virtio_pci_modern.o virtio_pci_common.o
drivers/virtio/virtio.c +6 -0
@@ -357,6 +357,12 @@ int register_virtio_device(struct virtio_device *dev) }EXPORT_SYMBOL_GPL (register_virtio_device); +bool is_virtio_device (struct device *dev) +{ +return dev->bus == &virtio_bus; +} +EXPORT_SYMBOL_GPL (is_virtio_device); +void unregister_virtio_device (struct virtio_device *dev) {int index = dev->index;/* save for after device release */
drivers/virtio/virtio_dma_buf.c new file +85 -0
85 lines not on this page · raw message
include/linux/virtio.h +1 -0
@@ -128,6 +128,7 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)void virtio_add_status (struct virtio_device *dev,unsigned int status);int register_virtio_device (struct virtio_device *dev);void unregister_virtio_device (struct virtio_device *dev); +bool is_virtio_device (struct device *dev);void virtio_break_device (struct virtio_device *dev);
include/linux/virtio_dma_buf.h new file +37 -0
@@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* dma-bufs for virtio exported objects +* +* Copyright (C) 2020 Google, Inc. +*/ + +#ifndef _LINUX_VIRTIO_DMA_BUF_H +#define _LINUX_VIRTIO_DMA_BUF_H + +#include <linux/dma-buf.h> +#include <linux/uuid.h> +#include <linux/virtio.h> + +/** +* struct virtio_dma_buf_ops - operations possible on exported object dma-buf +* @ops: the base dma_buf_ops. ops.attach MUST be virtio_dma_buf_attach. +* @device_attach: [optional] callback invoked by virtio_dma_buf_attach during +* all attach operations. +* @get_uid: [required] callback to get the uuid of the exported object. +*/ +struct virtio_dma_buf_ops { +struct dma_buf_ops ops; +int (*device_attach)(struct dma_buf *dma_buf, +struct dma_buf_attachment *attach); +int (*get_uuid)(struct dma_buf *dma_buf,uuid_t *uuid); +}; + +int virtio_dma_buf_attach (struct dma_buf *dma_buf, +struct dma_buf_attachment *attach); + +struct dma_buf *virtio_dma_buf_export + (const struct dma_buf_export_info *exp_info); +bool is_virtio_dma_buf (struct dma_buf *dma_buf); +int virtio_dma_buf_get_uuid (struct dma_buf *dma_buf,uuid_t *uuid); + +#endif /* _LINUX_VIRTIO_DMA_BUF_H */
Signature · 6 lines
2.28.0.220.ged08abb693-goog --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
kernel test robot
build botRe: [PATCH v7 1/3] virtio: add dma-buf support for exported objects
Thank you for the patch! Yet something to improve:
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc2]
[cannot apply to next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Stevens/Support-virtio-cross-device-resources/20200818-151606 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd config: arm-axm55xx_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: drivers/virtio/virtio_dma_buf.o: in function `virtio_dma_buf_export':
>> virtio_dma_buf.c:(.text+0x98): undefined reference to `dma_buf_export'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH v7 1/3] virtio: add dma-buf support for exported objects
In reply to David StevensQuoted 6 lines · David Stevens
This change adds a new flavor of dma-bufs that can be used by virtio drivers to share exported objects. A virtio dma-buf can be queried by virtio drivers to obtain the UUID which identifies the underlying exported object.
Signed-off-by David Stevens <[email protected]>
This makes VIRTIO dependent on DMA_SHARED_BUFFER. That means "select DMA_SHARED_BUFFER" will have to be added to "config VIRTIO".
Guenter
Quoted 174 lines
--- drivers/virtio/Makefile | 2 +- drivers/virtio/virtio.c | 6 +++ drivers/virtio/virtio_dma_buf.c | 85 +++++++++++++++++++++++++++++++++ include/linux/virtio.h | 1 + include/linux/virtio_dma_buf.h | 37 ++++++++++++++ 5 files changed, 130 insertions(+), 1 deletion(-) create mode 100644 drivers/virtio/virtio_dma_buf.c create mode 100644 include/linux/virtio_dma_buf.hdrivers/virtio/Makefile +1
-1@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_VIRTIO) += virtio.o virtio_ring.o +obj-$(CONFIG_VIRTIO) += virtio.o virtio_ring.o virtio_dma_buf.o obj-$(CONFIG_VIRTIO_MMIO) += virtio_mmio.o obj-$(CONFIG_VIRTIO_PCI) += virtio_pci.o virtio_pci-y := virtio_pci_modern.o virtio_pci_common.odrivers/virtio/virtio.c +6
-0@@ -357,6 +357,12 @@ int register_virtio_device(struct virtio_device *dev) }EXPORT_SYMBOL_GPL (register_virtio_device); +bool is_virtio_device (struct device *dev) +{ +return dev->bus == &virtio_bus; +} +EXPORT_SYMBOL_GPL (is_virtio_device); +void unregister_virtio_device (struct virtio_device *dev) {int index = dev->index;/* save for after device release */ drivers/virtio/virtio_dma_buf.c new file +85
-0@@ -0,0 +1,85 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* dma-bufs for virtio exported objects +* +* Copyright (C) 2020 Google, Inc. +*/ + +#include <linux/virtio_dma_buf.h> + +/** +* virtio_dma_buf_export - Creates a new dma-buf for a virtio exported object +* @exp_info: [in] see dma_buf_export(). ops MUST refer to a dma_buf_ops +* struct embedded in a virtio_dma_buf_ops. +* +* This wraps dma_buf_export() to allow virtio drivers to create a dma-buf +* for an virtio exported object that can be queried by other virtio drivers +* for the object's UUID. +*/ +struct dma_buf *virtio_dma_buf_export + (const struct dma_buf_export_info *exp_info) +{ +const struct virtio_dma_buf_ops *virtio_ops = +container_of (exp_info->ops, + const struct virtio_dma_buf_ops, ops); + +if (!exp_info->ops || + exp_info->ops->attach != &virtio_dma_buf_attach || + !virtio_ops->get_uuid) { +return ERR_PTR (-EINVAL ); + } + +return dma_buf_export (exp_info); +} +EXPORT_SYMBOL (virtio_dma_buf_export); + +/** +* virtio_dma_buf_attach - mandatory attach callback for virtio dma-bufs +*/ +int virtio_dma_buf_attach (struct dma_buf *dma_buf, +struct dma_buf_attachment *attach) +{ +int ret; +const struct virtio_dma_buf_ops *ops = +container_of (dma_buf->ops, + const struct virtio_dma_buf_ops, ops); + +if (ops->device_attach) { + ret = ops->device_attach (dma_buf, attach); +if (ret) +return ret; + } +return 0 ; +} +EXPORT_SYMBOL (virtio_dma_buf_attach); + +/** +* is_virtio_dma_buf - returns true if the given dma-buf is a virtio dma-buf +* @dma_buf: buffer to query +*/ +bool is_virtio_dma_buf (struct dma_buf *dma_buf) +{ +return dma_buf->ops->attach == &virtio_dma_buf_attach; +} +EXPORT_SYMBOL (is_virtio_dma_buf); + +/** +* virtio_dma_buf_get_uuid - gets a virtio dma-buf's exported object's uuid +* @dma_buf: [in] buffer to query +* @uuid: [out] the uuid +* +* Returns: 0 on success, negative on failure. +*/ +int virtio_dma_buf_get_uuid (struct dma_buf *dma_buf, +uuid_t *uuid) +{ +const struct virtio_dma_buf_ops *ops = +container_of (dma_buf->ops, + const struct virtio_dma_buf_ops, ops); + +if (!is_virtio_dma_buf (dma_buf)) +return -EINVAL ; + +return ops->get_uuid (dma_buf, uuid); +} +EXPORT_SYMBOL (virtio_dma_buf_get_uuid);include/linux/virtio.h +1
-0@@ -128,6 +128,7 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)void virtio_add_status (struct virtio_device *dev,unsigned int status);int register_virtio_device (struct virtio_device *dev);void unregister_virtio_device (struct virtio_device *dev); +bool is_virtio_device (struct device *dev);void virtio_break_device (struct virtio_device *dev);include/linux/virtio_dma_buf.h new file +27
-0@@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* dma-bufs for virtio exported objects +* +* Copyright (C) 2020 Google, Inc. +*/ + +#ifndef _LINUX_VIRTIO_DMA_BUF_H +#define _LINUX_VIRTIO_DMA_BUF_H + +#include <linux/dma-buf.h> +#include <linux/uuid.h> +#include <linux/virtio.h> + +/** +* struct virtio_dma_buf_ops - operations possible on exported object dma-buf +* @ops: the base dma_buf_ops. ops.attach MUST be virtio_dma_buf_attach. +* @device_attach: [optional] callback invoked by virtio_dma_buf_attach during +* all attach operations. +* @get_uid: [required] callback to get the uuid of the exported object. +*/ +struct virtio_dma_buf_ops { +struct dma_buf_ops ops; +int (*device_attach)(struct dma_buf *dma_buf, +struct dma_buf_attachment *attach); +int (*get_uuid)(struct dma_buf *dma_buf,uuid_t *uuid); +};
include/linux/virtio_dma_buf.h line 37
Quoted 10 lines
include/linux/virtio_dma_buf.h new file +10
-0+ +int virtio_dma_buf_attach (struct dma_buf *dma_buf, +struct dma_buf_attachment *attach); + +struct dma_buf *virtio_dma_buf_export + (const struct dma_buf_export_info *exp_info); +bool is_virtio_dma_buf (struct dma_buf *dma_buf); +int virtio_dma_buf_get_uuid (struct dma_buf *dma_buf,uuid_t *uuid); + +#endif /* _LINUX_VIRTIO_DMA_BUF_H */
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
PATCH v7 2/3 virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature
In reply to David StevensThis feature allows the guest to request a UUID from the host for a particular virtio_gpu resource. The UUID can then be shared with other virtio devices, to allow the other host devices to access the virtio_gpu's corresponding host resource.
--- include/uapi/linux/virtio_gpu.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
include/uapi/linux/virtio_gpu.h +19 -0
@@ -50,6 +50,10 @@* VIRTIO_GPU_CMD_GET_EDID */ #define VIRTIO_GPU_F_EDID 1 +/* +* VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID +*/ +#define VIRTIO_GPU_F_RESOURCE_UUID 2enum virtio_gpu_ctrl_type {VIRTIO_GPU_UNDEFINED =0 ,
@@ -66,6 +70,7 @@ enum virtio_gpu_ctrl_type {VIRTIO_GPU_CMD_GET_CAPSET_INFO ,VIRTIO_GPU_CMD_GET_CAPSET ,VIRTIO_GPU_CMD_GET_EDID , +VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID ,/* 3d commands */ VIRTIO_GPU_CMD_CTX_CREATE = 0x0200,
@@ -87,6 +92,7 @@ enum virtio_gpu_ctrl_type {VIRTIO_GPU_RESP_OK_CAPSET_INFO ,VIRTIO_GPU_RESP_OK_CAPSET ,VIRTIO_GPU_RESP_OK_EDID , +VIRTIO_GPU_RESP_OK_RESOURCE_UUID ,/* error responses */ VIRTIO_GPU_RESP_ERR_UNSPEC = 0x1200,
@@ -340,4 +346,17 @@ enum virtio_gpu_formats { VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM = 134, }; +/* VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID */ +struct virtio_gpu_resource_assign_uuid { +struct virtio_gpu_ctrl_hdr hdr; +__le32 resource_id; +__le32 padding; +}; + +/* VIRTIO_GPU_RESP_OK_RESOURCE_UUID */ +struct virtio_gpu_resp_resource_uuid { +struct virtio_gpu_ctrl_hdr hdr; +__u8 uuid[16 ]; +}; +#endif
Signature · 6 lines
2.28.0.220.ged08abb693-goog --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
PATCH v7 3/3 drm/virtio: Support virtgpu exported resources
In reply to David StevensAdd support for UUID-based resource sharing mechanism to virtgpu. This implements the new virtgpu commands and hooks them up to dma-buf's get_uuid callback.
--- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio/virtgpu_drv.h | 21 ++++++ drivers/gpu/drm/virtio/virtgpu_kms.c | 4 ++ drivers/gpu/drm/virtio/virtgpu_prime.c | 96 +++++++++++++++++++++++++- drivers/gpu/drm/virtio/virtgpu_vq.c | 55 +++++++++++++++ 5 files changed, 176 insertions(+), 3 deletions(-)
drivers/gpu/drm/virtio/virtgpu_drv.c +3 -0
@@ -165,6 +165,7 @@ static unsigned int features[] = { VIRTIO_GPU_F_VIRGL, #endif VIRTIO_GPU_F_EDID, + VIRTIO_GPU_F_RESOURCE_UUID, }; static struct virtio_driver virtio_gpu_driver = { .feature_table = features,
@@ -202,6 +203,8 @@ static struct drm_driver driver = { .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle, .gem_prime_mmap = drm_gem_prime_mmap, + .gem_prime_export = virtgpu_gem_prime_export, + .gem_prime_import = virtgpu_gem_prime_import, .gem_prime_import_sg_table = virtgpu_gem_prime_import_sg_table, .gem_create_object = virtio_gpu_create_object,
drivers/gpu/drm/virtio/virtgpu_drv.h +21 -0
@@ -49,6 +49,10 @@#define DRIVER_MINOR 1#define DRIVER_PATCHLEVEL 0 +#define UUID_INITIALIZING 0 +#define UUID_INITIALIZED 1 +#define UUID_INITIALIZATION_FAILED 2 +struct virtio_gpu_object_params {uint32_t format;uint32_t width;
@@ -71,6 +75,9 @@ struct virtio_gpu_object {uint32_t hw_res_handle;bool dumb;bool created; + +int uuid_state; +uuid_t uuid; };#define gem_to_virtio_gpu_obj (gobj) \ container_of((gobj), struct virtio_gpu_object, base.base)
@@ -200,6 +207,7 @@ struct virtio_gpu_device {bool has_virgl_3d;bool has_edid;bool has_indirect; +bool has_resource_assign_uuid;struct work_struct config_changed_work;
@@ -210,6 +218,9 @@ struct virtio_gpu_device {struct virtio_gpu_drv_capset *capsets;uint32_t num_capsets;struct list_head cap_cache; + +/* protects resource state when exporting */ +spinlock_t resource_export_lock; };struct virtio_gpu_fpriv {
@@ -335,6 +346,10 @@ void virtio_gpu_dequeue_fence_func(struct work_struct *work);void virtio_gpu_notify (struct virtio_gpu_device *vgdev); +int +virtio_gpu_cmd_resource_assign_uuid (struct virtio_gpu_device *vgdev, +struct virtio_gpu_object_array *objs); +/* virtgpu_display.c */ void virtio_gpu_modeset_init (struct virtio_gpu_device *vgdev);void virtio_gpu_modeset_fini (struct virtio_gpu_device *vgdev);
@@ -366,6 +381,12 @@ int virtio_gpu_object_create(struct virtio_gpu_device *vgdev,bool virtio_gpu_is_shmem (struct virtio_gpu_object *bo);/* virtgpu_prime.c */ +struct dma_buf *virtgpu_gem_prime_export (struct drm_gem_object *obj, +int flags); +struct drm_gem_object *virtgpu_gem_prime_import (struct drm_device *dev, +struct dma_buf *buf); +int virtgpu_gem_prime_get_uuid (struct drm_gem_object *obj, +uuid_t *uuid);struct drm_gem_object *virtgpu_gem_prime_import_sg_table (struct drm_device *dev,struct dma_buf_attachment *attach,struct sg_table *sgt);
drivers/gpu/drm/virtio/virtgpu_kms.c +4 -0
@@ -125,6 +125,7 @@ int virtio_gpu_init(struct drm_device *dev) vgdev->dev = dev->dev;spin_lock_init (&vgdev->display_info_lock); +spin_lock_init (&vgdev->resource_export_lock);ida_init (&vgdev->ctx_id_ida);ida_init (&vgdev->resource_ida);init_waitqueue_head (&vgdev->resp_wq);
@@ -153,6 +154,9 @@ int virtio_gpu_init(struct drm_device *dev)if (virtio_has_feature (vgdev->vdev,VIRTIO_RING_F_INDIRECT_DESC )) { vgdev->has_indirect = true; } +if (virtio_has_feature (vgdev->vdev,VIRTIO_GPU_F_RESOURCE_UUID )) { + vgdev->has_resource_assign_uuid = true; + } DRM_INFO("features: %cvirgl %cedid\n", vgdev->has_virgl_3d ? '+' : '-',
drivers/gpu/drm/virtio/virtgpu_prime.c +93 -3
105 lines not on this page · raw message
drivers/gpu/drm/virtio/virtgpu_vq.c +55 -0
58 lines not on this page · raw message
Signature · 6 lines
2.28.0.220.ged08abb693-goog --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]