net-tun: add type safety to tun_xdp_to_ptr() and tun_ptr_to_xdp()
Subsystems (4)
PATCH 1/1 net-tun: add type safety to tun_xdp_to_ptr() and tun_ptr_to_xdp()
From: Maciej Żenczykowski <[email protected]>
Test: builds
Signed-off-by Maciej Żenczykowski <[email protected]>
--- drivers/net/tun.c | 6 +++--- include/linux/if_tun.h | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/net/tun.c +3 -3
@@ -225,13 +225,13 @@ bool tun_is_xdp_frame(void *ptr) }EXPORT_SYMBOL (tun_is_xdp_frame); -void *tun_xdp_to_ptr (void *ptr) +void *tun_xdp_to_ptr (struct xdp_frame *xdp) { -return (void *)((unsigned long )ptr |TUN_XDP_FLAG ); +return (void *)((unsigned long )xdp |TUN_XDP_FLAG ); }EXPORT_SYMBOL (tun_xdp_to_ptr); -void *tun_ptr_to_xdp (void *ptr) +struct xdp_frame *tun_ptr_to_xdp (void *ptr) {return (void *)((unsigned long )ptr & ~TUN_XDP_FLAG ); }
include/linux/if_tun.h +4 -4
@@ -28,8 +28,8 @@ struct tun_xdp_hdr {struct socket *tun_get_socket (struct file *);struct ptr_ring *tun_get_tx_ring (struct file *file);bool tun_is_xdp_frame (void *ptr); -void *tun_xdp_to_ptr (void *ptr); -void *tun_ptr_to_xdp (void *ptr); +void *tun_xdp_to_ptr (struct xdp_frame *xdp); +struct xdp_frame *tun_ptr_to_xdp (void *ptr);void tun_ptr_free (void *ptr);#else #include <linux/err.h>
@@ -48,11 +48,11 @@ static inline bool tun_is_xdp_frame(void *ptr) {return false; } -static inline void *tun_xdp_to_ptr (void *ptr) +static inline void *tun_xdp_to_ptr (struct xdp_frame *xdp) {return NULL ; } -static inline void *tun_ptr_to_xdp (void *ptr) +static inline struct xdp_frame *tun_ptr_to_xdp (void *ptr) {return NULL ; }
Signature · 1 line
2.28.0.220.ged08abb693-goog
Quoted 5 lines · Maciej Żenczykowski
From: Maciej Żenczykowski <[email protected]>
Test: builds
Signed-off-by Maciej Żenczykowski <[email protected]>
I know it's a trivial patch, but please provide a proper commit log and explain _why_ this type safety is necessary.
Also pls use email subject with [PATCH bpf-next]