Skip to contentSkip to conversation

binderfs: make symbol 'binderfs_fs_parameters' static

PATCH In review Wei Yongjun 2 participants 2 messages Aug 18, 2020 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binderfs: make symbol 'binderfs_fs_parameters' static

The sparse tool complains as follows:

drivers/android/binderfs.c:66:32: warning:
symbol 'binderfs_fs_parameters' was not declared. Should it be static?

This variable is not used outside of binderfs.c, so this commit marks it static.

Fixes 095cf502b31e ("binderfs: port to new mount api")
---
 drivers/android/binderfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binderfs.c +1 -1
index 7b76fefde3f8..7b4f154f07e6 100644
@@ -63,7 +63,7 @@ static const struct constant_table binderfs_param_stats[] = {
 	{}
 };
 
-const struct fs_parameter_spec binderfs_fs_parameters[] = {
+static const struct fs_parameter_spec binderfs_fs_parameters[] = {
 	fsparam_u32("max",	Opt_max),
 	fsparam_enum("stats",	Opt_stats_mode, binderfs_param_stats),
 	{}
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Wei Yongjun

The sparse tool complains as follows:

drivers/android/binderfs.c:66:32: warning:
symbol 'binderfs_fs_parameters' was not declared. Should it be static?

Quoted 7 lines

This variable is not used outside of binderfs.c, so this commit marks it static.

Fixes 095cf502b31e ("binderfs: port to new mount api")

---

Thanks!