regulator: dbx500: no need to check return value of debugfs_create functions
PATCH 1/1 regulator: dbx500: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- drivers/regulator/dbx500-prcmu.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-)
drivers/regulator/dbx500-prcmu.c +5 -19
@@ -67,8 +67,6 @@ static int power_state_active_get(void) static struct ux500_regulator_debug { struct dentry *dir; - struct dentry *status_file; - struct dentry *power_state_cnt_file; struct dbx500_regulator_info *regulator_array; int num_regulators; u8 *state_before_suspend;
@@ -117,22 +115,14 @@ ux500_regulator_debug_init(struct platform_device *pdev, {/* create directory */ rdebug.dir =debugfs_create_dir ("ux500-regulator" ,NULL ); -if (!rdebug.dir) - goto exit_no_debugfs;/* create "status" file */ - rdebug.status_file =debugfs_create_file ("status" , -S_IRUGO , rdebug.dir, &pdev->dev, - &ux500_regulator_status_fops); -if (!rdebug.status_file) - goto exit_destroy_dir; +debugfs_create_file ("status" ,S_IRUGO , rdebug.dir, &pdev->dev, + &ux500_regulator_status_fops);/* create "power-state-count" file */ - rdebug.power_state_cnt_file =debugfs_create_file ("power-state-count" , -S_IRUGO , rdebug.dir, &pdev->dev, - &ux500_regulator_power_state_cnt_fops); -if (!rdebug.power_state_cnt_file) - goto exit_destroy_status; +debugfs_create_file ("power-state-count" ,S_IRUGO , rdebug.dir, + &pdev->dev, &ux500_regulator_power_state_cnt_fops); rdebug.regulator_array = regulator_info; rdebug.num_regulators = num_regulators;
@@ -150,11 +140,7 @@ ux500_regulator_debug_init(struct platform_device *pdev, exit_free:kfree (rdebug.state_before_suspend); exit_destroy_power_state: -debugfs_remove (rdebug.power_state_cnt_file); -exit_destroy_status: -debugfs_remove (rdebug.status_file); -exit_destroy_dir: -debugfs_remove (rdebug.dir); +debugfs_remove_recursive (rdebug.dir); exit_no_debugfs:dev_err (&pdev->dev,"failed to create debugfs entries.\n" );return -ENOMEM ;
Signature · 1 line
2.28.0
Mark Brown
maintainerQuoted 3 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: dbx500: no need to check return value of debugfs_create functions
commit: 8bdaa43808b7481eb61b251ae0e4ca308ee1093d
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark