drm/i915: Add support for HDCP 1.4 over MST
Subsystems (5)
v8 cover drm/i915: Add support for HDCP 1.4 over MST
From: Sean Paul <[email protected]>
Only one functional change, reversed the hdcp_1x/2x_present bits in the QUERY_STREAM_ENCRYPTION_STATUS parsing with a comment explaining my confusion.
Other than that, lots of rebasing, the most notable being the s/intel_dig_port/dig_port/ rename.
Every patch now has a Reviewed-by tag now, I've done build tests on each patch and tested the set as a whole. Hopefully we can get this landed.
Sean
Sean Paul (17):
drm/i915: Fix sha_text population code
drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP signalling is enabled upon disable drm/i915: Intercept Aksv writes in the aux hooks drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP
signalling
drm/i915: Factor out hdcp->value assignments
drm/i915: Protect workers against disappearing connectors drm/i915: Clean up intel_hdcp_disable
drm/i915: Don't fully disable HDCP on a port if multiple pipes are
using it
drm/i915: Support DP MST in enc_to_dig_port() function drm/i915: Use ddi_update_pipe in intel_dp_mst
drm/i915: Factor out HDCP shim functions from dp for use by dp_mst drm/i915: Plumb port through hdcp init
drm/i915: Add connector to hdcp_shim->check_link() drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband
message
drm/i915: Print HDCP version info for all connectors drm/i915: Add HDCP 1.4 support for MST connectors
drivers/gpu/drm/drm_dp_mst_topology.c | 150 ++++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 29 +- drivers/gpu/drm/i915/display/intel_ddi.h | 2 + .../drm/i915/display/intel_display_debugfs.c | 21 +- .../drm/i915/display/intel_display_types.h | 30 +- drivers/gpu/drm/i915/display/intel_dp.c | 646 +--------------- drivers/gpu/drm/i915/display/intel_dp.h | 9 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 703 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 + drivers/gpu/drm/i915/display/intel_hdcp.c | 217 ++++-- drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 30 +- .../drm/selftests/test-drm_dp_mst_helper.c | 17 + include/drm/drm_dp_helper.h | 3 + include/drm/drm_dp_mst_helper.h | 44 ++ include/drm/drm_hdcp.h | 3 + 17 files changed, 1202 insertions(+), 724 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dp_hdcp.c
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 1/17 drm/i915: Fix sha_text population code
From: Sean Paul <[email protected]>
This patch fixes a few bugs:
1- We weren't taking into account sha_leftovers when adding multiple
ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j]
2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was
being placed on the wrong half of sha_text, overlapping the leftover ksv value
3- In the sha_leftovers == 2 case, we need to manually terminate the
byte stream with 0x80 since the hardware doesn't have enough room to add it after writing M0
The upside is that all of the HDCP supported HDMI repeaters I could find on Amazon just strip HDCP anyways, so it turns out to be _really_ hard to hit any of these cases without an MST hub, which is not (yet) supported. Oh, and the sha_leftovers == 1 case works perfectly!
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-Rebased on intel_de_write changes
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 26 +++++++++++++++++------ include/drm/drm_hdcp.h | 3 +++ 2 files changed, 23 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_hdcp.c +20 -6
@@ -336,8 +336,10 @@ int intel_hdcp_validate_v_prime(struct intel_connector *connector,/* Fill up the empty slots in sha_text and write it out */ sha_empty =sizeof (sha_text) - sha_leftovers; -for (j =0 ; j < sha_empty; j++) - sha_text |= ksv[j] << ((sizeof (sha_text) - j -1 ) *8 ); +for (j =0 ; j < sha_empty; j++) { +u8 off = ((sizeof (sha_text) - j -1 - sha_leftovers) *8 ); + sha_text |= ksv[j] << off; + } ret =intel_write_sha_text (dev_priv, sha_text);if (ret <0 )
@@ -435,7 +437,7 @@ int intel_hdcp_validate_v_prime(struct intel_connector *connector,/* Write 32 bits of text */ intel_de_write (dev_priv,HDCP_REP_CTL , rep_ctl |HDCP_SHA1_TEXT_32 ); - sha_text |= bstatus[0 ] <<24 | bstatus[1 ] <<16 ; + sha_text |= bstatus[0 ] <<8 | bstatus[1 ]; ret =intel_write_sha_text (dev_priv, sha_text);if (ret <0 )return ret;
@@ -450,17 +452,29 @@ int intel_hdcp_validate_v_prime(struct intel_connector *connector,return ret; sha_idx +=sizeof (sha_text); } + +/* +* Terminate the SHA-1 stream by hand. For the other leftover +* cases this is appended by the hardware. +*/ +intel_de_write (dev_priv,HDCP_REP_CTL , + rep_ctl |HDCP_SHA1_TEXT_32 ); + sha_text =DRM_HDCP_SHA1_TERMINATOR <<24 ; + ret =intel_write_sha_text (dev_priv, sha_text); +if (ret <0 ) +return ret; + sha_idx +=sizeof (sha_text); }else if (sha_leftovers ==3 ) { -/* Write 32 bits of text */ +/* Write 32 bits of text (filled from LSB) */ intel_de_write (dev_priv,HDCP_REP_CTL , rep_ctl |HDCP_SHA1_TEXT_32 ); - sha_text |= bstatus[0 ] <<24 ; + sha_text |= bstatus[0 ]; ret =intel_write_sha_text (dev_priv, sha_text);if (ret <0 )return ret; sha_idx +=sizeof (sha_text); -/* Write 8 bits of text, 24 bits of M0 */ +/* Write 8 bits of text (filled from LSB), 24 bits of M0 */ intel_de_write (dev_priv,HDCP_REP_CTL , rep_ctl |HDCP_SHA1_TEXT_8 ); ret =intel_write_sha_text (dev_priv, bstatus[1 ]);
include/drm/drm_hdcp.h +3 -0
@@ -29,6 +29,9 @@/* Slave address for the HDCP registers in the receiver */ #define DRM_HDCP_DDC_ADDR 0x3A +/* Value to use at the end of the SHA-1 bytestream used for repeaters */ +#define DRM_HDCP_SHA1_TERMINATOR 0x80 +/* HDCP register offsets for HDMI/DVI devices */ #define DRM_HDCP_DDC_BKSV 0x00#define DRM_HDCP_DDC_RI_PRIME 0x08
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sasha Levin
maintainerRe: [PATCH v8 01/17] drm/i915: Fix sha_text population code
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation").
The bot has tested the following trees: v5.8.2, v5.7.16, v5.4.59, v4.19.140.
v5.8.2: Build OK!
v5.7.16: Build OK!
v5.4.59: Failed to apply! Possible dependencies:
65833c463886 ("drm/i915/hdcp: conversion to struct drm_device based logging macros.")
667944ad77f1 ("drm/i915/hdcp: use intel_de_*() functions for register access")
692059318c0f ("drm/i915/hdcp: Enable HDCP 1.4 and 2.2 on Gen12+")v4.19.140: Failed to apply! Possible dependencies:
09d7e46b97c6 ("drm/i915: Pull VM lists under the VM mutex.")
16e4dd0342a8 ("drm/i915: Markup paired operations on wakerefs")
1d455f8de8e8 ("drm/i915: rename intel_drv.h to display/intel_display_types.h")
27fec1f9734d ("drm/i915: extract intel_dp.h from intel_drv.h")
39e2f501c1b4 ("drm/i915: Split struct intel_context definition to its own header")
480cd6dd9287 ("drm/i915/selftests: Track evict objects explicitly")
499197dc1696 ("drm/i915: Stop tracking MRU activity on VMA")
528cbd17ceff ("drm/i915: Move vma lookup to its own lock")
531747b8200a ("drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained")
64d6c500a384 ("drm/i915: Generalise GPU activity tracking")
667944ad77f1 ("drm/i915/hdcp: use intel_de_*() functions for register access")
692059318c0f ("drm/i915/hdcp: Enable HDCP 1.4 and 2.2 on Gen12+")
71fc448c1aaf ("drm/i915/selftests: Make evict tolerant of foreign objects")
a037121c3c7f ("drm/i915: Mark up debugfs with rpm wakeref tracking")
c2400ec3b6d1 ("drm/i915: add Makefile magic for testing headers are self-contained")
d2ee2e8afeea ("drm/i915: extract intel_crt.h from intel_drv.h")
d4225a535b3b ("drm/i915: Syntatic sugar for using intel_runtime_pm")NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
Signature · 6 lines
Thanks Sasha _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 2/17 drm/i915: Clear the repeater bit on HDCP disable
In reply to Sean PaulFrom: Sean Paul <[email protected]>
On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect.
Changes in v2:
-Added to the set
Changes in v3:
-None
I had previously agreed that clearing the rep_ctl bits on enable would also be a good idea. However when I committed that idea to code, it didn't look right. So let's rely on enables and disables being paired and everything outside of that will be considered a bug
Changes in v4:
-s/I915_(READ|WRITE)/intel_de_(read|write)/
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/display/intel_hdcp.c +6 -0
@@ -795,6 +795,7 @@ static int _intel_hdcp_disable(struct intel_connector *connector)struct intel_hdcp *hdcp = &connector->hdcp;enum port port = dig_port->base.port;enum transcoder cpu_transcoder = hdcp->cpu_transcoder; +u32 repeater_ctl;int ret; drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
@@ -810,6 +811,11 @@ static int _intel_hdcp_disable(struct intel_connector *connector)return -ETIMEDOUT ; } + repeater_ctl =intel_hdcp_get_repeater_ctl (dev_priv, cpu_transcoder, + port); +intel_de_write (dev_priv,HDCP_REP_CTL , +intel_de_read (dev_priv,HDCP_REP_CTL ) & ~repeater_ctl); + ret = hdcp->shim->toggle_signalling (dig_port, false);if (ret) {drm_err (&dev_priv->drm,"Failed to disable HDCP signalling\n" );
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sasha Levin
maintainerRe: [PATCH v8 02/17] drm/i915: Clear the repeater bit on HDCP disable
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation").
The bot has tested the following trees: v5.8.2, v5.7.16, v5.4.59, v4.19.140.
v5.8.2: Failed to apply! Possible dependencies:
53de0a20c8cd ("drm/i915: Add {preemph,voltage}_max() vfuncs")
7801f3b792b0 ("drm/i915/display: prefer dig_port to reference intel_digital_port")
d1d08a4994a8 ("drm/i915: Fix cpt/ppt max pre-emphasis")
da882e6bb968 ("drm/i915: Fix ibx max vswing/preemph")v5.7.16: Failed to apply! Possible dependencies:
47bdb1caba0b ("drm/i915/ddi: use struct drm_device based logging")
589a4cd6cc43 ("drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belongs")
7801f3b792b0 ("drm/i915/display: prefer dig_port to reference intel_digital_port")
7c2fedd7608f ("drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook")
8b4f2137cc0f ("drm/i915/display/ddi: Prefer drm_WARN* over WARN*")
8fdda3854967 ("drm/i915: Introduce .set_idle_link_train() vfunc")
c38730987b4a ("drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point")
eed22a46b979 ("drm/i915: Pass encoder all the way to intel_ddi_transcoder_func_reg_val_get()")
eee3f91195ad ("drm/i915: Introduce .set_link_train() vfunc")
fb83f72c48a5 ("drm/i915: Introduce .set_signal_levels() vfunc")v5.4.59: Failed to apply! Possible dependencies:
0456417ef680 ("drm: Add for_each_oldnew_intel_crtc_in_state_reverse()")
0486513935ef ("drm/i915/dsi: take compression into account in afe_clk()")
1326a92c3466 ("drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.")
2225f3c6f1d7 ("drm/i915: Perform automated conversions for crtc uapi/hw split, base -> uapi.")
2b808b3a27d1 ("drm/i915: Add aliases for uapi and hw to crtc_state")
3e30d70805d5 ("drm/i915: Make .modeset_calc_cdclk() mandatory")
486bba4524e0 ("drm/i915/hdcp: Clean up local variables")
50003bf50d32 ("drm/i915/dsi: set pipe_bpp on ICL configure config")
54ed6902cabc ("drm/i915/dsi: abstract afe_clk calculation")
5d1db3f61aa9 ("drm/i915: Rename conn_to_dig_port() to intel_attached_dig_port()")
adf1bd3dfbae ("drm/i915/dsi: use afe_clk() instead of intel_dsi_bitrate()")
af9fbfa657c8 ("drm/i915: Introduce and use intel_atomic_crtc_state_for_each_plane_state.")
b7d02c3a124d ("drm/i915: Pass intel_encoder to enc_to_*()")
c47b7ddbcb29 ("drm/i915: Rename planar linked plane variables")
d06a79d33e0f ("drm/i915: Use enum pipe instead of crtc index to track active pipes")
fe4709a8d033 ("drm/i915: Extract intel_modeset_calc_cdclk()")v4.19.140: Failed to apply! Possible dependencies:
07d805721938 ("drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable")
2cd9a689e97b ("drm/i915: Refactor intel_display_set_init_power() logic")
486bba4524e0 ("drm/i915/hdcp: Clean up local variables")
48a287ed9d62 ("drm/i915: Rename intel_power_domains_fini() to intel_power_domains_fini_hw()")
49a630b00bac ("drm/i915: Enable and Disable of HDCP2.2")
6dfc4a8f134f ("drm/i915: Verify power domains after enabling them")
9055aac76589 ("drm/i915: MEI interface implementation")
bd780f37a361 ("drm/i915: Track all held rpm wakerefs")
f28ec6f4ea48 ("drm/i915: Constify power well descriptors")NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
Signature · 6 lines
Thanks Sasha _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 3/17 drm/i915: WARN if HDCP signalling is enabled upon disable
In reply to Sean PaulFrom: Sean Paul <[email protected]>
HDCP signalling should not be left on, WARN if it is
Changes in v2:
-Added to the set in lieu of just clearing the bit Changes in v3:
-None
Changes in v4:
-None
Changes in v5:
-Change WARN_ON to drm_WARN_ON
Changes in v6:
-None
Changes in v7:
-Rebased, variable name changed from 'ctl' to 'val' Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/intel_ddi.c +2 -0
@@ -1791,6 +1791,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state ctl =intel_de_read (dev_priv,TRANS_DDI_FUNC_CTL (cpu_transcoder)); +drm_WARN_ON (crtc->base.dev, ctl &TRANS_DDI_HDCP_SIGNALLING ); + ctl &= ~TRANS_DDI_FUNC_ENABLE ;if (IS_GEN_RANGE (dev_priv,8 ,10 ))
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 4/17 drm/i915: Intercept Aksv writes in the aux hooks
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook.
IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense.
However in testing an LG monitor on my desk, I noticed it was passing back a DEFER reply. This wasn't handled in our hand-rolled code and HDCP auth was failing as a result. Instead of copy/pasting all of the retry logic and delays from drm dp helpers, let's just use the helpers and hide the aksv select as best as we can.
Changes in v2:
-Remove 'generate' in intel_dp_aux_generate_xfer_flags, make arg const (Ville) -Bundle Aksv if statement together (Ville)
-Rename 'txbuf' to 'aksv' (Ville)
Changes in v3:
-None
Changes in v4:
-None
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_dp.c | 62 ++++++++++++------------- 1 file changed, 29 insertions(+), 33 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +29 -33
@@ -1563,6 +1563,20 @@ intel_dp_aux_header(u8 txbuf[HEADER_SIZE], txbuf[3 ] = msg->size -1 ; } +static u32 intel_dp_aux_xfer_flags (const struct drm_dp_aux_msg *msg) +{ +/* +* If we're trying to send the HDCP Aksv, we need to set a the Aksv +* select bit to inform the hardware to send the Aksv after our header +* since we can't access that data from software. +*/ +if ((msg->request & ~DP_AUX_I2C_MOT ) ==DP_AUX_NATIVE_WRITE && + msg->address ==DP_AUX_HDCP_AKSV ) +return DP_AUX_CH_CTL_AUX_AKSV_SELECT ; + +return 0 ; +} +static ssize_t intel_dp_aux_transfer (struct drm_dp_aux *aux,struct drm_dp_aux_msg *msg) {
@@ -1570,6 +1584,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)struct drm_i915_private *i915 =dp_to_i915 (intel_dp);u8 txbuf[20 ], rxbuf[20 ];size_t txsize, rxsize; +u32 flags =intel_dp_aux_xfer_flags (msg);int ret;intel_dp_aux_header (txbuf, msg);
@@ -1590,7 +1605,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)memcpy (txbuf +HEADER_SIZE , msg->buffer, msg->size); ret =intel_dp_aux_xfer (intel_dp, txbuf, txsize, - rxbuf, rxsize,0 ); + rxbuf, rxsize, flags);if (ret >0 ) { msg->reply = rxbuf[0 ] >>4 ;
@@ -1613,7 +1628,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)return -E2BIG ; ret =intel_dp_aux_xfer (intel_dp, txbuf, txsize, - rxbuf, rxsize,0 ); + rxbuf, rxsize, flags);if (ret >0 ) { msg->reply = rxbuf[0 ] >>4 ;/*
@@ -6403,15 +6418,8 @@ int intel_dp_hdcp_write_an_aksv(struct intel_digital_port *dig_port, u8 *an) {struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); -struct intel_dp *intel_dp =enc_to_intel_dp (to_intel_encoder (&dig_port->base.base)); -static const struct drm_dp_aux_msg msg = { - .request =DP_AUX_NATIVE_WRITE , - .address =DP_AUX_HDCP_AKSV , - .size =DRM_HDCP_KSV_LEN , - }; -u8 txbuf[HEADER_SIZE +DRM_HDCP_KSV_LEN ] = {}, rxbuf[2 ], reply =0 ; +u8 aksv[DRM_HDCP_KSV_LEN ] = {};ssize_t dpcd_ret; -int ret;/* Output An first, that's easy */ dpcd_ret = drm_dp_dpcd_write(&dig_port->dp.aux, DP_AUX_HDCP_AN,
@@ -6424,31 +6432,19 @@ int intel_dp_hdcp_write_an_aksv(struct intel_digital_port *dig_port, }/* -* Since Aksv is Oh-So-Secret, we can't access it in software. So in -* order to get it on the wire, we need to create the AUX header as if -* we were writing the data, and then tickle the hardware to output the -* data once the header is sent out. +* Since Aksv is Oh-So-Secret, we can't access it in software. So we +* send an empty buffer of the correct length through the DP helpers. On +* the other side, in the transfer hook, we'll generate a flag based on +* the destination address which will tickle the hardware to output the +* Aksv on our behalf after the header is sent. */ -intel_dp_aux_header (txbuf, &msg); - - ret =intel_dp_aux_xfer (intel_dp, txbuf,HEADER_SIZE + msg.size, - rxbuf,sizeof (rxbuf), -DP_AUX_CH_CTL_AUX_AKSV_SELECT ); -if (ret <0 ) { -drm_dbg_kms (&i915->drm, -"Write Aksv over DP/AUX failed (%d)\n" , ret); -return ret; - }else if (ret ==0 ) { -drm_dbg_kms (&i915->drm,"Aksv write over DP/AUX was empty\n" ); -return -EIO ; - } - - reply = (rxbuf[0 ] >>4 ) &DP_AUX_NATIVE_REPLY_MASK ; -if (reply !=DP_AUX_NATIVE_REPLY_ACK ) { + dpcd_ret =drm_dp_dpcd_write (&dig_port->dp.aux,DP_AUX_HDCP_AKSV , + aksv,DRM_HDCP_KSV_LEN ); +if (dpcd_ret !=DRM_HDCP_KSV_LEN ) {drm_dbg_kms (&i915->drm, -"Aksv write: no DP_AUX_NATIVE_REPLY_ACK %x\n" , - reply); -return -EIO ; +"Failed to write Aksv over DP/AUX (%zd)\n" , + dpcd_ret); +return dpcd_ret >=0 ? -EIO : dpcd_ret; }return 0 ; }
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 5/17 drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi.
This is particularly important for MST.
Changes in v2:
-Added to the set
Changes in v3:
-s/hdcp/hdmi/ in commit msg (Ram)
Changes in v4:
-Rebased on intel_de_(read|write) change
Changes in v5:
-Update hdcp->cpu_transcoder in intel_hdcp_enable so it works with pipe != 0 Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++---------- drivers/gpu/drm/i915/display/intel_ddi.h | 2 ++ .../gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_hdcp.c | 15 ++++++++------- drivers/gpu/drm/i915/display/intel_hdmi.c | 16 +++++++++++----- 6 files changed, 26 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +3 -10
@@ -1820,12 +1820,12 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state }int intel_ddi_toggle_hdcp_signalling (struct intel_encoder *intel_encoder, +enum transcoder cpu_transcoder,bool enable) {struct drm_device *dev = intel_encoder->base.dev;struct drm_i915_private *dev_priv =to_i915 (dev);intel_wakeref_t wakeref; -enum pipe pipe =0 ;int ret =0 ;u32 tmp;
@@ -1834,19 +1834,12 @@ int intel_ddi_toggle_hdcp_signalling(struct intel_encoder *intel_encoder,if (drm_WARN_ON (dev, !wakeref))return -ENXIO ; -if (drm_WARN_ON (dev, - !intel_encoder->get_hw_state (intel_encoder, &pipe))) { - ret = -EIO ; - goto out; - } - - tmp =intel_de_read (dev_priv,TRANS_DDI_FUNC_CTL (pipe)); + tmp =intel_de_read (dev_priv,TRANS_DDI_FUNC_CTL (cpu_transcoder));if (enable) tmp |=TRANS_DDI_HDCP_SIGNALLING ;else tmp &= ~TRANS_DDI_HDCP_SIGNALLING ; -intel_de_write (dev_priv,TRANS_DDI_FUNC_CTL (pipe), tmp); -out: +intel_de_write (dev_priv,TRANS_DDI_FUNC_CTL (cpu_transcoder), tmp);intel_display_power_put (dev_priv, intel_encoder->power_domain, wakeref);return ret; }
drivers/gpu/drm/i915/display/intel_ddi.h +2 -0
@@ -16,6 +16,7 @@ struct intel_crtc_state;struct intel_dp ;struct intel_dpll_hw_state ;struct intel_encoder ; +enum transcoder ; void intel_ddi_fdi_post_disable(struct intel_atomic_state *state, struct intel_encoder *intel_encoder,
@@ -43,6 +44,7 @@ void intel_ddi_compute_min_voltage_level(struct drm_i915_private *dev_priv,u32 bxt_signal_levels (struct intel_dp *intel_dp);u32 ddi_signal_levels (struct intel_dp *intel_dp);int intel_ddi_toggle_hdcp_signalling (struct intel_encoder *intel_encoder, +enum transcoder cpu_transcoder,bool enable);void icl_sanitize_encoder_pll_mapping (struct intel_encoder *encoder);
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -314,6 +314,7 @@ struct intel_hdcp_shim {/* Enables HDCP signalling on the port */ int (*toggle_signalling)(struct intel_digital_port *dig_port, +enum transcoder cpu_transcoder,bool enable);/* Ensures the link is still protected */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
@@ -6603,6 +6603,7 @@ int intel_dp_hdcp_read_v_prime_part(struct intel_digital_port *dig_port,static int intel_dp_hdcp_toggle_signalling (struct intel_digital_port *dig_port, +enum transcoder cpu_transcoder,bool enable) {/* Not used for single stream DisplayPort setups */
drivers/gpu/drm/i915/display/intel_hdcp.c +8 -7
@@ -713,7 +713,7 @@ static int intel_hdcp_auth(struct intel_connector *connector)intel_de_write (dev_priv,HDCP_REP_CTL ,intel_hdcp_get_repeater_ctl (dev_priv, cpu_transcoder, port)); - ret = shim->toggle_signalling (dig_port, true); + ret = shim->toggle_signalling (dig_port, cpu_transcoder, true);if (ret)return ret;
@@ -816,7 +816,7 @@ static int _intel_hdcp_disable(struct intel_connector *connector)intel_de_write (dev_priv,HDCP_REP_CTL ,intel_de_read (dev_priv,HDCP_REP_CTL ) & ~repeater_ctl); - ret = hdcp->shim->toggle_signalling (dig_port, false); + ret = hdcp->shim->toggle_signalling (dig_port, cpu_transcoder, false);if (ret) {drm_err (&dev_priv->drm,"Failed to disable HDCP signalling\n" );return ret;
@@ -1600,7 +1600,8 @@ static int hdcp2_enable_encryption(struct intel_connector *connector)intel_de_read (dev_priv,HDCP2_STATUS (dev_priv, cpu_transcoder, port)) & LINK_ENCRYPTION_STATUS);if (hdcp->shim->toggle_signalling) { - ret = hdcp->shim->toggle_signalling (dig_port, true); + ret = hdcp->shim->toggle_signalling (dig_port, cpu_transcoder, + true);if (ret) { drm_err(&dev_priv->drm, "Failed to enable HDCP signalling. %d\n",
@@ -1650,7 +1651,8 @@ static int hdcp2_disable_encryption(struct intel_connector *connector)drm_dbg_kms (&dev_priv->drm,"Disable Encryption Timedout" );if (hdcp->shim->toggle_signalling) { - ret = hdcp->shim->toggle_signalling (dig_port, false); + ret = hdcp->shim->toggle_signalling (dig_port, cpu_transcoder, + false);if (ret) { drm_err(&dev_priv->drm, "Failed to disable HDCP signalling. %d\n",
@@ -2036,11 +2038,10 @@ int intel_hdcp_enable(struct intel_connector *connector,drm_WARN_ON (&dev_priv->drm, hdcp->value ==DRM_MODE_CONTENT_PROTECTION_ENABLED ); hdcp->content_type = content_type; + hdcp->cpu_transcoder = cpu_transcoder; -if (INTEL_GEN (dev_priv) >=12 ) { - hdcp->cpu_transcoder = cpu_transcoder; +if (INTEL_GEN (dev_priv) >=12 ) hdcp->port_data.fw_tc =intel_get_mei_fw_tc (cpu_transcoder); - }/* * Considering that HDCP2.2 is more secure than HDCP1.4, If the setup
drivers/gpu/drm/i915/display/intel_hdmi.c +11 -5
@@ -1477,7 +1477,8 @@ int intel_hdmi_hdcp_read_v_prime_part(struct intel_digital_port *dig_port,return ret; } -static int kbl_repositioning_enc_en_signal (struct intel_connector *connector) +static int kbl_repositioning_enc_en_signal (struct intel_connector *connector, +enum transcoder cpu_transcoder) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);struct intel_digital_port *dig_port =intel_attached_dig_port (connector);
@@ -1494,13 +1495,15 @@ static int kbl_repositioning_enc_en_signal(struct intel_connector *connector)usleep_range (25 ,50 ); } - ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, false); + ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, cpu_transcoder, + false);if (ret) {drm_err (&dev_priv->drm,"Disable HDCP signalling failed (%d)\n" , ret);return ret; } - ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, true); + ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, cpu_transcoder, + true);if (ret) {drm_err (&dev_priv->drm,"Enable HDCP signalling failed (%d)\n" , ret);
@@ -1512,6 +1515,7 @@ static int kbl_repositioning_enc_en_signal(struct intel_connector *connector)static int intel_hdmi_hdcp_toggle_signalling (struct intel_digital_port *dig_port, +enum transcoder cpu_transcoder,bool enable) {struct intel_hdmi *hdmi = &dig_port->hdmi;
@@ -1522,7 +1526,8 @@ int intel_hdmi_hdcp_toggle_signalling(struct intel_digital_port *dig_port,if (!enable)usleep_range (6 ,60 );/* Bspec says >= 6us */ - ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, enable); + ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, cpu_transcoder, + enable);if (ret) {drm_err (&dev_priv->drm,"%s HDCP signalling failed (%d)\n" , enable ?"Enable" :"Disable" , ret);
@@ -1534,7 +1539,8 @@ int intel_hdmi_hdcp_toggle_signalling(struct intel_digital_port *dig_port,* opportunity and enc_en signalling in KABYLAKE. */ if (IS_KABYLAKE (dev_priv) && enable) -return kbl_repositioning_enc_en_signal (connector); +return kbl_repositioning_enc_en_signal (connector, + cpu_transcoder);return 0 ; }
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 6/17 drm/i915: Factor out hdcp->value assignments
In reply to Sean PaulFrom: Sean Paul <[email protected]>
This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us.
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-Rebased on top of drm_* logging changes
Changes in v5:
-Change WARN_ON to drm_WARN_ON
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 67 ++++++++++++++++------- 1 file changed, 46 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_hdcp.c +46 -21
@@ -876,6 +876,21 @@ static struct intel_connector *intel_hdcp_to_connector(struct intel_hdcp *hdcp) return container_of(hdcp, struct intel_connector, hdcp); } +static void intel_hdcp_update_value (struct intel_connector *connector, +u64 value,bool update_property) +{ +struct intel_hdcp *hdcp = &connector->hdcp; + +drm_WARN_ON (connector->base.dev, !mutex_is_locked (&hdcp->mutex)); + +if (hdcp->value == value) +return ; + + hdcp->value = value; +if (update_property) +schedule_work (&hdcp->prop_work); +} +/* Implements Part 3 of the HDCP authorization procedure */ static int intel_hdcp_check_link (struct intel_connector *connector) {
@@ -903,15 +918,16 @@ static int intel_hdcp_check_link(struct intel_connector *connector) connector->base.name, connector->base.base.id, intel_de_read(dev_priv, HDCP_STATUS(dev_priv, cpu_transcoder, port))); ret = -ENXIO ; - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , + true); goto out; }if (hdcp->shim->check_link (dig_port)) {if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { - hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_ENABLED , true); } goto out; }
@@ -923,16 +939,18 @@ static int intel_hdcp_check_link(struct intel_connector *connector) ret =_intel_hdcp_disable (connector);if (ret) {drm_err (&dev_priv->drm,"Failed to disable hdcp (%d)\n" , ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , + true); goto out; } ret =_intel_hdcp_enable (connector);if (ret) {drm_err (&dev_priv->drm,"Failed to enable hdcp (%d)\n" , ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , + true); goto out; }
@@ -1768,16 +1786,18 @@ static int intel_hdcp2_check_link(struct intel_connector *connector)"HDCP2.2 link stopped the encryption, %x\n" , intel_de_read(dev_priv, HDCP2_STATUS(dev_priv, cpu_transcoder, port))); ret = -ENXIO ; - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , + true); goto out; } ret = hdcp->shim->check_2_2_link (dig_port);if (ret ==HDCP_LINK_PROTECTED ) {if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { - hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_ENABLED , + true); } goto out; }
@@ -1790,8 +1810,9 @@ static int intel_hdcp2_check_link(struct intel_connector *connector) "HDCP2.2 Downstream topology change\n"); ret =hdcp2_authenticate_repeater_topology (connector);if (!ret) { - hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_ENABLED , + true); goto out; } drm_dbg_kms(&dev_priv->drm,
@@ -1809,8 +1830,8 @@ static int intel_hdcp2_check_link(struct intel_connector *connector)drm_err (&dev_priv->drm,"[%s:%d] Failed to disable hdcp2.2 (%d)\n" , connector->base.name, connector->base.base.id, ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , true); goto out; }
@@ -1820,8 +1841,9 @@ static int intel_hdcp2_check_link(struct intel_connector *connector)"[%s:%d] Failed to enable hdcp2.2 (%d)\n" , connector->base.name, connector->base.base.id, ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_DESIRED , + true); goto out; }
@@ -2064,8 +2086,9 @@ int intel_hdcp_enable(struct intel_connector *connector,if (!ret) {schedule_delayed_work (&hdcp->check_work, check_link_interval); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; -schedule_work (&hdcp->prop_work); +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_ENABLED , + true); }mutex_unlock (&hdcp->mutex);
@@ -2083,7 +2106,9 @@ int intel_hdcp_disable(struct intel_connector *connector)mutex_lock (&hdcp->mutex);if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { - hdcp->value =DRM_MODE_CONTENT_PROTECTION_UNDESIRED ; +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_UNDESIRED , + false);if (hdcp->hdcp2_encrypted) ret =_intel_hdcp2_disable (connector);else if (hdcp->hdcp_encrypted)
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 7/17 drm/i915: Protect workers against disappearing connectors
In reply to Sean PaulFrom: Sean Paul <[email protected]>
This patch adds some protection against connectors being destroyed before the HDCP workers are finished.
For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction.
In the case of prop_work, we can't do a synchronous wait since it needs to take connection_mutex which could cause deadlock. Instead, we'll take a reference on the connector when scheduling prop_work and give it up once we're done.
Changes in v2:
-Added to the set
Changes in v3:
-Change the WARN_ON condition in intel_hdcp_cleanup to allow for
initializing connectors as well
Changes in v4:
-None
Changes in v5:
-Change WARN_ON to drm_WARN_ON
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 44 ++++++++++++++++++++--- 1 file changed, 39 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_hdcp.c +39 -5
@@ -887,8 +887,10 @@ static void intel_hdcp_update_value(struct intel_connector *connector,return ; hdcp->value = value; -if (update_property) +if (update_property) { +drm_connector_get (&connector->base);schedule_work (&hdcp->prop_work); + } }/* Implements Part 3 of the HDCP authorization procedure */
@@ -980,6 +982,8 @@ static void intel_hdcp_prop_work(struct work_struct *work)mutex_unlock (&hdcp->mutex);drm_modeset_unlock (&dev_priv->drm.mode_config.connection_mutex); + +drm_connector_put (&connector->base); }bool is_hdcp_supported (struct drm_i915_private *dev_priv,enum port port)
@@ -1859,6 +1863,9 @@ static void intel_hdcp_check_work(struct work_struct *work) check_work);struct intel_connector *connector =intel_hdcp_to_connector (hdcp); +if (drm_connector_is_unregistered (&connector->base)) +return ; +if (!intel_hdcp2_check_link (connector))schedule_delayed_work (&hdcp->check_work,DRM_HDCP2_CHECK_PERIOD_MS );
@@ -2185,12 +2192,39 @@ void intel_hdcp_component_fini(struct drm_i915_private *dev_priv)void intel_hdcp_cleanup (struct intel_connector *connector) { -if (!connector->hdcp.shim) +struct intel_hdcp *hdcp = &connector->hdcp; + +if (!hdcp->shim)return ; -mutex_lock (&connector->hdcp.mutex); -kfree (connector->hdcp.port_data.streams); -mutex_unlock (&connector->hdcp.mutex); +/* +* If the connector is registered, it's possible userspace could kick +* off another HDCP enable, which would re-spawn the workers. +*/ +drm_WARN_ON (connector->base.dev, + connector->base.registration_state ==DRM_CONNECTOR_REGISTERED ); + +/* +* Now that the connector is not registered, check_work won't be run, +* but cancel any outstanding instances of it +*/ +cancel_delayed_work_sync (&hdcp->check_work); + +/* +* We don't cancel prop_work in the same way as check_work since it +* requires connection_mutex which could be held while calling this +* function. Instead, we rely on the connector references grabbed before +* scheduling prop_work to ensure the connector is alive when prop_work +* is run. So if we're in the destroy path (which is where this +* function should be called), we're "guaranteed" that prop_work is not +* active (tl;dr This Should Never Happen). +*/ +drm_WARN_ON (connector->base.dev,work_pending (&hdcp->prop_work)); + +mutex_lock (&hdcp->mutex); +kfree (hdcp->port_data.streams); + hdcp->shim =NULL ; +mutex_unlock (&hdcp->mutex); } void intel_hdcp_atomic_check(struct drm_connector *connector,
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 8/17 drm/i915: Clean up intel_hdcp_disable
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Add an out label and un-indent hdcp disable in preparation for hdcp_mutex. No functional changes
Changes in v7:
-Split into separate patch (Ramalingam)
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_hdcp.c +10 -9
@@ -2112,16 +2112,17 @@ int intel_hdcp_disable(struct intel_connector *connector)mutex_lock (&hdcp->mutex); -if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { -intel_hdcp_update_value (connector, -DRM_MODE_CONTENT_PROTECTION_UNDESIRED , - false); -if (hdcp->hdcp2_encrypted) - ret =_intel_hdcp2_disable (connector); -else if (hdcp->hdcp_encrypted) - ret =_intel_hdcp_disable (connector); - } +if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) + goto out; +intel_hdcp_update_value (connector, +DRM_MODE_CONTENT_PROTECTION_UNDESIRED , false); +if (hdcp->hdcp2_encrypted) + ret =_intel_hdcp2_disable (connector); +else if (hdcp->hdcp_encrypted) + ret =_intel_hdcp_disable (connector); + +out:mutex_unlock (&hdcp->mutex);cancel_delayed_work_sync (&hdcp->check_work);return ret;
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 9/17 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it
In reply to Sean PaulFrom: Sean Paul <[email protected]>
This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP will also bring down HDCP on the port.
In order to achieve this, we need to keep a refcount in intel_digital_port and protect it using a new hdcp_mutex.
Changes in v2:
-Move the toggle_signalling call into _intel_hdcp_disable so it's called from check_work Changes in v3:
-None
Changes in v4:
-None
Changes in v5:
-Change WARN_ON to drm_WARN_ON
Changes in v6:
-None
Changes in v7:
-Split minor intel_hdcp_disable refactor into separate patch (Ramalingam) Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++ .../drm/i915/display/intel_display_types.h | 5 +++ drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_hdcp.c | 33 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_hdmi.c | 2 ++ 5 files changed, 45 insertions(+)
drivers/gpu/drm/i915/display/intel_ddi.c +3 -0
@@ -4996,6 +4996,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)drm_encoder_init (&dev_priv->drm, &encoder->base, &intel_ddi_funcs,DRM_MODE_ENCODER_TMDS ,"DDI %c" ,port_name (port)); +mutex_init (&dig_port->hdcp_mutex); + dig_port->num_hdcp_streams =0 ; + encoder->hotplug = intel_ddi_hotplug; encoder->compute_output_type = intel_ddi_compute_output_type; encoder->compute_config = intel_ddi_compute_config;
drivers/gpu/drm/i915/display/intel_display_types.h +5 -0
@@ -1416,6 +1416,11 @@ struct intel_digital_port {enum phy_fia tc_phy_fia;u8 tc_phy_fia_idx; +/* protects num_hdcp_streams reference count */ +struct mutex hdcp_mutex; +/* the number of pipes using HDCP signalling out of this port */ +unsigned int num_hdcp_streams; + void (*write_infoframe)(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state, unsigned int type,
drivers/gpu/drm/i915/display/intel_dp.c +2 -0
@@ -8285,6 +8285,8 @@ bool intel_dp_init(struct drm_i915_private *dev_priv, intel_encoder = &dig_port->base; encoder = &intel_encoder->base; +mutex_init (&dig_port->hdcp_mutex); +if (drm_encoder_init (&dev_priv->drm, &intel_encoder->base, &intel_dp_enc_funcs,DRM_MODE_ENCODER_TMDS ,"DP %c" ,port_name (port)))
drivers/gpu/drm/i915/display/intel_hdcp.c +33 -0
@@ -801,6 +801,19 @@ static int _intel_hdcp_disable(struct intel_connector *connector)drm_dbg_kms (&dev_priv->drm,"[%s:%d] HDCP is being disabled...\n" , connector->base.name, connector->base.base.id); +/* +* If there are other connectors on this port using HDCP, don't disable +* it. Instead, toggle the HDCP signalling off on that particular +* connector/pipe and exit. +*/ +if (dig_port->num_hdcp_streams >0 ) { + ret = hdcp->shim->toggle_signalling (dig_port, + cpu_transcoder, false); +if (ret) +DRM_ERROR ("Failed to disable HDCP signalling\n" ); +return ret; + } + hdcp->hdcp_encrypted = false;intel_de_write (dev_priv,HDCP_CONF (dev_priv, cpu_transcoder, port),0 ); if (intel_de_wait_for_clear(dev_priv,
@@ -879,6 +892,8 @@ static struct intel_connector *intel_hdcp_to_connector(struct intel_hdcp *hdcp)static void intel_hdcp_update_value (struct intel_connector *connector,u64 value,bool update_property) { +struct drm_device *dev = connector->base.dev; +struct intel_digital_port *dig_port =intel_attached_dig_port (connector);struct intel_hdcp *hdcp = &connector->hdcp;drm_WARN_ON (connector->base.dev, !mutex_is_locked (&hdcp->mutex));
@@ -886,6 +901,15 @@ static void intel_hdcp_update_value(struct intel_connector *connector,if (hdcp->value == value)return ; +drm_WARN_ON (dev, !mutex_is_locked (&dig_port->hdcp_mutex)); + +if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_ENABLED ) { +if (!drm_WARN_ON (dev, dig_port->num_hdcp_streams ==0 )) + dig_port->num_hdcp_streams--; + }else if (value ==DRM_MODE_CONTENT_PROTECTION_ENABLED ) { + dig_port->num_hdcp_streams++; + } + hdcp->value = value;if (update_property) {drm_connector_get (&connector->base);
@@ -904,6 +928,8 @@ static int intel_hdcp_check_link(struct intel_connector *connector)int ret =0 ;mutex_lock (&hdcp->mutex); +mutex_lock (&dig_port->hdcp_mutex); + cpu_transcoder = hdcp->cpu_transcoder;/* Check_link valid only when HDCP1.4 is enabled */
@@ -957,6 +983,7 @@ static int intel_hdcp_check_link(struct intel_connector *connector) } out: +mutex_unlock (&dig_port->hdcp_mutex);mutex_unlock (&hdcp->mutex);return ret; }
@@ -2056,6 +2083,7 @@ int intel_hdcp_enable(struct intel_connector *connector, enum transcoder cpu_transcoder, u8 content_type) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); +struct intel_digital_port *dig_port =intel_attached_dig_port (connector);struct intel_hdcp *hdcp = &connector->hdcp;unsigned long check_link_interval =DRM_HDCP_CHECK_PERIOD_MS ;int ret = -EINVAL ;
@@ -2064,6 +2092,7 @@ int intel_hdcp_enable(struct intel_connector *connector,return -ENOENT ;mutex_lock (&hdcp->mutex); +mutex_lock (&dig_port->hdcp_mutex);drm_WARN_ON (&dev_priv->drm, hdcp->value ==DRM_MODE_CONTENT_PROTECTION_ENABLED ); hdcp->content_type = content_type;
@@ -2098,12 +2127,14 @@ int intel_hdcp_enable(struct intel_connector *connector, true); } +mutex_unlock (&dig_port->hdcp_mutex);mutex_unlock (&hdcp->mutex);return ret; }int intel_hdcp_disable (struct intel_connector *connector) { +struct intel_digital_port *dig_port =intel_attached_dig_port (connector);struct intel_hdcp *hdcp = &connector->hdcp;int ret =0 ;
@@ -2111,6 +2142,7 @@ int intel_hdcp_disable(struct intel_connector *connector)return -ENOENT ;mutex_lock (&hdcp->mutex); +mutex_lock (&dig_port->hdcp_mutex);if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) goto out;
@@ -2123,6 +2155,7 @@ int intel_hdcp_disable(struct intel_connector *connector) ret =_intel_hdcp_disable (connector); out: +mutex_unlock (&dig_port->hdcp_mutex);mutex_unlock (&hdcp->mutex);cancel_delayed_work_sync (&hdcp->check_work);return ret;
drivers/gpu/drm/i915/display/intel_hdmi.c +2 -0
@@ -3341,6 +3341,8 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv, intel_encoder = &dig_port->base; +mutex_init (&dig_port->hdcp_mutex); +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, &intel_hdmi_enc_funcs,DRM_MODE_ENCODER_TMDS ,"HDMI %c" ,port_name (port));
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 10/17 drm/i915: Support DP MST in enc_to_dig_port() function
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders.
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- .../drm/i915/display/intel_display_types.h | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +14 -7
@@ -1531,6 +1531,18 @@ static inline bool intel_encoder_is_dig_port(struct intel_encoder *encoder) } } +static inline bool intel_encoder_is_mst (struct intel_encoder *encoder) +{ +return encoder->type ==INTEL_OUTPUT_DP_MST ; +} + +static inline struct intel_dp_mst_encoder * +enc_to_mst (struct intel_encoder *encoder) +{ + return container_of(&encoder->base, struct intel_dp_mst_encoder, + base.base); +} +static inline struct intel_digital_port *enc_to_dig_port (struct intel_encoder *encoder) {
@@ -1539,6 +1551,8 @@ enc_to_dig_port(struct intel_encoder *encoder)if (intel_encoder_is_dig_port (intel_encoder)) return container_of(&encoder->base, struct intel_digital_port, base.base); +else if (intel_encoder_is_mst (intel_encoder)) +return enc_to_mst (encoder)->primary;else return NULL ; }
@@ -1549,13 +1563,6 @@ intel_attached_dig_port(struct intel_connector *connector)return enc_to_dig_port (intel_attached_encoder (connector)); } -static inline struct intel_dp_mst_encoder * -enc_to_mst (struct intel_encoder *encoder) -{ - return container_of(&encoder->base, struct intel_dp_mst_encoder, - base.base); -} -static inline struct intel_dp *enc_to_intel_dp (struct intel_encoder *encoder) {return &enc_to_dig_port (encoder)->dp;
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 11/17 drm/i915: Use ddi_update_pipe in intel_dp_mst
In reply to Sean PaulFrom: Sean Paul <[email protected]>
In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++++----- drivers/gpu/drm/i915/display/intel_dp.h | 6 ++++++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 + 3 files changed, 13 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +6 -5
@@ -4012,13 +4012,14 @@ static void intel_ddi_update_pipe_dp(struct intel_atomic_state *state,intel_panel_update_backlight (state, encoder, crtc_state, conn_state); } -static void intel_ddi_update_pipe (struct intel_atomic_state *state, -struct intel_encoder *encoder, -const struct intel_crtc_state *crtc_state, -const struct drm_connector_state *conn_state) +void intel_ddi_update_pipe (struct intel_atomic_state *state, +struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +const struct drm_connector_state *conn_state) { -if (!intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI )) +if (!intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI ) && + !intel_encoder_is_mst (encoder))intel_ddi_update_pipe_dp (state, encoder, crtc_state, conn_state);
drivers/gpu/drm/i915/display/intel_dp.h +6 -0
@@ -17,6 +17,7 @@ struct drm_encoder;struct drm_i915_private ;struct drm_modeset_acquire_ctx ;struct drm_dp_vsc_sdp ; +struct intel_atomic_state ;struct intel_connector ;struct intel_crtc_state ;struct intel_digital_port ;
@@ -128,4 +129,9 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count)u32 intel_dp_mode_to_fec_clock (u32 mode_clock); +void intel_ddi_update_pipe (struct intel_atomic_state *state, +struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +const struct drm_connector_state *conn_state); +#endif /* __INTEL_DP_H__ */
drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -0
@@ -865,6 +865,7 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe intel_encoder->compute_config_late = intel_dp_mst_compute_config_late; intel_encoder->disable = intel_mst_disable_dp; intel_encoder->post_disable = intel_mst_post_disable_dp; + intel_encoder->update_pipe = intel_ddi_update_pipe; intel_encoder->pre_pll_enable = intel_mst_pre_pll_enable_dp; intel_encoder->pre_enable = intel_mst_pre_enable_dp; intel_encoder->enable = intel_mst_enable_dp;
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 12/17 drm/i915: Factor out HDCP shim functions from dp for use by dp_mst
In reply to Sean PaulFrom: Sean Paul <[email protected]>
These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use.
Changes in v2:
-None
Changes in v3:
-Created intel_dp_hdcp.c for the shared functions to live (Ville) Changes in v4:
-Rebased on new drm logging change
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-Rebased patch
Changes in v8:
-None
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 607 +----------------- drivers/gpu/drm/i915/display/intel_dp.h | 3 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 637 +++++++++++++++++++ 4 files changed, 642 insertions(+), 606 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dp_hdcp.c
drivers/gpu/drm/i915/Makefile +1 -0
@@ -234,6 +234,7 @@ i915-y += \ display/intel_ddi.o \ display/intel_dp.o \ display/intel_dp_aux_backlight.o \ + display/intel_dp_hdcp.o \ display/intel_dp_link_training.o \ display/intel_dp_mst.o \ display/intel_dsi.o \
drivers/gpu/drm/i915/display/intel_dp.c +1 -606
625 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp.h +3 -0
@@ -134,4 +134,7 @@ void intel_ddi_update_pipe(struct intel_atomic_state *state,const struct intel_crtc_state *crtc_state, const struct drm_connector_state *conn_state); +int intel_dp_init_hdcp (struct intel_digital_port *dig_port, +struct intel_connector *intel_connector); +#endif /* __INTEL_DP_H__ */
drivers/gpu/drm/i915/display/intel_dp_hdcp.c new file +637 -0
637 lines not on this page · raw message
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 13/17 drm/i915: Plumb port through hdcp init
In reply to Sean PaulFrom: Sean Paul <[email protected]>
This patch plumbs port through hdcp init instead of relying on intel_attached_encoder() to return a non-NULL encoder which won't work for MST connectors.
Changes in v5:
-Added to the set
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 11 ++++++----- drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 4 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_hdcp.c +2 -1
@@ -631,7 +631,8 @@ int intel_dp_init_hdcp(struct intel_digital_port *dig_port,return 0 ;if (!intel_dp_is_edp (intel_dp)) -return intel_hdcp_init (intel_connector, &intel_dp_hdcp_shim); +return intel_hdcp_init (intel_connector, port, + &intel_dp_hdcp_shim);return 0 ; }
drivers/gpu/drm/i915/display/intel_hdcp.c +6 -5
@@ -1954,6 +1954,7 @@ static enum mei_fw_tc intel_get_mei_fw_tc(enum transcoder cpu_transcoder) }static int initialize_hdcp_port_data (struct intel_connector *connector, +enum port port,const struct intel_hdcp_shim *shim) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);
@@ -1961,8 +1962,7 @@ static int initialize_hdcp_port_data(struct intel_connector *connector,struct hdcp_port_data *data = &hdcp->port_data;if (INTEL_GEN (dev_priv) <12 ) - data->fw_ddi = -intel_get_mei_fw_ddi_index (intel_attached_encoder (connector)->port); + data->fw_ddi =intel_get_mei_fw_ddi_index (port);else /* * As per ME FW API expectation, for GEN 12+, fw_ddi is filled
@@ -2032,14 +2032,14 @@ void intel_hdcp_component_init(struct drm_i915_private *dev_priv) } } -static void intel_hdcp2_init (struct intel_connector *connector, +static void intel_hdcp2_init (struct intel_connector *connector,enum port port,const struct intel_hdcp_shim *shim) {struct drm_i915_private *i915 =to_i915 (connector->base.dev);struct intel_hdcp *hdcp = &connector->hdcp;int ret; - ret =initialize_hdcp_port_data (connector, shim); + ret =initialize_hdcp_port_data (connector, port, shim);if (ret) {drm_dbg_kms (&i915->drm,"Mei hdcp data init failed\n" );return ;
@@ -2049,6 +2049,7 @@ static void intel_hdcp2_init(struct intel_connector *connector, }int intel_hdcp_init (struct intel_connector *connector, +enum port port,const struct intel_hdcp_shim *shim) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);
@@ -2059,7 +2060,7 @@ int intel_hdcp_init(struct intel_connector *connector,return -EINVAL ;if (is_hdcp2_supported (dev_priv)) -intel_hdcp2_init (connector, shim); +intel_hdcp2_init (connector, port, shim); ret = drm_connector_attach_content_protection_property(&connector->base,
drivers/gpu/drm/i915/display/intel_hdcp.h +1 -1
@@ -22,7 +22,7 @@ enum transcoder;void intel_hdcp_atomic_check (struct drm_connector *connector,struct drm_connector_state *old_state,struct drm_connector_state *new_state); -int intel_hdcp_init (struct intel_connector *connector, +int intel_hdcp_init (struct intel_connector *connector,enum port port,const struct intel_hdcp_shim *hdcp_shim);int intel_hdcp_enable (struct intel_connector *connector,enum transcoder cpu_transcoder,u8 content_type);
drivers/gpu/drm/i915/display/intel_hdmi.c +1 -1
@@ -3270,7 +3270,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port, intel_hdmi->attached_connector = intel_connector;if (is_hdcp_supported (dev_priv, port)) { -int ret =intel_hdcp_init (intel_connector, +int ret =intel_hdcp_init (intel_connector, port, &intel_hdmi_hdcp_shim);if (ret) drm_dbg_kms(&dev_priv->drm,
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 14/17 drm/i915: Add connector to hdcp_shim->check_link()
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it.
Changes in v4:
-Added to the set
Changes in v5:
-None
Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +++++----- 4 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +2 -1
@@ -318,7 +318,8 @@ struct intel_hdcp_shim { bool enable);/* Ensures the link is still protected */ -bool (*check_link)(struct intel_digital_port *dig_port); +bool (*check_link)(struct intel_digital_port *dig_port, +struct intel_connector *connector);/* Detects panel's hdcp capability. This is optional for HDMI. */ int (*hdcp_capable)(struct intel_digital_port *dig_port,
drivers/gpu/drm/i915/display/intel_dp_hdcp.c +2 -1
@@ -224,7 +224,8 @@ int intel_dp_hdcp_toggle_signalling(struct intel_digital_port *dig_port, }static -bool intel_dp_hdcp_check_link (struct intel_digital_port *dig_port) +bool intel_dp_hdcp_check_link (struct intel_digital_port *dig_port, +struct intel_connector *connector) {struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev);ssize_t ret;
drivers/gpu/drm/i915/display/intel_hdcp.c +1 -1
@@ -952,7 +952,7 @@ static int intel_hdcp_check_link(struct intel_connector *connector) goto out; } -if (hdcp->shim->check_link (dig_port)) { +if (hdcp->shim->check_link (dig_port, connector)) {if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) {intel_hdcp_update_value (connector,DRM_MODE_CONTENT_PROTECTION_ENABLED , true);
drivers/gpu/drm/i915/display/intel_hdmi.c +5 -5
@@ -1546,11 +1546,10 @@ int intel_hdmi_hdcp_toggle_signalling(struct intel_digital_port *dig_port, }static -bool intel_hdmi_hdcp_check_link_once (struct intel_digital_port *dig_port) +bool intel_hdmi_hdcp_check_link_once (struct intel_digital_port *dig_port, +struct intel_connector *connector) {struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); -struct intel_connector *connector = - dig_port->hdmi.attached_connector;enum port port = dig_port->base.port;enum transcoder cpu_transcoder = connector->hdcp.cpu_transcoder;int ret;
@@ -1578,13 +1577,14 @@ bool intel_hdmi_hdcp_check_link_once(struct intel_digital_port *dig_port) }static -bool intel_hdmi_hdcp_check_link (struct intel_digital_port *dig_port) +bool intel_hdmi_hdcp_check_link (struct intel_digital_port *dig_port, +struct intel_connector *connector) {struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev);int retry;for (retry =0 ; retry <3 ; retry++) -if (intel_hdmi_hdcp_check_link_once (dig_port)) +if (intel_hdmi_hdcp_check_link_once (dig_port, connector))return true;drm_err (&i915->drm,"Link check failed\n" );
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 15/17 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Used to query whether an MST stream is encrypted or not.
Changes in v4:
-Added to the set
Changes in v5:
-None
Changes in v6:
-Use FIELD_PREP to generate request buffer bitfields (Lyude) -Add mst selftest and dump/decode_sideband_req for QSES (Lyude) Changes in v7:
-None
Changes in v8:
-Reverse the parsing on the hdcp_*x_device_present bits and leave
breadcrumb in case this is incorrect (Anshuman)
--- drivers/gpu/drm/drm_dp_mst_topology.c | 150 ++++++++++++++++++ .../drm/selftests/test-drm_dp_mst_helper.c | 17 ++ include/drm/drm_dp_helper.h | 3 + include/drm/drm_dp_mst_helper.h | 44 +++++ 4 files changed, 214 insertions(+)
drivers/gpu/drm/drm_dp_mst_topology.c +150 -0
@@ -20,11 +20,13 @@* OF THIS SOFTWARE. */ +#include <linux/bitfield.h> #include <linux/delay.h> #include <linux/errno.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/random.h> #include <linux/sched.h> #include <linux/seq_file.h> #include <linux/iopoll.h>
@@ -423,6 +425,22 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_write.bytes, req->u.i2c_write.num_bytes); idx += req->u.i2c_write.num_bytes;break ; +case DP_QUERY_STREAM_ENC_STATUS : { +const struct drm_dp_query_stream_enc_status *msg; + + msg = &req->u.enc_status; + buf[idx] = msg->stream_id; + idx++; +memcpy (&buf[idx], msg->client_id,sizeof (msg->client_id)); + idx +=sizeof (msg->client_id); + buf[idx] =0 ; + buf[idx] |=FIELD_PREP (GENMASK (1 ,0 ), msg->stream_event); + buf[idx] |= msg->valid_stream_event ?BIT (2 ) :0 ; + buf[idx] |=FIELD_PREP (GENMASK (4 ,3 ), msg->stream_behavior); + buf[idx] |= msg->valid_stream_behavior ?BIT (5 ) :0 ; + idx++; + } +break ; } raw->cur_len = idx; }
@@ -551,6 +569,20 @@ drm_dp_decode_sideband_req(const struct drm_dp_sideband_msg_tx *raw,return -ENOMEM ; }break ; +case DP_QUERY_STREAM_ENC_STATUS : + req->u.enc_status.stream_id = buf[idx++]; +for (i =0 ; i <sizeof (req->u.enc_status.client_id); i++) + req->u.enc_status.client_id[i] = buf[idx++]; + + req->u.enc_status.stream_event =FIELD_GET (GENMASK (1 ,0 ), + buf[idx]); + req->u.enc_status.valid_stream_event =FIELD_GET (BIT (2 ), + buf[idx]); + req->u.enc_status.stream_behavior =FIELD_GET (GENMASK (4 ,3 ), + buf[idx]); + req->u.enc_status.valid_stream_behavior =FIELD_GET (BIT (5 ), + buf[idx]); +break ; }return 0 ;
@@ -629,6 +661,16 @@ drm_dp_dump_sideband_msg_req_body(const struct drm_dp_sideband_msg_req_body *req req->u.i2c_write.num_bytes, req->u.i2c_write.num_bytes, req->u.i2c_write.bytes);break ; +case DP_QUERY_STREAM_ENC_STATUS : +P ("stream_id=%u client_id=%*ph stream_event=%x " +"valid_event=%d stream_behavior=%x valid_behavior=%d" , + req->u.enc_status.stream_id, + (int )ARRAY_SIZE (req->u.enc_status.client_id), + req->u.enc_status.client_id, req->u.enc_status.stream_event, + req->u.enc_status.valid_stream_event, + req->u.enc_status.stream_behavior, + req->u.enc_status.valid_stream_behavior); +break ;default :P ("???\n" );break ;
@@ -936,6 +978,42 @@ static bool drm_dp_sideband_parse_power_updown_phy_ack(struct drm_dp_sideband_msreturn true; } +static bool +drm_dp_sideband_parse_query_stream_enc_status ( +struct drm_dp_sideband_msg_rx *raw, +struct drm_dp_sideband_msg_reply_body *repmsg) +{ +struct drm_dp_query_stream_enc_status_ack_reply *reply; + + reply = &repmsg->u.enc_status; + + reply->stream_id = raw->msg[3 ]; + + reply->reply_signed = raw->msg[2 ] &BIT (0 ); + +/* +* NOTE: It's my impression from reading the spec that the below parsing +* is correct. However I noticed while testing with an HDCP 1.4 display +* through an HDCP 2.2 hub that only bit 3 was set. In that case, I +* would expect both bits to be set. So keep the parsing following the +* spec, but beware reality might not match the spec (at least for some +* configurations). +*/ + reply->hdcp_1x_device_present = raw->msg[2 ] &BIT (4 ); + reply->hdcp_2x_device_present = raw->msg[2 ] &BIT (3 ); + + reply->query_capable_device_present = raw->msg[2 ] &BIT (5 ); + reply->legacy_device_present = raw->msg[2 ] &BIT (6 ); + reply->unauthorizable_device_present = raw->msg[2 ] &BIT (7 ); + + reply->auth_completed = !!(raw->msg[1 ] &BIT (3 )); + reply->encryption_enabled = !!(raw->msg[1 ] &BIT (4 )); + reply->repeater_present = !!(raw->msg[1 ] &BIT (5 )); + reply->state = (raw->msg[1 ] &GENMASK (7 ,6 )) >>6 ; + +return true; +} +static bool drm_dp_sideband_parse_reply (struct drm_dp_sideband_msg_rx *raw,struct drm_dp_sideband_msg_reply_body *msg) {
@@ -970,6 +1048,8 @@ static bool drm_dp_sideband_parse_reply(struct drm_dp_sideband_msg_rx *raw,return drm_dp_sideband_parse_power_updown_phy_ack (raw, msg);case DP_CLEAR_PAYLOAD_ID_TABLE :return true;/* since there's nothing to parse */ +case DP_QUERY_STREAM_ENC_STATUS : +return drm_dp_sideband_parse_query_stream_enc_status (raw, msg);default :DRM_ERROR ("Got unknown reply 0x%02x (%s)\n" , msg->req_type,drm_dp_mst_req_type_str (msg->req_type));
@@ -1121,6 +1201,25 @@ static void build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, msg->path_msg = true; } +static int +build_query_stream_enc_status (struct drm_dp_sideband_msg_tx *msg,u8 stream_id, +u8 *q_id) +{ +struct drm_dp_sideband_msg_req_body req; + + req.req_type =DP_QUERY_STREAM_ENC_STATUS ; + req.u.enc_status.stream_id = stream_id; +memcpy (req.u.enc_status.client_id, q_id, +sizeof (req.u.enc_status.client_id)); + req.u.enc_status.stream_event =0 ; + req.u.enc_status.valid_stream_event = false; + req.u.enc_status.stream_behavior =0 ; + req.u.enc_status.valid_stream_behavior = false; + +drm_dp_encode_sideband_req (&req, msg); +return 0 ; +} +static int drm_dp_mst_assign_payload_id (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_vcpi *vcpi) {
@@ -3153,6 +3252,57 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, }EXPORT_SYMBOL (drm_dp_send_power_updown_phy); +int drm_dp_send_query_stream_enc_status (struct drm_dp_mst_topology_mgr *mgr, +struct drm_dp_mst_port *port, +struct drm_dp_query_stream_enc_status_ack_reply *status) +{ +struct drm_dp_sideband_msg_tx *txmsg; +u8 nonce[7 ]; +int len, ret; + + txmsg =kzalloc (sizeof (*txmsg),GFP_KERNEL ); +if (!txmsg) +return -ENOMEM ; + + port =drm_dp_mst_topology_get_port_validated (mgr, port); +if (!port) { + ret = -EINVAL ; + goto out_get_port; + } + +get_random_bytes (nonce,sizeof (nonce)); + +/* +* "Source device targets the QUERY_STREAM_ENCRYPTION_STATUS message +* transaction at the MST Branch device directly connected to the +* Source" +*/ + txmsg->dst = mgr->mst_primary; + + len =build_query_stream_enc_status (txmsg, port->vcpi.vcpi, nonce); + +drm_dp_queue_down_tx (mgr, txmsg); + + ret =drm_dp_mst_wait_tx_reply (mgr->mst_primary, txmsg); +if (ret <0 ) { + goto out; + }else if (txmsg->reply.reply_type ==DP_SIDEBAND_REPLY_NAK ) { +DRM_DEBUG_KMS ("query encryption status nak received\n" ); + ret = -ENXIO ; + goto out; + } + + ret =0 ; +memcpy (status, &txmsg->reply.u.enc_status,sizeof (*status)); + +out: +drm_dp_mst_topology_put_port (port); +out_get_port: +kfree (txmsg); +return ret; +} +EXPORT_SYMBOL (drm_dp_send_query_stream_enc_status); +static int drm_dp_create_payload_step1 (struct drm_dp_mst_topology_mgr *mgr,int id,struct drm_dp_payload *payload)
drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +17 -0
@@ -5,6 +5,8 @@#define PREFIX_STR "[drm_dp_mst_helper]" +#include <linux/random.h> +#include <drm/drm_dp_mst_helper.h> #include <drm/drm_print.h>
@@ -237,6 +239,21 @@ int igt_dp_mst_sideband_msg_req_decode(void *unused) in.u.i2c_write.bytes = data;DO_TEST (); + in.req_type =DP_QUERY_STREAM_ENC_STATUS ; + in.u.enc_status.stream_id =1 ; +DO_TEST (); +get_random_bytes (in.u.enc_status.client_id, +sizeof (in.u.enc_status.client_id)); +DO_TEST (); + in.u.enc_status.stream_event =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_event =0 ; +DO_TEST (); + in.u.enc_status.stream_behavior =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_behavior =1 ; +DO_TEST (); +#undef DO_TESTreturn 0 ; }
include/drm/drm_dp_helper.h +3 -0
@@ -1109,6 +1109,9 @@#define DP_POWER_DOWN_PHY 0x25#define DP_SINK_EVENT_NOTIFY 0x30#define DP_QUERY_STREAM_ENC_STATUS 0x38 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_NO_EXIST 0 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_INACTIVE 1 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_ACTIVE 2/* DP 1.2 MST sideband reply types */ #define DP_SIDEBAND_REPLY_ACK 0x00
include/drm/drm_dp_mst_helper.h +44 -0
74 lines not on this page · raw message
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v8 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message
Just one small comment
Quoted 238 lines · Sean Paul
From: Sean Paul <[email protected]>
Used to query whether an MST stream is encrypted or not.
Cc Lyude Paul <[email protected]>Reviewed-by Anshuman Gupta <[email protected]>Signed-off-by Sean Paul <[email protected]>Link:
https://patchwork.freedesktop.org/patch/msgid/[email protected]
#v4
Link:
https://patchwork.freedesktop.org/patch/msgid/[email protected]
#v5
Link:
https://patchwork.freedesktop.org/patch/msgid/[email protected]
#v6
Link:
https://patchwork.freedesktop.org/patch/msgid/[email protected]
#v7Changes in v4:
-Added to the set
Changes in v5:
-None
Changes in v6:(quoted diff) +0
-2-Use FIELD_PREP to generate request buffer bitfields (Lyude) -Add mst selftest and dump/decode_sideband_req for QSES (Lyude)Changes in v7:
-None
Changes in v8:(quoted diff) +0
-2-Reverse the parsing on the hdcp_*x_device_present bits and leave breadcrumb in case this is incorrect (Anshuman) --- drivers/gpu/drm/drm_dp_mst_topology.c | 150 ++++++++++++++++++ .../drm/selftests/test-drm_dp_mst_helper.c | 17 ++ include/drm/drm_dp_helper.h | 3 + include/drm/drm_dp_mst_helper.h | 44 +++++ 4 files changed, 214 insertions(+)drivers/gpu/drm/drm_dp_mst_topology.c +18
-0@@ -20,11 +20,13 @@* OF THIS SOFTWARE. */ +#include <linux/bitfield.h> #include <linux/delay.h> #include <linux/errno.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/random.h> #include <linux/sched.h> #include <linux/seq_file.h> #include <linux/iopoll.h> @@ -423,6 +425,22 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_write.bytes, req- >u.i2c_write.num_bytes); idx += req->u.i2c_write.num_bytes;break ; +case DP_QUERY_STREAM_ENC_STATUS : { +const struct drm_dp_query_stream_enc_status *msg; + + msg = &req->u.enc_status; + buf[idx] = msg->stream_id; + idx++; +memcpy (&buf[idx], msg->client_id,sizeof (msg->client_id)); + idx +=sizeof (msg->client_id); + buf[idx] =0 ; + buf[idx] |=FIELD_PREP (GENMASK (1 ,0 ), msg->stream_event); + buf[idx] |= msg->valid_stream_event ?BIT (2 ) :0 ; + buf[idx] |=FIELD_PREP (GENMASK (4 ,3 ), msg->stream_behavior); + buf[idx] |= msg->valid_stream_behavior ?BIT (5 ) :0 ; + idx++; + } +break ; }drivers/gpu/drm/drm_dp_mst_topology.c +14
-0raw->cur_len = idx; }@@ -551,6 +569,20 @@ drm_dp_decode_sideband_req(const struct drm_dp_sideband_msg_tx *raw, return -ENOMEM ; }break ; +case DP_QUERY_STREAM_ENC_STATUS : + req->u.enc_status.stream_id = buf[idx++]; +for (i =0 ; i <sizeof (req->u.enc_status.client_id); i++) + req->u.enc_status.client_id[i] = buf[idx++]; + + req->u.enc_status.stream_event =FIELD_GET (GENMASK (1 ,0 ), + buf[idx]); + req->u.enc_status.valid_stream_event =FIELD_GET (BIT (2 ), + buf[idx]); + req->u.enc_status.stream_behavior =FIELD_GET (GENMASK (4 ,3 ), + buf[idx]); + req->u.enc_status.valid_stream_behavior =FIELD_GET (BIT (5 ), + buf[idx]); +break ; }drivers/gpu/drm/drm_dp_mst_topology.c +0
-0return 0 ;@@ -629,6 +661,16 @@ drm_dp_dump_sideband_msg_req_body(const struct
drm_dp_sideband_msg_req_body*reqdrivers/gpu/drm/drm_dp_mst_topology.c +10
-0req->u.i2c_write.num_bytes, req->u.i2c_write.num_bytes, req->u.i2c_write.bytes);break ; +case DP_QUERY_STREAM_ENC_STATUS : +P ("stream_id=%u client_id=%*ph stream_event=%x " +"valid_event=%d stream_behavior=%x valid_behavior=%d" , + req->u.enc_status.stream_id, + (int )ARRAY_SIZE (req->u.enc_status.client_id), + req->u.enc_status.client_id, req->u.enc_status.stream_event, + req->u.enc_status.valid_stream_event, + req->u.enc_status.stream_behavior, + req->u.enc_status.valid_stream_behavior); +break ;default :P ("???\n" );break ;@@ -936,6 +978,42 @@ static booldrm_dp_sideband_parse_power_updown_phy_ack(struct
drm_dp_sideband_msdrivers/gpu/drm/drm_dp_mst_topology.c +36
-0return true; } +static bool +drm_dp_sideband_parse_query_stream_enc_status ( +struct drm_dp_sideband_msg_rx *raw, +struct drm_dp_sideband_msg_reply_body *repmsg) +{ +struct drm_dp_query_stream_enc_status_ack_reply *reply; + + reply = &repmsg->u.enc_status; + + reply->stream_id = raw->msg[3 ]; + + reply->reply_signed = raw->msg[2 ] &BIT (0 ); + +/* +* NOTE: It's my impression from reading the spec that the below parsing +* is correct. However I noticed while testing with an HDCP 1.4 display +* through an HDCP 2.2 hub that only bit 3 was set. In that case, I +* would expect both bits to be set. So keep the parsing following the +* spec, but beware reality might not match the spec (at least for some +* configurations). +*/ + reply->hdcp_1x_device_present = raw->msg[2 ] &BIT (4 ); + reply->hdcp_2x_device_present = raw->msg[2 ] &BIT (3 ); + + reply->query_capable_device_present = raw->msg[2 ] &BIT (5 ); + reply->legacy_device_present = raw->msg[2 ] &BIT (6 ); + reply->unauthorizable_device_present = raw->msg[2 ] &BIT (7 ); + + reply->auth_completed = !!(raw->msg[1 ] &BIT (3 )); + reply->encryption_enabled = !!(raw->msg[1 ] &BIT (4 )); + reply->repeater_present = !!(raw->msg[1 ] &BIT (5 )); + reply->state = (raw->msg[1 ] &GENMASK (7 ,6 )) >>6 ; + +return true; +} +static bool drm_dp_sideband_parse_reply (struct drm_dp_sideband_msg_rx *raw, struct drm_dp_sideband_msg_reply_body*msg)
{drivers/gpu/drm/drm_dp_mst_topology.c +2
-0@@ -970,6 +1048,8 @@ static bool drm_dp_sideband_parse_reply(structdrm_dp_sideband_msg_rx *raw, return drm_dp_sideband_parse_power_updown_phy_ack(raw, msg);case DP_CLEAR_PAYLOAD_ID_TABLE :return true;/* since there's nothing to parse */ +case DP_QUERY_STREAM_ENC_STATUS : +return drm_dp_sideband_parse_query_stream_enc_status (raw, msg);default : DRM_ERROR("Got unknown reply 0x%02x (%s)\n", msg->req_type,drivers/gpu/drm/drm_dp_mst_topology.c +19
-0drm_dp_mst_req_type_str(msg->req_type));@@ -1121,6 +1201,25 @@ static void build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, msg->path_msg = true; } +static int +build_query_stream_enc_status (struct drm_dp_sideband_msg_tx *msg,u8 stream_id, +u8 *q_id) +{ +struct drm_dp_sideband_msg_req_body req; + + req.req_type =DP_QUERY_STREAM_ENC_STATUS ; + req.u.enc_status.stream_id = stream_id; +memcpy (req.u.enc_status.client_id, q_id, +sizeof (req.u.enc_status.client_id)); + req.u.enc_status.stream_event =0 ; + req.u.enc_status.valid_stream_event = false; + req.u.enc_status.stream_behavior =0 ; + req.u.enc_status.valid_stream_behavior = false; + +drm_dp_encode_sideband_req (&req, msg); +return 0 ; +} + static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr,drivers/gpu/drm/drm_dp_mst_topology.c +26
-0struct drm_dp_vcpi *vcpi) {@@ -3153,6 +3252,57 @@ int drm_dp_send_power_updown_phy(structdrm_dp_mst_topology_mgr *mgr, }EXPORT_SYMBOL (drm_dp_send_power_updown_phy ); +int drm_dp_send_query_stream_enc_status (struct drm_dp_mst_topology_mgr *mgr, +struct drm_dp_mst_port *port, +struct drm_dp_query_stream_enc_status_ack_reply *status) +{ +struct drm_dp_sideband_msg_tx *txmsg; +u8 nonce[7 ]; +int len, ret; + + txmsg =kzalloc (sizeof (*txmsg),GFP_KERNEL ); +if (!txmsg) +return -ENOMEM ; + + port =drm_dp_mst_topology_get_port_validated (mgr, port); +if (!port) { + ret = -EINVAL ; + goto out_get_port; + } + +get_random_bytes (nonce,sizeof (nonce)); + +/* +* "Source device targets the QUERY_STREAM_ENCRYPTION_STATUS message +* transaction at the MST Branch device directly connected to the +* Source" +*/ + txmsg->dst = mgr->mst_primary;
drivers/gpu/drm/drm_dp_mst_topology.c int drm_dp_send_power_updown_phy(struct · line 3291
Quoted 10 lines
drivers/gpu/drm/drm_dp_mst_topology.c +10
-0+ + len =build_query_stream_enc_status (txmsg, port->vcpi.vcpi, nonce); + +drm_dp_queue_down_tx (mgr, txmsg); + + ret =drm_dp_mst_wait_tx_reply (mgr->mst_primary, txmsg); +if (ret <0 ) { + goto out; + }else if (txmsg->reply.reply_type ==DP_SIDEBAND_REPLY_NAK ) { +DRM_DEBUG_KMS ("query encryption status nak received\n" );
Should probably just use drm_dbg_kms() here
Otherwise:
Quoted 152 lines
drivers/gpu/drm/drm_dp_mst_topology.c +15
-0+ ret = -ENXIO ; + goto out; + } + + ret =0 ; +memcpy (status, &txmsg->reply.u.enc_status,sizeof (*status)); + +out: +drm_dp_mst_topology_put_port (port); +out_get_port: +kfree (txmsg); +return ret; +} +EXPORT_SYMBOL (drm_dp_send_query_stream_enc_status); + static int drm_dp_create_payload_step1(struct drm_dp_mst_topology_mgr *mgr, int id,drivers/gpu/drm/drm_dp_mst_topology.c +0
-0struct drm_dp_payload *payload)drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +17
-0@@ -5,6 +5,8 @@#define PREFIX_STR "[drm_dp_mst_helper]" +#include <linux/random.h> +#include <drm/drm_dp_mst_helper.h> #include <drm/drm_print.h> @@ -237,6 +239,21 @@ int igt_dp_mst_sideband_msg_req_decode(void *unused) in.u.i2c_write.bytes = data;DO_TEST (); + in.req_type =DP_QUERY_STREAM_ENC_STATUS ; + in.u.enc_status.stream_id =1 ; +DO_TEST (); +get_random_bytes (in.u.enc_status.client_id, +sizeof (in.u.enc_status.client_id)); +DO_TEST (); + in.u.enc_status.stream_event =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_event =0 ; +DO_TEST (); + in.u.enc_status.stream_behavior =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_behavior =1 ; +DO_TEST (); +#undef DO_TESTreturn 0 ; }include/drm/drm_dp_helper.h +3
-0@@ -1109,6 +1109,9 @@#define DP_POWER_DOWN_PHY 0x25#define DP_SINK_EVENT_NOTIFY 0x30#define DP_QUERY_STREAM_ENC_STATUS 0x38 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_NO_EXIST 0 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_INACTIVE 1 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_ACTIVE 2/* DP 1.2 MST sideband reply types */ #define DP_SIDEBAND_REPLY_ACK 0x00include/drm/drm_dp_mst_helper.h +44
-0@@ -313,6 +313,34 @@ struct drm_dp_remote_i2c_write_ack_reply {u8 port_number; }; +struct drm_dp_query_stream_enc_status_ack_reply { +/* Bit[23:16]- Stream Id */ +u8 stream_id; + +/* Bit[15]- Signed */ +bool reply_signed; + +/* Bit[10:8]- Stream Output Sink Type */ +bool unauthorizable_device_present; +bool legacy_device_present; +bool query_capable_device_present; + +/* Bit[12:11]- Stream Output CP Type */ +bool hdcp_1x_device_present; +bool hdcp_2x_device_present; + +/* Bit[4]- Stream Authentication */ +bool auth_completed; + +/* Bit[3]- Stream Encryption */ +bool encryption_enabled; + +/* Bit[2]- Stream Repeater Function Present */ +bool repeater_present; + +/* Bit[1:0]- Stream State */ +u8 state; +};#define DRM_DP_MAX_SDP_STREAMS 16struct drm_dp_allocate_payload {@@ -374,6 +402,15 @@ struct drm_dp_remote_i2c_write {u8 *bytes; }; +struct drm_dp_query_stream_enc_status { +u8 stream_id; +u8 client_id[7 ];/* 56-bit nonce */ +u8 stream_event; +bool valid_stream_event; +u8 stream_behavior; +u8 valid_stream_behavior; +}; +/* this covers ENUM_RESOURCES, POWER_DOWN_PHY, POWER_UP_PHY */ struct drm_dp_port_number_req {u8 port_number;@@ -422,6 +459,8 @@ struct drm_dp_sideband_msg_req_body {struct drm_dp_remote_i2c_read i2c_read;struct drm_dp_remote_i2c_write i2c_write; + +struct drm_dp_query_stream_enc_status enc_status; } u; };@@ -444,6 +483,8 @@ struct drm_dp_sideband_msg_reply_body {struct drm_dp_remote_i2c_read_ack_reply remote_i2c_read_ack;struct drm_dp_remote_i2c_read_nak_reply remote_i2c_read_nack;struct drm_dp_remote_i2c_write_ack_reply remote_i2c_write_ack; + +struct drm_dp_query_stream_enc_status_ack_reply enc_status; } u; };@@ -808,6 +849,9 @@ drm_dp_atomic_release_vcpi_slots(struct drm_atomic_state *state, struct drm_dp_mst_port *port);int drm_dp_send_power_updown_phy (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port,bool power_up); +int drm_dp_send_query_stream_enc_status (struct drm_dp_mst_topology_mgr *mgr, +struct drm_dp_mst_port *port, +struct drm_dp_query_stream_enc_status_ack_reply *status);int __must_check drm_dp_mst_atomic_check (struct drm_atomic_state *state);void
drm_dp_mst_get_port_malloc(struct drm_dp_mst_port *port);
Signature · 8 lines
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develPATCH 1/1 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message
From: Sean Paul <[email protected]>
Used to query whether an MST stream is encrypted or not.
Changes in v4:
-Added to the set
Changes in v5:
-None
Changes in v6:
-Use FIELD_PREP to generate request buffer bitfields (Lyude) -Add mst selftest and dump/decode_sideband_req for QSES (Lyude) Changes in v7:
-None
Changes in v8:
-Reverse the parsing on the hdcp_*x_device_present bits and leave
breadcrumb in case this is incorrect (Anshuman)
Changes in v8.5:
-s/DRM_DEBUG_KMS/drm_dbg_kms/ (Lyude)
--- drivers/gpu/drm/drm_dp_mst_topology.c | 150 ++++++++++++++++++ .../drm/selftests/test-drm_dp_mst_helper.c | 17 ++ include/drm/drm_dp_helper.h | 3 + include/drm/drm_dp_mst_helper.h | 44 +++++ 4 files changed, 214 insertions(+)
drivers/gpu/drm/drm_dp_mst_topology.c +150 -0
@@ -20,11 +20,13 @@* OF THIS SOFTWARE. */ +#include <linux/bitfield.h> #include <linux/delay.h> #include <linux/errno.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/random.h> #include <linux/sched.h> #include <linux/seq_file.h> #include <linux/iopoll.h>
@@ -423,6 +425,22 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,memcpy (&buf[idx], req->u.i2c_write.bytes, req->u.i2c_write.num_bytes); idx += req->u.i2c_write.num_bytes;break ; +case DP_QUERY_STREAM_ENC_STATUS : { +const struct drm_dp_query_stream_enc_status *msg; + + msg = &req->u.enc_status; + buf[idx] = msg->stream_id; + idx++; +memcpy (&buf[idx], msg->client_id,sizeof (msg->client_id)); + idx +=sizeof (msg->client_id); + buf[idx] =0 ; + buf[idx] |=FIELD_PREP (GENMASK (1 ,0 ), msg->stream_event); + buf[idx] |= msg->valid_stream_event ?BIT (2 ) :0 ; + buf[idx] |=FIELD_PREP (GENMASK (4 ,3 ), msg->stream_behavior); + buf[idx] |= msg->valid_stream_behavior ?BIT (5 ) :0 ; + idx++; + } +break ; } raw->cur_len = idx; }
@@ -551,6 +569,20 @@ drm_dp_decode_sideband_req(const struct drm_dp_sideband_msg_tx *raw,return -ENOMEM ; }break ; +case DP_QUERY_STREAM_ENC_STATUS : + req->u.enc_status.stream_id = buf[idx++]; +for (i =0 ; i <sizeof (req->u.enc_status.client_id); i++) + req->u.enc_status.client_id[i] = buf[idx++]; + + req->u.enc_status.stream_event =FIELD_GET (GENMASK (1 ,0 ), + buf[idx]); + req->u.enc_status.valid_stream_event =FIELD_GET (BIT (2 ), + buf[idx]); + req->u.enc_status.stream_behavior =FIELD_GET (GENMASK (4 ,3 ), + buf[idx]); + req->u.enc_status.valid_stream_behavior =FIELD_GET (BIT (5 ), + buf[idx]); +break ; }return 0 ;
@@ -629,6 +661,16 @@ drm_dp_dump_sideband_msg_req_body(const struct drm_dp_sideband_msg_req_body *req req->u.i2c_write.num_bytes, req->u.i2c_write.num_bytes, req->u.i2c_write.bytes);break ; +case DP_QUERY_STREAM_ENC_STATUS : +P ("stream_id=%u client_id=%*ph stream_event=%x " +"valid_event=%d stream_behavior=%x valid_behavior=%d" , + req->u.enc_status.stream_id, + (int )ARRAY_SIZE (req->u.enc_status.client_id), + req->u.enc_status.client_id, req->u.enc_status.stream_event, + req->u.enc_status.valid_stream_event, + req->u.enc_status.stream_behavior, + req->u.enc_status.valid_stream_behavior); +break ;default :P ("???\n" );break ;
@@ -936,6 +978,42 @@ static bool drm_dp_sideband_parse_power_updown_phy_ack(struct drm_dp_sideband_msreturn true; } +static bool +drm_dp_sideband_parse_query_stream_enc_status ( +struct drm_dp_sideband_msg_rx *raw, +struct drm_dp_sideband_msg_reply_body *repmsg) +{ +struct drm_dp_query_stream_enc_status_ack_reply *reply; + + reply = &repmsg->u.enc_status; + + reply->stream_id = raw->msg[3 ]; + + reply->reply_signed = raw->msg[2 ] &BIT (0 ); + +/* +* NOTE: It's my impression from reading the spec that the below parsing +* is correct. However I noticed while testing with an HDCP 1.4 display +* through an HDCP 2.2 hub that only bit 3 was set. In that case, I +* would expect both bits to be set. So keep the parsing following the +* spec, but beware reality might not match the spec (at least for some +* configurations). +*/ + reply->hdcp_1x_device_present = raw->msg[2 ] &BIT (4 ); + reply->hdcp_2x_device_present = raw->msg[2 ] &BIT (3 ); + + reply->query_capable_device_present = raw->msg[2 ] &BIT (5 ); + reply->legacy_device_present = raw->msg[2 ] &BIT (6 ); + reply->unauthorizable_device_present = raw->msg[2 ] &BIT (7 ); + + reply->auth_completed = !!(raw->msg[1 ] &BIT (3 )); + reply->encryption_enabled = !!(raw->msg[1 ] &BIT (4 )); + reply->repeater_present = !!(raw->msg[1 ] &BIT (5 )); + reply->state = (raw->msg[1 ] &GENMASK (7 ,6 )) >>6 ; + +return true; +} +static bool drm_dp_sideband_parse_reply (struct drm_dp_sideband_msg_rx *raw,struct drm_dp_sideband_msg_reply_body *msg) {
@@ -970,6 +1048,8 @@ static bool drm_dp_sideband_parse_reply(struct drm_dp_sideband_msg_rx *raw,return drm_dp_sideband_parse_power_updown_phy_ack (raw, msg);case DP_CLEAR_PAYLOAD_ID_TABLE :return true;/* since there's nothing to parse */ +case DP_QUERY_STREAM_ENC_STATUS : +return drm_dp_sideband_parse_query_stream_enc_status (raw, msg);default :DRM_ERROR ("Got unknown reply 0x%02x (%s)\n" , msg->req_type,drm_dp_mst_req_type_str (msg->req_type));
@@ -1121,6 +1201,25 @@ static void build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, msg->path_msg = true; } +static int +build_query_stream_enc_status (struct drm_dp_sideband_msg_tx *msg,u8 stream_id, +u8 *q_id) +{ +struct drm_dp_sideband_msg_req_body req; + + req.req_type =DP_QUERY_STREAM_ENC_STATUS ; + req.u.enc_status.stream_id = stream_id; +memcpy (req.u.enc_status.client_id, q_id, +sizeof (req.u.enc_status.client_id)); + req.u.enc_status.stream_event =0 ; + req.u.enc_status.valid_stream_event = false; + req.u.enc_status.stream_behavior =0 ; + req.u.enc_status.valid_stream_behavior = false; + +drm_dp_encode_sideband_req (&req, msg); +return 0 ; +} +static int drm_dp_mst_assign_payload_id (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_vcpi *vcpi) {
@@ -3153,6 +3252,57 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, }EXPORT_SYMBOL (drm_dp_send_power_updown_phy); +int drm_dp_send_query_stream_enc_status (struct drm_dp_mst_topology_mgr *mgr, +struct drm_dp_mst_port *port, +struct drm_dp_query_stream_enc_status_ack_reply *status) +{ +struct drm_dp_sideband_msg_tx *txmsg; +u8 nonce[7 ]; +int len, ret; + + txmsg =kzalloc (sizeof (*txmsg),GFP_KERNEL ); +if (!txmsg) +return -ENOMEM ; + + port =drm_dp_mst_topology_get_port_validated (mgr, port); +if (!port) { + ret = -EINVAL ; + goto out_get_port; + } + +get_random_bytes (nonce,sizeof (nonce)); + +/* +* "Source device targets the QUERY_STREAM_ENCRYPTION_STATUS message +* transaction at the MST Branch device directly connected to the +* Source" +*/ + txmsg->dst = mgr->mst_primary; + + len =build_query_stream_enc_status (txmsg, port->vcpi.vcpi, nonce); + +drm_dp_queue_down_tx (mgr, txmsg); + + ret =drm_dp_mst_wait_tx_reply (mgr->mst_primary, txmsg); +if (ret <0 ) { + goto out; + }else if (txmsg->reply.reply_type ==DP_SIDEBAND_REPLY_NAK ) { +drm_dbg_kms (mgr->dev,"query encryption status nak received\n" ); + ret = -ENXIO ; + goto out; + } + + ret =0 ; +memcpy (status, &txmsg->reply.u.enc_status,sizeof (*status)); + +out: +drm_dp_mst_topology_put_port (port); +out_get_port: +kfree (txmsg); +return ret; +} +EXPORT_SYMBOL (drm_dp_send_query_stream_enc_status); +static int drm_dp_create_payload_step1 (struct drm_dp_mst_topology_mgr *mgr,int id,struct drm_dp_payload *payload)
drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +17 -0
@@ -5,6 +5,8 @@#define PREFIX_STR "[drm_dp_mst_helper]" +#include <linux/random.h> +#include <drm/drm_dp_mst_helper.h> #include <drm/drm_print.h>
@@ -237,6 +239,21 @@ int igt_dp_mst_sideband_msg_req_decode(void *unused) in.u.i2c_write.bytes = data;DO_TEST (); + in.req_type =DP_QUERY_STREAM_ENC_STATUS ; + in.u.enc_status.stream_id =1 ; +DO_TEST (); +get_random_bytes (in.u.enc_status.client_id, +sizeof (in.u.enc_status.client_id)); +DO_TEST (); + in.u.enc_status.stream_event =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_event =0 ; +DO_TEST (); + in.u.enc_status.stream_behavior =3 ; +DO_TEST (); + in.u.enc_status.valid_stream_behavior =1 ; +DO_TEST (); +#undef DO_TESTreturn 0 ; }
include/drm/drm_dp_helper.h +3 -0
@@ -1109,6 +1109,9 @@#define DP_POWER_DOWN_PHY 0x25#define DP_SINK_EVENT_NOTIFY 0x30#define DP_QUERY_STREAM_ENC_STATUS 0x38 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_NO_EXIST 0 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_INACTIVE 1 +#define DP_QUERY_STREAM_ENC_STATUS_STATE_ACTIVE 2/* DP 1.2 MST sideband reply types */ #define DP_SIDEBAND_REPLY_ACK 0x00
include/drm/drm_dp_mst_helper.h +44 -0
74 lines not on this page · raw message
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 16/17 drm/i915: Print HDCP version info for all connectors
In reply to Sean PaulFrom: Sean Paul <[email protected]>
De-duplicate the HDCP version code for each connector and print it for all connectors.
Changes in v4:
- Added to the set
Changes in v5:
-Print "No connector support" for hdcp sink capability as well (Ram) Changes in v6:
-None
Changes in v7:
-None
Changes in v8:
-None
--- .../drm/i915/display/intel_display_debugfs.c | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +9 -12
@@ -601,6 +601,11 @@ static void intel_hdcp_info(struct seq_file *m, {bool hdcp_cap, hdcp2_cap; +if (!intel_connector->hdcp.shim) { +seq_puts (m,"No Connector Support" ); + goto out; + } + hdcp_cap =intel_hdcp_capable (intel_connector); hdcp2_cap =intel_hdcp2_capable (intel_connector);
@@ -612,6 +617,7 @@ static void intel_hdcp_info(struct seq_file *m,if (!hdcp_cap && !hdcp2_cap)seq_puts (m,"None" ); +out:seq_puts (m,"\n" ); }
@@ -628,10 +634,6 @@ static void intel_dp_info(struct seq_file *m,drm_dp_downstream_debug (m, intel_dp->dpcd, intel_dp->downstream_ports, &intel_dp->aux); -if (intel_connector->hdcp.shim) { -seq_puts (m,"\tHDCP version: " ); -intel_hdcp_info (m, intel_connector); - } } static void intel_dp_mst_info(struct seq_file *m,
@@ -649,10 +651,6 @@ static void intel_hdmi_info(struct seq_file *m,struct intel_hdmi *intel_hdmi =enc_to_intel_hdmi (intel_encoder);seq_printf (m,"\taudio support: %s\n" ,yesno (intel_hdmi->has_audio)); -if (intel_connector->hdcp.shim) { -seq_puts (m,"\tHDCP version: " ); -intel_hdcp_info (m, intel_connector); - } } static void intel_lvds_info(struct seq_file *m,
@@ -708,6 +706,9 @@ static void intel_connector_info(struct seq_file *m,break ; } +seq_puts (m,"\tHDCP version: " ); +intel_hdcp_info (m, intel_connector); +seq_printf (m,"\tmodes:\n" );list_for_each_entry (mode, &connector->modes, head)intel_seq_print_mode (m,2 , mode);
@@ -2029,10 +2030,6 @@ static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)if (connector->status != connector_status_connected)return -ENODEV ; -/* HDCP is supported by connector */ -if (!intel_connector->hdcp.shim) -return -EINVAL ; -seq_printf (m,"%s:%d HDCP version: " , connector->name, connector->base.id);intel_hdcp_info (m, intel_connector);
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 17/17 drm/i915: Add HDCP 1.4 support for MST connectors
In reply to Sean PaulFrom: Sean Paul <[email protected]>
Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks
Changes in v2:
-Toggle HDCP from encoder disable/enable
-Don't disable HDCP on MST connector destroy, leave that for encoder
disable, just ensure the check_work routine isn't running any longer
Changes in v3:
-Place the shim in the new intel_dp_hdcp.c file (Ville) Changes in v4:
-Actually use the mst shim for mst connections (Juston)
-Use QUERY_STREAM_ENC_STATUS MST message to verify channel is encrypted Changes in v5:
-Add sleep on disable signalling to match hdmi delay
Changes in v6:
-Disable HDCP over MST on GEN12+ since I'm unsure how it should work and I
don't have hardware to test it
Changes in v7:
-Remove hdcp2 shims for MST in favor of skipping hdcp2 init (Ramalingam) Changes in v8:
-None
--- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 66 +++++++++++++++++++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 18 ++++++ drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- 3 files changed, 84 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_hdcp.c +65 -1
@@ -7,10 +7,12 @@*/ #include <drm/drm_dp_helper.h> +#include <drm/drm_dp_mst_helper.h> #include <drm/drm_hdcp.h> #include <drm/drm_print.h> #include "intel_display_types.h" +#include "intel_ddi.h" #include "intel_dp.h" #include "intel_hdcp.h"
@@ -619,6 +621,65 @@ static const struct intel_hdcp_shim intel_dp_hdcp_shim = { .protocol = HDCP_PROTOCOL_DP, }; +static int +intel_dp_mst_hdcp_toggle_signalling (struct intel_digital_port *dig_port, +enum transcoder cpu_transcoder, +bool enable) +{ +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); +int ret; + +if (!enable) +usleep_range (6 ,60 );/* Bspec says >= 6us */ + + ret =intel_ddi_toggle_hdcp_signalling (&dig_port->base, + cpu_transcoder, enable); +if (ret) +drm_dbg_kms (&i915->drm,"%s HDCP signalling failed (%d)\n" , + enable ?"Enable" :"Disable" , ret); +return ret; +} + +static +bool intel_dp_mst_hdcp_check_link (struct intel_digital_port *dig_port, +struct intel_connector *connector) +{ +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); +struct intel_dp *intel_dp = &dig_port->dp; +struct drm_dp_query_stream_enc_status_ack_reply reply; +int ret; + +if (!intel_dp_hdcp_check_link (dig_port, connector)) +return false; + + ret =drm_dp_send_query_stream_enc_status (&intel_dp->mst_mgr, + connector->port, &reply); +if (ret) { +drm_dbg_kms (&i915->drm, +"[CONNECTOR:%d:%s] failed QSES ret=%d\n" , + connector->base.base.id, connector->base.name, ret); +return false; + } + +return reply.auth_completed && reply.encryption_enabled; +} + +static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = { + .write_an_aksv = intel_dp_hdcp_write_an_aksv, + .read_bksv = intel_dp_hdcp_read_bksv, + .read_bstatus = intel_dp_hdcp_read_bstatus, + .repeater_present = intel_dp_hdcp_repeater_present, + .read_ri_prime = intel_dp_hdcp_read_ri_prime, + .read_ksv_ready = intel_dp_hdcp_read_ksv_ready, + .read_ksv_fifo = intel_dp_hdcp_read_ksv_fifo, + .read_v_prime_part = intel_dp_hdcp_read_v_prime_part, + .toggle_signalling = intel_dp_mst_hdcp_toggle_signalling, + .check_link = intel_dp_mst_hdcp_check_link, + .hdcp_capable = intel_dp_hdcp_capable, + + .protocol =HDCP_PROTOCOL_DP , +}; +int intel_dp_init_hdcp (struct intel_digital_port *dig_port,struct intel_connector *intel_connector) {
@@ -631,7 +692,10 @@ int intel_dp_init_hdcp(struct intel_digital_port *dig_port,if (!is_hdcp_supported (dev_priv, port))return 0 ; -if (!intel_dp_is_edp (intel_dp)) +if (intel_connector->mst_port) +return intel_hdcp_init (intel_connector, port, + &intel_dp_mst_hdcp_shim); +else if (!intel_dp_is_edp (intel_dp))return intel_hdcp_init (intel_connector, port, &intel_dp_hdcp_shim);
drivers/gpu/drm/i915/display/intel_dp_mst.c +18 -0
@@ -37,6 +37,7 @@#include "intel_dp.h" #include "intel_dp_mst.h" #include "intel_dpio_phy.h" +#include "intel_hdcp.h" static int intel_dp_mst_compute_link_config(struct intel_encoder *encoder, struct intel_crtc_state *crtc_state,
@@ -352,6 +353,8 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state,drm_dbg_kms (&i915->drm,"active links %d\n" , intel_dp->active_mst_links); +intel_hdcp_disable (intel_mst->connector); +drm_dp_mst_reset_vcpi_slots (&intel_dp->mst_mgr, connector->port); ret =drm_dp_update_payload_part1 (&intel_dp->mst_mgr);
@@ -556,6 +559,13 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,if (pipe_config->has_audio)intel_audio_codec_enable (encoder, pipe_config, conn_state); + +/* Enable hdcp if it's desired */ +if (conn_state->content_protection == +DRM_MODE_CONTENT_PROTECTION_DESIRED ) +intel_hdcp_enable (to_intel_connector (conn_state->connector), + pipe_config->cpu_transcoder, + (u8 )conn_state->hdcp_content_type); } static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
@@ -799,6 +809,14 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolointel_attach_force_audio_property (connector);intel_attach_broadcast_rgb_property (connector); + +/* TODO: Figure out how to make HDCP work on GEN12+ */ +if (INTEL_GEN (dev_priv) <12 ) { + ret =intel_dp_init_hdcp (dig_port, intel_connector); +if (ret) +DRM_DEBUG_KMS ("HDCP init failed, skipping.\n" ); + } +/* * Reuse the prop from the SST connector because we're * not allowed to create new props after device registration.
drivers/gpu/drm/i915/display/intel_hdcp.c +1 -1
@@ -2059,7 +2059,7 @@ int intel_hdcp_init(struct intel_connector *connector,if (!shim)return -EINVAL ; -if (is_hdcp2_supported (dev_priv)) +if (is_hdcp2_supported (dev_priv) && !connector->mst_port)intel_hdcp2_init (connector, port, shim); ret =
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST (rev2)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev2)
URL : https://patchwork.freedesktop.org/series/78749/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip ad446f228d24 drm/i915: Fix sha_text population code -:72: WARNING:LINE_SPACING: Missing a blank line after declarations #72: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:341: + u8 off = ((sizeof(sha_text) - j - 1 - sha_leftovers) * 8); + sha_text |= ksv[j] << off;
total: 0 errors, 1 warnings, 0 checks, 61 lines checkedbe78fd1d52cb drm/i915: Clear the repeater bit on HDCP disable 96f56301c229 drm/i915: WARN if HDCP signalling is enabled upon disable 2a9f21eb9c09 drm/i915: Intercept Aksv writes in the aux hooks 1a56bdc02def drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling 8d6b5fe7b16e drm/i915: Factor out hdcp->value assignments
-:78: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #78: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:930:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED, true);
-:123: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #123: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1799:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED,
-:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #135: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1814:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED,
-:147: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #147: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1834:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_DESIRED, true);
total: 0 errors, 0 warnings, 4 checks, 138 lines checked d8b168bd5d5a drm/i915: Protect workers against disappearing connectors -:95: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #95: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:2205:
+ drm_WARN_ON(connector->base.dev,
+ connector->base.registration_state == DRM_CONNECTOR_REGISTERED);
total: 0 errors, 0 warnings, 1 checks, 71 lines checked5390eda47a58 drm/i915: Clean up intel_hdcp_disablea82bad65d0b2 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it f155946735e0 drm/i915: Support DP MST in enc_to_dig_port() function260f90f909b5 drm/i915: Use ddi_update_pipe in intel_dp_mst8b7aea4234cf drm/i915: Factor out HDCP shim functions from dp for use by dp_mst -:692: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #692:
new file mode 100644
-:697: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_dp_hdcp.c', please use '//' instead #697: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:1:
+/* SPDX-License-Identifier: MIT */
-:697: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #697: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:1:
+/* SPDX-License-Identifier: MIT */
-:878: WARNING:LINE_SPACING: Missing a blank line after declarations #878: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:182:
+ size_t len = min(num_downstream - i, 3) * DRM_HDCP_KSV_LEN;
+ ret = drm_dp_dpcd_read(&dig_port->dp.aux,
-:1254: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1254: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:558:
+
+}
total: 0 errors, 4 warnings, 1 checks, 1276 lines checked8379b02b9940 drm/i915: Plumb port through hdcp initbbb5610468ab drm/i915: Add connector to hdcp_shim->check_link() f4915cd92791 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message -:115: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#115: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:982:
+drm_dp_sideband_parse_query_stream_enc_status(
-:193: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #193: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:3256:
+int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
+ struct drm_dp_mst_port *port,
-:373: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #373: FILE: include/drm/drm_dp_mst_helper.h:853:
+int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
+ struct drm_dp_mst_port *port,
total: 0 errors, 0 warnings, 3 checks, 315 lines checked f589de4d6946 drm/i915: Print HDCP version info for all connectors 3a5e18d9ce36 drm/i915: Add HDCP 1.4 support for MST connectors -:76: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #76: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:639:
+ drm_dbg_kms(&i915->drm, "%s HDCP signalling failed (%d)\n",
+ enable ? "Enable" : "Disable", ret);
-:174: CHECK:LINE_SPACING: Please don't use multiple blank lines #174: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:812:
+
total: 0 errors, 0 warnings, 2 checks, 138 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add support for HDCP 1.4 over MST (rev2)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev2)
URL : https://patchwork.freedesktop.org/series/78749/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: expected unsigned int [addressable] [usertype] ulClockParams +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: got restricted __le32 [usertype] +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: warning: incorrect type in assignment (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1028:50: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1029:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1037:47: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:184:44: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:283:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:320:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:323:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:326:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:329:18: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:330:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:338:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:340:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:342:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:346:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:348:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:353:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:367:43: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:369:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:374:67: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:375:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:378:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:389:80: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:395:57: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:402:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:403:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:406:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:414:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:423:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:424:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:473:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:476:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:477:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:484:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:52:28: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:531:35: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:53:29: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:533:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:54:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:55:27: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:56:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:57:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:577:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:581:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:58:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:583:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:586:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:590:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:59:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:598:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:600:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:617:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:621:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:623:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:630:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:632:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:644:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:648:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:650:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:657:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:659:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:662:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:664:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:676:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:688:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:691:47: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:697:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:796:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:797:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:800:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:801:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:804:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:805:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:812:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:813:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:816:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:817:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:820:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:821:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:828:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:829:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:832:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:833:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:836:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:837:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:844:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:845:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:848:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:849:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:852:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:853:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:916:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:918:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:920:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:934:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:936:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:938:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:956:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:958:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:960:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:328:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:365:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:395:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:397:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:404:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:418:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:441:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:44:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:482:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:486:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:489:61: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:490:64: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:492:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:518:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:521:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:64:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:85:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:86:24: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:98:39: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:222:29: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:227:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:233:43: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:236:44: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:239:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:464:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:465:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:466:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:468:24: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: expected unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: got unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: expected struct drm_amdgpu_cs_chunk [noderef] __user **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: expected struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: got struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: got struct drm_amdgpu_cs_chunk [noderef] __user **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: expected restricted __poll_t ( *poll )( ... ) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: got unsigned int ( * )( ... ) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: warning: incorrect type in initializer (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1666:65: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1674:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1675:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1676:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1677:56: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1679:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1680:45: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1681:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1682:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1683:57: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1685:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1686:53: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1688:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1690:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1691:46: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1695:73: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1697:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1699:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for HDCP 1.4 over MST (rev2)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev2)
URL : https://patchwork.freedesktop.org/series/78749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8898 -> Patchwork_18368
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18368:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@debugfs_test@read_all_entries:
- {fi-kbl-7560u}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
Known issues
------------
Here are the changes found in Patchwork_18368 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@engines@contexts:
- fi-tgl-u2: [PASS][3] -> [INCOMPLETE][4] ([CI#80])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-tgl-u2/igt@gem_exec_parallel@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-tgl-u2/igt@gem_exec_parallel@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-bsw-kefka/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-bsw-kefka/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-icl-y: [PASS][7] -> [INCOMPLETE][8] ([i915#2276])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-icl-y/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-icl-y/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-bxt-dsi: [DMESG-WARN][9] ([i915#1635] / [i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-bxt-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-bxt-dsi/igt@[email protected]
#### Warnings ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92]) -> [DMESG-WARN][12] ([i915#62] / [i915#92] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/fi-kbl-x1275/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (39 -> 34)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8898 -> Patchwork_18368
CI-20190529: 20190529
CI_DRM_8898: 7a3c826e246d18af05f662cf6425e750eb00aec5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18368: 3a5e18d9ce3659322d1b3623d8641463ce454851 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3a5e18d9ce36 drm/i915: Add HDCP 1.4 support for MST connectorsf589de4d6946 drm/i915: Print HDCP version info for all connectors f4915cd92791 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message bbb5610468ab drm/i915: Add connector to hdcp_shim->check_link() 8379b02b9940 drm/i915: Plumb port through hdcp init8b7aea4234cf drm/i915: Factor out HDCP shim functions from dp for use by dp_mst 260f90f909b5 drm/i915: Use ddi_update_pipe in intel_dp_mstf155946735e0 drm/i915: Support DP MST in enc_to_dig_port() function a82bad65d0b2 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it 5390eda47a58 drm/i915: Clean up intel_hdcp_disabled8b168bd5d5a drm/i915: Protect workers against disappearing connectors 8d6b5fe7b16e drm/i915: Factor out hdcp->value assignments1a56bdc02def drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling 2a9f21eb9c09 drm/i915: Intercept Aksv writes in the aux hooks96f56301c229 drm/i915: WARN if HDCP signalling is enabled upon disable be78fd1d52cb drm/i915: Clear the repeater bit on HDCP disablead446f228d24 drm/i915: Fix sha_text population code
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add support for HDCP 1.4 over MST (rev2)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev2)
URL : https://patchwork.freedesktop.org/series/78749/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8898_full -> Patchwork_18368_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18368_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18368_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18368_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-hsw4/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-hsw1/igt@kms_flip@[email protected]
### Piglit changes ###
#### Possible regressions ####
* [email protected]@execution@built-in-functions@fs-op-bitor-uint-uvec2 (NEW):
- {pig-icl-1065g7}: NOTRUN -> [CRASH][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/pig-icl-1065g7/[email protected]@execution@[email protected]
* [email protected]@execution@built-in-functions@vs-op-add-uint-uvec4 (NEW):
- {pig-icl-1065g7}: NOTRUN -> [INCOMPLETE][4] +6 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/pig-icl-1065g7/[email protected]@execution@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_8898_full and Patchwork_18368_full:
### New Piglit tests (8) ###
* [email protected]@execution@built-in-functions@fs-clamp-ivec4-int-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-assign-bitor-uvec3-uvec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-bitor-uint-uvec2:
- Statuses : 1 crash(s)
- Exec time: [0.63] s
* [email protected]@execution@built-in-functions@fs-op-bitor-uint-uvec4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-bitxor-neg-abs-int-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-add-uint-uvec4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-assign-lshift-ivec2-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-bitor-neg-int-ivec2:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18368_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@bonded-early:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#2079])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-kbl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-kbl6/igt@[email protected]
* igt@gem_exec_gttfill@all:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk7/igt@[email protected]
* igt@i915_pm_rpm@drm-resources-equal:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-apl8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-apl1/igt@[email protected]
* igt@i915_selftest@mock@contexts:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#198] / [i915#2278])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl1/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl2/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-iclb: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb3/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][15] -> [DMESG-FAIL][16] ([i915#118] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk8/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk4/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-dp1:
- shard-apl: [PASS][19] -> [FAIL][20] ([i915#1635] / [i915#79])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-apl2/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-fences@a-edp1:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +13 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl3/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl4/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][27] -> [FAIL][28] ([i915#173])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb3/igt@kms_psr@no_drrs.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][29] -> [FAIL][30] ([i915#31])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-kbl4/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +6 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-kbl2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-kbl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_mmap_gtt@fault-concurrent:
- shard-glk: [DMESG-WARN][33] ([i915#2165]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk8/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][35] ([i915#1436] / [i915#1635] / [i915#716]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-apl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-apl6/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][37] ([i915#1436] / [i915#716]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][39] ([i915#454]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb4/igt@[email protected]
* igt@i915_query@query-topology-coherent-slice-mask:
- shard-hsw: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-hsw1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-hsw2/igt@[email protected]
* igt@i915_selftest@perf@request:
- shard-tglb: [INCOMPLETE][43] ([i915#1823]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-tglb1/igt@i915_selftest@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-tglb8/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][45] ([i915#118] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk9/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +7 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-kbl7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-kbl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [INCOMPLETE][49] ([i915#198]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl3/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][51] ([i915#2122]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl9/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +13 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl5/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][55] ([fdo#109642] / [fdo#111068]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb6/igt@kms_psr2_su@page_flip.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@perf_pmu@module-unload:
- shard-iclb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-iclb4/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-iclb8/igt@[email protected]
* igt@prime_busy@after@vecs0:
- shard-hsw: [FAIL][61] ([i915#2258]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-hsw7/igt@prime_busy@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-hsw8/igt@prime_busy@[email protected]
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-glk: [INCOMPLETE][63] ([i915#1958]) -> [TIMEOUT][64] ([i915#1958])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-glk3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-glk6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [INCOMPLETE][65] ([i915#155]) -> [DMESG-WARN][66] ([i915#180])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-kbl6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-kbl7/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][67], [FAIL][68]) ([fdo#109271] / [i915#1635] / [i915#2110] / [i915#716]) -> [FAIL][69] ([i915#1635] / [i915#2110])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-apl4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-apl3/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-apl6/igt@[email protected]
- shard-skl: ([FAIL][70], [FAIL][71]) ([i915#1436] / [i915#2029]) -> ([FAIL][72], [FAIL][73]) ([i915#1436] / [i915#2110])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl3/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8898/shard-skl2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl2/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/shard-skl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1823]: https://gitlab.freedesktop.org/drm/intel/issues/1823
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2079]: https://gitlab.freedesktop.org/drm/intel/issues/2079
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2165]: https://gitlab.freedesktop.org/drm/intel/issues/2165
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8898 -> Patchwork_18368
CI-20190529: 20190529
CI_DRM_8898: 7a3c826e246d18af05f662cf6425e750eb00aec5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18368: 3a5e18d9ce3659322d1b3623d8641463ce454851 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18368/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST (rev3)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev3)
URL : https://patchwork.freedesktop.org/series/78749/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 75835fa85a82 drm/i915: Fix sha_text population code -:72: WARNING:LINE_SPACING: Missing a blank line after declarations #72: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:341: + u8 off = ((sizeof(sha_text) - j - 1 - sha_leftovers) * 8); + sha_text |= ksv[j] << off;
total: 0 errors, 1 warnings, 0 checks, 61 lines checked2022ef4a6151 drm/i915: Clear the repeater bit on HDCP disable f75a1292a09a drm/i915: WARN if HDCP signalling is enabled upon disable f61be32af4f4 drm/i915: Intercept Aksv writes in the aux hooks cd2828c49252 drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling 7659c82aec36 drm/i915: Factor out hdcp->value assignments
-:78: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #78: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:930:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED, true);
-:123: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #123: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1799:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED,
-:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #135: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1814:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_ENABLED,
-:147: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #147: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1834:
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_DESIRED, true);
total: 0 errors, 0 warnings, 4 checks, 138 lines checked f6bb1a3e3379 drm/i915: Protect workers against disappearing connectors -:95: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #95: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:2205:
+ drm_WARN_ON(connector->base.dev,
+ connector->base.registration_state == DRM_CONNECTOR_REGISTERED);
total: 0 errors, 0 warnings, 1 checks, 71 lines checkedaae84a3d1e58 drm/i915: Clean up intel_hdcp_disablec9bf9bc90816 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it 2b6b206b775b drm/i915: Support DP MST in enc_to_dig_port() functionec3ad644d55f drm/i915: Use ddi_update_pipe in intel_dp_mst3c4ef5d3a2fa drm/i915: Factor out HDCP shim functions from dp for use by dp_mst -:692: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #692:
new file mode 100644
-:697: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_dp_hdcp.c', please use '//' instead #697: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:1:
+/* SPDX-License-Identifier: MIT */
-:697: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #697: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:1:
+/* SPDX-License-Identifier: MIT */
-:878: WARNING:LINE_SPACING: Missing a blank line after declarations #878: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:182:
+ size_t len = min(num_downstream - i, 3) * DRM_HDCP_KSV_LEN;
+ ret = drm_dp_dpcd_read(&dig_port->dp.aux,
-:1254: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1254: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:558:
+
+}
total: 0 errors, 4 warnings, 1 checks, 1276 lines checkedcbf6864233d8 drm/i915: Plumb port through hdcp init88ed54f45d4a drm/i915: Add connector to hdcp_shim->check_link() ee796c747bb0 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message -:119: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#119: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:982:
+drm_dp_sideband_parse_query_stream_enc_status(
-:197: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #197: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:3256:
+int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
+ struct drm_dp_mst_port *port,
-:377: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #377: FILE: include/drm/drm_dp_mst_helper.h:853:
+int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
+ struct drm_dp_mst_port *port,
total: 0 errors, 0 warnings, 3 checks, 315 lines checked 8b877b97b221 drm/i915: Print HDCP version info for all connectors 4e90cfaa37a5 drm/i915: Add HDCP 1.4 support for MST connectors -:76: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #76: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:639:
+ drm_dbg_kms(&i915->drm, "%s HDCP signalling failed (%d)\n",
+ enable ? "Enable" : "Disable", ret);
-:174: CHECK:LINE_SPACING: Please don't use multiple blank lines #174: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:812:
+
total: 0 errors, 0 warnings, 2 checks, 138 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add support for HDCP 1.4 over MST (rev3)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev3)
URL : https://patchwork.freedesktop.org/series/78749/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: expected unsigned int [addressable] [usertype] ulClockParams +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: got restricted __le32 [usertype] +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: warning: incorrect type in assignment (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1028:50: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1029:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1037:47: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:184:44: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:283:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:320:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:323:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:326:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:329:18: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:330:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:338:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:340:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:342:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:346:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:348:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:353:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:367:43: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:369:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:374:67: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:375:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:378:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:389:80: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:395:57: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:402:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:403:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:406:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:414:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:423:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:424:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:473:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:476:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:477:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:484:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:52:28: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:531:35: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:53:29: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:533:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:54:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:55:27: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:56:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:57:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:577:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:581:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:58:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:583:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:586:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:590:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:59:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:598:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:600:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:617:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:621:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:623:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:630:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:632:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:644:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:648:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:650:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:657:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:659:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:662:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:664:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:676:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:688:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:691:47: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:697:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:796:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:797:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:800:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:801:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:804:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:805:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:812:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:813:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:816:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:817:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:820:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:821:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:828:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:829:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:832:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:833:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:836:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:837:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:844:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:845:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:848:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:849:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:852:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:853:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:916:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:918:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:920:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:934:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:936:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:938:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:956:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:958:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:960:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:328:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:365:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:395:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:397:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:404:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:418:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:441:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:44:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:482:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:486:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:489:61: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:490:64: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:492:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:518:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:521:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:64:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:85:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:86:24: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:98:39: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:222:29: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:227:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:233:43: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:236:44: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:239:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:464:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:465:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:466:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:468:24: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: expected unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: got unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: expected struct drm_amdgpu_cs_chunk [noderef] __user **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: expected struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: got void [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: got struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: expected void const [noderef] __user *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: got struct drm_amdgpu_cs_chunk [noderef] __user **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1357:25: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1358:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: expected restricted __poll_t ( *poll )( ... ) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: got unsigned int ( * )( ... ) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:138:17: warning: incorrect type in initializer (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1417:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:261:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:263:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:354:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:412:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:473:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:531:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:592:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:650:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: expected void const volatile [noderef] __user * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: cast removes address space '__user' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:747:21: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1666:65: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1674:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1675:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1676:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1677:56: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1679:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1680:45: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1681:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1682:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1683:57: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1685:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1686:53: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1688:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1690:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1691:46: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1695:73: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1697:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1699:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for HDCP 1.4 over MST (rev3)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev3)
URL : https://patchwork.freedesktop.org/series/78749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8908 -> Patchwork_18375
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/index.html
Known issues
------------
Here are the changes found in Patchwork_18375 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-icl-y: [PASS][1] -> [DMESG-FAIL][2] ([i915#1993])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-icl-y/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-icl-y/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@gt_lrc:
- fi-tgl-u2: [PASS][3] -> [DMESG-FAIL][4] ([i915#1233])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-bsw-n3050/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-bsw-n3050/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-bsw-kefka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-bsw-kefka/igt@[email protected]
#### Warnings ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][10] ([i915#62] / [i915#92]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-kbl-x1275/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92]) -> [DMESG-WARN][12] ([i915#62] / [i915#92] / [i915#95]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/fi-kbl-x1275/igt@[email protected]
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (39 -> 34)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8908 -> Patchwork_18375
CI-20190529: 20190529
CI_DRM_8908: 03a59fdcea84502e199bf7fa55fd117dcd161dab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18375: 4e90cfaa37a596889db30ec5df8554617f6876c7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4e90cfaa37a5 drm/i915: Add HDCP 1.4 support for MST connectors8b877b97b221 drm/i915: Print HDCP version info for all connectors ee796c747bb0 drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message 88ed54f45d4a drm/i915: Add connector to hdcp_shim->check_link() cbf6864233d8 drm/i915: Plumb port through hdcp init3c4ef5d3a2fa drm/i915: Factor out HDCP shim functions from dp for use by dp_mst ec3ad644d55f drm/i915: Use ddi_update_pipe in intel_dp_mst2b6b206b775b drm/i915: Support DP MST in enc_to_dig_port() function c9bf9bc90816 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it aae84a3d1e58 drm/i915: Clean up intel_hdcp_disablef6bb1a3e3379 drm/i915: Protect workers against disappearing connectors 7659c82aec36 drm/i915: Factor out hdcp->value assignmentscd2828c49252 drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling f61be32af4f4 drm/i915: Intercept Aksv writes in the aux hooksf75a1292a09a drm/i915: WARN if HDCP signalling is enabled upon disable 2022ef4a6151 drm/i915: Clear the repeater bit on HDCP disable75835fa85a82 drm/i915: Fix sha_text population code
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for HDCP 1.4 over MST (rev3)
In reply to Sean Paul== Series Details ==
== Series Details ==
Series: drm/i915: Add support for HDCP 1.4 over MST (rev3)
URL : https://patchwork.freedesktop.org/series/78749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8908_full -> Patchwork_18375_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18375_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@nop:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([i915#2277])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-iclb8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-iclb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] / [i915#1635] / [i915#716])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-apl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-apl1/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-glk3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-glk8/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#1635] / [i915#54])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-apl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-apl2/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-glk7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-glk5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl4/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-fences@a-edp1:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +13 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl6/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +9 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl2/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#2122])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl2/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl1/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][27] -> [DMESG-FAIL][28] ([fdo#108145] / [i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl10/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][31] -> [FAIL][32] ([i915#31])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-hsw7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-hsw2/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([i915#198])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl10/igt@[email protected]
* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][35] -> [FAIL][36] ([i915#1542])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-iclb1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-iclb8/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [DMESG-WARN][37] ([i915#118] / [i915#95]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-glk4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-glk2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [WARN][39] ([i915#1519]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-hsw6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-hsw4/igt@[email protected]
* igt@i915_selftest@mock@contexts:
- shard-skl: [INCOMPLETE][41] ([i915#198] / [i915#2278]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl8/igt@i915_selftest@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl3/igt@i915_selftest@[email protected]
- shard-apl: [INCOMPLETE][43] ([i915#1635] / [i915#2278]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-apl3/igt@i915_selftest@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-apl1/igt@i915_selftest@[email protected]
* igt@kms_addfb_basic@bo-too-small:
- shard-iclb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-iclb2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-iclb6/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +10 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl9/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl1/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- shard-skl: [FAIL][51] ([i915#52] / [i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl10/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl7/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl3/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][57] ([fdo#108145] / [i915#265]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-skl6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-skl10/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-kbl: [DMESG-WARN][61] ([i915#165]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl1/igt@[email protected]
* igt@prime_busy@after@vecs0:
- shard-hsw: [FAIL][63] ([i915#2258]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-hsw7/igt@prime_busy@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-hsw2/igt@prime_busy@[email protected]
#### Warnings ####
* igt@kms_content_protection@lic:
- shard-kbl: [TIMEOUT][65] ([i915#1319] / [i915#1958]) -> [TIMEOUT][66] ([i915#1319])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [INCOMPLETE][67] ([i915#155]) -> [DMESG-WARN][68] ([i915#180])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-kbl2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-kbl7/igt@[email protected]
* igt@runner@aborted:
- shard-apl: [FAIL][69] ([i915#1635]) -> [FAIL][70] ([fdo#109271] / [i915#1635] / [i915#716])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8908/shard-apl3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/shard-apl1/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#2277]: https://gitlab.freedesktop.org/drm/intel/issues/2277
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8908 -> Patchwork_18375
CI-20190529: 20190529
CI_DRM_8908: 03a59fdcea84502e199bf7fa55fd117dcd161dab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18375: 4e90cfaa37a596889db30ec5df8554617f6876c7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18375/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Sean Paul
From: Sean Paul <[email protected]>
Only one functional change, reversed the hdcp_1x/2x_present bits in the
QUERY_STREAM_ENCRYPTION_STATUSparsing with a comment explaining my confusion.Other than that, lots of rebasing, the most notable being the s/intel_dig_port/dig_port/ rename.
Every patch now has a Reviewed-by tag now, I've done build tests on each patch and tested the set as a whole. Hopefully we can get this landed.
Thanks for the change. Merged into dinq.
Ram
Quoted 36 lines
Sean
Sean Paul (17):
drm/i915: Fixsha_textpopulation code
drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP signalling is enabled upon disable drm/i915: Intercept Aksv writes in the aux hooks drm/i915: Use thecpu_transcoderinintel_hdcpto toggle HDCP
signalling
drm/i915: Factor outhdcp->valueassignments
drm/i915: Protect workers against disappearing connectors drm/i915: Clean upintel_hdcp_disable
drm/i915: Don't fully disable HDCP on a port if multiple pipes are
using it
drm/i915: Support DP MST inenc_to_dig_port()function drm/i915: Useddi_update_pipeinintel_dp_mst
drm/i915: Factor out HDCP shim functions from dp for use bydp_mstdrm/i915: Plumb port through hdcp init
drm/i915: Add connector tohdcp_shim->check_link()drm/mst: Add support forQUERY_STREAM_ENCRYPTION_STATUSMST sideband
message
drm/i915: Print HDCP version info for all connectors drm/i915: Add HDCP 1.4 support for MST connectorsdrivers/gpu/drm/drm_dp_mst_topology.c | 150 ++++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 29 +- drivers/gpu/drm/i915/display/intel_ddi.h | 2 + .../drm/i915/display/intel_display_debugfs.c | 21 +- .../drm/i915/display/intel_display_types.h | 30 +- drivers/gpu/drm/i915/display/intel_dp.c | 646 +--------------- drivers/gpu/drm/i915/display/intel_dp.h | 9 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 703 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 + drivers/gpu/drm/i915/display/intel_hdcp.c | 217 ++++--
Quoted 16 lines
drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 30 +- .../drm/selftests/test-drm_dp_mst_helper.c | 17 + include/drm/drm_dp_helper.h | 3 + include/drm/drm_dp_mst_helper.h | 44 ++ include/drm/drm_hdcp.h | 3 + 17 files changed, 1202 insertions(+), 724 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dp_hdcp.cSignature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx