docs: trusted-encrypted.rst: update parameters for command examples
Subsystems (4)
PATCH v3 1/1 docs: trusted-encrypted.rst: update parameters for command examples
The parameters in command examples for tpm2_createprimary and tpm2_evictcontrol are outdated, people (like me) are not able to create trusted key by these command examples.
This patch updates the parameters of command example tpm2_createprimary and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.
---
Changelog:
v3: update commit log with review comments from Jarkko Sakkinen.
v2: remove the change of trusted key related operation.
v1: initial version.
Documentation/security/keys/trusted-encrypted.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Documentation/security/keys/trusted-encrypted.rst +2 -3
@@ -39,10 +39,9 @@ With the IBM TSS 2 stack:: Or with the Intel TSS 2 stack:: - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt [...] - handle: 0x800000FF - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001 + #> tpm2_evictcontrol -c key.ctxt 0x81000001 persistentHandle: 0x81000001 Usage::
Signature · 1 line
2.26.2
Quoted 9 lines · Coly Li
The parameters in command examples for
tpm2_createprimaryandtpm2_evictcontrolare outdated, people (like me) are not able to create trusted key by these command examples.This patch updates the parameters of command example
tpm2_createprimaryandtpm2_evictcontrolintrusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.
Quoted 6 lines
Signed-off-by Coly Li <[email protected]>Cc Dan Williams <[email protected]>Cc James Bottomley <[email protected]>Cc Jarkko Sakkinen <[email protected]>Cc Mimi Zohar <[email protected]>Cc Stefan Berger <[email protected]>
OK, now it is clear. Thank you.
/Jarkko
Quoted 29 lines
---
Changelog:
v3: update commit log with review comments from Jarkko Sakkinen.
v2: remove the change of trusted key related operation.
v1: initial version.Documentation/security/keys/trusted-encrypted.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Documentation/security/keys/trusted-encrypted.rst +2
-3@@ -39,10 +39,9 @@ With the IBM TSS 2 stack:: Or with the Intel TSS 2 stack:: - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt - handle: 0x800000FF - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001 + #> tpm2_evictcontrol -c key.ctxt 0x81000001 persistentHandle: 0x81000001 Usage::Signature · 1 line
2.26.2
Quoted 17 lines · Jarkko Sakkinen
Quoted 9 lines · Coly Li
The parameters in command examples for
tpm2_createprimaryandtpm2_evictcontrolare outdated, people (like me) are not able to create trusted key by these command examples.This patch updates the parameters of command example
tpm2_createprimaryandtpm2_evictcontrolintrusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.Quoted 6 lines
Signed-off-by Coly Li <[email protected]>Cc Dan Williams <[email protected]>Cc James Bottomley <[email protected]>Cc Jarkko Sakkinen <[email protected]>Cc Mimi Zohar <[email protected]>Cc Stefan Berger <[email protected]>
Quoted 3 lines
OK, now it is clear. Thank you.
Reviewed-by Jarkko Sakkinen <[email protected]>
There is one problem though.
You have missed to add linux-doc and linux-integrity maintainers and also their maintainers from the CC list. You need to resend this patch with that information. Use get_maintainers.pl or look from the file called MAINTAINERS.
/Jarkko
Quoted 20 lines · Jarkko Sakkinen
Quoted 19 lines · Jarkko Sakkinen
Quoted 9 lines · Coly Li
The parameters in command examples for
tpm2_createprimaryandtpm2_evictcontrolare outdated, people (like me) are not able to create trusted key by these command examples.This patch updates the parameters of command example
tpm2_createprimaryandtpm2_evictcontrolintrusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.Quoted 6 lines
Signed-off-by Coly Li <[email protected]>Cc Dan Williams <[email protected]>Cc James Bottomley <[email protected]>Cc Jarkko Sakkinen <[email protected]>Cc Mimi Zohar <[email protected]>Cc Stefan Berger <[email protected]>OK, now it is clear. Thank you.
Quoted 8 lines
Quoted 1 line
Reviewed-by Jarkko Sakkinen <[email protected]>There is one problem though.
You have missed to add linux-doc and linux-integrity maintainers and also their maintainers from the CC list. You need to resend this patch with that information. Use get_maintainers.pl or look from the file called
MAINTAINERS.
Copied. Some of the maintainers are in Cc list already, I add rested in v4 patch, and Cc linux-doc and linux-integrity mailing lists.
Thanks.
Coly Li
Quoted 25 lines · Coly Li
Quoted 24 lines · Jarkko Sakkinen
Quoted 17 lines · Jarkko Sakkinen
Quoted 9 lines · Coly Li
The parameters in command examples for
tpm2_createprimaryandtpm2_evictcontrolare outdated, people (like me) are not able to create trusted key by these command examples.This patch updates the parameters of command example
tpm2_createprimaryandtpm2_evictcontrolintrusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.Quoted 6 lines
Signed-off-by Coly Li <[email protected]>Cc Dan Williams <[email protected]>Cc James Bottomley <[email protected]>Cc Jarkko Sakkinen <[email protected]>Cc Mimi Zohar <[email protected]>Cc Stefan Berger <[email protected]>Quoted 3 lines
OK, now it is clear. Thank you.
Reviewed-by Jarkko Sakkinen <[email protected]>There is one problem though.
Quoted 7 lines
Quoted 4 lines
You have missed to add linux-doc and linux-integrity maintainers and also their maintainers from the CC list. You need to resend this patch with that information. Use get_maintainers.pl or look from the file called
MAINTAINERS.Copied. Some of the maintainers are in Cc list already, I add rested in v4 patch, and Cc linux-doc and linux-integrity mailing lists.
Please do.
Quoted 3 lines
Thanks.
Coly Li
BR,
/Jarkko
Stefan Berger
Reviewed-byQuoted 16 lines · Jarkko Sakkinen
Quoted 9 lines · Coly Li
The parameters in command examples for
tpm2_createprimaryandtpm2_evictcontrolare outdated, people (like me) are not able to create trusted key by these command examples.This patch updates the parameters of command example
tpm2_createprimaryandtpm2_evictcontrolintrusted-encrypted.rst. With Linux kernel v5.8 and tpm2-tools-4.1, people can create a trusted key by following the examples in this document.Quoted 6 lines
Signed-off-by Coly Li <[email protected]>Cc Dan Williams <[email protected]>Cc James Bottomley <[email protected]>Cc Jarkko Sakkinen <[email protected]>Cc Mimi Zohar <[email protected]>Cc Stefan Berger <[email protected]>
Quoted 3 lines
OK, now it is clear. Thank you.
Reviewed-by Jarkko Sakkinen <[email protected]>
Quoted 32 lines
/Jarkko
Quoted 29 lines
---
Changelog:
v3: update commit log with review comments from Jarkko Sakkinen.
v2: remove the change of trusted key related operation.
v1: initial version.Documentation/security/keys/trusted-encrypted.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Documentation/security/keys/trusted-encrypted.rst +2
-3@@ -39,10 +39,9 @@ With the IBM TSS 2 stack:: Or with the Intel TSS 2 stack:: - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt - handle: 0x800000FF - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001 + #> tpm2_evictcontrol -c key.ctxt 0x81000001 persistentHandle: 0x81000001 Usage::Signature · 1 line
2.26.2