Skip to contentSkip to conversation

nvme: skip noiob for zoned devices

PATCH In review Keith Busch 3 participants 7 messages Aug 18, 2020 NVMe

lore
Share & tools
lore

Keith Busch

author maintainer
#0 lore raw

PATCH v3 1/1 nvme: skip noiob for zoned devices

Zoned block devices reuse the chunk_sectors queue limit to define zone boundaries. If a such a device happens to also report an optimal boundary, log a warning of the conflicting attributes and do not use that to define the chunk_sectors as that may intermittently interfere with io splitting and zone size queries.

---
v2 -> v3:

Emit a warning on the initial validation if a zoned device reports an optimal boundary.

 drivers/nvme/host/core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/nvme/host/core.c +7 -2
index 88cff309d8e4..10cf40d2cfef 100644
@@ -2075,8 +2075,13 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)
 		}
 	}
 
-	if (iob)
-		blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+	if (iob) {
+		if (!blk_queue_is_zoned(disk->queue))
+			blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+		else if (!(disk->flags & GENHD_FL_UP))
+			pr_warn("%s: zone namespace has unused IO boundary:%u\n",
+				disk->disk_name, iob);
+	}
 	nvme_update_disk_info(disk, ns, id);
 #ifdef CONFIG_NVME_MULTIPATH
 	if (ns->head->disk) {
Signature · 7 lines
2.24.1


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
#1 lore raw
Quoted 22 lines · Keith Busch

Zoned block devices reuse the chunk_sectors queue limit to define zone boundaries. If a such a device happens to also report an optimal boundary, log a warning of the conflicting attributes and do not use that to define the chunk_sectors as that may intermittently interfere with io splitting and zone size queries.

---
v2 -> v3:

Emit a warning on the initial validation if a zoned device reports an optimal boundary.

 drivers/nvme/host/core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/nvme/host/core.c +0 -0
index 88cff309d8e4..10cf40d2cfef 100644
@@ -2075,8 +2075,13 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)
 		}

drivers/nvme/host/core.c static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) · line 2083

Quoted 10 lines
drivers/nvme/host/core.c +6 -2
 	}
 
-	if (iob)
-		blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+	if (iob) {
+		if (!blk_queue_is_zoned(disk->queue))
+			blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+		else if (!(disk->flags & GENHD_FL_UP))
+			pr_warn("%s: zone namespace has unused IO boundary:%u\n",
+				disk->disk_name, iob);

This has some overly long line and looks fairly convoluted, what about something like:

	if (iob) {
		unsigned int chunk_sectors = rounddown_pow_of_two(iob);

		if (blk_queue_is_zoned(disk->queue) &&
		    chunk_sectors > blk_queue_zone_sectors(disk->queue))
			pr_warn("%s: ignoring too large IO boundary: %u\n",
				disk->disk_name, iob);
		else
			blk_queue_chunk_sectors(ns->queue, chunk_sectors);
	}

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

author maintainer
#2 lore raw
Quoted 12 lines · Christoph Hellwig

drivers/nvme/host/core.c static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) · line 2083

Quoted 8 lines
drivers/nvme/host/core.c +6 -2
-	if (iob)
-		blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+	if (iob) {
+		if (!blk_queue_is_zoned(disk->queue))
+			blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+		else if (!(disk->flags & GENHD_FL_UP))
+			pr_warn("%s: zone namespace has unused IO boundary:%u\n",
+				disk->disk_name, iob);

This has some overly long line and looks fairly convoluted, what about something like:

Quoted 2 lines
	if (iob) {
		unsigned int chunk_sectors = rounddown_pow_of_two(iob);

Unrelated to this particular patch, but ... why is this rounddown here? While we can't use chunk_sectors if it is not a power of two, but what benefit are we expecting to get from using the wrong boundary just because it's convenient to our block stack?

Quoted 2 lines
		if (blk_queue_is_zoned(disk->queue) &&
		    chunk_sectors > blk_queue_zone_sectors(disk->queue))

I don't think we should skip iob just for the case where chunk_sectors is the larger value. A smaller value still ruins things like blk_queue_zone_sectors() and blk_queue_zone_no().

Also, we call blk_revalidate_disk_zones() after the iob check, so the blk_queue_zone_sectors() hasn't been initialized for this revalidate.

Quoted 2 lines
			pr_warn("%s: ignoring too large IO boundary: %u\n",
				disk->disk_name, iob);

We don't want to emit a repeated warning on every disk revalidation, so I added the check for GENHD_FL_UP to warn only on the very first disk validation.

Quoted 3 lines
		else
			blk_queue_chunk_sectors(ns->queue, chunk_sectors);
	}

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

#3 lore raw
Quoted 13 lines · Keith Busch
Quoted 12 lines · Christoph Hellwig

drivers/nvme/host/core.c static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) · line 2083

Quoted 8 lines
drivers/nvme/host/core.c +6 -2
-	if (iob)
-		blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+	if (iob) {
+		if (!blk_queue_is_zoned(disk->queue))
+			blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+		else if (!(disk->flags & GENHD_FL_UP))
+			pr_warn("%s: zone namespace has unused IO boundary:%u\n",
+				disk->disk_name, iob);

This has some overly long line and looks fairly convoluted, what about something like:

Quoted 7 lines
Quoted 2 lines
	if (iob) {
		unsigned int chunk_sectors = rounddown_pow_of_two(iob);

Unrelated to this particular patch, but ... why is this rounddown here? While we can't use chunk_sectors if it is not a power of two, but what benefit are we expecting to get from using the wrong boundary just because it's convenient to our block stack?

True, might make sense to add a validity check instead.

Quoted 11 lines
Quoted 3 lines
 
		if (blk_queue_is_zoned(disk->queue) &&
		    chunk_sectors > blk_queue_zone_sectors(disk->queue))

I don't think we should skip iob just for the case where chunk_sectors is the larger value. A smaller value still ruins things like blk_queue_zone_sectors() and blk_queue_zone_no().

Also, we call blk_revalidate_disk_zones() after the iob check, so the blk_queue_zone_sectors() hasn't been initialized for this revalidate.

Quoted 6 lines
Quoted 2 lines
			pr_warn("%s: ignoring too large IO boundary: %u\n",
				disk->disk_name, iob);

We don't want to emit a repeated warning on every disk revalidation, so I added the check for GENHD_FL_UP to warn only on the very first disk validation.

Ok. Maybe we just need to move the whole thing into a helper to look less confusing.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme