net: gianfar: Add of_node_put() before goto statement
PATCH 1/1 net: gianfar: Add of_node_put() before goto statement
Every iteration of for_each_available_child_of_node() decrements reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.
Fix a potential memory leak in gianfar.c by inserting of_node_put() before the goto statement.
Issue found with Coccinelle.
--- drivers/net/ethernet/freescale/gianfar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/freescale/gianfar.c +3 -1
@@ -750,8 +750,10 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)continue ; err =gfar_parse_group (child, priv, model); -if (err) +if (err) { +of_node_put (child); goto err_grp_init; + } } }else {/* SQ_SG_MODE */ err =gfar_parse_group (np, priv, model);
Signature · 1 line
2.17.1
From: Sumera Priyadarsini <[email protected]>
Date: Wed, 19 Aug 2020 00:22:41 +0530
Quoted 6 lines
Every iteration of
for_each_available_child_of_node()decrements reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.
Quoted 6 lines
Fix a potential memory leak in
gianfar.cby insertingof_node_put()before the goto statement.Issue found with Coccinelle.
Signed-off-by Sumera Priyadarsini <[email protected]>
These OF iterators are so error prone...
Applied, thanks.