tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe()
PATCH v2 1/2 tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe()
From: Lyude Paul <[email protected]>
v2: Rebase
--- tests/kms_pipe_crc_basic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
tests/kms_pipe_crc_basic.c +3 -4
@@ -65,15 +65,14 @@ static void test_bad_source(data_t *data)static void test_read_crc (data_t *data,enum pipe pipe,unsigned flags) {igt_display_t *display = &data->display; -igt_output_t *output =igt_get_single_output_for_pipe (display, pipe); +igt_output_t *output;igt_plane_t *primary;drmModeModeInfo *mode;igt_crc_t *crcs =NULL ;int c, j; -igt_require_pipe (display, pipe); -igt_require_f (output,"No connector found for pipe %s\n" , -kmstest_pipe_name (pipe)); +igt_display_require_output_on_pipe (display, pipe); + output =igt_get_single_output_for_pipe (display, pipe);igt_display_reset (display);igt_output_set_pipe (output, pipe);
Signature · 6 lines
2.26.2 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v2 2/2 tests/kms_pipe_crc_basic: Add disable-crc-after-crtc-pipe-* tests
From: Lyude Paul <[email protected]>
I ended up hitting some bugs when writing nouveau's CRC implementation due to incorrectly handling the situation where we disable CRCs on a pipe that already been disabled, which ended up causing some other vague igt issues when running certain tests in multi-mode.
So, let's add a trivial test for this scenario while we're at it.
v2:
* Rebased
* Write test description for new tests
--- tests/kms_pipe_crc_basic.c | 40 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
tests/kms_pipe_crc_basic.c +40 -0
@@ -221,6 +221,41 @@ static void test_compare_crc(data_t *data, enum pipe pipe)igt_remove_fb (data->drm_fd, &fb1); } +static void test_disable_crc_after_crtc (data_t *data,enum pipe pipe) +{ +igt_display_t *display = &data->display; +igt_output_t *output =igt_get_single_output_for_pipe (&data->display, pipe); +igt_pipe_crc_t *pipe_crc =igt_pipe_crc_new (data->drm_fd, pipe,"auto" ); +drmModeModeInfo *mode =igt_output_get_mode (output); +igt_crc_t crc[2 ]; + +igt_display_reset (display); +igt_output_set_pipe (output, pipe); + +igt_create_color_fb (data->drm_fd, + mode->hdisplay, mode->vdisplay, +DRM_FORMAT_XRGB8888 , +LOCAL_DRM_FORMAT_MOD_NONE , +0.0 ,1.0 ,0.0 , &data->fb); +igt_plane_set_fb (igt_output_get_plane (output,0 ), &data->fb); +igt_display_commit (display); + +igt_pipe_crc_start (pipe_crc); +igt_pipe_crc_get_current (data->drm_fd, pipe_crc, &crc[0 ]); + +kmstest_set_connector_dpms (data->drm_fd, output->config.connector, +DRM_MODE_DPMS_OFF ); +igt_pipe_crc_stop (pipe_crc); + +kmstest_set_connector_dpms (data->drm_fd, output->config.connector, +DRM_MODE_DPMS_ON ); +igt_pipe_crc_collect_crc (pipe_crc, &crc[1 ]); +igt_assert_crc_equal (&crc[0 ], &crc[1 ]); + +igt_pipe_crc_free (pipe_crc); +igt_remove_fb (data->drm_fd, &data->fb); +} +data_t data = {0 , }; igt_main
@@ -265,6 +300,11 @@ igt_maintest_read_crc (&data, pipe,0 ); } +igt_describe ("Check that disabling CRCs on a CRTC after having disabled the CRTC " +"does not cause issues." ); + igt_subtest_f("disable-crc-after-crtc-pipe-%s", kmstest_pipe_name(pipe)) +test_disable_crc_after_crtc (&data, pipe); + igt_subtest_f("hang-read-crc-pipe-%s", kmstest_pipe_name(pipe)) {igt_hang_t hang =igt_allow_hang (data.drm_fd,0 ,0 );
Signature · 6 lines
2.26.2 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_pipe_crc_basic: Add disable-crc-after-crtc-pipe-* tests
Quoted 32 lines · Lyude
From: Lyude Paul <[email protected]>
I ended up hitting some bugs when writing nouveau's CRC implementation due to incorrectly handling the situation where we disable CRCs on a pipe that already been disabled, which ended up causing some other vague igt issues when running certain tests in multi-mode.
So, let's add a trivial test for this scenario while we're at it.
v2:
* Rebased
* Write test description for new testsSigned-off-by Lyude Paul <[email protected]>--- tests/kms_pipe_crc_basic.c | 40 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)tests/kms_pipe_crc_basic.c +6
-0@@ -221,6 +221,41 @@ static void test_compare_crc(data_t *data, enum pipe pipe)igt_remove_fb (data->drm_fd, &fb1); } +static void test_disable_crc_after_crtc (data_t *data,enum pipe pipe) +{ +igt_display_t *display = &data->display; +igt_output_t *output =igt_get_single_output_for_pipe (&data->display, pipe); +igt_pipe_crc_t *pipe_crc =igt_pipe_crc_new (data->drm_fd, pipe,"auto" ); +drmModeModeInfo *mode =igt_output_get_mode (output);
tests/kms_pipe_crc_basic.c static void test_compare_crc(data_t *data, enum pipe pipe) · line 239
Quoted 10 lines
tests/kms_pipe_crc_basic.c +10
-0+igt_crc_t crc[2 ]; + +igt_display_reset (display); +igt_output_set_pipe (output, pipe); + +igt_create_color_fb (data->drm_fd, + mode->hdisplay, mode->vdisplay, +DRM_FORMAT_XRGB8888 , +LOCAL_DRM_FORMAT_MOD_NONE , +0.0 ,1.0 ,0.0 , &data->fb);
The API docs indicate this could return a negative error code. I'm not sure what errors there could be so I don't know if it's worth adding a check here, but just something to consider. It looks like much (all?) the existing code doesn't check so I guess it's not that problematic.
Quoted 37 lines
tests/kms_pipe_crc_basic.c +24
-0+igt_plane_set_fb (igt_output_get_plane (output,0 ), &data->fb); +igt_display_commit (display); + +igt_pipe_crc_start (pipe_crc); +igt_pipe_crc_get_current (data->drm_fd, pipe_crc, &crc[0 ]); + +kmstest_set_connector_dpms (data->drm_fd, output->config.connector, +DRM_MODE_DPMS_OFF ); +igt_pipe_crc_stop (pipe_crc); + +kmstest_set_connector_dpms (data->drm_fd, output->config.connector, +DRM_MODE_DPMS_ON ); +igt_pipe_crc_collect_crc (pipe_crc, &crc[1 ]); +igt_assert_crc_equal (&crc[0 ], &crc[1 ]); + +igt_pipe_crc_free (pipe_crc); +igt_remove_fb (data->drm_fd, &data->fb); +} +data_t data = {0 , }; igt_main@@ -265,6 +300,11 @@ igt_maintest_read_crc (&data, pipe,0 ); } +igt_describe ("Check that disabling CRCs on a CRTC after having disabled the CRTC " +"does not cause issues." ); + igt_subtest_f("disable-crc-after-crtc-pipe-%s", kmstest_pipe_name(pipe)) +test_disable_crc_after_crtc (&data, pipe); + igt_subtest_f("hang-read-crc-pipe-%s", kmstest_pipe_name(pipe)) {igt_hang_t hang =igt_allow_hang (data.drm_fd,0 ,0 );Signature · 1 line
2.26.2
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe()
In reply to Lyude== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe()
URL : https://patchwork.freedesktop.org/series/80759/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8900 -> IGTPW_4887
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4887 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_4887, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4887:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_parallel@engines@contexts:
- fi-skl-lmem: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-skl-lmem/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-skl-lmem/igt@gem_exec_parallel@[email protected]
* igt@runner@aborted:
- fi-skl-lmem: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-skl-lmem/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_4887 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][4] -> [DMESG-WARN][5] ([i915#62] / [i915#92] / [i915#95])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@kms_busy@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][6] -> [DMESG-WARN][7] ([i915#1982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-byt-j1900/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-byt-j1900/igt@[email protected]
- fi-bsw-kefka: [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-bsw-kefka/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-bsw-kefka/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][10] ([i915#1888]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-tgl-u2/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-tgl-u2/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-apl-guc: [INCOMPLETE][12] ([i915#1635]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-apl-guc/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-apl-guc/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][14] ([i915#2203]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-7500u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-7500u/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][16] ([i915#2203]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-skl-guc/igt@kms_flip@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-skl-guc/igt@kms_flip@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][18] ([i915#62] / [i915#92]) -> [DMESG-WARN][19] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][20] ([fdo#109271]) -> [DMESG-FAIL][21] ([i915#2203])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-guc/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-guc/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][22] ([i915#62] / [i915#95]) -> [DMESG-FAIL][23] ([i915#62])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-kbl-x1275: [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][25] ([i915#62] / [i915#92]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][26] ([i915#62] / [i915#92]) -> [DMESG-WARN][27] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (39 -> 34)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5769 -> IGTPW_4887
CI-20190529: 20190529
CI_DRM_8900: 3dc196787bc40e012dece11fc052a4dd467bc421 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4887: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/index.html
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-a +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-e +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-f
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4887/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe() (rev2)
In reply to Lyude== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe() (rev2)
URL : https://patchwork.freedesktop.org/series/80759/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8900 -> IGTPW_4888
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
Known issues
------------
Here are the changes found in IGTPW_4888 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-bsw-n3050: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-bsw-n3050/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-bsw-n3050/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-byt-j1900/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-bsw-kefka/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-bsw-kefka/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][7] ([i915#1888]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-tgl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-tgl-u2/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-apl-guc: [INCOMPLETE][9] ([i915#1635]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-apl-guc/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-apl-guc/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][11] ([i915#2203]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-kbl-7500u/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-kbl-x1275/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][17] ([i915#62] / [i915#95]) -> [DMESG-FAIL][18] ([i915#62])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/fi-kbl-x1275/igt@[email protected]
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (39 -> 34)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5769 -> IGTPW_4888
CI-20190529: 20190529
CI_DRM_8900: 3dc196787bc40e012dece11fc052a4dd467bc421 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4888: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-a +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-e +igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-f
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe() (rev2)
In reply to Lyude== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,v2,1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe() (rev2)
URL : https://patchwork.freedesktop.org/series/80759/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8900_full -> IGTPW_4888_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
New tests
---------
New tests have been introduced between CI_DRM_8900_full and IGTPW_4888_full:
### New IGT tests (4) ###
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-a:
- Statuses : 7 pass(s)
- Exec time: [0.33, 1.50] s
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b:
- Statuses : 7 pass(s)
- Exec time: [0.39, 2.48] s
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 2.60] s
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- Statuses : 1 pass(s) 6 skip(s)
- Exec time: [0.0, 2.46] s
Known issues
------------
Here are the changes found in IGTPW_4888_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@execbuf:
- shard-hsw: [PASS][1] -> [TIMEOUT][2] ([i915#1958])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw6/igt@[email protected]
- shard-snb: [PASS][3] -> [TIMEOUT][4] ([i915#1958])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-snb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-snb5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][5] -> [FAIL][6] ([i915#454])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb6/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [PASS][7] -> [WARN][8] ([i915#1515])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-tglb3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-tglb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#49])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-glk9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-glk8/igt@[email protected]
* igt@kms_panel_fitting@atomic-fastset:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#83])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb3/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#1385])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl4/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#62] / [i915#92]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl6/igt@[email protected]
* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#1542])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb8/igt@[email protected]
* igt@perf@create-destroy-userspace-config:
- shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-glk2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-glk9/igt@[email protected]
- shard-apl: [PASS][27] -> [SKIP][28] ([fdo#109271] / [i915#1635])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-apl7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-apl4/igt@[email protected]
- shard-tglb: [PASS][29] -> [SKIP][30] ([i915#405])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-tglb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-tglb3/igt@[email protected]
- shard-kbl: [PASS][31] -> [SKIP][32] ([fdo#109271])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl1/igt@[email protected]
- shard-hsw: [PASS][33] -> [SKIP][34] ([fdo#109271])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw1/igt@[email protected]
- shard-iclb: [PASS][35] -> [SKIP][36] ([i915#405])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb6/igt@[email protected]
* igt@prime_busy@before@vecs0:
- shard-hsw: [PASS][37] -> [FAIL][38] ([i915#2258]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw7/igt@prime_busy@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw4/igt@prime_busy@[email protected]
#### Possible fixes ####
* igt@gem_ctx_shared@q-smoketest-all:
- shard-glk: [DMESG-WARN][39] ([i915#118] / [i915#95]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-glk5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-glk7/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-snb: [TIMEOUT][41] ([i915#1958]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-snb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-snb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][43] ([i915#1436] / [i915#1635] / [i915#716]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-apl3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-apl8/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- shard-tglb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-tglb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-tglb2/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][47] ([i915#79]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-glk6/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-glk4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-kbl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [INCOMPLETE][51] ([i915#155]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl2/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl1/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- shard-glk: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-glk2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-glk1/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@oa-exponents:
- shard-hsw: [INCOMPLETE][59] ([i915#1958]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw7/igt@[email protected]
* igt@prime_busy@hang-wait@bcs0:
- shard-hsw: [FAIL][61] ([i915#2258]) -> [PASS][62] +9 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw4/igt@prime_busy@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw8/igt@prime_busy@[email protected]
#### Warnings ####
* igt@gem_exec_schedule@preemptive-hang:
- shard-snb: [TIMEOUT][63] ([i915#1958]) -> [SKIP][64] ([fdo#109271]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-snb4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-snb4/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt:
- shard-hsw: [SKIP][65] ([fdo#109271]) -> [TIMEOUT][66] ([i915#1958]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw7/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: [FAIL][67] ([fdo#108145] / [i915#265]) -> [FAIL][68] ([fdo#108145] / [i915#1385] / [i915#265])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-kbl1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-kbl6/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-snb: [SKIP][69] ([fdo#109271]) -> [TIMEOUT][70] ([i915#1958]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-snb5/igt@kms_psr@psr2_basic.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-snb5/igt@kms_psr@psr2_basic.html
* igt@runner@aborted:
- shard-hsw: ([FAIL][71], [FAIL][72]) ([i915#1958] / [i915#2283]) -> [FAIL][73] ([i915#2283])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-hsw4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-hsw8/igt@[email protected]
- shard-apl: ([FAIL][74], [FAIL][75]) ([fdo#109271] / [i915#1635] / [i915#2110] / [i915#716]) -> [FAIL][76] ([i915#1635] / [i915#2110])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-apl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8900/shard-apl3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/shard-apl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#405]: https://gitlab.freedesktop.org/drm/intel/issues/405
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#83]: https://gitlab.freedesktop.org/drm/intel/issues/83
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5769 -> IGTPW_4888
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8900: 3dc196787bc40e012dece11fc052a4dd467bc421 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4888: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4888/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 6 lines · Lyude
From: Lyude Paul <[email protected]>
v2: Rebase
Signed-off-by Lyude Paul <[email protected]>---
It might be worth a short commit message body, something like "Refactor tests_read_crc() to use igt_display_require_output_on_pipe() rather than checking the validity of the pipe and output separately" maybe?
Quoted 29 lines
tests/kms_pipe_crc_basic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)tests/kms_pipe_crc_basic.c +3
-4@@ -65,15 +65,14 @@ static void test_bad_source(data_t *data)static void test_read_crc (data_t *data,enum pipe pipe,unsigned flags) {igt_display_t *display = &data->display; -igt_output_t *output =igt_get_single_output_for_pipe (display, pipe); +igt_output_t *output;igt_plane_t *primary;drmModeModeInfo *mode;igt_crc_t *crcs =NULL ;int c, j; -igt_require_pipe (display, pipe); -igt_require_f (output,"No connector found for pipe %s\n" , -kmstest_pipe_name (pipe)); +igt_display_require_output_on_pipe (display, pipe); + output =igt_get_single_output_for_pipe (display, pipe);igt_display_reset (display);igt_output_set_pipe (output, pipe);Signature · 1 line
2.26.2
Looks like a good refactor to me:
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev