Skip to contentSkip to conversation

package/iprutils: fix build with gcc 4.8

PATCH New Fabrice Fontaine 2 participants 2 messages Aug 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/iprutils: fix build with gcc 4.8

Fixes:
- http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f

---
 ...gure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch | 44 +++++++++++++++++++
 package/iprutils/iprutils.mk                  |  2 +
 2 files changed, 46 insertions(+)
 create mode 100644 package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch new file +44 -0
new file mode 100644
index 0000000000..76085b4a3c
@@ -0,0 +1,44 @@
+From 068f37c100e105fd8edcae07762613e8e33c5282 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Tue, 18 Aug 2020 20:26:58 +0200
+Subject: [PATCH] configure.ac: add AC_USE_SYSTEM_EXTENSIONS
+
+Build with gcc 4.8 will raise two errors, one on uint, the other one on
+alphasort:
+
+In file included from iprdump.c:17:0:
+iprlib.h:1866:2: error: unknown type name 'uint'
+  uint supported_with_min_ucode_level;
+  ^
+
+iprlib.c: In function 'ipr_get_pci_slots':
+iprlib.c:1999:48: error: 'alphasort' undeclared (first use in this function)
+  num_slots = scandir(rootslot, &slotdir, NULL, alphasort);
+                                                ^
+
+Fix them by adding AC_USE_SYSTEM_EXTENSIONS in configure.ac
+
+Fixes:
+ - http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: https://github.com/bjking1/iprutils/pull/4]
+---
+ configure.ac | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/configure.ac b/configure.ac
+index 462a8b5..7f5fa7d 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -14,6 +14,7 @@ AC_INIT([iprutils], [2.4.19.1], [iprdd-devel at lists.sourceforge.net])
+ 
+ AM_INIT_AUTOMAKE([1.9 foreign])
+ AC_CONFIG_MACRO_DIR([build-aux])
++AC_USE_SYSTEM_EXTENSIONS
+ 
+ # Checks for programs.
+ AC_PROG_CC
+-- 
+2.27.0
+
package/iprutils/iprutils.mk +2 -0
index 3fa8223ff6..9595125ac9 100644
@@ -10,5 +10,7 @@ IPRUTILS_SITE = https://downloads.sourceforge.net/project/iprdd/iprutils%20for%2
 IPRUTILS_DEPENDENCIES = ncurses libsysfs pciutils zlib
 IPRUTILS_LICENSE = Common Public License Version 1.0
 IPRUTILS_LICENSE_FILES = LICENSE
+# We"re patching configure.ac
+IPRUTILS_AUTORECONF = YES
 
 $(eval $(autotools-package))
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/iprutils: fix build with gcc 4.8

Fabrice, All,

On 2020-08-18 21:12 +0200, Fabrice Fontaine spake thusly:

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f

Issues are with glibc version, not gcc version, so I tweaked the patch' commit and the commit log accordingly, and applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 75 lines
---
 ...gure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch | 44 +++++++++++++++++++
 package/iprutils/iprutils.mk                  |  2 +
 2 files changed, 46 insertions(+)
 create mode 100644 package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch new file +44 -0
new file mode 100644
index 0000000000..76085b4a3c
@@ -0,0 +1,44 @@
+From 068f37c100e105fd8edcae07762613e8e33c5282 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Tue, 18 Aug 2020 20:26:58 +0200
+Subject: [PATCH] configure.ac: add AC_USE_SYSTEM_EXTENSIONS
+
+Build with gcc 4.8 will raise two errors, one on uint, the other one on
+alphasort:
+
+In file included from iprdump.c:17:0:
+iprlib.h:1866:2: error: unknown type name 'uint'
+  uint supported_with_min_ucode_level;
+  ^
+
+iprlib.c: In function 'ipr_get_pci_slots':
+iprlib.c:1999:48: error: 'alphasort' undeclared (first use in this function)
+  num_slots = scandir(rootslot, &slotdir, NULL, alphasort);
+                                                ^
+
+Fix them by adding AC_USE_SYSTEM_EXTENSIONS in configure.ac
+
+Fixes:
+ - http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: https://github.com/bjking1/iprutils/pull/4]
+---
+ configure.ac | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/configure.ac b/configure.ac
+index 462a8b5..7f5fa7d 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -14,6 +14,7 @@ AC_INIT([iprutils], [2.4.19.1], [iprdd-devel at lists.sourceforge.net])
+ 
+ AM_INIT_AUTOMAKE([1.9 foreign])
+ AC_CONFIG_MACRO_DIR([build-aux])
++AC_USE_SYSTEM_EXTENSIONS
+ 
+ # Checks for programs.
+ AC_PROG_CC
+-- 
+2.27.0
+
package/iprutils/iprutils.mk +2 -0
index 3fa8223ff6..9595125ac9 100644
@@ -10,5 +10,7 @@ IPRUTILS_SITE = https://downloads.sourceforge.net/project/iprdd/iprutils%20for%2
 IPRUTILS_DEPENDENCIES = ncurses libsysfs pciutils zlib
 IPRUTILS_LICENSE = Common Public License Version 1.0
 IPRUTILS_LICENSE_FILES = LICENSE
+# We"re patching configure.ac
+IPRUTILS_AUTORECONF = YES
 
 $(eval $(autotools-package))
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'