spi: imx: Do not print an error when PIO is used
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 spi: imx: Do not print an error when PIO is used
There are cases that DMA is not used and the driver gracefully falls back to PIO mode.
Do not treat it like an error message and move it to debug level instead.
--- drivers/spi/spi-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-imx.c +1 -1
@@ -1693,7 +1693,7 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put;if (ret <0 ) -dev_err (&pdev->dev,"dma setup error %d, use pio\n" , +dev_dbg (&pdev->dev,"dma setup error %d, use pio\n" , ret); }
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH 2/2 spi: imx: Remove unneeded probe message
There is no point in printing a plain "probed" message on successful probe.
Just remove it and make the kernel log a bit less noisier.
--- drivers/spi/spi-imx.c | 2 -- 1 file changed, 2 deletions(-)
drivers/spi/spi-imx.c +0 -2
@@ -1708,8 +1708,6 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put; } -dev_info (&pdev->dev,"probed\n" ); -clk_disable (spi_imx->clk_ipg);clk_disable (spi_imx->clk_per);return ret;
Signature · 1 line
2.17.1
Mark Brown
maintainerRe: [PATCH 2/2] spi: imx: Remove unneeded probe message
Quoted 3 lines · Fabio Estevam
There is no point in printing a plain "probed" message on successful probe.
Just remove it and make the kernel log a bit less noisier.
This doesn't apply against current code, please check and resend.
Mark Brown
maintainerQuoted 4 lines · Fabio Estevam
There are cases that DMA is not used and the driver gracefully falls back to PIO mode.
Do not treat it like an error message and move it to debug level instead.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/2] spi: imx: Do not print an error when PIO is used
commit: 0ec0da744bbb11ebb49790e991171a13bf114f9f
[2/2] spi: imx: Remove unneeded probe message
(no commit info)
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark