drm/amd/display: remove unintended executable mode
Subsystems (2)
PATCH 1/1 drm/amd/display: remove unintended executable mode
Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM prefix with PCI device info for gfx/mmhub") also set the source files mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode 644 to new mode 755.
Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755.
Set to the usual modes for source and headers files and clean up those mistakes. No functional change.
---
applies cleanly on current master and next-20200819
Alex, Christian, please pick this minor non-urgent cleanup patch.
Dennis, Jerry, please ack.
Dennis, Jerry, you might want to check your development environment introducing those executable modes on files.
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 6 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c +0 -0
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h +0 -0
Signature · 1 line
2.17.1
Am 19.08.20 um 10:18 schrieb Lukas Bulwahn:
Quoted 5 lines
Besides the intended change, commit
4cc1178e166a("drm/amdgpu: replace DRM prefix with PCI device info for gfx/mmhub") also set the source filesmmhub_v1_0.candgfx_v9_4.cto be executable, i.e., changed fromold mode 644 to new mode 755.
Quoted 8 lines
Commit
241b2ec9317e("drm/amd/display: Add dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755.Set to the usual modes for source and headers files and clean up those mistakes. No functional change.
Signed-off-by Lukas Bulwahn <[email protected]>
Quoted 4 lines
---
applies cleanly on current master and next-20200819Alex, Christian, please pick this minor non-urgent cleanup patch.
Alex is usually the one picking those up. If he misses something feel free to ping us once more.
Thanks,
Christian.
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
Quoted 38 lines
Dennis, Jerry, please ack.
Dennis, Jerry, you might want to check your development environment introducing those executable modes on files.
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 6 files changed, 0 insertions(+), 0 deletions(-)mode change 100755 => 100644
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
mode change 100755 => 100644drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
mode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.hdrivers/gpu/drm/amd/amdgpu/gfx_v9_4.c +0
-0drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h +0
-0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 64 lines · Christian König
Am 19.08.20 um 10:18 schrieb Lukas Bulwahn:
Quoted 5 lines
Besides the intended change, commit
4cc1178e166a("drm/amdgpu: replace DRM prefix with PCI device info for gfx/mmhub") also set the source filesmmhub_v1_0.candgfx_v9_4.cto be executable, i.e., changed fromold mode 644 to new mode 755.Quoted 8 lines
Commit
241b2ec9317e("drm/amd/display: Add dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755.Set to the usual modes for source and headers files and clean up those mistakes. No functional change.
Signed-off-by Lukas Bulwahn <[email protected]>Reviewed-by Christian König <[email protected]>Quoted 4 lines
---
applies cleanly on current master and next-20200819Alex, Christian, please pick this minor non-urgent cleanup patch.
Alex is usually the one picking those up. If he misses something feel free to ping us once more.
Thanks,
Christian.Quoted 35 lines
Dennis, Jerry, please ack.
Dennis, Jerry, you might want to check your development environment introducing those executable modes on files.
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 6 files changed, 0 insertions(+), 0 deletions(-)mode change 100755 => 100644
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
mode change 100755 => 100644drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
mode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.hmode change 100755 => 100644drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.hdrivers/gpu/drm/amd/amdgpu/gfx_v9_4.c +0
-0drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h +0
-0drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h +0
-0
Quoted 8 lines
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
Quoted 3 lines
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h +0
-0_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Hi, Lukas,
Thanks for your fix. This issue was caused by that I modified these files in windows system with Samba. I will take care in the future.
Best Regards
Dennis Li
-----Original Message-----
From: Lukas Bulwahn <[email protected]>
Sent: Wednesday, August 19, 2020 4:18 PM
To: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Li, Dennis <[email protected]>; Zuo, Jerry <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Chen, Guchun <[email protected]>; Wu, Hersen <[email protected]>; Lukas Bulwahn <[email protected]>
Subject: [PATCH] drm/amd/display: remove unintended executable mode
Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM prefix with PCI device info for gfx/mmhub") also set the source files mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode 644 to new mode 755.
Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755.
Set to the usual modes for source and headers files and clean up those mistakes. No functional change.
---
applies cleanly on current master and next-20200819
Alex, Christian, please pick this minor non-urgent cleanup patch.
Dennis, Jerry, please ack.
Dennis, Jerry, you might want to check your development environment introducing those executable modes on files.
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 6 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c +0 -0
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h +0 -0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h +0 -0
--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx