fabrics: fix segfault when -t <transport> is not passed
Sagi Grimberg
maintainerPATCH 1/1 fabrics: fix segfault when -t <transport> is not passed
Need to check if transport was provided before we derefernce it.
Fixes 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")
Signed-off-by Sagi Grimberg <[email protected]>
--- fabrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fabrics.c +1 -1
@@ -923,7 +923,7 @@ static bool traddr_is_hostname(struct config *cfg) {char addrstr[NVMF_TRADDR_SIZE ]; -if (!cfg->traddr) +if (!cfg->traddr || !cfg->transport)return false;if (strcmp (cfg->transport,"tcp" ) &&strcmp (cfg->transport,"rdma" ))return false;
Signature · 7 lines
2.25.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 5 lines · Sagi Grimberg
Need to check if transport was provided before we derefernce it.
Fixes 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")Signed-off-by Sagi Grimberg<[email protected]>
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keith Busch
maintainerThank you, patch applied.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme