Skip to contentSkip to conversation

fabrics: fix segfault when -t <transport> is not passed

PATCH In review Sagi Grimberg 3 participants 3 messages Aug 19, 2020 NVMe

lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH 1/1 fabrics: fix segfault when -t <transport> is not passed

Need to check if transport was provided before we derefernce it.

Fixes 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")
---
 fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fabrics.c +1 -1
index 73bb37529448..c93b752ff142 100644
@@ -923,7 +923,7 @@ static bool traddr_is_hostname(struct config *cfg)
 {
 	char addrstr[NVMF_TRADDR_SIZE];
 
-	if (!cfg->traddr)
+	if (!cfg->traddr || !cfg->transport)
 		return false;
 	if (strcmp(cfg->transport, "tcp") && strcmp(cfg->transport, "rdma"))
 		return false;
Signature · 7 lines
2.25.1


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Sagi Grimberg

Need to check if transport was provided before we derefernce it.

Fixes 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")

Looks good.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme