Skip to contentSkip to conversation

ARM: at91: Add GARDENA smart Gateway AT91SAM board

PATCH Superseded Reto Schneider 3 participants 9 messages Aug 10, 2020 – Aug 25, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: at91: Add GARDENA smart Gateway AT91SAM board

From: Reto Schneider <[email protected]>

This patch adds support for the GARDENA smart Gateway, which is based on the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and 256 MiB NAND storage.

Please note that this gateway is not actually based on a AT91SAM9x5 EK board, but is close enough to allow its DT to be used.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/at91sam9g25-gardena-smart-gateway.dts | 186 ++++++++++++++++++
 2 files changed, 187 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..d38d256f59fa 100644
@@ -44,6 +44,7 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
 	at91-wb45n.dtb \
 	at91sam9g15ek.dtb \
 	at91sam9g25ek.dtb \
+	at91sam9g25-gardena-smart-gateway.dtb \
 	at91sam9g35ek.dtb \
 	at91sam9x25ek.dtb \
 	at91sam9x35ek.dtb
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +186 -0

186 lines not on this page · raw message

Signature · 7 lines
2.27.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hello,

Thank you for this submission.

Quoted 44 lines · Reto Schneider

From: Reto Schneider <[email protected]>

This patch adds support for the GARDENA smart Gateway, which is based on the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and 256 MiB NAND storage.

Please note that this gateway is not actually based on a AT91SAM9x5 EK board, but is close enough to allow its DT to be used.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/at91sam9g25-gardena-smart-gateway.dts | 186 ++++++++++++++++++
 2 files changed, 187 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..d38d256f59fa 100644
@@ -44,6 +44,7 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
 	at91-wb45n.dtb \
 	at91sam9g15ek.dtb \
 	at91sam9g25ek.dtb \
+	at91sam9g25-gardena-smart-gateway.dtb \
 	at91sam9g35ek.dtb \
 	at91sam9x25ek.dtb \
 	at91sam9x35ek.dtb
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +6 -0
new file mode 100644
index 000000000000..19b0f67a7af6
@@ -0,0 +1,186 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Device Tree file for the GARDENA smart Gateway (AT91SAM)
+ *
+ *  Copyright (C) 2020 GARDENA GmbH
+ */

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 16

Quoted 10 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +10 -0
+
+/dts-v1/;
+
+#include "at91sam9g25.dtsi"
+#include "at91sam9x5ek.dtsi"
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "GARDENA smart Gateway (AT91SAM)";
+	compatible = "gardena,smart-gateway-at91sam", "atmel,at91sam9g25", "atmel,at91sam9x5", "atmel,at91sam9";

You should document the vendor string. And ideally, gardena,smart-gateway-at91sam should be documented in Documentation/devicetree/bindings/arm/atmel-at91.yaml

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 23

Quoted 7 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +7 -0
+
+	aliases {
+		serial1 = &usart3;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";

This is already in at91sam9x5ek.dtsi

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 27

Quoted 4 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +4 -0
+	};
+
+	memory {
+		reg = <0x20000000 0x8000000>;

This is already in at91sam9x5cm.dtsi, included fromat91sam9x5ek.dtsi

Quoted 82 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +82 -0
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		user_btn1 {
+			label = "USER_BTN1";
+			gpios = <&pioA 24 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_PROG1>;
+		};
+	};
+
+	1wire_cm {
+		status = "disabled";
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		power_blue {
+			label = "smartgw:power:blue";
+			gpios = <&pioC 21 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		power_green {
+			label = "smartgw:power:green";
+			gpios = <&pioC 20 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+
+		power_red {
+			label = "smartgw:power:red";
+			gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		radio_blue {
+			label = "smartgw:radio:blue";
+			gpios = <&pioC 18 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		radio_green {
+			label = "smartgw:radio:green";
+			gpios = <&pioC 17 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		radio_red {
+			label = "smartgw:radio:red";
+			gpios = <&pioC 16 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		internet_blue {
+			label = "smartgw:internet:blue";
+			gpios = <&pioC 15 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		internet_green {
+			label = "smartgw:internet:green";
+			gpios = <&pioC 14 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		internet_red {
+			label = "smartgw:internet:red";
+			gpios = <&pioC 13 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		heartbeat {
+			label = "smartgw:heartbeat";
+			gpios = <&pioB 8 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+
+		pb18 {
+			status = "disabled";
+		};

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 119

Quoted 10 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +10 -0
+
+		pd21 {
+			status = "disabled";
+		};
+	};
+};
+
+&dbgu {
+	status = "okay";
+};

This is already in at91sam9x5ek.dtsi and is duplicated below

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 127

Quoted 8 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +8 -0
+
+&macb0 {
+	phy-mode = "rmii";
+	status = "okay";
+};
+
+&nand_controller {
+	status = "okay";

This is already in at91sam9x5cm.dtsi

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 132

Quoted 5 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +5 -0
+};
+
+&usb0 {
+	status = "okay";
+	num-ports = <3>;

This is already in at91sam9x5ek.dtsi

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 136

Quoted 4 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +4 -0
+};
+
+&usb1 {
+	status = "okay";

This is already in at91sam9x5ek.dtsi

Quoted 40 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +40 -0
+};
+
+&usart0 {
+	status = "disabled";
+};
+
+&usart2 {
+	status = "disabled";
+};
+
+&dbgu {
+	status = "okay";
+};
+
+&usart3 {
+	status = "okay";
+
+	pinctrl-0 = <&pinctrl_usart3
+		     &pinctrl_usart3_rts
+		     &pinctrl_usart3_cts
+		    >;
+};
+
+&watchdog {
+	status = "okay";
+};
+
+&mmc0 {
+	status = "disabled";
+};
+
+&mmc1 {
+	status = "disabled";
+};
+
+&spi0 {
+	status = "disabled";
+};
+
+&i2c0 {

arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts line 186

Quoted 10 lines
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +10 -0
+	status = "disabled";
+};
+
+&adc0 {
+	status = "disabled";
+};
+
+&ssc0 {
+	status = "disabled";
+};

Overall, I'm not convinced it is a good idea to start from at91sam9x5ek.dtsi as it makes you dtb bigger than necessary but if you want it that way, I'm fine with that.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

Hi Alexandre,

Quoted 1 line · Alexandre Belloni

Thank you for this submission.

Thanks a lot for the feedback.

I will send a v2.

Quoted 3 lines

Overall, I'm not convinced it is a good idea to start from at91sam9x5ek.dtsi as it makes you dtb bigger than necessary but if you want it that way, I'm fine with that.

Because using at91sam9x5ek.dtsi saves some code (maintenance effort?!) I am willing to accept the extra binary size.
However, if you think that this causes the maintenance efforts to be greater than when doing it your way, I'd be up for changing it.

Kind regards,
Reto

#3 lore raw
Quoted 9 lines · Reto Schneider

Hi Alexandre,

Quoted 1 line · Alexandre Belloni

Thank you for this submission.

Thanks a lot for the feedback.

I will send a v2.

Quoted 9 lines
Quoted 3 lines

Overall, I'm not convinced it is a good idea to start from at91sam9x5ek.dtsi as it makes you dtb bigger than necessary but if you want it that way, I'm fine with that.

Because using at91sam9x5ek.dtsi saves some code (maintenance effort?!) I am willing to accept the extra binary size.
However, if you think that this causes the maintenance efforts to be greater than when doing it your way, I'd be up for changing it.

I'd say at91sam9x5ek.dtsi has very little chances to change and even if this is the case, it will probably not break your device tree but it is still a possibility.

As said, I'll let you choose.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 1/1 ARM: at91: Add GARDENA smart Gateway (Art. 19000) board

In reply to Reto Schneider

From: Reto Schneider <[email protected]>

This patch adds support for the GARDENA smart Gateway, which is based on the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and 256 MiB NAND storage.

Please note that this gateway is not actually based on a AT91SAM9x5 EK board, but is close enough to allow its DT to be used.

---
 .../devicetree/bindings/arm/atmel-at91.yaml   |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/at91sam9g25-gardena-smart-gateway.dts | 157 ++++++++++++++++++
 3 files changed, 160 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
Documentation/devicetree/bindings/arm/atmel-at91.yaml +2 -0
index 31b0c54fa2cf..b8da32f5d0a7 100644
@@ -41,6 +41,8 @@ properties:
               - overkiz,kizboxmini-mb   # Overkiz kizbox Mini Mother Board
               - overkiz,kizboxmini-rd   # Overkiz kizbox Mini RailDIN
               - overkiz,smartkiz        # Overkiz SmartKiz Board
+              - gardena,smart-gateway-at91sam" # GARDENA smart Gateway (Article
+                                               # No. 19000)
           - const: atmel,at91sam9g25
           - const: atmel,at91sam9x5
           - const: atmel,at91sam9
arch/arm/boot/dts/Makefile +1 -0
index e6a1cac0bfc7..6368dac016dd 100644
@@ -44,6 +44,7 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
 	at91-wb45n.dtb \
 	at91sam9g15ek.dtb \
 	at91sam9g25ek.dtb \
+	at91sam9g25-gardena-smart-gateway.dtb \
 	at91sam9g35ek.dtb \
 	at91sam9x25ek.dtb \
 	at91sam9x35ek.dtb
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +157 -0

157 lines not on this page · raw message

Signature · 1 line
2.27.0
maintainer
#5 lore raw

Re: [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) board

Quoted 14 lines · Reto Schneider

From: Reto Schneider <[email protected]>

This patch adds support for the GARDENA smart Gateway, which is based on the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and 256 MiB NAND storage.

Please note that this gateway is not actually based on a AT91SAM9x5 EK board, but is close enough to allow its DT to be used.

Quoted 7 lines
---
 .../devicetree/bindings/arm/atmel-at91.yaml   |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/at91sam9g25-gardena-smart-gateway.dts | 157 ++++++++++++++++++
 3 files changed, 160 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not valid under any of the given schemas (Possible causes of the failure):

	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not of type 'object'
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items:0:enum:4: 'gardena,smart-gateway-at91sam"' does not match '^[a-zA-Z0-9,.\\-_ #+/]+$'

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: ignoring, error in schema: properties: compatible: oneOf: 2: items
warning: no schema found in file: ./Documentation/devicetree/bindings/arm/atmel-at91.yaml

See https://patchwork.ozlabs.org/patch/1347723

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

#6 lore raw

PATCH v3 1/2 dt-bindings: arm: at91: Add GARDENA smart Gateway (Art. 19000) board

In reply to Reto Schneider

From: Reto Schneider <[email protected]>

Document devicetree's bindings for the GARDENA smart Gateway with article number 19000, based on the SAM9G25 Atmel SoC.

---
 Documentation/devicetree/bindings/arm/atmel-at91.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/atmel-at91.yaml +2 -0
index 31b0c54fa2cf..c0fa195698c8 100644
@@ -41,6 +41,8 @@ properties:
               - overkiz,kizboxmini-mb   # Overkiz kizbox Mini Mother Board
               - overkiz,kizboxmini-rd   # Overkiz kizbox Mini RailDIN
               - overkiz,smartkiz        # Overkiz SmartKiz Board
+              - gardena,smart-gateway-at91sam # GARDENA smart Gateway (Article
+                                              # No. 19000)
           - const: atmel,at91sam9g25
           - const: atmel,at91sam9x5
           - const: atmel,at91sam9
Signature · 1 line
2.27.0
#7 lore raw

PATCH v3 2/2 ARM: at91: Add GARDENA smart Gateway (Art. 19000) support

From: Reto Schneider <[email protected]>

This patch adds support for the GARDENA smart Gateway, which is based on the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and 256 MiB NAND storage.

Please note that this gateway is not actually based on a AT91SAM9x5 EK board, but is close enough to allow its DT to be used.

---
Changes in v3:
- Fix DT binding schema violation, put it in separate commit
- Fix line length violation
- Sort new dtb entry in Makefile

Changes in v2:
- Remove duplicated DT entries
- Improve model name
- Add device to relevant DT binding schema

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/at91sam9g25-gardena-smart-gateway.dts | 158 ++++++++++++++++++
 2 files changed, 159 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
arch/arm/boot/dts/Makefile +1 -0
index e6a1cac0bfc7..6cd1cfcd5316 100644
@@ -43,6 +43,7 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
 	at91-smartkiz.dtb \
 	at91-wb45n.dtb \
 	at91sam9g15ek.dtb \
+	at91sam9g25-gardena-smart-gateway.dtb \
 	at91sam9g25ek.dtb \
 	at91sam9g35ek.dtb \
 	at91sam9x25ek.dtb \
arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts new file +158 -0

158 lines not on this page · raw message

Signature · 1 line
2.27.0
maintainer Applied
#8 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: at91: Add GARDENA smart Gateway (Art. 19000) board

In reply to Reto Schneider
Quoted 2 lines · Reto Schneider

Document devicetree's bindings for the GARDENA smart Gateway with article number 19000, based on the SAM9G25 Atmel SoC.

Applied, thanks!

I did join back the long line in the device tree documention as I found that clearer.

[1/2] dt-bindings: arm: at91: Add GARDENA smart Gateway (Art. 19000) board

      commit: c05a4bff5c509afda0ee60009d62b5abc0e08311
[2/2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) support
      commit: 25ffa0dde53c14cd6ddc938e39f70db4f8837591

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>