usb: gadget: s3c: Remove unused 'udc' variable
PATCH 1/1 usb: gadget: s3c: Remove unused 'udc' variable
Remove unused 'udc' variable to fix compile warnings:
drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>
--- drivers/usb/gadget/udc/s3c2410_udc.c | 3 --- 1 file changed, 3 deletions(-)
drivers/usb/gadget/udc/s3c2410_udc.c +0 -3
@@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,static int s3c2410_udc_dequeue (struct usb_ep *_ep,struct usb_request *_req) {struct s3c2410_ep *ep =to_s3c2410_ep (_ep); -struct s3c2410_udc *udc;int retval = -EINVAL ;unsigned long flags;struct s3c2410_request *req =NULL ;
@@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)if (!_ep || !_req)return retval; - udc =to_s3c2410_udc (ep->gadget); -local_irq_save (flags);list_for_each_entry (req, &ep->queue, queue) {
Signature · 1 line
2.17.1
Quoted 6 lines · Krzysztof Kozlowski
Remove unused 'udc' variable to fix compile warnings:
drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue': drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>
Weird, looks like it has been unused since the introduction of the driver.
Reviewed-by Nathan Chancellor <[email protected]>
Quoted 28 lines
--- drivers/usb/gadget/udc/s3c2410_udc.c | 3 --- 1 file changed, 3 deletions(-)drivers/usb/gadget/udc/s3c2410_udc.c +0
-3@@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,static int s3c2410_udc_dequeue (struct usb_ep *_ep,struct usb_request *_req) {struct s3c2410_ep *ep =to_s3c2410_ep (_ep); -struct s3c2410_udc *udc;int retval = -EINVAL ;unsigned long flags;struct s3c2410_request *req =NULL ;@@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)if (!_ep || !_req)return retval; - udc =to_s3c2410_udc (ep->gadget); -local_irq_save (flags);list_for_each_entry (req, &ep->queue, queue) {Signature · 1 line
2.17.1
Quoted 8 lines · Krzysztof Kozlowski
Remove unused 'udc' variable to fix compile warnings:
drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue': drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
Applied along with other mach-s3c (and related usb) cleanups to samsung-soc.
Best regards,
Krzysztof