Skip to contentSkip to conversation

ARM: dts: imx6q-logicpd: Fix broken PWM

PATCH Superseded Adam Ford 2 participants 2 messages Aug 19, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/1 ARM: dts: imx6q-logicpd: Fix broken PWM

The DTC doesn't like the default PWM settings, because it's expecting three cells. This patch reduces adds the extra entry of 0 to the PWM reference.

Fixes fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")

---
V2: Don't change HDMI

arch/arm/boot/dts/imx6q-logicpd.dts +1 -1
index 7a3d1d3e54a9..8f94364ba484 100644
@@ -13,7 +13,7 @@ / {
 
 	backlight: backlight-lvds {
 		compatible = "pwm-backlight";
-		pwms = <&pwm3 0 20000>;
+		pwms = <&pwm3 0 20000 0>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;
 		default-brightness-level = <6>;
 		power-supply = <&reg_lcd>;
Signature · 1 line
2.25.1
reviewer Reviewed-by on v2 1/1
#1 lore raw

Hi Adam,

Quoted 10 lines · Adam Ford

The DTC doesn't like the default PWM settings, because it's expecting three cells. This patch reduces adds the extra entry of 0 to the PWM reference.

Fixes fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")

---
V2: Don't change HDMI

Your Signed-off-by tag should go below the Fixes line (without a blank line between) and above the --- line.

With that fixed you can add: