Skip to contentSkip to conversation

package/dieharder: fix build with gcc 10

PATCH New Fabrice Fontaine 3 participants 4 messages Aug 19, 2020 – Aug 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/dieharder: fix build with gcc 10

Disable -fno-common with dieharder, there is more than 100 variables to fix and upstream seems dead.

Fixes:
- http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786

---
 package/dieharder/dieharder.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/dieharder/dieharder.mk +5 -0
index c3eee64553..cbf28922fd 100644
@@ -36,4 +36,9 @@ endif
 # parallel build fail, disable it
 DIEHARDER_MAKE = $(MAKE1)
 
+# Too many fixes needed to build with -fno-common which is default since gcc 10
+ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y)
+DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/dieharder: fix build with gcc 10

Fabrice, All,

On 2020-08-19 18:34 +0200, Fabrice Fontaine spake thusly:

Quoted 7 lines

Disable -fno-common with dieharder, there is more than 100 variables to fix and upstream seems dead.

Fixes:
- http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786

Initially, I was not very happy that we just papered over the problem, but this is too daunting to fix, and indeed upstream is not very well alive it seems: last release in 2011, no public VCS... It's a bit shamefull that we have a security-related package that is so old an unmaintained... :-(

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/dieharder/dieharder.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/dieharder/dieharder.mk +5 -0
index c3eee64553..cbf28922fd 100644
@@ -36,4 +36,9 @@ endif
 # parallel build fail, disable it
 DIEHARDER_MAKE = $(MAKE1)
 
+# Too many fixes needed to build with -fno-common which is default since gcc 10
+ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y)
+DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon"
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/dieharder: fix build with gcc 10

Quoted 1 line · Yann E. MORIN

Fabrice, All,

Yann, Fabrice, All,

Quoted 8 lines

On 2020-08-19 18:34 +0200, Fabrice Fontaine spake thusly:

Quoted 6 lines

Disable -fno-common with dieharder, there is more than 100 variables to fix and upstream seems dead.

Fixes:
- http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786

Quoted 7 lines
Quoted 1 line

Initially, I was not very happy that we just papered over the problem, but this is too daunting to fix, and indeed upstream is not very well alive it seems: last release in 2011, no public VCS... It's a bit shamefull that we have a security-related package that is so old an unmaintained... :-(

As I introduced the package a few years ago, I was wondering if we had a way to measure the usage of this package and think about removing it. Then I checked with the guardians of the temple aka debian and found that the maintainer probably fixed the gcc 10 issue:

| dieharder (3.31.1.2-1) unstable; urgency=medium
|
|   * New upstream minor release accomodating gcc-10 and its treatment of
|     multiple definitions of global variables		(Closes: #957134)
|
|   * Based on new 'upstream' git repo at github.com/eddelbuettel/dieharder
|     which spawned off the salsa.debian.org repo for this package
|
|  -- Dirk Eddelbuettel <[email protected]>  Sat, 25 Jul 2020 12:36:49 -0500

This would not be the first time that debian extended the life of unmaintained upstream.

What do you think ?

Regards,

Julien VdG

Quoted 39 lines

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/dieharder/dieharder.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/dieharder/dieharder.mk +5 -0
index c3eee64553..cbf28922fd 100644
@@ -36,4 +36,9 @@ endif
 # parallel build fail, disable it
 DIEHARDER_MAKE = $(MAKE1)
 
+# Too many fixes needed to build with -fno-common which is default since gcc 10
+ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y)
+DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon"
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/dieharder: fix build with gcc 10

Julien, All,

On 2020-08-20 08:21 +0200, Julien Viard de Galbert spake thusly:
[--SNIP--]

Quoted 15 lines

As I introduced the package a few years ago, I was wondering if we had a way to measure the usage of this package and think about removing it. Then I checked with the guardians of the temple aka debian and found that the maintainer probably fixed the gcc 10 issue:

| dieharder (3.31.1.2-1) unstable; urgency=medium
|
|   * New upstream minor release accomodating gcc-10 and its treatment of
|     multiple definitions of global variables		(Closes: #957134)
|
|   * Based on new 'upstream' git repo at github.com/eddelbuettel/dieharder
|     which spawned off the salsa.debian.org repo for this package
|
|  -- Dirk Eddelbuettel <[email protected]>  Sat, 25 Jul 2020 12:36:49 -0500
Quoted 4 lines

This would not be the first time that debian extended the life of unmaintained upstream.

What do you think ?

I would be OK with switching to the github repo, indeed.

When you send the update patch, could you identify how much it has diverged from the original upstream, too, so we can assess if that can be considered for master (only bug fixes), or if it would go to next (if there are features).

thanks for the heads up! :-)

Regards,
Yann E. MORIN.

Quoted 43 lines

Regards,

Julien VdG

Quoted 39 lines

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/dieharder/dieharder.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/dieharder/dieharder.mk +5 -0
index c3eee64553..cbf28922fd 100644
@@ -36,4 +36,9 @@ endif
 # parallel build fail, disable it
 DIEHARDER_MAKE = $(MAKE1)
 
+# Too many fixes needed to build with -fno-common which is default since gcc 10
+ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y)
+DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon"
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'