Skip to contentSkip to conversation

i2c: Remove 'default n' from busses/Kconfig

PATCH Applied Jarkko Nikula 3 participants 5 messages Aug 20, 2020 – Aug 25, 2020 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: Remove 'default n' from busses/Kconfig

The default value for a config option defaults to 'n' so it doesn't need to be set here.

---
 drivers/i2c/busses/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
drivers/i2c/busses/Kconfig +0 -3
index 085ca9b009ed..9731121ec561 100644
@@ -840,7 +840,6 @@ config I2C_PASEMI
 config I2C_PCA_PLATFORM
 	tristate "PCA9564/PCA9665 as platform device"
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports a memory mapped Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.
@@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
 	depends on TTY
 	select SERIO
 	select SERIO_SERPORT
-	default n
 	help
 	  This supports TAOS evaluation modules on serial port. In order to
 	  use this driver, you will need the inputattach tool, which is part
@@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
 	tristate "PCA9564/PCA9665 on an ISA bus"
 	depends on ISA
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports ISA boards using the Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jarkko Nikula
Quoted 29 lines · Jarkko Nikula

The default value for a config option defaults to 'n' so it doesn't need to be set here.

---
 drivers/i2c/busses/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
drivers/i2c/busses/Kconfig +0 -2
index 085ca9b009ed..9731121ec561 100644
@@ -840,7 +840,6 @@ config I2C_PASEMI
 config I2C_PCA_PLATFORM
 	tristate "PCA9564/PCA9665 as platform device"
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports a memory mapped Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.
@@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
 	depends on TTY
 	select SERIO
 	select SERIO_SERPORT
-	default n
 	help
 	  This supports TAOS evaluation modules on serial port. In order to
 	  use this driver, you will need the inputattach tool, which is part

drivers/i2c/busses/Kconfig config I2C_PCA_ISA · line 1338

Quoted 7 lines
drivers/i2c/busses/Kconfig +0 -1
@@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
 	tristate "PCA9564/PCA9665 on an ISA bus"
 	depends on ISA
 	select I2C_ALGOPCA
-	default n
 	help
 	  This driver supports ISA boards using the Philips PCA9564/PCA9665
 	  parallel bus to I2C bus controller.

Definitely a good move, this was on my informal to-do list for some time already...

Option I2C_STUB suffers from the same but uses a different syntax, which may explain why you missed it.

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#4 lore raw
Quoted 8 lines · Wolfram Sang
Quoted 5 lines

Option I2C_STUB suffers from the same but uses a different syntax, which may explain why you missed it.

I removed that one, too, and added your tag. Thanks!

Ah, thanks! I was just going to send another patch removing it :-)

Jarkko